René's URL Explorer Experiment


Title: assert: improve performance by BridgeAR · Pull Request #13973 · nodejs/node · GitHub

Open Graph Title: assert: improve performance by BridgeAR · Pull Request #13973 · nodejs/node

X Title: assert: improve performance by BridgeAR · Pull Request #13973 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: While refactoring the assert in #13862 I stumbled open a couple of improvements. This change is only about performance changes and not about style. I added a few more benchmarks and fixed the descr...

X Description: While refactoring the assert in #13862 I stumbled open a couple of improvements. This change is only about performance changes and not about style. I added a few more benchmarks and fixed the descr...

Opengraph URL: https://github.com/nodejs/node/pull/13973

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1b61ede8-4d50-f67e-e4ab-948b7f4faf0f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC662:52F66:6CD320:9D9BC1:6A4E0E8F
html-safe-nonce6f128d2d45a2db3d07367a4f18b7db6a7148fe7174534f73694fb0761ac56834
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjYyOjUyRjY2OjZDRDMyMDo5RDlCQzE6NkE0RTBFOEYiLCJ2aXNpdG9yX2lkIjoiODI1OTcwNTQxMTc3NjQxNzQyMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd5f87b3596241a8a60a304fe5a37f2bbd47c8bd56a8926a8b1293c596be0c77e
hovercard-subject-tagpull_request:128043380
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/13973/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/45fb6a4d3ebde11846d25b76d4758dd0c45ad40921ca6056b3cf390ff5a0f3cd/nodejs/node/pull/13973
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/45fb6a4d3ebde11846d25b76d4758dd0c45ad40921ca6056b3cf390ff5a0f3cd/nodejs/node/pull/13973
og:image:altWhile refactoring the assert in #13862 I stumbled open a couple of improvements. This change is only about performance changes and not about style. I added a few more benchmarks and fixed the descr...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBridgeAR
hostnamegithub.com
expected-hostnamegithub.com
Nonedf0492960db29b4938cb72070351d6b1d0c6c0767b27ceb8394bbf4fcc0223c6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release51470c353b8a1f52a88d3e3cc2014b17ab8cc1ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/13973#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13973
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13973
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/13973
Reloadhttps://github.com/nodejs/node/pull/13973
Reloadhttps://github.com/nodejs/node/pull/13973
Please reload this pagehttps://github.com/nodejs/node/pull/13973
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/13973
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:improve-assert-performancehttps://github.com/BridgeAR/node/tree/improve-assert-performance
Conversationhttps://github.com/nodejs/node/pull/13973
Commits3 (3)https://github.com/nodejs/node/pull/13973/commits
Checkshttps://github.com/nodejs/node/pull/13973/checks
Files changedhttps://github.com/nodejs/node/pull/13973/files
assert: improve performancehttps://github.com/nodejs/node/pull/13973#top
BridgeARhttps://github.com/BridgeAR
nodejs:masterhttps://github.com/nodejs/node/tree/master
BridgeAR:improve-assert-performancehttps://github.com/BridgeAR/node/tree/improve-assert-performance
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jun 28, 2017https://github.com/nodejs/node/pull/13973#issue-239328946
#13862https://github.com/nodejs/node/pull/13862
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/13973
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
Jun 28, 2017https://github.com/nodejs/node/pull/13973#event-1143334799
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/f72aa63d5d1febd033437fe15ddde9dd28306268..b8451b0e14ec52605ba0c5a69f16474a936ec1de
f72aa63https://github.com/nodejs/node/commit/f72aa63d5d1febd033437fe15ddde9dd28306268
b8451b0https://github.com/nodejs/node/commit/b8451b0e14ec52605ba0c5a69f16474a936ec1de
Compare https://github.com/nodejs/node/compare/f72aa63d5d1febd033437fe15ddde9dd28306268..b8451b0e14ec52605ba0c5a69f16474a936ec1de
June 28, 2017 23:48https://github.com/nodejs/node/pull/13973#event-1143336763
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jun 28, 2017 https://github.com/nodejs/node/pull/13973#ref-pullrequest-237710779
assert: make assert.fail doc compliant #13862 https://github.com/nodejs/node/pull/13862
https://github.com/refack
refackhttps://github.com/refack
Jun 28, 2017 https://github.com/nodejs/node/pull/13973#pullrequestreview-46998061
View reviewed changes https://github.com/nodejs/node/pull/13973/files
benchmark/assert/deepequal-prims-and-objs-big-loop.jshttps://github.com/nodejs/node/pull/13973/files#diff-59f6efd70883b32707bb66aefd87297398d368402a1511d1a5b17f1d32e298ba
refackhttps://github.com/refack
Jun 28, 2017https://github.com/nodejs/node/pull/13973#discussion_r124684373
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13973
BridgeARhttps://github.com/BridgeAR
Jun 29, 2017https://github.com/nodejs/node/pull/13973#discussion_r124744868
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13973
refackhttps://github.com/refack
Jun 29, 2017https://github.com/nodejs/node/pull/13973#discussion_r124777312
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13973
BridgeARhttps://github.com/BridgeAR
Jun 29, 2017https://github.com/nodejs/node/pull/13973#discussion_r124779142
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13973
test/parallel/test-assert.jshttps://github.com/nodejs/node/pull/13973/files#diff-968e57a9f4d4ce7494523f71b2594d844620c2794a68049cce33fcdc8c7c7b7c
refackhttps://github.com/refack
Jun 28, 2017https://github.com/nodejs/node/pull/13973#discussion_r124684777
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13973
refackhttps://github.com/refack
Jul 4, 2017https://github.com/nodejs/node/pull/13973#discussion_r125451520
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
4f679fd#diff-02063f30815b78f7986ee0c212140b8eR110https://github.com/nodejs/node/commit/4f679fd8d01c11c908bd5ca439a7aff956cda4ad#diff-02063f30815b78f7986ee0c212140b8eR110
Please reload this pagehttps://github.com/nodejs/node/pull/13973
https://github.com/refack
refackhttps://github.com/refack
Jun 28, 2017https://github.com/nodejs/node/pull/13973#event-1143341808
https://github.com/refack
refackhttps://github.com/refack
Jun 28, 2017https://github.com/nodejs/node/pull/13973#issuecomment-311824279
https://ci.nodejs.org/job/node-test-commit-linuxone/6915/https://ci.nodejs.org/job/node-test-commit-linuxone/6915/
Please reload this pagehttps://github.com/nodejs/node/pull/13973
https://github.com/mscdex
mscdexhttps://github.com/mscdex
performance https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance
Jun 29, 2017https://github.com/nodejs/node/pull/13973#event-1143432155
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 29, 2017 https://github.com/nodejs/node/pull/13973#pullrequestreview-47019134
View reviewed changes https://github.com/nodejs/node/pull/13973/files
benchmark/assert/deepequal-buffer.jshttps://github.com/nodejs/node/pull/13973/files#diff-1b71d832626063fc81029f74adaad6d94186e439776662bd16803af4b53cce4d
jasnellhttps://github.com/jasnell
Jun 29, 2017https://github.com/nodejs/node/pull/13973#discussion_r124704556
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13973
BridgeARhttps://github.com/BridgeAR
Jun 29, 2017https://github.com/nodejs/node/pull/13973#discussion_r124745168
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13973
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 29, 2017https://github.com/nodejs/node/pull/13973#issuecomment-311865329
Please reload this pagehttps://github.com/nodejs/node/pull/13973
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jun 29, 2017https://github.com/nodejs/node/pull/13973#event-1145160647
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jun 30, 2017https://github.com/nodejs/node/pull/13973#issuecomment-312247208
Please reload this pagehttps://github.com/nodejs/node/pull/13973
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/13973
https://github.com/Trott
Trotthttps://github.com/Trott
Jun 30, 2017 https://github.com/nodejs/node/pull/13973#pullrequestreview-47467549
View reviewed changes https://github.com/nodejs/node/pull/13973/files
benchmark/assert/deepequal-buffer.jshttps://github.com/nodejs/node/pull/13973/files#diff-1b71d832626063fc81029f74adaad6d94186e439776662bd16803af4b53cce4d
Trotthttps://github.com/Trott
Jun 30, 2017https://github.com/nodejs/node/pull/13973#discussion_r125105495
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/13973
refackhttps://github.com/refack
Jun 30, 2017https://github.com/nodejs/node/pull/13973#discussion_r125105768
Please reload this pagehttps://github.com/nodejs/node/pull/13973
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13973
gareth-ellishttps://github.com/gareth-ellis
Jun 30, 2017https://github.com/nodejs/node/pull/13973#discussion_r125125113
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/13973
BridgeARhttps://github.com/BridgeAR
Jun 30, 2017https://github.com/nodejs/node/pull/13973#discussion_r125141808
Please reload this pagehttps://github.com/nodejs/node/pull/13973
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/13973
https://github.com/refack
refackhttps://github.com/refack
Jun 30, 2017https://github.com/nodejs/node/pull/13973#issuecomment-312346035
https://ci.nodejs.org/job/node-test-commit-linuxone/6974/https://ci.nodejs.org/job/node-test-commit-linuxone/6974/
Please reload this pagehttps://github.com/nodejs/node/pull/13973
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jun 30, 2017https://github.com/nodejs/node/pull/13973#issuecomment-312387853
Please reload this pagehttps://github.com/nodejs/node/pull/13973
https://github.com/refack
refackhttps://github.com/refack
Jun 30, 2017 https://github.com/nodejs/node/pull/13973#pullrequestreview-47509807
View reviewed changes https://github.com/nodejs/node/pull/13973/files
lib/assert.jshttps://github.com/nodejs/node/pull/13973/files#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f
refackhttps://github.com/refack
Jun 30, 2017https://github.com/nodejs/node/pull/13973#discussion_r125142732
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13973
BridgeARhttps://github.com/BridgeAR
Jun 30, 2017https://github.com/nodejs/node/pull/13973#discussion_r125145069
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13973
https://github.com/refack
refackhttps://github.com/refack
Jun 30, 2017 https://github.com/nodejs/node/pull/13973#pullrequestreview-47512574
View reviewed changes https://github.com/nodejs/node/pull/13973/files
refackhttps://github.com/refack
https://github.com/nodejs/node/pull/13973#pullrequestreview-47512574
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13973
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jul 2, 2017 https://github.com/nodejs/node/pull/13973#pullrequestreview-47541276
View reviewed changes https://github.com/nodejs/node/pull/13973/files
lib/assert.jshttps://github.com/nodejs/node/pull/13973/files#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f
joyeecheunghttps://github.com/joyeecheung
Jul 2, 2017https://github.com/nodejs/node/pull/13973#discussion_r125173527
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13973
BridgeARhttps://github.com/BridgeAR
Jul 2, 2017https://github.com/nodejs/node/pull/13973#discussion_r125187206
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13973
lib/assert.jshttps://github.com/nodejs/node/pull/13973/files#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f
joyeecheunghttps://github.com/joyeecheung
Jul 2, 2017https://github.com/nodejs/node/pull/13973#discussion_r125173539
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13973
BridgeARhttps://github.com/BridgeAR
Jul 2, 2017https://github.com/nodejs/node/pull/13973#discussion_r125187137
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13973
benchmark/assert/throws.jshttps://github.com/nodejs/node/pull/13973/files#diff-e88c7208fec1920ef0bc6fd3784ef79e607e923cd3aa225a729ba92d9bae74d9
joyeecheunghttps://github.com/joyeecheung
Jul 2, 2017https://github.com/nodejs/node/pull/13973#discussion_r125173595
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13973
BridgeARhttps://github.com/BridgeAR
Jul 2, 2017https://github.com/nodejs/node/pull/13973#discussion_r125181951
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13973
https://github.com/refack
refackhttps://github.com/refack
Jul 2, 2017 https://github.com/nodejs/node/pull/13973#ref-pullrequest-240034407
assert: replace many if's with if-else statement #14043 https://github.com/nodejs/node/pull/14043
https://github.com/refack
refackhttps://github.com/refack
Jul 2, 2017https://github.com/nodejs/node/pull/13973#issuecomment-312519189
https://ci.nodejs.org/job/node-test-commit/10890/https://ci.nodejs.org/job/node-test-commit/10890/
Please reload this pagehttps://github.com/nodejs/node/pull/13973
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jul 3, 2017 https://github.com/nodejs/node/pull/13973#pullrequestreview-47667886
View reviewed changes https://github.com/nodejs/node/pull/13973/files
benjamingrhttps://github.com/benjamingr
https://github.com/nodejs/node/pull/13973#pullrequestreview-47667886
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13973
https://github.com/refack
refackhttps://github.com/refack
Jul 4, 2017https://github.com/nodejs/node/pull/13973#issuecomment-312851868
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/897/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/897/
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/898/https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/898/
Please reload this pagehttps://github.com/nodejs/node/pull/13973
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jul 5, 2017 https://github.com/nodejs/node/pull/13973#pullrequestreview-47938680
View reviewed changes https://github.com/nodejs/node/pull/13973/files
https://github.com/refack
refackhttps://github.com/refack
Jul 8, 2017https://github.com/nodejs/node/pull/13973#issuecomment-313875473
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/13973
BridgeARhttps://github.com/BridgeAR
July 8, 2017 21:57https://github.com/nodejs/node/pull/13973#commits-pushed-7727eeb
https://github.com/BridgeAR
benchmark: fix and extend assert benchmarkshttps://github.com/nodejs/node/pull/13973/commits/7727eeb54d1fb52d06c367865cb61f04eb29f04d
7727eebhttps://github.com/nodejs/node/pull/13973/commits/7727eeb54d1fb52d06c367865cb61f04eb29f04d
https://github.com/BridgeAR
assert: refactor to reduce unecessary code pathshttps://github.com/nodejs/node/pull/13973/commits/a3e619466f4c23e7c4ae845b5e06066dd2f1319a
a3e6194https://github.com/nodejs/node/pull/13973/commits/a3e619466f4c23e7c4ae845b5e06066dd2f1319a
https://github.com/BridgeAR
test: remove obsolete argumenthttps://github.com/nodejs/node/pull/13973/commits/6e456f1899b3191b8bd59d05198bc549f4a6034f
6e456f1https://github.com/nodejs/node/pull/13973/commits/6e456f1899b3191b8bd59d05198bc549f4a6034f
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
force-pushedhttps://github.com/nodejs/node/compare/83a6d778e6dc2523654797cc7d111ac36a3271fc..6e456f1899b3191b8bd59d05198bc549f4a6034f
83a6d77https://github.com/nodejs/node/commit/83a6d778e6dc2523654797cc7d111ac36a3271fc
6e456f1https://github.com/nodejs/node/commit/6e456f1899b3191b8bd59d05198bc549f4a6034f
Compare https://github.com/nodejs/node/compare/83a6d778e6dc2523654797cc7d111ac36a3271fc..6e456f1899b3191b8bd59d05198bc549f4a6034f
July 8, 2017 20:43https://github.com/nodejs/node/pull/13973#event-1155608317
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jul 8, 2017https://github.com/nodejs/node/pull/13973#issuecomment-313879972
Please reload this pagehttps://github.com/nodejs/node/pull/13973
https://github.com/refack
refackhttps://github.com/refack
Jul 8, 2017https://github.com/nodejs/node/pull/13973#issuecomment-313883327
https://ci.nodejs.org/job/node-test-pull-request/9046/https://ci.nodejs.org/job/node-test-pull-request/9046/
Please reload this pagehttps://github.com/nodejs/node/pull/13973
refackhttps://github.com/refack
Jul 9, 2017 https://github.com/nodejs/node/pull/13973#ref-commit-be20e9e
https://github.com/BridgeAR
https://github.com/refack
assert: refactor to reduce unecessary code pathshttps://github.com/refack/node/commit/be20e9ecfe79bea30fdca0f5757c0c54a02ac062
be20e9ehttps://github.com/refack/node/commit/be20e9ecfe79bea30fdca0f5757c0c54a02ac062
nodejs#13973https://github.com/nodejs/node/pull/13973
https://github.com/refack
refackhttps://github.com/refack
Jul 9, 2017https://github.com/nodejs/node/pull/13973#issuecomment-313936274
be20e9ehttps://github.com/nodejs/node/commit/be20e9ecfe79bea30fdca0f5757c0c54a02ac062
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/13973
https://github.com/refack
refackhttps://github.com/refack
Jul 9, 2017https://github.com/nodejs/node/pull/13973#event-1155852501
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jul 9, 2017 https://github.com/nodejs/node/pull/13973#ref-pullrequest-241550602
benchmark: fix and extend assert benchmarks #14147 https://github.com/nodejs/node/pull/14147
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 22, 2017https://github.com/nodejs/node/pull/13973#issuecomment-317208339
@refackhttps://github.com/refack
guidehttps://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md
Please reload this pagehttps://github.com/nodejs/node/pull/13973
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
backport-requested-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v8.x
Jul 22, 2017https://github.com/nodejs/node/pull/13973#event-1174989859
https://github.com/refack
refackhttps://github.com/refack
Jul 22, 2017https://github.com/nodejs/node/pull/13973#issuecomment-317215318
@refackhttps://github.com/refack
https://benchmarking.nodejs.org/https://benchmarking.nodejs.org/
#14147https://github.com/nodejs/node/pull/14147
Please reload this pagehttps://github.com/nodejs/node/pull/13973
https://github.com/refack
refackhttps://github.com/refack
Jul 22, 2017https://github.com/nodejs/node/pull/13973#issuecomment-317216138
#14258https://github.com/nodejs/node/pull/14258
Please reload this pagehttps://github.com/nodejs/node/pull/13973
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jul 27, 2017https://github.com/nodejs/node/pull/13973#issuecomment-318507359
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/13973
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
backport-requested-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v8.x
Jul 28, 2017https://github.com/nodejs/node/pull/13973#event-1182755366
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 28, 2017https://github.com/nodejs/node/pull/13973#issuecomment-318524320
Please reload this pagehttps://github.com/nodejs/node/pull/13973
addaleaxhttps://github.com/addaleax
Jul 28, 2017 https://github.com/nodejs/node/pull/13973#ref-commit-9252b8c
https://github.com/BridgeAR
https://github.com/addaleax
assert: refactor to reduce unecessary code pathshttps://github.com/nodejs/node/commit/9252b8c057165d9d5fbdd93e3c96c5a97aa865e9
9252b8chttps://github.com/nodejs/node/commit/9252b8c057165d9d5fbdd93e3c96c5a97aa865e9
#13973https://github.com/nodejs/node/pull/13973
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 2, 2017 https://github.com/nodejs/node/pull/13973#ref-pullrequest-247351530
v8.3.0 proposal #14594 https://github.com/nodejs/node/pull/14594
refackhttps://github.com/refack
Aug 13, 2017 https://github.com/nodejs/node/pull/13973#ref-commit-a7189c0
https://github.com/BridgeAR
https://github.com/refack
benchmark: fix and extend assert benchmarkshttps://github.com/nodejs/node/commit/a7189c0177938545050421a600fb12c21db3858f
a7189c0https://github.com/nodejs/node/commit/a7189c0177938545050421a600fb12c21db3858f
#14147https://github.com/nodejs/node/pull/14147
#13973https://github.com/nodejs/node/pull/13973
addaleaxhttps://github.com/addaleax
Aug 13, 2017 https://github.com/nodejs/node/pull/13973#ref-commit-b3c1c6f
https://github.com/BridgeAR
https://github.com/addaleax
benchmark: fix and extend assert benchmarkshttps://github.com/nodejs/node/commit/b3c1c6ff7f65c6bf8c08585d11b8da9779e0d371
b3c1c6fhttps://github.com/nodejs/node/commit/b3c1c6ff7f65c6bf8c08585d11b8da9779e0d371
#14147https://github.com/nodejs/node/pull/14147
#13973https://github.com/nodejs/node/pull/13973
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Aug 16, 2017https://github.com/nodejs/node/pull/13973#event-1207805057
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
backported-to-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v8.x
Sep 14, 2017https://github.com/nodejs/node/pull/13973#event-1248326229
https://github.com/refack
refackhttps://github.com/refack
Oct 20, 2018https://github.com/nodejs/node/pull/13973#event-1916393623
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
April 1, 2019 23:36https://github.com/nodejs/node/pull/13973#event-2244905805
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13973
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/13973/files/b8451b0e14ec52605ba0c5a69f16474a936ec1de
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/13973/files/a9227dfc087d1ded075053d8366b7cec5a60ed46
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/13973/files/83a6d778e6dc2523654797cc7d111ac36a3271fc
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/13973/files/83a6d778e6dc2523654797cc7d111ac36a3271fc
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/13973/files/83a6d778e6dc2523654797cc7d111ac36a3271fc
https://github.com/gareth-ellis
gareth-ellis https://github.com/gareth-ellis
https://github.com/nodejs/node/pull/13973/files/a9227dfc087d1ded075053d8366b7cec5a60ed46
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
performance https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance
Please reload this pagehttps://github.com/nodejs/node/pull/13973
https://github.com/BridgeAR
https://github.com/refack
https://github.com/Trott
https://github.com/addaleax
https://github.com/jasnell
https://github.com/benjamingr
https://github.com/joyeecheung
https://github.com/gareth-ellis
https://github.com/mscdex
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.