René's URL Explorer Experiment


Title: cluster: disconnect event was not emitted correctly by Olegas · Pull Request #1386 · nodejs/node · GitHub

Open Graph Title: cluster: disconnect event was not emitted correctly by Olegas · Pull Request #1386 · nodejs/node

X Title: cluster: disconnect event was not emitted correctly by Olegas · Pull Request #1386 · nodejs/node

Description: Fix for #1304 Inside of a worker, disconnect event was not emitted on cluster.worker

Open Graph Description: Fix for #1304 Inside of a worker, disconnect event was not emitted on cluster.worker

X Description: Fix for #1304 Inside of a worker, disconnect event was not emitted on cluster.worker

Opengraph URL: https://github.com/nodejs/node/pull/1386

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:10c4d913-a37d-08ba-4dcc-a7074a2427f2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD2AC:3A35C6:9FA1FE:D7035F:696AB995
html-safe-noncee18488aea130df963f48f13092b8bc07c5c15ee8dbfadb58d040e95f5eb27a5a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkFDOjNBMzVDNjo5RkExRkU6RDcwMzVGOjY5NkFCOTk1IiwidmlzaXRvcl9pZCI6IjkwNDE2MTUzMzE5NjM2MTU2MzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc273929556ad9eda9276da0abe1f57964c9e7b0b099c5d4362e23867575d0c12
hovercard-subject-tagpull_request:32993029
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1386/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fe0125c54ca11fe823af109b132b906e9274167a70a61edd0f17bb5f97286c69/nodejs/node/pull/1386
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fe0125c54ca11fe823af109b132b906e9274167a70a61edd0f17bb5f97286c69/nodejs/node/pull/1386
og:image:altFix for #1304 Inside of a worker, disconnect event was not emitted on cluster.worker
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameOlegas
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/1386#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1386
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1386
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/1386
Reloadhttps://github.com/nodejs/node/pull/1386
Reloadhttps://github.com/nodejs/node/pull/1386
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/1386
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/1386
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/1386#issue-comment-box
Olegashttps://github.com/Olegas
nodejs:v1.xhttps://github.com/nodejs/node/tree/v1.x
Olegas:worker-emit-disconnecthttps://github.com/Olegas/io.js/tree/worker-emit-disconnect
cluster: disconnect event was not emitted correctly https://github.com/nodejs/node/pull/1386#top
Olegashttps://github.com/Olegas
nodejs:v1.xhttps://github.com/nodejs/node/tree/v1.x
Olegas:worker-emit-disconnecthttps://github.com/Olegas/io.js/tree/worker-emit-disconnect
Conversation 11 https://github.com/nodejs/node/pull/1386
Commits 1 https://github.com/nodejs/node/pull/1386/commits
Checks 0 https://github.com/nodejs/node/pull/1386/checks
Files changed https://github.com/nodejs/node/pull/1386/files
Please reload this pagehttps://github.com/nodejs/node/pull/1386
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/Olegas
Olegashttps://github.com/Olegas
Apr 9, 2015https://github.com/nodejs/node/pull/1386#issue-67444420
#1304https://github.com/nodejs/node/issues/1304
Please reload this pagehttps://github.com/nodejs/node/pull/1386
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
cluster https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acluster
Apr 9, 2015https://github.com/nodejs/node/pull/1386#event-277540412
cjihrighttps://github.com/cjihrig
Apr 9, 2015 https://github.com/nodejs/node/pull/1386#discussion-diff-28100805
View reviewed changes https://github.com/nodejs/node/pull/1386/files/ee643bd0facfb75e77dd132260801f9e78a4c838#diff-b23add1a2a86105826ab9fa398d260babb2bdcab50e2421b10bb5c56c845f92f
test/parallel/test-cluster-worker-disconnect.jshttps://github.com/nodejs/node/pull/1386/files#diff-b23add1a2a86105826ab9fa398d260babb2bdcab50e2421b10bb5c56c845f92f
cjihrighttps://github.com/cjihrig
Apr 9, 2015https://github.com/nodejs/node/pull/1386#discussion_r28100805
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/1386
cjihrighttps://github.com/cjihrig
Apr 9, 2015https://github.com/nodejs/node/pull/1386#discussion_r28103529
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1386
https://github.com/Olegas
Olegashttps://github.com/Olegas
Apr 9, 2015https://github.com/nodejs/node/pull/1386#issuecomment-91363254
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/1386
cjihrighttps://github.com/cjihrig
Apr 9, 2015 https://github.com/nodejs/node/pull/1386#discussion-diff-28105948
View reviewed changes https://github.com/nodejs/node/pull/1386/files/fd21b922e373831fd76b3ade0516d6b002f4a13f#diff-b23add1a2a86105826ab9fa398d260babb2bdcab50e2421b10bb5c56c845f92f
test/parallel/test-cluster-worker-disconnect.jshttps://github.com/nodejs/node/pull/1386/files#diff-b23add1a2a86105826ab9fa398d260babb2bdcab50e2421b10bb5c56c845f92f
cjihrighttps://github.com/cjihrig
Apr 9, 2015https://github.com/nodejs/node/pull/1386#discussion_r28105948
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1386
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Apr 9, 2015https://github.com/nodejs/node/pull/1386#issuecomment-91364758
Please reload this pagehttps://github.com/nodejs/node/pull/1386
https://github.com/Olegas
cluster: disconnect event was not emitted correctlyhttps://github.com/nodejs/node/pull/1386/commits/ded311cba5b7934185c331b282fb8ac925e80269
ded311chttps://github.com/nodejs/node/pull/1386/commits/ded311cba5b7934185c331b282fb8ac925e80269
nodejs#1304https://github.com/nodejs/node/issues/1304
https://github.com/Olegas
Olegashttps://github.com/Olegas
force-pushedhttps://github.com/nodejs/node/compare/fd21b922e373831fd76b3ade0516d6b002f4a13f..ded311cba5b7934185c331b282fb8ac925e80269
fd21b92https://github.com/nodejs/node/commit/fd21b922e373831fd76b3ade0516d6b002f4a13f
ded311chttps://github.com/nodejs/node/commit/ded311cba5b7934185c331b282fb8ac925e80269
Compare https://github.com/nodejs/node/compare/fd21b922e373831fd76b3ade0516d6b002f4a13f..ded311cba5b7934185c331b282fb8ac925e80269
April 9, 2015 21:54https://github.com/nodejs/node/pull/1386#event-277603349
https://github.com/Olegas
Olegashttps://github.com/Olegas
Apr 9, 2015https://github.com/nodejs/node/pull/1386#issuecomment-91366421
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/1386
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Apr 9, 2015https://github.com/nodejs/node/pull/1386#issuecomment-91367189
https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/480/https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/480/
Please reload this pagehttps://github.com/nodejs/node/pull/1386
https://github.com/chrisdickinson
chrisdickinsonhttps://github.com/chrisdickinson
land-on-master https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-master
Apr 17, 2015https://github.com/nodejs/node/pull/1386#event-284308443
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
May 5, 2015https://github.com/nodejs/node/pull/1386#issuecomment-98889701
Please reload this pagehttps://github.com/nodejs/node/pull/1386
https://github.com/Olegas
Olegashttps://github.com/Olegas
May 5, 2015https://github.com/nodejs/node/pull/1386#issuecomment-99025694
@brendanashworthhttps://github.com/brendanashworth
Please reload this pagehttps://github.com/nodejs/node/pull/1386
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
May 5, 2015https://github.com/nodejs/node/pull/1386#issuecomment-99102679
Please reload this pagehttps://github.com/nodejs/node/pull/1386
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
May 8, 2015https://github.com/nodejs/node/pull/1386#event-300558480
brendanashworthhttps://github.com/brendanashworth
May 8, 2015 https://github.com/nodejs/node/pull/1386#ref-commit-5883a59
https://github.com/Olegas
https://github.com/brendanashworth
cluster: disconnect event not emitted correctlyhttps://github.com/nodejs/node/commit/5883a59b21a97e8b7339f435c977155a2c29ba8d
5883a59https://github.com/nodejs/node/commit/5883a59b21a97e8b7339f435c977155a2c29ba8d
#1304https://github.com/nodejs/node/issues/1304
#1386https://github.com/nodejs/node/pull/1386
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
May 8, 2015https://github.com/nodejs/node/pull/1386#issuecomment-100342982
5883a59https://github.com/nodejs/node/commit/5883a59b21a97e8b7339f435c977155a2c29ba8d
Please reload this pagehttps://github.com/nodejs/node/pull/1386
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
May 8, 2015https://github.com/nodejs/node/pull/1386#event-300571848
https://github.com/brendanashworth
brendanashworthhttps://github.com/brendanashworth
May 9, 2015https://github.com/nodejs/node/pull/1386#event-300762713
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
May 12, 2015 https://github.com/nodejs/node/pull/1386#ref-pullrequest-75427061
Release proposal: v2.0.2 #1679 https://github.com/nodejs/node/pull/1679
Fishrock123https://github.com/Fishrock123
May 15, 2015 https://github.com/nodejs/node/pull/1386#ref-commit-3e7a143
https://github.com/Fishrock123
2015-05-15 io.js v2.0.2 Releasehttps://github.com/Fishrock123/node/commit/3e7a14381497a3b73dda68d05b5130563cdab420
3e7a143https://github.com/Fishrock123/node/commit/3e7a14381497a3b73dda68d05b5130563cdab420
nodejs#1679https://github.com/nodejs/node/pull/1679
nodejs#1433https://github.com/nodejs/node/pull/1433
nodejs#1673https://github.com/nodejs/node/pull/1673
nodejs#1660https://github.com/nodejs/node/pull/1660
nodejs#1663https://github.com/nodejs/node/pull/1663
nodejs#1694https://github.com/nodejs/node/pull/1694
nodejs#1313https://github.com/nodejs/node/pull/1313
nodejs#1386https://github.com/nodejs/node/pull/1386
nodejs#1654https://github.com/nodejs/node/pull/1654
Fishrock123https://github.com/Fishrock123
May 19, 2015 https://github.com/nodejs/node/pull/1386#ref-commit-ebc671b
https://github.com/Olegas
https://github.com/Fishrock123
cluster: disconnect event not emitted correctlyhttps://github.com/Fishrock123/node/commit/ebc671b6c6915fc40ad3642250080b90fad8d3d5
ebc671bhttps://github.com/Fishrock123/node/commit/ebc671b6c6915fc40ad3642250080b90fad8d3d5
nodejs#1304https://github.com/nodejs/node/issues/1304
nodejs#1386https://github.com/nodejs/node/pull/1386
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1386
cluster https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acluster
Please reload this pagehttps://github.com/nodejs/node/pull/1386
https://github.com/Olegas
https://github.com/cjihrig
https://github.com/brendanashworth
https://github.com/chrisdickinson
https://github.com/Fishrock123
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.