René's URL Explorer Experiment


Title: fix `common.expectsError` type checking by refack · Pull Request #13686 · nodejs/node · GitHub

Open Graph Title: fix `common.expectsError` type checking by refack · Pull Request #13686 · nodejs/node

X Title: fix `common.expectsError` type checking by refack · Pull Request #13686 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #13682 More exact types for Errors in the tests fix common.expectsError type checking /cc @cjihrig @nodejs/testing Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tes...

X Description: Fixes: #13682 More exact types for Errors in the tests fix common.expectsError type checking /cc @cjihrig @nodejs/testing Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tes...

Opengraph URL: https://github.com/nodejs/node/pull/13686

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:be10a62d-74dc-2769-b2bc-53af4fe95179
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id85A8:189FE3:F6FBD6:13A4367:69919100
html-safe-noncebebc48b65d7ffc6dcea38d85499b2a41c3b746e3c9bdd136396432427c128171
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUE4OjE4OUZFMzpGNkZCRDY6MTNBNDM2Nzo2OTkxOTEwMCIsInZpc2l0b3JfaWQiOiI0NTExOTA5OTM0MzUzMzI4NjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca46663ade23dc5ea75d7d9d922144df9ff1c149e0b148c1a965a2367df6c2322
hovercard-subject-tagpull_request:125678340
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/13686/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/47c616fd3f435cf7e14db52c66f7fb801e4d920d0101632f2b936452dfb706f3/nodejs/node/pull/13686
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/47c616fd3f435cf7e14db52c66f7fb801e4d920d0101632f2b936452dfb706f3/nodejs/node/pull/13686
og:image:altFixes: #13682 More exact types for Errors in the tests fix common.expectsError type checking /cc @cjihrig @nodejs/testing Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tes...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerefack
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/13686#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13686
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13686
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/13686
Reloadhttps://github.com/nodejs/node/pull/13686
Reloadhttps://github.com/nodejs/node/pull/13686
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/13686
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 711 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
refackhttps://github.com/refack
nodejs:masterhttps://github.com/nodejs/node/tree/master
refack:common.expectError-you-would-not-expect-expectError-to-errhttps://github.com/refack/node/tree/common.expectError-you-would-not-expect-expectError-to-err
Conversationhttps://github.com/nodejs/node/pull/13686
Commits3 (3)https://github.com/nodejs/node/pull/13686/commits
Checkshttps://github.com/nodejs/node/pull/13686/checks
Files changedhttps://github.com/nodejs/node/pull/13686/files
fix common.expectsError type checkinghttps://github.com/nodejs/node/pull/13686#top
refackhttps://github.com/refack
nodejs:masterhttps://github.com/nodejs/node/tree/master
refack:common.expectError-you-would-not-expect-expectError-to-errhttps://github.com/refack/node/tree/common.expectError-you-would-not-expect-expectError-to-err
https://github.com/refack
refackhttps://github.com/refack
Jun 14, 2017https://github.com/nodejs/node/pull/13686#issue-235990290
Please reload this pagehttps://github.com/nodejs/node/pull/13686
#13682https://github.com/nodejs/node/issues/13682
@cjihrighttps://github.com/cjihrig
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Jun 14, 2017https://github.com/nodejs/node/pull/13686#event-1123947362
https://github.com/refack
refackhttps://github.com/refack
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Jun 14, 2017https://github.com/nodejs/node/pull/13686#event-1123948106
https://github.com/refack
refackhttps://github.com/refack
Jun 14, 2017https://github.com/nodejs/node/pull/13686#issuecomment-308539279
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/refack
refackhttps://github.com/refack
Jun 14, 2017 https://github.com/nodejs/node/pull/13686#ref-pullrequest-207296563
errors, repl: migrate to use internal/errors.js #11347 https://github.com/nodejs/node/pull/11347
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 14, 2017 https://github.com/nodejs/node/pull/13686#pullrequestreview-44129661
View reviewed changes https://github.com/nodejs/node/pull/13686/files
test/parallel/test-dgram-bind.jshttps://github.com/nodejs/node/pull/13686/files#diff-0556e3d2571099e74619b99a09ea0bbdafe4908ee7bebb3b31a7973f6acbb324
jasnellhttps://github.com/jasnell
Jun 14, 2017https://github.com/nodejs/node/pull/13686#discussion_r122047881
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 14, 2017 https://github.com/nodejs/node/pull/13686#pullrequestreview-44130209
View reviewed changes https://github.com/nodejs/node/pull/13686/files
test/parallel/test-fs-watchfile.jshttps://github.com/nodejs/node/pull/13686/files#diff-6cf404215c88151caea93963d279e4a4630e3e70bbea1ffb49900819c70f5885
jasnellhttps://github.com/jasnell
Jun 14, 2017https://github.com/nodejs/node/pull/13686#discussion_r122048369
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 14, 2017 https://github.com/nodejs/node/pull/13686#pullrequestreview-44130277
View reviewed changes https://github.com/nodejs/node/pull/13686/files
test/parallel/test-fs-watchfile.jshttps://github.com/nodejs/node/pull/13686/files#diff-6cf404215c88151caea93963d279e4a4630e3e70bbea1ffb49900819c70f5885
jasnellhttps://github.com/jasnell
Jun 14, 2017https://github.com/nodejs/node/pull/13686#discussion_r122048440
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 14, 2017 https://github.com/nodejs/node/pull/13686#pullrequestreview-44130522
View reviewed changes https://github.com/nodejs/node/pull/13686/files
test/parallel/test-internal-errors.jshttps://github.com/nodejs/node/pull/13686/files#diff-dee890a54d8682024c7107ca5fd0f8c219e16a2bf63a5be96a92bfaf851fc25c
jasnellhttps://github.com/jasnell
Jun 14, 2017https://github.com/nodejs/node/pull/13686#discussion_r122048651
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 14, 2017https://github.com/nodejs/node/pull/13686#issuecomment-308541255
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/refack
refackhttps://github.com/refack
Jun 14, 2017https://github.com/nodejs/node/pull/13686#issuecomment-308549010
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 14, 2017https://github.com/nodejs/node/pull/13686#issuecomment-308553933
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 14, 2017https://github.com/nodejs/node/pull/13686#issuecomment-308564933
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/refack
refackhttps://github.com/refack
force-pushedhttps://github.com/nodejs/node/compare/665dca27f67f473d0e6c238b6c0215475262805c..f8405bce42602523004e50f7a3b782a98c71615a
665dca2https://github.com/nodejs/node/commit/665dca27f67f473d0e6c238b6c0215475262805c
f8405bchttps://github.com/nodejs/node/commit/f8405bce42602523004e50f7a3b782a98c71615a
Compare https://github.com/nodejs/node/compare/665dca27f67f473d0e6c238b6c0215475262805c..f8405bce42602523004e50f7a3b782a98c71615a
June 14, 2017 23:12https://github.com/nodejs/node/pull/13686#event-1124210244
https://github.com/refack
refackhttps://github.com/refack
Jun 14, 2017https://github.com/nodejs/node/pull/13686#event-1124211118
https://github.com/refack
refackhttps://github.com/refack
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Jun 14, 2017https://github.com/nodejs/node/pull/13686#event-1124211156
https://github.com/refack
refackhttps://github.com/refack
Jun 14, 2017https://github.com/nodejs/node/pull/13686#issuecomment-308584850
https://ci.nodejs.org/job/node-test-commit-linuxone/6638/https://ci.nodejs.org/job/node-test-commit-linuxone/6638/
@jasnellhttps://github.com/jasnell
fix common.expectsError type checking #13686 (comment)https://github.com/nodejs/node/pull/13686#issuecomment-308541255
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/refack
refackhttps://github.com/refack
Jun 14, 2017https://github.com/nodejs/node/pull/13686#issuecomment-308584957
https://ci.nodejs.org/job/node-test-pull-request/8663/https://ci.nodejs.org/job/node-test-pull-request/8663/
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/refack
refackhttps://github.com/refack
Jun 14, 2017https://github.com/nodejs/node/pull/13686#event-1124216313
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 15, 2017https://github.com/nodejs/node/pull/13686#issuecomment-308591218
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 15, 2017https://github.com/nodejs/node/pull/13686#issuecomment-308592335
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 15, 2017https://github.com/nodejs/node/pull/13686#issuecomment-308891343
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/refack
refackhttps://github.com/refack
Jun 16, 2017https://github.com/nodejs/node/pull/13686#issuecomment-308915875
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 16, 2017https://github.com/nodejs/node/pull/13686#issuecomment-309045705
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 16, 2017 https://github.com/nodejs/node/pull/13686#pullrequestreview-44580232
View reviewed changes https://github.com/nodejs/node/pull/13686/files
test/parallel/test-fs-realpath.jshttps://github.com/nodejs/node/pull/13686/files#diff-ffa673f4e2a32cc7923e6d486362b6600b5763f682490d8e7d9609d4b7e9d2ff
jasnellhttps://github.com/jasnell
Jun 16, 2017https://github.com/nodejs/node/pull/13686#discussion_r122459294
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13686
refackhttps://github.com/refack
Jun 17, 2017https://github.com/nodejs/node/pull/13686#discussion_r122560420
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13686
jasnellhttps://github.com/jasnell
Jun 19, 2017https://github.com/nodejs/node/pull/13686#discussion_r122773120
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13686
refackhttps://github.com/refack
Jun 19, 2017https://github.com/nodejs/node/pull/13686#discussion_r122775571
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 16, 2017 https://github.com/nodejs/node/pull/13686#pullrequestreview-44580756
View reviewed changes https://github.com/nodejs/node/pull/13686/files
test/common/index.jshttps://github.com/nodejs/node/pull/13686/files#diff-f75d7f53e0dbb5033126f9e985a67109aecee73364c6f41e6e2c125178ab48bb
jasnellhttps://github.com/jasnell
Jun 16, 2017https://github.com/nodejs/node/pull/13686#discussion_r122459760
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13686
refackhttps://github.com/refack
Jun 17, 2017https://github.com/nodejs/node/pull/13686#discussion_r122560377
Please reload this pagehttps://github.com/nodejs/node/pull/13686
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13686
jasnellhttps://github.com/jasnell
Jun 19, 2017https://github.com/nodejs/node/pull/13686#discussion_r122739824
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13686
cjihrighttps://github.com/cjihrig
Jun 19, 2017https://github.com/nodejs/node/pull/13686#discussion_r122740826
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13686
refackhttps://github.com/refack
Jun 19, 2017https://github.com/nodejs/node/pull/13686#discussion_r122749758
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/13686
jasnellhttps://github.com/jasnell
Jun 19, 2017https://github.com/nodejs/node/pull/13686#discussion_r122761939
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13686
cjihrighttps://github.com/cjihrig
Jun 19, 2017https://github.com/nodejs/node/pull/13686#discussion_r122764564
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13686
refackhttps://github.com/refack
Jun 19, 2017https://github.com/nodejs/node/pull/13686#discussion_r122765916
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
one such casehttps://github.com/nodejs/node/pull/13686/commits/215099b06a3addffe33a21c78fa5f2e6e62a5e23#diff-9e1e157e684832463865e5433e9be5deL153
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/refack
refackhttps://github.com/refack
Jun 19, 2017https://github.com/nodejs/node/pull/13686#issuecomment-309506798
Please reload this pagehttps://github.com/nodejs/node/pull/13686
ceef6c7https://github.com/nodejs/node/commit/ceef6c75652b8ccf029d00eda59f58c51671d712
2012d3fhttps://github.com/nodejs/node/commit/2012d3f4ae5ca1c3a4d0a2148ed7af2d3b7a32f2
b0c8375https://github.com/nodejs/node/commit/b0c8375a7ad4e3850a942e5aceba9810df7347f1
fix common.expectsError type checking #13686 (comment)https://github.com/nodejs/node/pull/13686#discussion_r122048369
f8405bchttps://github.com/nodejs/node/commit/f8405bce42602523004e50f7a3b782a98c71615a
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 19, 2017 https://github.com/nodejs/node/pull/13686#pullrequestreview-44918018
View reviewed changes https://github.com/nodejs/node/pull/13686/files
test/parallel/test-internal-errors.jshttps://github.com/nodejs/node/pull/13686/files#diff-dee890a54d8682024c7107ca5fd0f8c219e16a2bf63a5be96a92bfaf851fc25c
jasnellhttps://github.com/jasnell
Jun 19, 2017https://github.com/nodejs/node/pull/13686#discussion_r122773305
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 19, 2017https://github.com/nodejs/node/pull/13686#issuecomment-309512418
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/refack
refackhttps://github.com/refack
Jun 19, 2017https://github.com/nodejs/node/pull/13686#issuecomment-309514696
https://ci.nodejs.org/job/node-test-commit-linuxone/6738/nodes=rhel72-s390x/https://ci.nodejs.org/job/node-test-commit-linuxone/6738/nodes=rhel72-s390x/
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jan 6, 2018https://github.com/nodejs/node/pull/13686#issuecomment-355720241
15016f2https://github.com/nodejs/node/commit/15016f227b371c85dc74c0ad3d773ce9814fdfb3
29d99c1https://github.com/nodejs/node/commit/29d99c1885cc99c955543df33b9f43d48158fc0d
f26cabbhttps://github.com/nodejs/node/commit/f26cabbe249ae6e095736ef65bd925fb82c4908c
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jan 6, 2018https://github.com/nodejs/node/pull/13686#event-1412276701
BridgeARhttps://github.com/BridgeAR
Jan 6, 2018 https://github.com/nodejs/node/pull/13686#ref-commit-f26cabb
https://github.com/BridgeAR
test: fix wrong error classes passed in as typehttps://github.com/BridgeAR/node/commit/f26cabbe249ae6e095736ef65bd925fb82c4908c
f26cabbhttps://github.com/BridgeAR/node/commit/f26cabbe249ae6e095736ef65bd925fb82c4908c
nodejs#13686https://github.com/nodejs/node/pull/13686
nodejs#13682https://github.com/nodejs/node/issues/13682
BridgeARhttps://github.com/BridgeAR
Jan 6, 2018 https://github.com/nodejs/node/pull/13686#ref-commit-29d99c1
https://github.com/refack
https://github.com/BridgeAR
test: fix common.expectsErrorhttps://github.com/BridgeAR/node/commit/29d99c1885cc99c955543df33b9f43d48158fc0d
29d99c1https://github.com/BridgeAR/node/commit/29d99c1885cc99c955543df33b9f43d48158fc0d
nodejs#13686https://github.com/nodejs/node/pull/13686
nodejs#13682https://github.com/nodejs/node/issues/13682
BridgeARhttps://github.com/BridgeAR
Jan 6, 2018 https://github.com/nodejs/node/pull/13686#ref-commit-15016f2
https://github.com/refack
https://github.com/BridgeAR
test: add more asserts to test-internal-errorshttps://github.com/BridgeAR/node/commit/15016f227b371c85dc74c0ad3d773ce9814fdfb3
15016f2https://github.com/BridgeAR/node/commit/15016f227b371c85dc74c0ad3d773ce9814fdfb3
nodejs#13686https://github.com/nodejs/node/pull/13686
nodejs#13682https://github.com/nodejs/node/issues/13682
MylesBorinshttps://github.com/MylesBorins
Jan 8, 2018 https://github.com/nodejs/node/pull/13686#ref-commit-d7e536d
https://github.com/refack
https://github.com/MylesBorins
test: fix common.expectsErrorhttps://github.com/nodejs/node/commit/d7e536d27273f8fb7161a72ee9dadb9a4358f35b
d7e536dhttps://github.com/nodejs/node/commit/d7e536d27273f8fb7161a72ee9dadb9a4358f35b
#13686https://github.com/nodejs/node/pull/13686
#13682https://github.com/nodejs/node/issues/13682
MylesBorinshttps://github.com/MylesBorins
Jan 8, 2018 https://github.com/nodejs/node/pull/13686#ref-commit-015c146
https://github.com/refack
https://github.com/MylesBorins
test: add more asserts to test-internal-errorshttps://github.com/nodejs/node/commit/015c1469e6b4bb89c2ac290ee5db2fa381810e44
015c146https://github.com/nodejs/node/commit/015c1469e6b4bb89c2ac290ee5db2fa381810e44
#13686https://github.com/nodejs/node/pull/13686
#13682https://github.com/nodejs/node/issues/13682
MylesBorinshttps://github.com/MylesBorins
Jan 9, 2018 https://github.com/nodejs/node/pull/13686#ref-commit-95ff8f0
https://github.com/refack
https://github.com/MylesBorins
test: fix common.expectsErrorhttps://github.com/nodejs/node/commit/95ff8f0aef19fce25878cad58f88ab579e8641da
95ff8f0https://github.com/nodejs/node/commit/95ff8f0aef19fce25878cad58f88ab579e8641da
#13686https://github.com/nodejs/node/pull/13686
#13682https://github.com/nodejs/node/issues/13682
MylesBorinshttps://github.com/MylesBorins
Jan 9, 2018 https://github.com/nodejs/node/pull/13686#ref-commit-fffb127
https://github.com/refack
https://github.com/MylesBorins
test: add more asserts to test-internal-errorshttps://github.com/nodejs/node/commit/fffb12757b630e00a5a61981319b15ebbec07611
fffb127https://github.com/nodejs/node/commit/fffb12757b630e00a5a61981319b15ebbec07611
#13686https://github.com/nodejs/node/pull/13686
#13682https://github.com/nodejs/node/issues/13682
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 9, 2018https://github.com/nodejs/node/pull/13686#issuecomment-356223696
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backport-requested-v9.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v9.x
Jan 9, 2018https://github.com/nodejs/node/pull/13686#event-1415209831
targoshttps://github.com/targos
Mar 24, 2018 https://github.com/nodejs/node/pull/13686#ref-commit-b59f421
https://github.com/refack
https://github.com/targos
test: add more asserts to test-internal-errorshttps://github.com/targos/node/commit/b59f42184f39e96d532edf138eaf24f014523f30
b59f421https://github.com/targos/node/commit/b59f42184f39e96d532edf138eaf24f014523f30
nodejs#13686https://github.com/nodejs/node/pull/13686
nodejs#13682https://github.com/nodejs/node/issues/13682
targoshttps://github.com/targos
Mar 24, 2018 https://github.com/nodejs/node/pull/13686#ref-commit-fd94671
https://github.com/refack
https://github.com/targos
test: fix common.expectsErrorhttps://github.com/targos/node/commit/fd9467196f4be75a35fd278e9810fb0fe89db97f
fd94671https://github.com/targos/node/commit/fd9467196f4be75a35fd278e9810fb0fe89db97f
nodejs#13686https://github.com/nodejs/node/pull/13686
nodejs#13682https://github.com/nodejs/node/issues/13682
targoshttps://github.com/targos
Mar 24, 2018 https://github.com/nodejs/node/pull/13686#ref-commit-8e5fd45
https://github.com/BridgeAR
https://github.com/targos
test: fix wrong error classes passed in as typehttps://github.com/targos/node/commit/8e5fd45ce2cdc2e2e9f4d417ca2d0702515947a4
8e5fd45https://github.com/targos/node/commit/8e5fd45ce2cdc2e2e9f4d417ca2d0702515947a4
nodejs#13686https://github.com/nodejs/node/pull/13686
nodejs#13682https://github.com/nodejs/node/issues/13682
https://github.com/targos
targoshttps://github.com/targos
Mar 24, 2018 https://github.com/nodejs/node/pull/13686#ref-pullrequest-308283413
[v9.x backport] Various http2 changes #19579 https://github.com/nodejs/node/pull/19579
targoshttps://github.com/targos
Mar 30, 2018 https://github.com/nodejs/node/pull/13686#ref-commit-cc68bc2
https://github.com/refack
https://github.com/targos
test: add more asserts to test-internal-errorshttps://github.com/nodejs/node/commit/cc68bc27f8acc62fb8b2145865c995415648735a
cc68bc2https://github.com/nodejs/node/commit/cc68bc27f8acc62fb8b2145865c995415648735a
#19579https://github.com/nodejs/node/pull/19579
#13686https://github.com/nodejs/node/pull/13686
#13682https://github.com/nodejs/node/issues/13682
targoshttps://github.com/targos
Mar 30, 2018 https://github.com/nodejs/node/pull/13686#ref-commit-44b12c1
https://github.com/refack
https://github.com/targos
test: fix common.expectsErrorhttps://github.com/nodejs/node/commit/44b12c158def631962a1907140d679dc293567a8
44b12c1https://github.com/nodejs/node/commit/44b12c158def631962a1907140d679dc293567a8
#19579https://github.com/nodejs/node/pull/19579
#13686https://github.com/nodejs/node/pull/13686
#13682https://github.com/nodejs/node/issues/13682
targoshttps://github.com/targos
Mar 30, 2018 https://github.com/nodejs/node/pull/13686#ref-commit-ca97be5
https://github.com/BridgeAR
https://github.com/targos
test: fix wrong error classes passed in as typehttps://github.com/nodejs/node/commit/ca97be52a2d3a6c23aeb942e8cd65202a2e7f147
ca97be5https://github.com/nodejs/node/commit/ca97be52a2d3a6c23aeb942e8cd65202a2e7f147
#19579https://github.com/nodejs/node/pull/19579
#13686https://github.com/nodejs/node/pull/13686
#13682https://github.com/nodejs/node/issues/13682
https://github.com/targos
targoshttps://github.com/targos
backported-to-v9.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v9.x
backport-requested-v9.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v9.x
Mar 30, 2018https://github.com/nodejs/node/pull/13686#event-1549719343
https://github.com/targos
targoshttps://github.com/targos
Apr 4, 2018 https://github.com/nodejs/node/pull/13686#ref-pullrequest-311275671
v9.11.0 proposal #19799 https://github.com/nodejs/node/pull/19799
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
backport-requested-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v8.x
Jul 31, 2018https://github.com/nodejs/node/pull/13686#event-1763478438
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jul 31, 2018https://github.com/nodejs/node/pull/13686#issuecomment-409326143
#19244https://github.com/nodejs/node/pull/19244
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/refack
refackhttps://github.com/refack
Oct 12, 2018https://github.com/nodejs/node/pull/13686#event-1899617728
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13686
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/13686/files/f8405bce42602523004e50f7a3b782a98c71615a
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/13686/files/d4823f477c40944070ba677c3e93d43e89db94c7
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/13686/files/c0606e0626222c7d2269c5599c410f57529fb711
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
test: common.expectsError() is subtly broken https://github.com/nodejs/node/issues/13682
Please reload this pagehttps://github.com/nodejs/node/pull/13686
https://github.com/refack
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/benjamingr
https://github.com/BridgeAR
https://github.com/Trott
https://github.com/joyeecheung
https://github.com/MylesBorins
https://github.com/targos
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.