René's URL Explorer Experiment


Title: buffer: implement WHATWG Encoding Standard API by jasnell · Pull Request #13644 · nodejs/node · GitHub

Open Graph Title: buffer: implement WHATWG Encoding Standard API by jasnell · Pull Request #13644 · nodejs/node

X Title: buffer: implement WHATWG Encoding Standard API by jasnell · Pull Request #13644 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Provide an (initially experimental) implementation of the WHATWG Encoding Standard API (TextDecoder and TextEncoder). The is the same API implemented on the browser side. By default, with small-icu...

X Description: Provide an (initially experimental) implementation of the WHATWG Encoding Standard API (TextDecoder and TextEncoder). The is the same API implemented on the browser side. By default, with small-icu...

Opengraph URL: https://github.com/nodejs/node/pull/13644

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3b99ef13-33a4-a3a4-f6b9-e33f5e1eb699
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA0A4:178552:1AFF86D:229E3F4:6991B5A5
html-safe-noncee99bc6c25e777460a2e9dc8626076fd9ac59fc21257901f96fec6a3d7bed69f3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEE0OjE3ODU1MjoxQUZGODZEOjIyOUUzRjQ6Njk5MUI1QTUiLCJ2aXNpdG9yX2lkIjoiNDQwMTQwMzMwMzQ1NTQzMDc3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd8652b6fe23ff6275ebaf0a4f600970eeb54f8ba8ffafdca444073dd3e7a7adf
hovercard-subject-tagpull_request:125270893
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/13644/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8ad061a84665433385b3b8c2424d228ab49722355cbe797d12123f2f47f3afa6/nodejs/node/pull/13644
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8ad061a84665433385b3b8c2424d228ab49722355cbe797d12123f2f47f3afa6/nodejs/node/pull/13644
og:image:altProvide an (initially experimental) implementation of the WHATWG Encoding Standard API (TextDecoder and TextEncoder). The is the same API implemented on the browser side. By default, with small-icu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/13644#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13644
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13644
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/13644
Reloadhttps://github.com/nodejs/node/pull/13644
Reloadhttps://github.com/nodejs/node/pull/13644
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/13644
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 712 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:encoding-standardhttps://github.com/jasnell/node/tree/encoding-standard
Conversationhttps://github.com/nodejs/node/pull/13644
Commits1 (1)https://github.com/nodejs/node/pull/13644/commits
Checkshttps://github.com/nodejs/node/pull/13644/checks
Files changedhttps://github.com/nodejs/node/pull/13644/files
buffer: implement WHATWG Encoding Standard APIhttps://github.com/nodejs/node/pull/13644#top
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:encoding-standardhttps://github.com/jasnell/node/tree/encoding-standard
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 13, 2017https://github.com/nodejs/node/pull/13644#issue-235424368
https://encoding.spec.whatwg.org/https://encoding.spec.whatwg.org/
@domenichttps://github.com/domenic
@TimothyGuhttps://github.com/TimothyGu
@addaleaxhttps://github.com/addaleax
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/jasnell
jasnellhttps://github.com/jasnell
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Jun 13, 2017https://github.com/nodejs/node/pull/13644#event-1120609582
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
i18n-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Jun 13, 2017https://github.com/nodejs/node/pull/13644#event-1120609619
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jun 13, 2017https://github.com/nodejs/node/pull/13644#issuecomment-307999910
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 13, 2017https://github.com/nodejs/node/pull/13644#issuecomment-308002722
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/domenic
domenichttps://github.com/domenic
Jun 13, 2017 https://github.com/nodejs/node/pull/13644#ref-issue-235434040
Discussion of implementing the Encoding Standard with ICU, and associated web platform tests #13646 https://github.com/nodejs/node/issues/13646
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 13, 2017 https://github.com/nodejs/node/pull/13644#pullrequestreview-43646668
View reviewed changes https://github.com/nodejs/node/pull/13644/files
TimothyGuhttps://github.com/TimothyGu
https://github.com/nodejs/node/pull/13644#pullrequestreview-43646668
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
lib/internal/encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3
TimothyGuhttps://github.com/TimothyGu
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121607674
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
spechttps://encoding.spec.whatwg.org/#concept-encoding-get
Please reload this pagehttps://github.com/nodejs/node/pull/13644
lib/internal/encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3
TimothyGuhttps://github.com/TimothyGu
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121607859
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
ASCII whitespacehttps://infra.spec.whatwg.org/#ascii-whitespace
spechttps://encoding.spec.whatwg.org/#concept-encoding-get
Please reload this pagehttps://github.com/nodejs/node/pull/13644
lib/internal/encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3
TimothyGuhttps://github.com/TimothyGu
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121607979
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
src/node_i18n.cchttps://github.com/nodejs/node/pull/13644/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de
TimothyGuhttps://github.com/TimothyGu
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121608333
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
lib/internal/encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3
TimothyGuhttps://github.com/TimothyGu
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121609474
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
src/node_i18n.cchttps://github.com/nodejs/node/pull/13644/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de
TimothyGuhttps://github.com/TimothyGu
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121613159
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
src/node_i18n.cchttps://github.com/nodejs/node/pull/13644/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de
TimothyGuhttps://github.com/TimothyGu
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121613823
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
TimothyGuhttps://github.com/TimothyGu
Jun 15, 2017https://github.com/nodejs/node/pull/13644#discussion_r122125387
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
jasnellhttps://github.com/jasnell
Jun 15, 2017https://github.com/nodejs/node/pull/13644#discussion_r122304327
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
src/node_i18n.cchttps://github.com/nodejs/node/pull/13644/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de
TimothyGuhttps://github.com/TimothyGu
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121614215
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
tools/icu/icu-generic.gyphttps://github.com/nodejs/node/pull/13644/files#diff-205ef7ec1e9f132109d49def57108823e0ef5a9cf8111dd6a962b2e65b931322
TimothyGuhttps://github.com/TimothyGu
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121615944
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
jasnellhttps://github.com/jasnell
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121748752
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
doc/api/buffer.mdhttps://github.com/nodejs/node/pull/13644/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0
TimothyGuhttps://github.com/TimothyGu
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121616327
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121652830
Please reload this pagehttps://github.com/nodejs/node/pull/13644
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/nodejs/node/blob/master/BUILDING.md#intl-ecma-402-supporthttps://github.com/nodejs/node/blob/master/BUILDING.md#intl-ecma-402-support
https://github.com/nodejs/node/wiki/Intlhttps://github.com/nodejs/node/wiki/Intl
Please reload this pagehttps://github.com/nodejs/node/pull/13644
jasnellhttps://github.com/jasnell
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121763005
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 13, 2017 https://github.com/nodejs/node/pull/13644#pullrequestreview-43660036
View reviewed changes https://github.com/nodejs/node/pull/13644/files
lib/internal/encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3
TimothyGuhttps://github.com/TimothyGu
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121620444
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
spechttps://encoding.spec.whatwg.org/#dom-textencoder-encode
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 13, 2017 https://github.com/nodejs/node/pull/13644#pullrequestreview-43694497
View reviewed changes https://github.com/nodejs/node/pull/13644/files
doc/api/buffer.mdhttps://github.com/nodejs/node/pull/13644/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121650985
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 13, 2017 https://github.com/nodejs/node/pull/13644#pullrequestreview-43695475
View reviewed changes https://github.com/nodejs/node/pull/13644/files
doc/api/buffer.mdhttps://github.com/nodejs/node/pull/13644/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121651939
Please reload this pagehttps://github.com/nodejs/node/pull/13644
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 13, 2017 https://github.com/nodejs/node/pull/13644#pullrequestreview-43695632
View reviewed changes https://github.com/nodejs/node/pull/13644/files
doc/api/buffer.mdhttps://github.com/nodejs/node/pull/13644/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121652072
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 13, 2017 https://github.com/nodejs/node/pull/13644#pullrequestreview-43699242
View reviewed changes https://github.com/nodejs/node/pull/13644/files
doc/api/buffer.mdhttps://github.com/nodejs/node/pull/13644/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121655137
Please reload this pagehttps://github.com/nodejs/node/pull/13644
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
TimothyGuhttps://github.com/TimothyGu
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121664078
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121666075
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/vsemozhetbyt
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 13, 2017 https://github.com/nodejs/node/pull/13644#pullrequestreview-43702546
View reviewed changes https://github.com/nodejs/node/pull/13644/files
test/parallel/test-whatwg-encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-7f5dd7382a9ac836835998f3ada2166a43a242fec30a5302084d8ec07a7c3b0a
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121658087
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
TimothyGuhttps://github.com/TimothyGu
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121662425
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121662971
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@TimothyGuhttps://github.com/TimothyGu
Please reload this pagehttps://github.com/nodejs/node/pull/13644
TimothyGuhttps://github.com/TimothyGu
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121665757
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/nodejs/node/blob/master/tools/eslint-rules/require-buffer.jshttps://github.com/nodejs/node/blob/master/tools/eslint-rules/require-buffer.js
#1794https://github.com/nodejs/node/pull/1794
Please reload this pagehttps://github.com/nodejs/node/pull/13644
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121667233
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
lib/.eslintrc.yamlhttps://github.com/nodejs/node/blob/master/lib/.eslintrc.yaml#L3
test/.eslintrc.yamlhttps://github.com/nodejs/node/blob/master/test/.eslintrc.yaml
Please reload this pagehttps://github.com/nodejs/node/pull/13644
TimothyGuhttps://github.com/TimothyGu
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121677073
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
nodejs/node-convergence-archive#21https://github.com/nodejs/node-convergence-archive/issues/21
Please reload this pagehttps://github.com/nodejs/node/pull/13644
vsemozhetbythttps://github.com/vsemozhetbyt
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121680110
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@TimothyGuhttps://github.com/TimothyGu
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 13, 2017https://github.com/nodejs/node/pull/13644#issuecomment-308211271
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Jun 13, 2017 https://github.com/nodejs/node/pull/13644#pullrequestreview-43819487
View reviewed changes https://github.com/nodejs/node/pull/13644/files
doc/api/buffer.mdhttps://github.com/nodejs/node/pull/13644/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0
sam-githubhttps://github.com/sam-github
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121764640
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://help.github.com/articles/organizing-information-with-tables/https://help.github.com/articles/organizing-information-with-tables/
Please reload this pagehttps://github.com/nodejs/node/pull/13644
jasnellhttps://github.com/jasnell
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121765267
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Jun 13, 2017 https://github.com/nodejs/node/pull/13644#pullrequestreview-43820517
View reviewed changes https://github.com/nodejs/node/pull/13644/files
doc/api/buffer.mdhttps://github.com/nodejs/node/pull/13644/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0
sam-githubhttps://github.com/sam-github
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121765551
Please reload this pagehttps://github.com/nodejs/node/pull/13644
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
jasnellhttps://github.com/jasnell
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121767488
Please reload this pagehttps://github.com/nodejs/node/pull/13644
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
sam-githubhttps://github.com/sam-github
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121768939
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 14, 2017 https://github.com/nodejs/node/pull/13644#pullrequestreview-43885764
View reviewed changes https://github.com/nodejs/node/pull/13644/files
lib/internal/encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3
TimothyGuhttps://github.com/TimothyGu
Jun 13, 2017https://github.com/nodejs/node/pull/13644#discussion_r121825948
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://heycam.github.io/webidl/#es-dictionaryhttps://heycam.github.io/webidl/#es-dictionary
Please reload this pagehttps://github.com/nodejs/node/pull/13644
lib/internal/encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3
TimothyGuhttps://github.com/TimothyGu
Jun 14, 2017https://github.com/nodejs/node/pull/13644#discussion_r121826126
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
recognizeshttps://heycam.github.io/webidl/#es-boolean
Please reload this pagehttps://github.com/nodejs/node/pull/13644
lib/internal/encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3
TimothyGuhttps://github.com/TimothyGu
Jun 14, 2017https://github.com/nodejs/node/pull/13644#discussion_r121826416
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
herehttps://github.com/nodejs/node/blob/448c4c62d2b413226dfdef03d6f8d243de0984a3/lib/internal/url.js#L56
Please reload this pagehttps://github.com/nodejs/node/pull/13644
lib/internal/encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3
TimothyGuhttps://github.com/TimothyGu
Jun 14, 2017https://github.com/nodejs/node/pull/13644#discussion_r121826497
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
lib/internal/encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3
TimothyGuhttps://github.com/TimothyGu
Jun 14, 2017https://github.com/nodejs/node/pull/13644#discussion_r121826788
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://heycam.github.io/webidl/#es-buffer-source-typeshttps://heycam.github.io/webidl/#es-buffer-source-types
Please reload this pagehttps://github.com/nodejs/node/pull/13644
jasnellhttps://github.com/jasnell
Jun 14, 2017https://github.com/nodejs/node/pull/13644#discussion_r122028045
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
domenichttps://github.com/domenic
Jun 14, 2017https://github.com/nodejs/node/pull/13644#discussion_r122032312
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
jasnellhttps://github.com/jasnell
Jun 14, 2017https://github.com/nodejs/node/pull/13644#discussion_r122043763
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
src/node_i18n.cchttps://github.com/nodejs/node/pull/13644/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de
TimothyGuhttps://github.com/TimothyGu
Jun 14, 2017https://github.com/nodejs/node/pull/13644#discussion_r121828291
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
src/node_i18n.cchttps://github.com/nodejs/node/pull/13644/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de
TimothyGuhttps://github.com/TimothyGu
Jun 14, 2017https://github.com/nodejs/node/pull/13644#discussion_r121828347
Please reload this pagehttps://github.com/nodejs/node/pull/13644
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
src/node_i18n.cchttps://github.com/nodejs/node/pull/13644/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de
TimothyGuhttps://github.com/TimothyGu
Jun 14, 2017https://github.com/nodejs/node/pull/13644#discussion_r121828739
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
src/node_i18n.cchttps://github.com/nodejs/node/pull/13644/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de
TimothyGuhttps://github.com/TimothyGu
Jun 14, 2017https://github.com/nodejs/node/pull/13644#discussion_r121828794
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
jasnellhttps://github.com/jasnell
Jun 14, 2017https://github.com/nodejs/node/pull/13644#discussion_r122040995
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://encoding.spec.whatwg.org/#interface-textdecoderhttps://encoding.spec.whatwg.org/#interface-textdecoder
Please reload this pagehttps://github.com/nodejs/node/pull/13644
src/node_i18n.cchttps://github.com/nodejs/node/pull/13644/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de
TimothyGuhttps://github.com/TimothyGu
Jun 14, 2017https://github.com/nodejs/node/pull/13644#discussion_r121829082
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
docshttp://icu-project.org/apiref/icu4c/ucnv_8h.html#ad43176e199992be4069b67177ce6d3ce
Please reload this pagehttps://github.com/nodejs/node/pull/13644
jasnellhttps://github.com/jasnell
Jun 14, 2017https://github.com/nodejs/node/pull/13644#discussion_r122042048
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
TimothyGuhttps://github.com/TimothyGu
Jun 15, 2017https://github.com/nodejs/node/pull/13644#discussion_r122108401
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 14, 2017 https://github.com/nodejs/node/pull/13644#pullrequestreview-43954033
View reviewed changes https://github.com/nodejs/node/pull/13644/files
lib/internal/encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3
TimothyGuhttps://github.com/TimothyGu
Jun 14, 2017https://github.com/nodejs/node/pull/13644#discussion_r121890499
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://encoding.spec.whatwg.org/#interface-textencoderhttps://encoding.spec.whatwg.org/#interface-textencoder
Please reload this pagehttps://github.com/nodejs/node/pull/13644
lib/internal/encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3
TimothyGuhttps://github.com/TimothyGu
Jun 14, 2017https://github.com/nodejs/node/pull/13644#discussion_r121890717
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
node/lib/internal/url.jshttps://github.com/nodejs/node/blob/448c4c62d2b413226dfdef03d6f8d243de0984a3/lib/internal/url.js#L56
448c4c6https://github.com/nodejs/node/commit/448c4c62d2b413226dfdef03d6f8d243de0984a3
Please reload this pagehttps://github.com/nodejs/node/pull/13644
lib/internal/encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3
TimothyGuhttps://github.com/TimothyGu
Jun 14, 2017https://github.com/nodejs/node/pull/13644#discussion_r121890849
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/1e8402f57c5bf2f46a52a8edf2f11ae0b79ce004..97f84761add6d1e6fb79852618ac47e4bfa505cc
1e8402fhttps://github.com/nodejs/node/commit/1e8402f57c5bf2f46a52a8edf2f11ae0b79ce004
97f8476https://github.com/nodejs/node/commit/97f84761add6d1e6fb79852618ac47e4bfa505cc
Compare https://github.com/nodejs/node/compare/1e8402f57c5bf2f46a52a8edf2f11ae0b79ce004..97f84761add6d1e6fb79852618ac47e4bfa505cc
June 14, 2017 19:33https://github.com/nodejs/node/pull/13644#event-1123924049
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 14, 2017https://github.com/nodejs/node/pull/13644#issuecomment-308535477
@TimothyGuhttps://github.com/TimothyGu
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 15, 2017 https://github.com/nodejs/node/pull/13644#pullrequestreview-44210617
View reviewed changes https://github.com/nodejs/node/pull/13644/files
TimothyGuhttps://github.com/TimothyGu
https://github.com/nodejs/node/pull/13644#pullrequestreview-44210617
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
doc/api/buffer.mdhttps://github.com/nodejs/node/pull/13644/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0
TimothyGuhttps://github.com/TimothyGu
Jun 15, 2017https://github.com/nodejs/node/pull/13644#discussion_r122124554
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
doc/api/buffer.mdhttps://github.com/nodejs/node/pull/13644/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0
TimothyGuhttps://github.com/TimothyGu
Jun 15, 2017https://github.com/nodejs/node/pull/13644#discussion_r122124625
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
doc/api/buffer.mdhttps://github.com/nodejs/node/pull/13644/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0
TimothyGuhttps://github.com/TimothyGu
Jun 15, 2017https://github.com/nodejs/node/pull/13644#discussion_r122124743
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
lib/internal/encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3
TimothyGuhttps://github.com/TimothyGu
Jun 15, 2017https://github.com/nodejs/node/pull/13644#discussion_r122125013
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
lib/internal/encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3
TimothyGuhttps://github.com/TimothyGu
Jun 15, 2017https://github.com/nodejs/node/pull/13644#discussion_r122125136
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
jasnellhttps://github.com/jasnell
Jun 15, 2017https://github.com/nodejs/node/pull/13644#discussion_r122301930
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
TimothyGuhttps://github.com/TimothyGu
Jun 16, 2017https://github.com/nodejs/node/pull/13644#discussion_r122347231
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Web IDL create a operation functionhttps://heycam.github.io/webidl/#dfn-create-operation-function
Please reload this pagehttps://github.com/nodejs/node/pull/13644
domenichttps://github.com/domenic
Jun 16, 2017https://github.com/nodejs/node/pull/13644#discussion_r122491727
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
jasnellhttps://github.com/jasnell
Jun 16, 2017https://github.com/nodejs/node/pull/13644#discussion_r122492161
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@domenichttps://github.com/domenic
Please reload this pagehttps://github.com/nodejs/node/pull/13644
domenichttps://github.com/domenic
Jun 16, 2017https://github.com/nodejs/node/pull/13644#discussion_r122499604
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
TimothyGuhttps://github.com/TimothyGu
Jul 18, 2017https://github.com/nodejs/node/pull/13644#discussion_r127867992
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
lib/internal/encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3
TimothyGuhttps://github.com/TimothyGu
Jun 15, 2017https://github.com/nodejs/node/pull/13644#discussion_r122125201
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
jasnellhttps://github.com/jasnell
Jun 15, 2017https://github.com/nodejs/node/pull/13644#discussion_r122302678
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
lib/internal/encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3
TimothyGuhttps://github.com/TimothyGu
Jun 15, 2017https://github.com/nodejs/node/pull/13644#discussion_r122125339
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
src/node_i18n.cchttps://github.com/nodejs/node/pull/13644/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de
TimothyGuhttps://github.com/TimothyGu
Jun 15, 2017https://github.com/nodejs/node/pull/13644#discussion_r122125387
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
lib/internal/encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3
TimothyGuhttps://github.com/TimothyGu
Jun 15, 2017https://github.com/nodejs/node/pull/13644#discussion_r122125467
Please reload this pagehttps://github.com/nodejs/node/pull/13644
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
jasnellhttps://github.com/jasnell
Jun 15, 2017https://github.com/nodejs/node/pull/13644#discussion_r122301480
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 15, 2017https://github.com/nodejs/node/pull/13644#issuecomment-308638611
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://encoding.spec.whatwg.org/#dom-textdecoder-decodehttps://encoding.spec.whatwg.org/#dom-textdecoder-decode
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 15, 2017 https://github.com/nodejs/node/pull/13644#pullrequestreview-44234460
View reviewed changes https://github.com/nodejs/node/pull/13644/files
TimothyGuhttps://github.com/TimothyGu
https://github.com/nodejs/node/pull/13644#pullrequestreview-44234460
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
lib/internal/encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3
TimothyGuhttps://github.com/TimothyGu
Jun 15, 2017https://github.com/nodejs/node/pull/13644#discussion_r122146769
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
lib/internal/encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3
TimothyGuhttps://github.com/TimothyGu
Jun 15, 2017https://github.com/nodejs/node/pull/13644#discussion_r122147224
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 15, 2017https://github.com/nodejs/node/pull/13644#issuecomment-308860823
@TimothyGuhttps://github.com/TimothyGu
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jun 16, 2017 https://github.com/nodejs/node/pull/13644#pullrequestreview-44456405
View reviewed changes https://github.com/nodejs/node/pull/13644/files
TimothyGuhttps://github.com/TimothyGu
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/nodejs/node/pull/13644#pullrequestreview-44456405
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
TimothyGu@0d0f7fchttps://github.com/TimothyGu/node/commit/0d0f7fc79dc0bb57d961a33973c51534c84f370b
Please reload this pagehttps://github.com/nodejs/node/pull/13644
lib/internal/encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3
TimothyGuhttps://github.com/TimothyGu
Jun 16, 2017https://github.com/nodejs/node/pull/13644#discussion_r122347231
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Web IDL create a operation functionhttps://heycam.github.io/webidl/#dfn-create-operation-function
Please reload this pagehttps://github.com/nodejs/node/pull/13644
lib/internal/encoding.jshttps://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3
TimothyGuhttps://github.com/TimothyGu
Jun 16, 2017https://github.com/nodejs/node/pull/13644#discussion_r122347298
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
backport-requested-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v8.x
Jul 27, 2017https://github.com/nodejs/node/pull/13644#event-1182646340
https://github.com/kunalspathak
kunalspathakhttps://github.com/kunalspathak
Jul 28, 2017 https://github.com/nodejs/node/pull/13644#ref-pullrequest-246427311
fix build break from JsCopyString nodejs/node-chakracore#349 https://github.com/nodejs/node-chakracore/pull/349
https://github.com/Trott
Trotthttps://github.com/Trott
ctc-review https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Actc-review
Jul 31, 2017https://github.com/nodejs/node/pull/13644#event-1184995844
jasnellhttps://github.com/jasnell
Aug 1, 2017 https://github.com/nodejs/node/pull/13644#ref-commit-e1f4db6
https://github.com/jasnell
util: implement WHATWG Encoding Standard APIhttps://github.com/jasnell/node/commit/e1f4db6ec6e6b095bf40809531f407d041f13b01
e1f4db6https://github.com/jasnell/node/commit/e1f4db6ec6e6b095bf40809531f407d041f13b01
https://encoding.spec.whatwg.org/https://encoding.spec.whatwg.org/
nodejs#13644https://github.com/nodejs/node/pull/13644
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 1, 2017 https://github.com/nodejs/node/pull/13644#ref-pullrequest-247233236
[8.x] backport of util refactor and whatwg encoding #14585 https://github.com/nodejs/node/pull/14585
addaleaxhttps://github.com/addaleax
Aug 2, 2017 https://github.com/nodejs/node/pull/13644#ref-commit-9a3fc10
https://github.com/jasnell
https://github.com/addaleax
util: implement WHATWG Encoding Standard APIhttps://github.com/nodejs/node/commit/9a3fc10dd4eab551fc0c5176698b5ddd591a4ae3
9a3fc10https://github.com/nodejs/node/commit/9a3fc10dd4eab551fc0c5176698b5ddd591a4ae3
#14585https://github.com/nodejs/node/pull/14585
https://encoding.spec.whatwg.org/https://encoding.spec.whatwg.org/
#13644https://github.com/nodejs/node/pull/13644
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
backported-to-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v8.x
notable-change https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change
backport-requested-v8.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v8.x
Aug 2, 2017https://github.com/nodejs/node/pull/13644#event-1189253033
addaleaxhttps://github.com/addaleax
Aug 2, 2017 https://github.com/nodejs/node/pull/13644#ref-commit-d665127
https://github.com/addaleax
2017-08-??, Version 8.3.0 (Current)https://github.com/nodejs/node/commit/d665127835c214f91f38f92f68426461a5b433da
d665127https://github.com/nodejs/node/commit/d665127835c214f91f38f92f68426461a5b433da
#14574https://github.com/nodejs/node/pull/14574
#14574https://github.com/nodejs/node/pull/14574
https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4dehttps://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de
#14518https://github.com/nodejs/node/pull/14518
#14518https://github.com/nodejs/node/pull/14518
#14409https://github.com/nodejs/node/pull/14409
#14409https://github.com/nodejs/node/pull/14409
#13644https://github.com/nodejs/node/pull/13644
#13644https://github.com/nodejs/node/pull/13644
https://github.com/XadillaXhttps://github.com/XadillaX
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 2, 2017 https://github.com/nodejs/node/pull/13644#ref-pullrequest-247351530
v8.3.0 proposal #14594 https://github.com/nodejs/node/pull/14594
addaleaxhttps://github.com/addaleax
Aug 3, 2017 https://github.com/nodejs/node/pull/13644#ref-commit-178e9dc
https://github.com/addaleax
2017-08-??, Version 8.3.0 (Current)https://github.com/nodejs/node/commit/178e9dc2388b7b527aa91f38d9d0aa4ee7538e1a
178e9dchttps://github.com/nodejs/node/commit/178e9dc2388b7b527aa91f38d9d0aa4ee7538e1a
#14574https://github.com/nodejs/node/pull/14574
#14574https://github.com/nodejs/node/pull/14574
https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4dehttps://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de
#14518https://github.com/nodejs/node/pull/14518
#14518https://github.com/nodejs/node/pull/14518
#13988https://github.com/nodejs/node/pull/13988
#13988https://github.com/nodejs/node/pull/13988
#14409https://github.com/nodejs/node/pull/14409
#14409https://github.com/nodejs/node/pull/14409
#13644https://github.com/nodejs/node/pull/13644
#13644https://github.com/nodejs/node/pull/13644
https://github.com/XadillaXhttps://github.com/XadillaX
addaleaxhttps://github.com/addaleax
Aug 7, 2017 https://github.com/nodejs/node/pull/13644#ref-commit-9f2863f
https://github.com/addaleax
2017-08-??, Version 8.3.0 (Current)https://github.com/nodejs/node/commit/9f2863f1f7bda1917386d242924dd1640a77beba
9f2863fhttps://github.com/nodejs/node/commit/9f2863f1f7bda1917386d242924dd1640a77beba
#14574https://github.com/nodejs/node/pull/14574
#14574https://github.com/nodejs/node/pull/14574
https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4dehttps://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de
#14518https://github.com/nodejs/node/pull/14518
#14518https://github.com/nodejs/node/pull/14518
#13988https://github.com/nodejs/node/pull/13988
#13988https://github.com/nodejs/node/pull/13988
#14409https://github.com/nodejs/node/pull/14409
#14409https://github.com/nodejs/node/pull/14409
#13644https://github.com/nodejs/node/pull/13644
#13644https://github.com/nodejs/node/pull/13644
https://github.com/XadillaXhttps://github.com/XadillaX
cjihrighttps://github.com/cjihrig
Aug 8, 2017 https://github.com/nodejs/node/pull/13644#ref-commit-54cb14c
https://github.com/addaleax
https://github.com/cjihrig
2017-08-08, Version 8.3.0 (Current)https://github.com/nodejs/node/commit/54cb14c4ddbb83d3586894bcbef87549f197510d
54cb14chttps://github.com/nodejs/node/commit/54cb14c4ddbb83d3586894bcbef87549f197510d
#14574https://github.com/nodejs/node/pull/14574
#14574https://github.com/nodejs/node/pull/14574
https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4dehttps://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de
#14518https://github.com/nodejs/node/pull/14518
#14518https://github.com/nodejs/node/pull/14518
#13988https://github.com/nodejs/node/pull/13988
#13988https://github.com/nodejs/node/pull/13988
#14409https://github.com/nodejs/node/pull/14409
#14409https://github.com/nodejs/node/pull/14409
#13644https://github.com/nodejs/node/pull/13644
#13644https://github.com/nodejs/node/pull/13644
https://github.com/XadillaXhttps://github.com/XadillaX
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 9, 2017 https://github.com/nodejs/node/pull/13644#pullrequestreview-55190177
View reviewed changes https://github.com/nodejs/node/pull/13644/files/5622e14d9fed7b65e398b31682859406e2833563
tools/icu/icu-generic.gyphttps://github.com/nodejs/node/pull/13644/files/5622e14d9fed7b65e398b31682859406e2833563#diff-205ef7ec1e9f132109d49def57108823e0ef5a9cf8111dd6a962b2e65b931322
bnoordhuishttps://github.com/bnoordhuis
Aug 9, 2017https://github.com/nodejs/node/pull/13644#discussion_r132142721
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13644
addaleaxhttps://github.com/addaleax
Aug 9, 2017 https://github.com/nodejs/node/pull/13644#ref-commit-fb88fa1
https://github.com/addaleax
2017-08-09, Version 8.3.0 (Current)https://github.com/nodejs/node/commit/fb88fa19f1268d9627035eea0a402d3802a2d26a
fb88fa1https://github.com/nodejs/node/commit/fb88fa19f1268d9627035eea0a402d3802a2d26a
#14574https://github.com/nodejs/node/pull/14574
#14574https://github.com/nodejs/node/pull/14574
https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4dehttps://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de
#14518https://github.com/nodejs/node/pull/14518
#14518https://github.com/nodejs/node/pull/14518
#13988https://github.com/nodejs/node/pull/13988
#13988https://github.com/nodejs/node/pull/13988
#14409https://github.com/nodejs/node/pull/14409
#14409https://github.com/nodejs/node/pull/14409
#13644https://github.com/nodejs/node/pull/13644
#13644https://github.com/nodejs/node/pull/13644
https://github.com/XadillaXhttps://github.com/XadillaX
https://github.com/gabrielschulhofhttps://github.com/gabrielschulhof
cjihrighttps://github.com/cjihrig
Aug 10, 2017 https://github.com/nodejs/node/pull/13644#ref-commit-b72e702
https://github.com/addaleax
https://github.com/cjihrig
2017-08-09, Version 8.3.0 (Current)https://github.com/nodejs/node/commit/b72e702247a4dcbbb9d678253dad2b9b223459f4
b72e702https://github.com/nodejs/node/commit/b72e702247a4dcbbb9d678253dad2b9b223459f4
#14574https://github.com/nodejs/node/pull/14574
#14574https://github.com/nodejs/node/pull/14574
https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4dehttps://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de
#14518https://github.com/nodejs/node/pull/14518
#14518https://github.com/nodejs/node/pull/14518
#13988https://github.com/nodejs/node/pull/13988
#13988https://github.com/nodejs/node/pull/13988
#14409https://github.com/nodejs/node/pull/14409
#14409https://github.com/nodejs/node/pull/14409
#13644https://github.com/nodejs/node/pull/13644
#13644https://github.com/nodejs/node/pull/13644
https://github.com/XadillaXhttps://github.com/XadillaX
https://github.com/gabrielschulhofhttps://github.com/gabrielschulhof
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Sep 12, 2017 https://github.com/nodejs/node/pull/13644#ref-pullrequest-256896859
[v6.x backport] doc: add documentation on ICU #15353 https://github.com/nodejs/node/pull/15353
TimothyGuhttps://github.com/TimothyGu
Sep 15, 2017 https://github.com/nodejs/node/pull/13644#ref-commit-d7293be
https://github.com/TimothyGu
doc: add documentation on ICUhttps://github.com/TimothyGu/node/commit/d7293be4bcfc14797ed659befdeb4d0fd6bc4fcd
d7293behttps://github.com/TimothyGu/node/commit/d7293be4bcfc14797ed659befdeb4d0fd6bc4fcd
nodejs#13916https://github.com/nodejs/node/pull/13916
nodejs#13644 (comment)https://github.com/nodejs/node/pull/13644#discussion_r121616327
MylesBorinshttps://github.com/MylesBorins
Sep 19, 2017 https://github.com/nodejs/node/pull/13644#ref-commit-90fcccd
https://github.com/TimothyGu
https://github.com/MylesBorins
doc: add documentation on ICUhttps://github.com/nodejs/node/commit/90fcccd7a35834780dd838eff941de188d25cb45
90fcccdhttps://github.com/nodejs/node/commit/90fcccd7a35834780dd838eff941de188d25cb45
#13916https://github.com/nodejs/node/pull/13916
#13644 (comment)https://github.com/nodejs/node/pull/13644#discussion_r121616327
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Jan 15, 2018https://github.com/nodejs/node/pull/13644#event-1425117239
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Jan 15, 2018https://github.com/nodejs/node/pull/13644#issuecomment-357799514
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/lance
lancehttps://github.com/lance
Mar 14, 2018 https://github.com/nodejs/node/pull/13644#ref-pullrequest-288328428
test: add assertions for TextEncoder/Decoder #18132 https://github.com/nodejs/node/pull/18132
https://github.com/RReverser
RReverserhttps://github.com/RReverser
Mar 25, 2019 https://github.com/nodejs/node/pull/13644#ref-issue-424929708
Add TextEncoder.prototype.encodeInto #26904 https://github.com/nodejs/node/issues/26904
https://github.com/skyclouds2001
skyclouds2001https://github.com/skyclouds2001
Nov 20, 2024 https://github.com/nodejs/node/pull/13644#ref-issue-2677220714
doc: Missing version info for TextEncoder.prototype.encodeInto() #55938 https://github.com/nodejs/node/issues/55938
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13644
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/13644/files/5622e14d9fed7b65e398b31682859406e2833563
https://github.com/ChALkeR
ChALkeR https://github.com/ChALkeR
https://github.com/nodejs/node/pull/13644/files/f11c21745ae6dc4926e9acc0eb5ce66154dfcc7f
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/13644/files/f11c21745ae6dc4926e9acc0eb5ce66154dfcc7f
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/13644/files/f11c21745ae6dc4926e9acc0eb5ce66154dfcc7f
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/13644/files/1e8402f57c5bf2f46a52a8edf2f11ae0b79ce004
https://github.com/domenic
domenic https://github.com/domenic
https://github.com/nodejs/node/pull/13644/files/97f84761add6d1e6fb79852618ac47e4bfa505cc
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/13644/files/f11c21745ae6dc4926e9acc0eb5ce66154dfcc7f
https://github.com/vsemozhetbyt
vsemozhetbyt https://github.com/vsemozhetbyt
https://github.com/nodejs/node/pull/13644/files/97d2fe8e80ea8f6a6748dafe1863ce29119a0344
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
i18n-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api
notable-change https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Please reload this pagehttps://github.com/nodejs/node/pull/13644
https://github.com/jasnell
https://github.com/mscdex
https://github.com/TimothyGu
https://github.com/yoshuawuyts
https://github.com/domenic
https://github.com/mhdawson
https://github.com/mcollina
https://github.com/calvinmetcalf
https://github.com/tniessen
https://github.com/lucamaraschi
https://github.com/sam-github
https://github.com/bmeck
https://github.com/vsemozhetbyt
https://github.com/addaleax
https://github.com/gibfahn
https://github.com/bnoordhuis
https://github.com/ChALkeR
https://github.com/targos
https://github.com/Trott
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.