| Skip to content | https://github.com/nodejs/node/pull/13644#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13644 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13644 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/13644 |
| Reload | https://github.com/nodejs/node/pull/13644 |
| Reload | https://github.com/nodejs/node/pull/13644 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
712
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:encoding-standard | https://github.com/jasnell/node/tree/encoding-standard |
| Conversation | https://github.com/nodejs/node/pull/13644 |
| Commits1 (1) | https://github.com/nodejs/node/pull/13644/commits |
| Checks | https://github.com/nodejs/node/pull/13644/checks |
| Files changed | https://github.com/nodejs/node/pull/13644/files |
| buffer: implement WHATWG Encoding Standard API | https://github.com/nodejs/node/pull/13644#top |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:encoding-standard | https://github.com/jasnell/node/tree/encoding-standard |
|
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#issue-235424368 |
| https://encoding.spec.whatwg.org/ | https://encoding.spec.whatwg.org/ |
| @domenic | https://github.com/domenic |
| @TimothyGu | https://github.com/TimothyGu |
| @addaleax | https://github.com/addaleax |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#event-1120609582 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
|
i18n-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#event-1120609619 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#issuecomment-307999910 |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#issuecomment-308002722 |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/domenic |
| domenic | https://github.com/domenic |
|
Jun 13, 2017
| https://github.com/nodejs/node/pull/13644#ref-issue-235434040 |
|
Discussion of implementing the Encoding Standard with ICU, and associated web platform tests
#13646
| https://github.com/nodejs/node/issues/13646 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
Jun 13, 2017
| https://github.com/nodejs/node/pull/13644#pullrequestreview-43646668 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13644/files |
| TimothyGu | https://github.com/TimothyGu |
| https://github.com/nodejs/node/pull/13644#pullrequestreview-43646668 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121607674 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| spec | https://encoding.spec.whatwg.org/#concept-encoding-get |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121607859 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| ASCII whitespace | https://infra.spec.whatwg.org/#ascii-whitespace |
| spec | https://encoding.spec.whatwg.org/#concept-encoding-get |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121607979 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| src/node_i18n.cc | https://github.com/nodejs/node/pull/13644/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de |
| TimothyGu | https://github.com/TimothyGu |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121608333 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121609474 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| src/node_i18n.cc | https://github.com/nodejs/node/pull/13644/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de |
| TimothyGu | https://github.com/TimothyGu |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121613159 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| src/node_i18n.cc | https://github.com/nodejs/node/pull/13644/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de |
| TimothyGu | https://github.com/TimothyGu |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121613823 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 15, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122125387 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| jasnell | https://github.com/jasnell |
| Jun 15, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122304327 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| src/node_i18n.cc | https://github.com/nodejs/node/pull/13644/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de |
| TimothyGu | https://github.com/TimothyGu |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121614215 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| tools/icu/icu-generic.gyp | https://github.com/nodejs/node/pull/13644/files#diff-205ef7ec1e9f132109d49def57108823e0ef5a9cf8111dd6a962b2e65b931322 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121615944 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| jasnell | https://github.com/jasnell |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121748752 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| doc/api/buffer.md | https://github.com/nodejs/node/pull/13644/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121616327 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121652830 |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/nodejs/node/blob/master/BUILDING.md#intl-ecma-402-support | https://github.com/nodejs/node/blob/master/BUILDING.md#intl-ecma-402-support |
| https://github.com/nodejs/node/wiki/Intl | https://github.com/nodejs/node/wiki/Intl |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| jasnell | https://github.com/jasnell |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121763005 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
Jun 13, 2017
| https://github.com/nodejs/node/pull/13644#pullrequestreview-43660036 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13644/files |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121620444 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| spec | https://encoding.spec.whatwg.org/#dom-textencoder-encode |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Jun 13, 2017
| https://github.com/nodejs/node/pull/13644#pullrequestreview-43694497 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13644/files |
| doc/api/buffer.md | https://github.com/nodejs/node/pull/13644/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121650985 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Jun 13, 2017
| https://github.com/nodejs/node/pull/13644#pullrequestreview-43695475 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13644/files |
| doc/api/buffer.md | https://github.com/nodejs/node/pull/13644/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121651939 |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Jun 13, 2017
| https://github.com/nodejs/node/pull/13644#pullrequestreview-43695632 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13644/files |
| doc/api/buffer.md | https://github.com/nodejs/node/pull/13644/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121652072 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Jun 13, 2017
| https://github.com/nodejs/node/pull/13644#pullrequestreview-43699242 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13644/files |
| doc/api/buffer.md | https://github.com/nodejs/node/pull/13644/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121655137 |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121664078 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121666075 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Jun 13, 2017
| https://github.com/nodejs/node/pull/13644#pullrequestreview-43702546 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13644/files |
| test/parallel/test-whatwg-encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-7f5dd7382a9ac836835998f3ada2166a43a242fec30a5302084d8ec07a7c3b0a |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121658087 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121662425 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121662971 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @TimothyGu | https://github.com/TimothyGu |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121665757 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/nodejs/node/blob/master/tools/eslint-rules/require-buffer.js | https://github.com/nodejs/node/blob/master/tools/eslint-rules/require-buffer.js |
| #1794 | https://github.com/nodejs/node/pull/1794 |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121667233 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| lib/.eslintrc.yaml | https://github.com/nodejs/node/blob/master/lib/.eslintrc.yaml#L3 |
| test/.eslintrc.yaml | https://github.com/nodejs/node/blob/master/test/.eslintrc.yaml |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121677073 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| nodejs/node-convergence-archive#21 | https://github.com/nodejs/node-convergence-archive/issues/21 |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121680110 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @TimothyGu | https://github.com/TimothyGu |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#issuecomment-308211271 |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Jun 13, 2017
| https://github.com/nodejs/node/pull/13644#pullrequestreview-43819487 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13644/files |
| doc/api/buffer.md | https://github.com/nodejs/node/pull/13644/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0 |
| sam-github | https://github.com/sam-github |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121764640 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://help.github.com/articles/organizing-information-with-tables/ | https://help.github.com/articles/organizing-information-with-tables/ |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| jasnell | https://github.com/jasnell |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121765267 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Jun 13, 2017
| https://github.com/nodejs/node/pull/13644#pullrequestreview-43820517 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13644/files |
| doc/api/buffer.md | https://github.com/nodejs/node/pull/13644/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0 |
| sam-github | https://github.com/sam-github |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121765551 |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| jasnell | https://github.com/jasnell |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121767488 |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| sam-github | https://github.com/sam-github |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121768939 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
Jun 14, 2017
| https://github.com/nodejs/node/pull/13644#pullrequestreview-43885764 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13644/files |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 13, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121825948 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://heycam.github.io/webidl/#es-dictionary | https://heycam.github.io/webidl/#es-dictionary |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 14, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121826126 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| recognizes | https://heycam.github.io/webidl/#es-boolean |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 14, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121826416 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| here | https://github.com/nodejs/node/blob/448c4c62d2b413226dfdef03d6f8d243de0984a3/lib/internal/url.js#L56 |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 14, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121826497 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 14, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121826788 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://heycam.github.io/webidl/#es-buffer-source-types | https://heycam.github.io/webidl/#es-buffer-source-types |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| jasnell | https://github.com/jasnell |
| Jun 14, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122028045 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| domenic | https://github.com/domenic |
| Jun 14, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122032312 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| jasnell | https://github.com/jasnell |
| Jun 14, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122043763 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| src/node_i18n.cc | https://github.com/nodejs/node/pull/13644/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de |
| TimothyGu | https://github.com/TimothyGu |
| Jun 14, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121828291 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| src/node_i18n.cc | https://github.com/nodejs/node/pull/13644/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de |
| TimothyGu | https://github.com/TimothyGu |
| Jun 14, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121828347 |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| src/node_i18n.cc | https://github.com/nodejs/node/pull/13644/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de |
| TimothyGu | https://github.com/TimothyGu |
| Jun 14, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121828739 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| src/node_i18n.cc | https://github.com/nodejs/node/pull/13644/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de |
| TimothyGu | https://github.com/TimothyGu |
| Jun 14, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121828794 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| jasnell | https://github.com/jasnell |
| Jun 14, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122040995 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://encoding.spec.whatwg.org/#interface-textdecoder | https://encoding.spec.whatwg.org/#interface-textdecoder |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| src/node_i18n.cc | https://github.com/nodejs/node/pull/13644/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de |
| TimothyGu | https://github.com/TimothyGu |
| Jun 14, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121829082 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| docs | http://icu-project.org/apiref/icu4c/ucnv_8h.html#ad43176e199992be4069b67177ce6d3ce |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| jasnell | https://github.com/jasnell |
| Jun 14, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122042048 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 15, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122108401 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
Jun 14, 2017
| https://github.com/nodejs/node/pull/13644#pullrequestreview-43954033 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13644/files |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 14, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121890499 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://encoding.spec.whatwg.org/#interface-textencoder | https://encoding.spec.whatwg.org/#interface-textencoder |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 14, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121890717 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| node/lib/internal/url.js | https://github.com/nodejs/node/blob/448c4c62d2b413226dfdef03d6f8d243de0984a3/lib/internal/url.js#L56 |
| 448c4c6 | https://github.com/nodejs/node/commit/448c4c62d2b413226dfdef03d6f8d243de0984a3 |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 14, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r121890849 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/1e8402f57c5bf2f46a52a8edf2f11ae0b79ce004..97f84761add6d1e6fb79852618ac47e4bfa505cc |
| 1e8402f | https://github.com/nodejs/node/commit/1e8402f57c5bf2f46a52a8edf2f11ae0b79ce004 |
| 97f8476 | https://github.com/nodejs/node/commit/97f84761add6d1e6fb79852618ac47e4bfa505cc |
|
Compare
| https://github.com/nodejs/node/compare/1e8402f57c5bf2f46a52a8edf2f11ae0b79ce004..97f84761add6d1e6fb79852618ac47e4bfa505cc |
| June 14, 2017 19:33 | https://github.com/nodejs/node/pull/13644#event-1123924049 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 14, 2017 | https://github.com/nodejs/node/pull/13644#issuecomment-308535477 |
| @TimothyGu | https://github.com/TimothyGu |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
Jun 15, 2017
| https://github.com/nodejs/node/pull/13644#pullrequestreview-44210617 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13644/files |
| TimothyGu | https://github.com/TimothyGu |
| https://github.com/nodejs/node/pull/13644#pullrequestreview-44210617 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| doc/api/buffer.md | https://github.com/nodejs/node/pull/13644/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 15, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122124554 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| doc/api/buffer.md | https://github.com/nodejs/node/pull/13644/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 15, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122124625 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| doc/api/buffer.md | https://github.com/nodejs/node/pull/13644/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 15, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122124743 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 15, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122125013 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 15, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122125136 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| jasnell | https://github.com/jasnell |
| Jun 15, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122301930 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 16, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122347231 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Web IDL create a operation function | https://heycam.github.io/webidl/#dfn-create-operation-function |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| domenic | https://github.com/domenic |
| Jun 16, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122491727 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| jasnell | https://github.com/jasnell |
| Jun 16, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122492161 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @domenic | https://github.com/domenic |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| domenic | https://github.com/domenic |
| Jun 16, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122499604 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| TimothyGu | https://github.com/TimothyGu |
| Jul 18, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r127867992 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 15, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122125201 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| jasnell | https://github.com/jasnell |
| Jun 15, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122302678 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 15, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122125339 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| src/node_i18n.cc | https://github.com/nodejs/node/pull/13644/files#diff-28d6633238de330d8638d6acc0614d2449aabd3b6b25cd4f3fc25747ac46a8de |
| TimothyGu | https://github.com/TimothyGu |
| Jun 15, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122125387 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 15, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122125467 |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| jasnell | https://github.com/jasnell |
| Jun 15, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122301480 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
| Jun 15, 2017 | https://github.com/nodejs/node/pull/13644#issuecomment-308638611 |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://encoding.spec.whatwg.org/#dom-textdecoder-decode | https://encoding.spec.whatwg.org/#dom-textdecoder-decode |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
Jun 15, 2017
| https://github.com/nodejs/node/pull/13644#pullrequestreview-44234460 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13644/files |
| TimothyGu | https://github.com/TimothyGu |
| https://github.com/nodejs/node/pull/13644#pullrequestreview-44234460 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 15, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122146769 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 15, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122147224 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 15, 2017 | https://github.com/nodejs/node/pull/13644#issuecomment-308860823 |
| @TimothyGu | https://github.com/TimothyGu |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
Jun 16, 2017
| https://github.com/nodejs/node/pull/13644#pullrequestreview-44456405 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13644/files |
| TimothyGu | https://github.com/TimothyGu |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/nodejs/node/pull/13644#pullrequestreview-44456405 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| TimothyGu@0d0f7fc | https://github.com/TimothyGu/node/commit/0d0f7fc79dc0bb57d961a33973c51534c84f370b |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 16, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122347231 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Web IDL create a operation function | https://heycam.github.io/webidl/#dfn-create-operation-function |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/13644/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| TimothyGu | https://github.com/TimothyGu |
| Jun 16, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r122347298 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
backport-requested-v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v8.x |
| Jul 27, 2017 | https://github.com/nodejs/node/pull/13644#event-1182646340 |
| https://github.com/kunalspathak |
| kunalspathak | https://github.com/kunalspathak |
|
Jul 28, 2017
| https://github.com/nodejs/node/pull/13644#ref-pullrequest-246427311 |
|
fix build break from JsCopyString
nodejs/node-chakracore#349
| https://github.com/nodejs/node-chakracore/pull/349 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
ctc-review
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Actc-review |
| Jul 31, 2017 | https://github.com/nodejs/node/pull/13644#event-1184995844 |
| jasnell | https://github.com/jasnell |
|
Aug 1, 2017
| https://github.com/nodejs/node/pull/13644#ref-commit-e1f4db6 |
|
| https://github.com/jasnell |
| util: implement WHATWG Encoding Standard API | https://github.com/jasnell/node/commit/e1f4db6ec6e6b095bf40809531f407d041f13b01 |
| e1f4db6 | https://github.com/jasnell/node/commit/e1f4db6ec6e6b095bf40809531f407d041f13b01 |
| https://encoding.spec.whatwg.org/ | https://encoding.spec.whatwg.org/ |
| nodejs#13644 | https://github.com/nodejs/node/pull/13644 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 1, 2017
| https://github.com/nodejs/node/pull/13644#ref-pullrequest-247233236 |
|
[8.x] backport of util refactor and whatwg encoding
#14585
| https://github.com/nodejs/node/pull/14585 |
| addaleax | https://github.com/addaleax |
|
Aug 2, 2017
| https://github.com/nodejs/node/pull/13644#ref-commit-9a3fc10 |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
| util: implement WHATWG Encoding Standard API | https://github.com/nodejs/node/commit/9a3fc10dd4eab551fc0c5176698b5ddd591a4ae3 |
| 9a3fc10 | https://github.com/nodejs/node/commit/9a3fc10dd4eab551fc0c5176698b5ddd591a4ae3 |
| #14585 | https://github.com/nodejs/node/pull/14585 |
| https://encoding.spec.whatwg.org/ | https://encoding.spec.whatwg.org/ |
| #13644 | https://github.com/nodejs/node/pull/13644 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
backported-to-v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v8.x |
|
notable-change
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change |
|
backport-requested-v8.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v8.x |
| Aug 2, 2017 | https://github.com/nodejs/node/pull/13644#event-1189253033 |
| addaleax | https://github.com/addaleax |
|
Aug 2, 2017
| https://github.com/nodejs/node/pull/13644#ref-commit-d665127 |
|
| https://github.com/addaleax |
| 2017-08-??, Version 8.3.0 (Current) | https://github.com/nodejs/node/commit/d665127835c214f91f38f92f68426461a5b433da |
| d665127 | https://github.com/nodejs/node/commit/d665127835c214f91f38f92f68426461a5b433da |
| #14574 | https://github.com/nodejs/node/pull/14574 |
| #14574 | https://github.com/nodejs/node/pull/14574 |
| https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de | https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de |
| #14518 | https://github.com/nodejs/node/pull/14518 |
| #14518 | https://github.com/nodejs/node/pull/14518 |
| #14409 | https://github.com/nodejs/node/pull/14409 |
| #14409 | https://github.com/nodejs/node/pull/14409 |
| #13644 | https://github.com/nodejs/node/pull/13644 |
| #13644 | https://github.com/nodejs/node/pull/13644 |
| https://github.com/XadillaX | https://github.com/XadillaX |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Aug 2, 2017
| https://github.com/nodejs/node/pull/13644#ref-pullrequest-247351530 |
|
v8.3.0 proposal
#14594
| https://github.com/nodejs/node/pull/14594 |
| addaleax | https://github.com/addaleax |
|
Aug 3, 2017
| https://github.com/nodejs/node/pull/13644#ref-commit-178e9dc |
|
| https://github.com/addaleax |
| 2017-08-??, Version 8.3.0 (Current) | https://github.com/nodejs/node/commit/178e9dc2388b7b527aa91f38d9d0aa4ee7538e1a |
| 178e9dc | https://github.com/nodejs/node/commit/178e9dc2388b7b527aa91f38d9d0aa4ee7538e1a |
| #14574 | https://github.com/nodejs/node/pull/14574 |
| #14574 | https://github.com/nodejs/node/pull/14574 |
| https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de | https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de |
| #14518 | https://github.com/nodejs/node/pull/14518 |
| #14518 | https://github.com/nodejs/node/pull/14518 |
| #13988 | https://github.com/nodejs/node/pull/13988 |
| #13988 | https://github.com/nodejs/node/pull/13988 |
| #14409 | https://github.com/nodejs/node/pull/14409 |
| #14409 | https://github.com/nodejs/node/pull/14409 |
| #13644 | https://github.com/nodejs/node/pull/13644 |
| #13644 | https://github.com/nodejs/node/pull/13644 |
| https://github.com/XadillaX | https://github.com/XadillaX |
| addaleax | https://github.com/addaleax |
|
Aug 7, 2017
| https://github.com/nodejs/node/pull/13644#ref-commit-9f2863f |
|
| https://github.com/addaleax |
| 2017-08-??, Version 8.3.0 (Current) | https://github.com/nodejs/node/commit/9f2863f1f7bda1917386d242924dd1640a77beba |
| 9f2863f | https://github.com/nodejs/node/commit/9f2863f1f7bda1917386d242924dd1640a77beba |
| #14574 | https://github.com/nodejs/node/pull/14574 |
| #14574 | https://github.com/nodejs/node/pull/14574 |
| https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de | https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de |
| #14518 | https://github.com/nodejs/node/pull/14518 |
| #14518 | https://github.com/nodejs/node/pull/14518 |
| #13988 | https://github.com/nodejs/node/pull/13988 |
| #13988 | https://github.com/nodejs/node/pull/13988 |
| #14409 | https://github.com/nodejs/node/pull/14409 |
| #14409 | https://github.com/nodejs/node/pull/14409 |
| #13644 | https://github.com/nodejs/node/pull/13644 |
| #13644 | https://github.com/nodejs/node/pull/13644 |
| https://github.com/XadillaX | https://github.com/XadillaX |
| cjihrig | https://github.com/cjihrig |
|
Aug 8, 2017
| https://github.com/nodejs/node/pull/13644#ref-commit-54cb14c |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
| 2017-08-08, Version 8.3.0 (Current) | https://github.com/nodejs/node/commit/54cb14c4ddbb83d3586894bcbef87549f197510d |
| 54cb14c | https://github.com/nodejs/node/commit/54cb14c4ddbb83d3586894bcbef87549f197510d |
| #14574 | https://github.com/nodejs/node/pull/14574 |
| #14574 | https://github.com/nodejs/node/pull/14574 |
| https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de | https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de |
| #14518 | https://github.com/nodejs/node/pull/14518 |
| #14518 | https://github.com/nodejs/node/pull/14518 |
| #13988 | https://github.com/nodejs/node/pull/13988 |
| #13988 | https://github.com/nodejs/node/pull/13988 |
| #14409 | https://github.com/nodejs/node/pull/14409 |
| #14409 | https://github.com/nodejs/node/pull/14409 |
| #13644 | https://github.com/nodejs/node/pull/13644 |
| #13644 | https://github.com/nodejs/node/pull/13644 |
| https://github.com/XadillaX | https://github.com/XadillaX |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Aug 9, 2017
| https://github.com/nodejs/node/pull/13644#pullrequestreview-55190177 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13644/files/5622e14d9fed7b65e398b31682859406e2833563 |
| tools/icu/icu-generic.gyp | https://github.com/nodejs/node/pull/13644/files/5622e14d9fed7b65e398b31682859406e2833563#diff-205ef7ec1e9f132109d49def57108823e0ef5a9cf8111dd6a962b2e65b931322 |
| bnoordhuis | https://github.com/bnoordhuis |
| Aug 9, 2017 | https://github.com/nodejs/node/pull/13644#discussion_r132142721 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| addaleax | https://github.com/addaleax |
|
Aug 9, 2017
| https://github.com/nodejs/node/pull/13644#ref-commit-fb88fa1 |
|
| https://github.com/addaleax |
| 2017-08-09, Version 8.3.0 (Current) | https://github.com/nodejs/node/commit/fb88fa19f1268d9627035eea0a402d3802a2d26a |
| fb88fa1 | https://github.com/nodejs/node/commit/fb88fa19f1268d9627035eea0a402d3802a2d26a |
| #14574 | https://github.com/nodejs/node/pull/14574 |
| #14574 | https://github.com/nodejs/node/pull/14574 |
| https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de | https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de |
| #14518 | https://github.com/nodejs/node/pull/14518 |
| #14518 | https://github.com/nodejs/node/pull/14518 |
| #13988 | https://github.com/nodejs/node/pull/13988 |
| #13988 | https://github.com/nodejs/node/pull/13988 |
| #14409 | https://github.com/nodejs/node/pull/14409 |
| #14409 | https://github.com/nodejs/node/pull/14409 |
| #13644 | https://github.com/nodejs/node/pull/13644 |
| #13644 | https://github.com/nodejs/node/pull/13644 |
| https://github.com/XadillaX | https://github.com/XadillaX |
| https://github.com/gabrielschulhof | https://github.com/gabrielschulhof |
| cjihrig | https://github.com/cjihrig |
|
Aug 10, 2017
| https://github.com/nodejs/node/pull/13644#ref-commit-b72e702 |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
| 2017-08-09, Version 8.3.0 (Current) | https://github.com/nodejs/node/commit/b72e702247a4dcbbb9d678253dad2b9b223459f4 |
| b72e702 | https://github.com/nodejs/node/commit/b72e702247a4dcbbb9d678253dad2b9b223459f4 |
| #14574 | https://github.com/nodejs/node/pull/14574 |
| #14574 | https://github.com/nodejs/node/pull/14574 |
| https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de | https://medium.com/the-node-js-collection/get-ready-a-new-v8-is-coming-node-js-performance-is-changing-46a63d6da4de |
| #14518 | https://github.com/nodejs/node/pull/14518 |
| #14518 | https://github.com/nodejs/node/pull/14518 |
| #13988 | https://github.com/nodejs/node/pull/13988 |
| #13988 | https://github.com/nodejs/node/pull/13988 |
| #14409 | https://github.com/nodejs/node/pull/14409 |
| #14409 | https://github.com/nodejs/node/pull/14409 |
| #13644 | https://github.com/nodejs/node/pull/13644 |
| #13644 | https://github.com/nodejs/node/pull/13644 |
| https://github.com/XadillaX | https://github.com/XadillaX |
| https://github.com/gabrielschulhof | https://github.com/gabrielschulhof |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
Sep 12, 2017
| https://github.com/nodejs/node/pull/13644#ref-pullrequest-256896859 |
|
[v6.x backport] doc: add documentation on ICU
#15353
| https://github.com/nodejs/node/pull/15353 |
| TimothyGu | https://github.com/TimothyGu |
|
Sep 15, 2017
| https://github.com/nodejs/node/pull/13644#ref-commit-d7293be |
|
| https://github.com/TimothyGu |
| doc: add documentation on ICU | https://github.com/TimothyGu/node/commit/d7293be4bcfc14797ed659befdeb4d0fd6bc4fcd |
| d7293be | https://github.com/TimothyGu/node/commit/d7293be4bcfc14797ed659befdeb4d0fd6bc4fcd |
| nodejs#13916 | https://github.com/nodejs/node/pull/13916 |
| nodejs#13644 (comment) | https://github.com/nodejs/node/pull/13644#discussion_r121616327 |
| MylesBorins | https://github.com/MylesBorins |
|
Sep 19, 2017
| https://github.com/nodejs/node/pull/13644#ref-commit-90fcccd |
|
| https://github.com/TimothyGu |
|
| https://github.com/MylesBorins |
| doc: add documentation on ICU | https://github.com/nodejs/node/commit/90fcccd7a35834780dd838eff941de188d25cb45 |
| 90fcccd | https://github.com/nodejs/node/commit/90fcccd7a35834780dd838eff941de188d25cb45 |
| #13916 | https://github.com/nodejs/node/pull/13916 |
| #13644 (comment) | https://github.com/nodejs/node/pull/13644#discussion_r121616327 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Jan 15, 2018 | https://github.com/nodejs/node/pull/13644#event-1425117239 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Jan 15, 2018 | https://github.com/nodejs/node/pull/13644#issuecomment-357799514 |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
| https://github.com/lance |
| lance | https://github.com/lance |
|
Mar 14, 2018
| https://github.com/nodejs/node/pull/13644#ref-pullrequest-288328428 |
|
test: add assertions for TextEncoder/Decoder
#18132
| https://github.com/nodejs/node/pull/18132 |
| https://github.com/RReverser |
| RReverser | https://github.com/RReverser |
|
Mar 25, 2019
| https://github.com/nodejs/node/pull/13644#ref-issue-424929708 |
|
Add TextEncoder.prototype.encodeInto
#26904
| https://github.com/nodejs/node/issues/26904 |
| https://github.com/skyclouds2001 |
| skyclouds2001 | https://github.com/skyclouds2001 |
|
Nov 20, 2024
| https://github.com/nodejs/node/pull/13644#ref-issue-2677220714 |
|
doc: Missing version info for TextEncoder.prototype.encodeInto()
#55938
| https://github.com/nodejs/node/issues/55938 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13644 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/13644/files/5622e14d9fed7b65e398b31682859406e2833563 |
|
| https://github.com/ChALkeR |
|
ChALkeR
| https://github.com/ChALkeR |
|
| https://github.com/nodejs/node/pull/13644/files/f11c21745ae6dc4926e9acc0eb5ce66154dfcc7f |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/13644/files/f11c21745ae6dc4926e9acc0eb5ce66154dfcc7f |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/13644/files/f11c21745ae6dc4926e9acc0eb5ce66154dfcc7f |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/nodejs/node/pull/13644/files/1e8402f57c5bf2f46a52a8edf2f11ae0b79ce004 |
|
| https://github.com/domenic |
|
domenic
| https://github.com/domenic |
|
| https://github.com/nodejs/node/pull/13644/files/97f84761add6d1e6fb79852618ac47e4bfa505cc |
|
| https://github.com/TimothyGu |
|
TimothyGu
| https://github.com/TimothyGu |
|
| https://github.com/nodejs/node/pull/13644/files/f11c21745ae6dc4926e9acc0eb5ce66154dfcc7f |
|
| https://github.com/vsemozhetbyt |
|
vsemozhetbyt
| https://github.com/vsemozhetbyt |
|
| https://github.com/nodejs/node/pull/13644/files/97d2fe8e80ea8f6a6748dafe1863ce29119a0344 |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
|
i18n-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api |
|
notable-change
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/13644 |
|
| https://github.com/jasnell |
|
| https://github.com/mscdex |
|
| https://github.com/TimothyGu |
|
| https://github.com/yoshuawuyts |
|
| https://github.com/domenic |
|
| https://github.com/mhdawson |
|
| https://github.com/mcollina |
|
| https://github.com/calvinmetcalf |
|
| https://github.com/tniessen |
|
| https://github.com/lucamaraschi |
|
| https://github.com/sam-github |
|
| https://github.com/bmeck |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/addaleax |
|
| https://github.com/gibfahn |
|
| https://github.com/bnoordhuis |
|
| https://github.com/ChALkeR |
|
| https://github.com/targos |
|
| https://github.com/Trott |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |