René's URL Explorer Experiment


Title: WIP: crypto: support multiple Crypto versions/libraries by danbev · Pull Request #13575 · nodejs/node · GitHub

Open Graph Title: WIP: crypto: support multiple Crypto versions/libraries by danbev · Pull Request #13575 · nodejs/node

X Title: WIP: crypto: support multiple Crypto versions/libraries by danbev · Pull Request #13575 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The goal is to be able to support different versions/vendors of SSL/Crypto libraries. Motivation for this have been brought up in #11828. This pull request is meant to be a proof of concept/spike t...

X Description: The goal is to be able to support different versions/vendors of SSL/Crypto libraries. Motivation for this have been brought up in #11828. This pull request is meant to be a proof of concept/spike t...

Opengraph URL: https://github.com/nodejs/node/pull/13575

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9787e087-d802-b571-a430-8e8751628021
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC1B2:3E6EAA:2ABC0EA:3B295B6:6A4F0215
html-safe-nonce60680dfa987e4a8e6bdb666715fda2492ab12a6c7174e255a345472d77159c65
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUIyOjNFNkVBQToyQUJDMEVBOjNCMjk1QjY6NkE0RjAyMTUiLCJ2aXNpdG9yX2lkIjoiMTgzNDc1ODU1OTc0NjY4NzUwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb59b8f38fa1f9e5659bece3b8029aac55f2ffbbe7b6c62e62970f1e5f3aab4a2
hovercard-subject-tagpull_request:124865385
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/13575/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b14fb43e7e05160b8c24b96e9f283febc2a1281e6afd4d6db5f92f4c6f1a8806/nodejs/node/pull/13575
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b14fb43e7e05160b8c24b96e9f283febc2a1281e6afd4d6db5f92f4c6f1a8806/nodejs/node/pull/13575
og:image:altThe goal is to be able to support different versions/vendors of SSL/Crypto libraries. Motivation for this have been brought up in #11828. This pull request is meant to be a proof of concept/spike t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedanbev
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/13575#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13575
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13575
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/13575
Reloadhttps://github.com/nodejs/node/pull/13575
Reloadhttps://github.com/nodejs/node/pull/13575
Please reload this pagehttps://github.com/nodejs/node/pull/13575
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/13575
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:crypto-interfacehttps://github.com/danbev/node/tree/crypto-interface
Conversationhttps://github.com/nodejs/node/pull/13575
Commits7 (7)https://github.com/nodejs/node/pull/13575/commits
Checkshttps://github.com/nodejs/node/pull/13575/checks
Files changedhttps://github.com/nodejs/node/pull/13575/files
WIP: crypto: support multiple Crypto versions/librarieshttps://github.com/nodejs/node/pull/13575#top
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:crypto-interfacehttps://github.com/danbev/node/tree/crypto-interface
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 9, 2017https://github.com/nodejs/node/pull/13575#issue-234824495
#11828https://github.com/nodejs/node/pull/11828
src/node_crypto.hhttps://github.com/danbev/node/blob/ec4e31c0f0730e55db58692535a7a774ffa23c41/src/node_crypto.h
node_crypto_versionhttps://github.com/danbev/node/blob/ec4e31c0f0730e55db58692535a7a774ffa23c41/configure#L999
NODE_CRYPTO_VERSIONhttps://github.com/danbev/node/blob/ec4e31c0f0730e55db58692535a7a774ffa23c41/configure#L1000
std::string crypto_versionhttps://github.com/danbev/node/blob/ec4e31c0f0730e55db58692535a7a774ffa23c41/src/node.cc#L217
CryptoFactoryhttps://github.com/danbev/node/blob/ec4e31c0f0730e55db58692535a7a774ffa23c41/src/node_crypto_factory.h
openssl_1_0_2ehttps://github.com/danbev/node/blob/ec4e31c0f0730e55db58692535a7a774ffa23c41/src/crypto_impl/openssl/1_0_2e/openssl_1_0_2e.cc
openssl_1_1_0fhttps://github.com/danbev/node/blob/ec4e31c0f0730e55db58692535a7a774ffa23c41/src/crypto_impl/openssl/1_1_0f/openssl_1_1_0f.cc
#11828https://github.com/nodejs/node/pull/11828
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/13575
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
inspector https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainspector
Jun 9, 2017https://github.com/nodejs/node/pull/13575#event-1117231677
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 9, 2017 https://github.com/nodejs/node/pull/13575#ref-pullrequest-213797499
Upgrade openssl-1.1.0e for Node-v8 (DO NOT LAND THIS) #11828 https://github.com/nodejs/node/pull/11828
https://github.com/danbev
danbevhttps://github.com/danbev
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Jun 9, 2017https://github.com/nodejs/node/pull/13575#event-1117255397
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Jun 9, 2017https://github.com/nodejs/node/pull/13575#issuecomment-307392399
#9376https://github.com/nodejs/node/pull/9376
@rvagghttps://github.com/rvagg
Please reload this pagehttps://github.com/nodejs/node/pull/13575
https://github.com/mscdex
mscdexhttps://github.com/mscdex
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
inspector https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainspector
Jun 9, 2017https://github.com/nodejs/node/pull/13575#event-1117573749
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 12, 2017 https://github.com/nodejs/node/pull/13575#ref-issue-232468795
Node Crypto Interface bucharest-gold/entente#160 https://github.com/bucharest-gold/entente/issues/160
danbevhttps://github.com/danbev
June 13, 2017 13:20https://github.com/nodejs/node/pull/13575#commits-pushed-debb4b9
https://github.com/danbev
crypto: move crypto sources to src/crypto_implhttps://github.com/nodejs/node/pull/13575/commits/debb4b9acbe4942973e05aab1b312245a60def19
debb4b9https://github.com/nodejs/node/pull/13575/commits/debb4b9acbe4942973e05aab1b312245a60def19
https://github.com/danbev
crypto: add Crypto and CryptoFactoryhttps://github.com/nodejs/node/pull/13575/commits/d3e9cc08cb909ed05cc4c7b6586c4ce779de437d
d3e9cc0https://github.com/nodejs/node/pull/13575/commits/d3e9cc08cb909ed05cc4c7b6586c4ce779de437d
https://github.com/danbev
crypto: add openssl_1_1_0f implementationhttps://github.com/nodejs/node/pull/13575/commits/39fac636d3df7d12373807672ef5b8e9d560907a
39fac63https://github.com/nodejs/node/pull/13575/commits/39fac636d3df7d12373807672ef5b8e9d560907a
https://github.com/danbev
crypto: split crypto into two implementationshttps://github.com/nodejs/node/pull/13575/commits/45677cae204ad14ebf083cab994e89eb32809d2e
45677cahttps://github.com/nodejs/node/pull/13575/commits/45677cae204ad14ebf083cab994e89eb32809d2e
https://github.com/shigeki
https://github.com/danbev
test: fix tests work on both openssl102 and 110https://github.com/nodejs/node/pull/13575/commits/8fde1f2ff90050d898688936f106d713a9fcd703
8fde1f2https://github.com/nodejs/node/pull/13575/commits/8fde1f2ff90050d898688936f106d713a9fcd703
https://github.com/danbev
danbevhttps://github.com/danbev
force-pushedhttps://github.com/nodejs/node/compare/849896197de59e2d976d8f79b3ce6e144f9b53f4..8fde1f2ff90050d898688936f106d713a9fcd703
8498961https://github.com/nodejs/node/commit/849896197de59e2d976d8f79b3ce6e144f9b53f4
8fde1f2https://github.com/nodejs/node/commit/8fde1f2ff90050d898688936f106d713a9fcd703
Compare https://github.com/nodejs/node/compare/849896197de59e2d976d8f79b3ce6e144f9b53f4..8fde1f2ff90050d898688936f106d713a9fcd703
June 13, 2017 12:57https://github.com/nodejs/node/pull/13575#event-1121309091
https://github.com/danbev
danbevhttps://github.com/danbev
Jun 13, 2017https://github.com/nodejs/node/pull/13575#issuecomment-308107134
https://ci.nodejs.org/job/node-test-pull-request/8631/https://ci.nodejs.org/job/node-test-pull-request/8631/
Please reload this pagehttps://github.com/nodejs/node/pull/13575
danbevhttps://github.com/danbev
June 13, 2017 15:14https://github.com/nodejs/node/pull/13575#commits-pushed-5252a4f
https://github.com/danbev
move __attributes__ to after function signaturehttps://github.com/nodejs/node/pull/13575/commits/5252a4f69b76beed00c2055929b4de5e205ca9ed
5252a4fhttps://github.com/nodejs/node/pull/13575/commits/5252a4f69b76beed00c2055929b4de5e205ca9ed
https://github.com/danbev
remove ctor/dtor __attributes__https://github.com/nodejs/node/pull/13575/commits/8ee2cd1d9755723b99e67f52134ddfc8f703ef00
8ee2cd1https://github.com/nodejs/node/pull/13575/commits/8ee2cd1d9755723b99e67f52134ddfc8f703ef00
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Jun 15, 2017 https://github.com/nodejs/node/pull/13575#ref-issue-230919971
libcrypto.so.1.0.0 error #13185 https://github.com/nodejs/node/issues/13185
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
openssl https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aopenssl
Jun 17, 2017https://github.com/nodejs/node/pull/13575#event-1127867589
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 17, 2017 https://github.com/nodejs/node/pull/13575#ref-issue-236662350
Should we deprecate OpenSSL,switch to LibreSSL #13746 https://github.com/nodejs/node/issues/13746
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 12, 2017https://github.com/nodejs/node/pull/13575#issuecomment-328972633
@danbevhttps://github.com/danbev
Please reload this pagehttps://github.com/nodejs/node/pull/13575
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
Sep 12, 2017https://github.com/nodejs/node/pull/13575#event-1246027618
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 22, 2017https://github.com/nodejs/node/pull/13575#issuecomment-331579717
@danbevhttps://github.com/danbev
Please reload this pagehttps://github.com/nodejs/node/pull/13575
https://github.com/danbev
danbevhttps://github.com/danbev
Sep 23, 2017https://github.com/nodejs/node/pull/13575#issuecomment-331611730
@danbevhttps://github.com/danbev
Please reload this pagehttps://github.com/nodejs/node/pull/13575
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Sep 25, 2017https://github.com/nodejs/node/pull/13575#issuecomment-331871365
#11828https://github.com/nodejs/node/pull/11828
Please reload this pagehttps://github.com/nodejs/node/pull/13575
https://github.com/danbev
danbevhttps://github.com/danbev
Sep 27, 2017https://github.com/nodejs/node/pull/13575#issuecomment-332416787
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/13575
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Sep 27, 2017https://github.com/nodejs/node/pull/13575#issuecomment-332424929
Please reload this pagehttps://github.com/nodejs/node/pull/13575
https://github.com/danbev
danbevhttps://github.com/danbev
Sep 27, 2017https://github.com/nodejs/node/pull/13575#issuecomment-332428012
Please reload this pagehttps://github.com/nodejs/node/pull/13575
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Sep 27, 2017https://github.com/nodejs/node/pull/13575#issuecomment-332450860
ciphers string parserhttps://github.com/nodejs/node/blob/v8.6.0/doc/api/tls.md#modifying-the-default-tls-cipher-suite
Please reload this pagehttps://github.com/nodejs/node/pull/13575
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 28, 2017https://github.com/nodejs/node/pull/13575#issuecomment-332823124
Please reload this pagehttps://github.com/nodejs/node/pull/13575
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 11, 2017 https://github.com/nodejs/node/pull/13575#ref-issue-258230412
Technical projects ayojs/ayo#59 https://github.com/ayojs/ayo/issues/59
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 15, 2017https://github.com/nodejs/node/pull/13575#issuecomment-336734535
@danbevhttps://github.com/danbev
Please reload this pagehttps://github.com/nodejs/node/pull/13575
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 25, 2017https://github.com/nodejs/node/pull/13575#issuecomment-339417437
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/13575
https://github.com/danbev
danbevhttps://github.com/danbev
Oct 25, 2017https://github.com/nodejs/node/pull/13575#event-1310437041
https://github.com/volschin
volschinhttps://github.com/volschin
Jan 6, 2018 https://github.com/nodejs/node/pull/13575#ref-pullrequest-284308268
Minor Code / Dependencies Updates homebridge/HAP-NodeJS#537 https://github.com/homebridge/HAP-NodeJS/pull/537
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13575
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
openssl https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aopenssl
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Please reload this pagehttps://github.com/nodejs/node/pull/13575
https://github.com/danbev
https://github.com/gibfahn
https://github.com/BridgeAR
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/mscdex
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/shigeki
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.