René's URL Explorer Experiment


Title: http: always cork outgoing writes by mscdex · Pull Request #13522 · nodejs/node · GitHub

Open Graph Title: http: always cork outgoing writes by mscdex · Pull Request #13522 · nodejs/node

X Title: http: always cork outgoing writes by mscdex · Pull Request #13522 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This PR always corks outgoing writes, no matter whether it's using chunked encoding or has a Content-Length set. Previously it was only enabled for chunked encoding writes. Some benchmark resul...

X Description: This PR always corks outgoing writes, no matter whether it's using chunked encoding or has a Content-Length set. Previously it was only enabled for chunked encoding writes. Some benchmark r...

Opengraph URL: https://github.com/nodejs/node/pull/13522

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e81aa7a5-5bd8-f0f4-9e5a-e5f1cf069aaf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id91E4:1EC7:7BAF45:AC2362:6A4EEDCB
html-safe-nonce4acf6e304a0a2cd10951c41cc04d67e42b9e6d12c558d2c7bcad586af6034582
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MUU0OjFFQzc6N0JBRjQ1OkFDMjM2Mjo2QTRFRURDQiIsInZpc2l0b3JfaWQiOiIxMzQ1OTY2NjMyNjQ0NTcwNTcyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6bc0aec726cecc983486cf3ee872b73912492c0935d60b8a0c9c6ae52ee3883b
hovercard-subject-tagpull_request:124459625
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/13522/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0d5e4b12c177df3b0e2d8d0f2ddf35c691ecb8bd6b3ed82fd54a5d9d38cb065f/nodejs/node/pull/13522
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0d5e4b12c177df3b0e2d8d0f2ddf35c691ecb8bd6b3ed82fd54a5d9d38cb065f/nodejs/node/pull/13522
og:image:altThis PR always corks outgoing writes, no matter whether it's using chunked encoding or has a Content-Length set. Previously it was only enabled for chunked encoding writes. Some benchmark resul...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemscdex
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release00d04d6b867d2f16ab50bebae8ccc56e07c8988b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/13522#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13522
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13522
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/13522
Reloadhttps://github.com/nodejs/node/pull/13522
Reloadhttps://github.com/nodejs/node/pull/13522
Please reload this pagehttps://github.com/nodejs/node/pull/13522
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/13522
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mscdexhttps://github.com/mscdex
nodejs:masterhttps://github.com/nodejs/node/tree/master
mscdex:http-outgoing-always-cork-writeshttps://github.com/mscdex/io.js/tree/http-outgoing-always-cork-writes
Conversationhttps://github.com/nodejs/node/pull/13522
Commits1 (1)https://github.com/nodejs/node/pull/13522/commits
Checkshttps://github.com/nodejs/node/pull/13522/checks
Files changedhttps://github.com/nodejs/node/pull/13522/files
http: always cork outgoing writeshttps://github.com/nodejs/node/pull/13522#top
mscdexhttps://github.com/mscdex
nodejs:masterhttps://github.com/nodejs/node/tree/master
mscdex:http-outgoing-always-cork-writeshttps://github.com/mscdex/io.js/tree/http-outgoing-always-cork-writes
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jun 7, 2017https://github.com/nodejs/node/pull/13522#issue-234262818
Please reload this pagehttps://github.com/nodejs/node/pull/13522
#13446https://github.com/nodejs/node/pull/13446
https://ci.nodejs.org/job/node-test-pull-request/8532/https://ci.nodejs.org/job/node-test-pull-request/8532/
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/13522
https://github.com/mscdex
mscdexhttps://github.com/mscdex
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
performance https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance
Jun 7, 2017https://github.com/nodejs/node/pull/13522#event-1113967031
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Jun 7, 2017https://github.com/nodejs/node/pull/13522#event-1113967118
https://github.com/mscdex
mscdexhttps://github.com/mscdex
force-pushedhttps://github.com/nodejs/node/compare/110efcf32ffccfac204443114cd9cf0787a3fadc..1e0f85b2e6cdf8b3160b7e26983bdcdbdf347596
110efcfhttps://github.com/nodejs/node/commit/110efcf32ffccfac204443114cd9cf0787a3fadc
1e0f85bhttps://github.com/nodejs/node/commit/1e0f85b2e6cdf8b3160b7e26983bdcdbdf347596
Compare https://github.com/nodejs/node/compare/110efcf32ffccfac204443114cd9cf0787a3fadc..1e0f85b2e6cdf8b3160b7e26983bdcdbdf347596
June 7, 2017 16:11https://github.com/nodejs/node/pull/13522#event-1113973463
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Jun 7, 2017https://github.com/nodejs/node/pull/13522#issuecomment-306890856
Please reload this pagehttps://github.com/nodejs/node/pull/13522
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jun 7, 2017https://github.com/nodejs/node/pull/13522#issuecomment-306895222
@Fishrock123https://github.com/Fishrock123
Please reload this pagehttps://github.com/nodejs/node/pull/13522
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jun 8, 2017https://github.com/nodejs/node/pull/13522#issuecomment-307007355
Please reload this pagehttps://github.com/nodejs/node/pull/13522
Please reload this pagehttps://github.com/nodejs/node/pull/13522
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jun 9, 2017https://github.com/nodejs/node/pull/13522#issuecomment-307298139
Please reload this pagehttps://github.com/nodejs/node/pull/13522
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jun 9, 2017https://github.com/nodejs/node/pull/13522#issuecomment-307313410
#7946https://github.com/nodejs/node/pull/7946
Please reload this pagehttps://github.com/nodejs/node/pull/13522
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jun 9, 2017 https://github.com/nodejs/node/pull/13522#pullrequestreview-43081000
View reviewed changes https://github.com/nodejs/node/pull/13522/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/13522#pullrequestreview-43081000
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13522
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jun 9, 2017 https://github.com/nodejs/node/pull/13522#pullrequestreview-43157178
View reviewed changes https://github.com/nodejs/node/pull/13522/files
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jun 9, 2017 https://github.com/nodejs/node/pull/13522#pullrequestreview-43157421
View reviewed changes https://github.com/nodejs/node/pull/13522/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 9, 2017 https://github.com/nodejs/node/pull/13522#pullrequestreview-43214839
View reviewed changes https://github.com/nodejs/node/pull/13522/files
https://github.com/indutny
indutnyhttps://github.com/indutny
Jun 9, 2017 https://github.com/nodejs/node/pull/13522#pullrequestreview-43215242
View reviewed changes https://github.com/nodejs/node/pull/13522/files
indutnyhttps://github.com/indutny
https://github.com/nodejs/node/pull/13522#pullrequestreview-43215242
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13522
https://github.com/mscdex
mscdexhttps://github.com/mscdex
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Jun 12, 2017https://github.com/nodejs/node/pull/13522#event-1119952009
https://github.com/mscdex
mscdexhttps://github.com/mscdex
force-pushedhttps://github.com/nodejs/node/compare/1e0f85b2e6cdf8b3160b7e26983bdcdbdf347596..be4b5835945338c75c7fa4bb8f5f51558ad14ccf
1e0f85bhttps://github.com/nodejs/node/commit/1e0f85b2e6cdf8b3160b7e26983bdcdbdf347596
be4b583https://github.com/nodejs/node/commit/be4b5835945338c75c7fa4bb8f5f51558ad14ccf
Compare https://github.com/nodejs/node/compare/1e0f85b2e6cdf8b3160b7e26983bdcdbdf347596..be4b5835945338c75c7fa4bb8f5f51558ad14ccf
June 12, 2017 17:55https://github.com/nodejs/node/pull/13522#event-1119957016
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Jun 12, 2017https://github.com/nodejs/node/pull/13522#issuecomment-307867314
https://ci.nodejs.org/job/node-test-pull-request/8613/https://ci.nodejs.org/job/node-test-pull-request/8613/
Please reload this pagehttps://github.com/nodejs/node/pull/13522
https://github.com/mscdex
http: always cork outgoing writeshttps://github.com/nodejs/node/pull/13522/commits/c4fc7d90eddbdb23d814a38192e6979f8fc285a7
c4fc7d9https://github.com/nodejs/node/pull/13522/commits/c4fc7d90eddbdb23d814a38192e6979f8fc285a7
nodejs#13522https://github.com/nodejs/node/pull/13522
https://github.com/mscdex
mscdexhttps://github.com/mscdex
force-pushedhttps://github.com/nodejs/node/compare/be4b5835945338c75c7fa4bb8f5f51558ad14ccf..c4fc7d90eddbdb23d814a38192e6979f8fc285a7
be4b583https://github.com/nodejs/node/commit/be4b5835945338c75c7fa4bb8f5f51558ad14ccf
c4fc7d9https://github.com/nodejs/node/commit/c4fc7d90eddbdb23d814a38192e6979f8fc285a7
Compare https://github.com/nodejs/node/compare/be4b5835945338c75c7fa4bb8f5f51558ad14ccf..c4fc7d90eddbdb23d814a38192e6979f8fc285a7
June 13, 2017 00:42https://github.com/nodejs/node/pull/13522#event-1120499863
https://github.com/mscdex
mscdexhttps://github.com/mscdex
c4fc7d9https://github.com/nodejs/node/commit/c4fc7d90eddbdb23d814a38192e6979f8fc285a7
Jun 13, 2017https://github.com/nodejs/node/pull/13522#event-1120500506
https://github.com/mscdex
mscdexhttps://github.com/mscdex
June 13, 2017 00:45https://github.com/nodejs/node/pull/13522#event-1120501999
addaleaxhttps://github.com/addaleax
Jun 17, 2017 https://github.com/nodejs/node/pull/13522#ref-commit-6aa790c
https://github.com/mscdex
https://github.com/addaleax
http: always cork outgoing writeshttps://github.com/nodejs/node/commit/6aa790c5160b34b27fdc791075301cc80a6c07e4
6aa790chttps://github.com/nodejs/node/commit/6aa790c5160b34b27fdc791075301cc80a6c07e4
#13522https://github.com/nodejs/node/pull/13522
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jun 17, 2017 https://github.com/nodejs/node/pull/13522#ref-pullrequest-236661599
v8.2.0 proposal #13744 https://github.com/nodejs/node/pull/13744
addaleaxhttps://github.com/addaleax
Jun 21, 2017 https://github.com/nodejs/node/pull/13522#ref-commit-9d002c2
https://github.com/mscdex
https://github.com/addaleax
http: always cork outgoing writeshttps://github.com/nodejs/node/commit/9d002c2bb739698e8bfe99d300559ec1655ff8c7
9d002c2https://github.com/nodejs/node/commit/9d002c2bb739698e8bfe99d300559ec1655ff8c7
#13522https://github.com/nodejs/node/pull/13522
addaleaxhttps://github.com/addaleax
Jun 24, 2017 https://github.com/nodejs/node/pull/13522#ref-commit-93c1774
https://github.com/mscdex
https://github.com/addaleax
http: always cork outgoing writeshttps://github.com/nodejs/node/commit/93c1774dfdfffaa452b82fe6a88a50d5be97a70d
93c1774https://github.com/nodejs/node/commit/93c1774dfdfffaa452b82fe6a88a50d5be97a70d
#13522https://github.com/nodejs/node/pull/13522
rvagghttps://github.com/rvagg
Jun 29, 2017 https://github.com/nodejs/node/pull/13522#ref-commit-02a62da
https://github.com/mscdex
https://github.com/rvagg
http: always cork outgoing writeshttps://github.com/nodejs/node/commit/02a62da3310f24ec678cdb11e9283361891830f0
02a62dahttps://github.com/nodejs/node/commit/02a62da3310f24ec678cdb11e9283361891830f0
#13522https://github.com/nodejs/node/pull/13522
addaleaxhttps://github.com/addaleax
Jul 11, 2017 https://github.com/nodejs/node/pull/13522#ref-commit-b22a04b
https://github.com/mscdex
https://github.com/addaleax
http: always cork outgoing writeshttps://github.com/nodejs/node/commit/b22a04b2c6b20d0b8993919389439a7c9528a19d
b22a04bhttps://github.com/nodejs/node/commit/b22a04b2c6b20d0b8993919389439a7c9528a19d
#13522https://github.com/nodejs/node/pull/13522
https://github.com/andrewjjenkins
andrewjjenkinshttps://github.com/andrewjjenkins
Aug 2, 2017 https://github.com/nodejs/node/pull/13522#ref-issue-168211038
HTTP OutgoingMessage _send in two packets when a Buffer is written #7914 https://github.com/nodejs/node/issues/7914
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13522
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/13522/files/1e0f85b2e6cdf8b3160b7e26983bdcdbdf347596
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/13522/files/1e0f85b2e6cdf8b3160b7e26983bdcdbdf347596
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/13522/files/1e0f85b2e6cdf8b3160b7e26983bdcdbdf347596
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/13522/files/1e0f85b2e6cdf8b3160b7e26983bdcdbdf347596
https://github.com/indutny
indutny https://github.com/indutny
https://github.com/nodejs/node/pull/13522/files/1e0f85b2e6cdf8b3160b7e26983bdcdbdf347596
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
performance https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance
Please reload this pagehttps://github.com/nodejs/node/pull/13522
https://github.com/mscdex
https://github.com/Fishrock123
https://github.com/mcollina
https://github.com/indutny
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/tniessen
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.