| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2b76f6b8-47ed-02e7-4b20-cbb15b6c77bc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BDA4:6AD77:8135E5:A97186:6AED386A |
| html-safe-nonce | 2c569d9a6d1cc82df2ca64c5654f93583bc6398d3f1887b472f6ed57c27a0737 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREE0OjZBRDc3OjgxMzVFNTpBOTcxODY6NkFFRDM4NkEiLCJ2aXNpdG9yX2lkIjoiMTU3ODM2NzA0MjQ1ODU2NDcxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 07d1f8c2f5064d8dd5bd78042dd6bb54760ed0788224684f1fb3a314d01744a9 |
| hovercard-subject-tag | pull_request:32570068 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1335/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/34dd8b2bd60389722a52c5a9c1a4895a19005943be89e70732b5054225ad5b3d/nodejs/node/pull/1335 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/34dd8b2bd60389722a52c5a9c1a4895a19005943be89e70732b5054225ad5b3d/nodejs/node/pull/1335 |
| og:image:alt | Validate some of the arguments passed to configurable options. Also, move defaults to optparse default.
I can't really vouch for options; just pulled them from comments. I've tested a few p... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jbergstroem |
| hostname | github.com |
| expected-hostname | github.com |
| None | 26c92a9388ddfad3fa88d132b5d5f0b4747030233dcc4e5efb05f1cbae152184 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c629ad99c254d306375fc8354d04321c2c362236 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/nodejs/node/pull/1335#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1335 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1335 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/1335 |
| Reload | https://github.com/nodejs/node/pull/1335 |
| Reload | https://github.com/nodejs/node/pull/1335 |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues656 (656) | https://github.com/nodejs/node/issues |
| Pull requests665 (665) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/pulse |
| https://github.com/nodejs/node |
| jbergstroem | https://github.com/jbergstroem |
| nodejs:v1.x | https://github.com/nodejs/node/tree/v1.x |
| jbergstroem:feature/stricter_configure | https://github.com/jbergstroem/node/tree/feature/stricter_configure |
| Conversation | https://github.com/nodejs/node/pull/1335 |
| Commits6 (6) | https://github.com/nodejs/node/pull/1335/commits |
| Checks | https://github.com/nodejs/node/pull/1335/checks |
| Files changed | https://github.com/nodejs/node/pull/1335/files |
| build: validate options passed to configure | https://github.com/nodejs/node/pull/1335#top |
| jbergstroem | https://github.com/jbergstroem |
| nodejs:v1.x | https://github.com/nodejs/node/tree/v1.x |
| jbergstroem:feature/stricter_configure | https://github.com/jbergstroem/node/tree/feature/stricter_configure |
|
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Apr 3, 2015 | https://github.com/nodejs/node/pull/1335#issue-66075984 |
| Please reload this page | https://github.com/nodejs/node/pull/1335 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Apr 3, 2015 | https://github.com/nodejs/node/pull/1335#event-272391197 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Apr 3, 2015 | https://github.com/nodejs/node/pull/1335#issuecomment-89163291 |
| https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/434/ | https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/434/ |
| Please reload this page | https://github.com/nodejs/node/pull/1335 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Apr 3, 2015 | https://github.com/nodejs/node/pull/1335#issuecomment-89164054 |
| Please reload this page | https://github.com/nodejs/node/pull/1335 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| force-pushed | https://github.com/nodejs/node/compare/66208705c4d1fc279c6658708486495dc18be9f7..6ea8cbcdb1f14ff8b59fcc199e80070a5dbf4277 |
| 6620870 | https://github.com/nodejs/node/commit/66208705c4d1fc279c6658708486495dc18be9f7 |
| 6ea8cbc | https://github.com/nodejs/node/commit/6ea8cbcdb1f14ff8b59fcc199e80070a5dbf4277 |
|
Compare
| https://github.com/nodejs/node/compare/66208705c4d1fc279c6658708486495dc18be9f7..6ea8cbcdb1f14ff8b59fcc199e80070a5dbf4277 |
| April 3, 2015 05:11 | https://github.com/nodejs/node/pull/1335#event-272395742 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Apr 3, 2015 | https://github.com/nodejs/node/pull/1335#issuecomment-89169860 |
| Please reload this page | https://github.com/nodejs/node/pull/1335 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| force-pushed | https://github.com/nodejs/node/compare/6ea8cbcdb1f14ff8b59fcc199e80070a5dbf4277..260b8b62d2dbfb4464503269a23f6c328e1b1295 |
| 6ea8cbc | https://github.com/nodejs/node/commit/6ea8cbcdb1f14ff8b59fcc199e80070a5dbf4277 |
| 260b8b6 | https://github.com/nodejs/node/commit/260b8b62d2dbfb4464503269a23f6c328e1b1295 |
|
Compare
| https://github.com/nodejs/node/compare/6ea8cbcdb1f14ff8b59fcc199e80070a5dbf4277..260b8b62d2dbfb4464503269a23f6c328e1b1295 |
| April 3, 2015 06:02 | https://github.com/nodejs/node/pull/1335#event-272421302 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Apr 3, 2015 | https://github.com/nodejs/node/pull/1335#issuecomment-89180614 |
| https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/438/ | https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/438/ |
| Please reload this page | https://github.com/nodejs/node/pull/1335 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Apr 3, 2015 | https://github.com/nodejs/node/pull/1335#issuecomment-89192604 |
| Please reload this page | https://github.com/nodejs/node/pull/1335 |
| bnoordhuis | https://github.com/bnoordhuis |
|
Apr 3, 2015
| https://github.com/nodejs/node/pull/1335#discussion-diff-27724370 |
| View reviewed changes
| https://github.com/nodejs/node/pull/1335/files/260b8b62d2dbfb4464503269a23f6c328e1b1295#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2 |
| configure | https://github.com/nodejs/node/pull/1335/files#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2 |
| bnoordhuis | https://github.com/bnoordhuis |
| Apr 3, 2015 | https://github.com/nodejs/node/pull/1335#discussion_r27724370 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/1335 |
| jbergstroem | https://github.com/jbergstroem |
| Apr 3, 2015 | https://github.com/nodejs/node/pull/1335#discussion_r27724683 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/1335 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Apr 6, 2015 | https://github.com/nodejs/node/pull/1335#issuecomment-89960471 |
| #1331 | https://github.com/nodejs/node/pull/1331 |
| Please reload this page | https://github.com/nodejs/node/pull/1335 |
| jbergstroem | https://github.com/jbergstroem |
| April 13, 2015 15:30 | https://github.com/nodejs/node/pull/1335#commits-pushed-12ed7cd |
|
| https://github.com/jbergstroem |
| build: validate options passed to configure | https://github.com/nodejs/node/pull/1335/commits/12ed7cd1a41a747bc1df1e23faf3bf160419652e |
| 12ed7cd | https://github.com/nodejs/node/pull/1335/commits/12ed7cd1a41a747bc1df1e23faf3bf160419652e |
|
| https://github.com/jbergstroem |
| fixup! avoid adding libraries if shared is unset | https://github.com/nodejs/node/pull/1335/commits/5d9a99fd80918b327e6a706f476a8a1e76bd08eb |
| 5d9a99f | https://github.com/nodejs/node/pull/1335/commits/5d9a99fd80918b327e6a706f476a8a1e76bd08eb |
|
| https://github.com/jbergstroem |
| fixup! revert icu change | https://github.com/nodejs/node/pull/1335/commits/d8419a6f00fa8f3a8623c7982a1df3f194a17b6e |
| d8419a6 | https://github.com/nodejs/node/pull/1335/commits/d8419a6f00fa8f3a8623c7982a1df3f194a17b6e |
|
| https://github.com/jbergstroem |
| fixup! simplify help text | https://github.com/nodejs/node/pull/1335/commits/c95847f67e9fd9c538c64f98a32b765bd3f81ee7 |
| c95847f | https://github.com/nodejs/node/pull/1335/commits/c95847f67e9fd9c538c64f98a32b765bd3f81ee7 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| force-pushed | https://github.com/nodejs/node/compare/260b8b62d2dbfb4464503269a23f6c328e1b1295..c95847f67e9fd9c538c64f98a32b765bd3f81ee7 |
| 260b8b6 | https://github.com/nodejs/node/commit/260b8b62d2dbfb4464503269a23f6c328e1b1295 |
| c95847f | https://github.com/nodejs/node/commit/c95847f67e9fd9c538c64f98a32b765bd3f81ee7 |
|
Compare
| https://github.com/nodejs/node/compare/260b8b62d2dbfb4464503269a23f6c328e1b1295..c95847f67e9fd9c538c64f98a32b765bd3f81ee7 |
| April 13, 2015 05:42 | https://github.com/nodejs/node/pull/1335#event-279419879 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Apr 13, 2015 | https://github.com/nodejs/node/pull/1335#issuecomment-92220967 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/1335 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Apr 13, 2015 | https://github.com/nodejs/node/pull/1335#issuecomment-92225781 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/1335 |
|
| https://github.com/jbergstroem |
| fixup! don't bail on a combo we don't use | https://github.com/nodejs/node/pull/1335/commits/c4fa5c91cb8ddc2191cdac2c95edf94e6100ee35 |
| c4fa5c9 | https://github.com/nodejs/node/pull/1335/commits/c4fa5c91cb8ddc2191cdac2c95edf94e6100ee35 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Apr 13, 2015 | https://github.com/nodejs/node/pull/1335#issuecomment-92273144 |
| @jbergstroem | https://github.com/jbergstroem |
| Please reload this page | https://github.com/nodejs/node/pull/1335 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Apr 13, 2015 | https://github.com/nodejs/node/pull/1335#issuecomment-92274530 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/1335 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Apr 13, 2015 | https://github.com/nodejs/node/pull/1335#issuecomment-92275056 |
| Please reload this page | https://github.com/nodejs/node/pull/1335 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Apr 13, 2015 | https://github.com/nodejs/node/pull/1335#issuecomment-92276663 |
| @bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/iojs/io.js/pull/1335/files#diff-e2d5a00791bce9a01f99bc6fd613a39dR259 | https://github.com/iojs/io.js/pull/1335/files#diff-e2d5a00791bce9a01f99bc6fd613a39dR259 |
| Please reload this page | https://github.com/nodejs/node/pull/1335 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Apr 13, 2015 | https://github.com/nodejs/node/pull/1335#issuecomment-92279042 |
| Please reload this page | https://github.com/nodejs/node/pull/1335 |
|
| https://github.com/jbergstroem |
| fixup! simplify locs further | https://github.com/nodejs/node/pull/1335/commits/04772af09b790b2e4ca813fa31fda0a62593d788 |
| 04772af | https://github.com/nodejs/node/pull/1335/commits/04772af09b790b2e4ca813fa31fda0a62593d788 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Apr 13, 2015 | https://github.com/nodejs/node/pull/1335#issuecomment-92529575 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/1335 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Apr 14, 2015 | https://github.com/nodejs/node/pull/1335#issuecomment-92679188 |
| Please reload this page | https://github.com/nodejs/node/pull/1335 |
| jbergstroem | https://github.com/jbergstroem |
|
Apr 14, 2015
| https://github.com/nodejs/node/pull/1335#ref-commit-fd90b33 |
|
| https://github.com/jbergstroem |
| build: validate options passed to configure | https://github.com/nodejs/node/commit/fd90b33b94e6ce64fde193deca2e2aa6c774f558 |
| fd90b33 | https://github.com/nodejs/node/commit/fd90b33b94e6ce64fde193deca2e2aa6c774f558 |
| #1335 | https://github.com/nodejs/node/pull/1335 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Apr 14, 2015 | https://github.com/nodejs/node/pull/1335#issuecomment-92690129 |
| fd90b33 | https://github.com/nodejs/node/commit/fd90b33b94e6ce64fde193deca2e2aa6c774f558 |
| Please reload this page | https://github.com/nodejs/node/pull/1335 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Apr 14, 2015 | https://github.com/nodejs/node/pull/1335#event-280590082 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
|
Apr 14, 2015
| https://github.com/nodejs/node/pull/1335#ref-issue-67769134 |
|
Release proposal: v1.7.0
#1396
| https://github.com/nodejs/node/issues/1396 |
| https://github.com/Nibbler999 |
| Nibbler999 | https://github.com/Nibbler999 |
|
Apr 15, 2015
| https://github.com/nodejs/node/pull/1335#ref-issue-68788652 |
|
1.7.1 --shared-zlib fails
#1434
| https://github.com/nodejs/node/issues/1434 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1335 |
| Please reload this page | https://github.com/nodejs/node/pull/1335 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
| Please reload this page | https://github.com/nodejs/node/pull/1335 |
|
| https://github.com/jbergstroem |
|
| https://github.com/mscdex |
|
| https://github.com/rvagg |
|
| https://github.com/bnoordhuis |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |