| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:97f50520-fbe6-0197-641f-09d4cf01644c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B88E:28F125:2C3431:3C5432:6AED4A7A |
| html-safe-nonce | 582ac3c39d097d8e2184bec57dd6b81e878c1eb99d37a4823efeacddcdd1d377 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODhFOjI4RjEyNToyQzM0MzE6M0M1NDMyOjZBRUQ0QTdBIiwidmlzaXRvcl9pZCI6IjYyMTQxODkyNTU2MzY2MDkyMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 35cadb0c2277dfea01e792a43a5269e5d1d8ddf2f6cf740aadad25ff67f46308 |
| hovercard-subject-tag | pull_request:32560839 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1331/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/42b6d8bdd8bb7c1c8f74e3c3a3ce8203f6faf3d61f17938ef568b09ad63f7ee0/nodejs/node/pull/1331 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/42b6d8bdd8bb7c1c8f74e3c3a3ce8203f6faf3d61f17938ef568b09ad63f7ee0/nodejs/node/pull/1331 |
| og:image:alt | This action is to encourage packagers to not build against a shared V8 library since even minor bumps of V8 can create issues. For people that know what they're doing -- revert this commit.
/R=... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jbergstroem |
| hostname | github.com |
| expected-hostname | github.com |
| None | 56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/nodejs/node/pull/1331#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1331 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1331 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/1331 |
| Reload | https://github.com/nodejs/node/pull/1331 |
| Reload | https://github.com/nodejs/node/pull/1331 |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues654 (654) | https://github.com/nodejs/node/issues |
| Pull requests662 (662) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/pulse |
| https://github.com/nodejs/node |
| jbergstroem | https://github.com/jbergstroem |
| nodejs:v1.x | https://github.com/nodejs/node/tree/v1.x |
| jbergstroem:remove_shared_v8 | https://github.com/jbergstroem/node/tree/remove_shared_v8 |
| Conversation | https://github.com/nodejs/node/pull/1331 |
| Commits2 (2) | https://github.com/nodejs/node/pull/1331/commits |
| Checks | https://github.com/nodejs/node/pull/1331/checks |
| Files changed | https://github.com/nodejs/node/pull/1331/files |
| build: Remove building against a shared V8 | https://github.com/nodejs/node/pull/1331#top |
| jbergstroem | https://github.com/jbergstroem |
| nodejs:v1.x | https://github.com/nodejs/node/tree/v1.x |
| jbergstroem:remove_shared_v8 | https://github.com/jbergstroem/node/tree/remove_shared_v8 |
|
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Apr 2, 2015 | https://github.com/nodejs/node/pull/1331#issue-66034606 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/1331 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Apr 2, 2015 | https://github.com/nodejs/node/pull/1331#issuecomment-89082994 |
| Please reload this page | https://github.com/nodejs/node/pull/1331 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Apr 2, 2015 | https://github.com/nodejs/node/pull/1331#event-272218717 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Apr 2, 2015 | https://github.com/nodejs/node/pull/1331#issuecomment-89083128 |
| https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/433/ | https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/433/ |
| Please reload this page | https://github.com/nodejs/node/pull/1331 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Apr 3, 2015 | https://github.com/nodejs/node/pull/1331#event-272236146 |
| bnoordhuis | https://github.com/bnoordhuis |
|
Apr 3, 2015
| https://github.com/nodejs/node/pull/1331#discussion-diff-27760145 |
| View reviewed changes
| https://github.com/nodejs/node/pull/1331/files#diff-9f1d0716c75f4df39d9e88499ac205b50301c0c672b816ce54d5339be4c2238c |
| node.gyp | https://github.com/nodejs/node/pull/1331/files#diff-9f1d0716c75f4df39d9e88499ac205b50301c0c672b816ce54d5339be4c2238c |
| bnoordhuis | https://github.com/bnoordhuis |
| Apr 3, 2015 | https://github.com/nodejs/node/pull/1331#discussion_r27760145 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/1331 |
| jbergstroem | https://github.com/jbergstroem |
| April 6, 2015 17:01 | https://github.com/nodejs/node/pull/1331#commits-pushed-82f27fb |
|
| https://github.com/jbergstroem |
| build: Remove building against a shared V8 | https://github.com/nodejs/node/pull/1331/commits/82f27fb5af70b47b6e837d48a13d2f21a472d3c8 |
| 82f27fb | https://github.com/nodejs/node/pull/1331/commits/82f27fb5af70b47b6e837d48a13d2f21a472d3c8 |
|
| https://github.com/jbergstroem |
| fixup! cctest needs v8 | https://github.com/nodejs/node/pull/1331/commits/f534a4823789285336b8e042cbd9d6bf2d388457 |
| f534a48 | https://github.com/nodejs/node/pull/1331/commits/f534a4823789285336b8e042cbd9d6bf2d388457 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| force-pushed | https://github.com/nodejs/node/compare/c6429ca85159ff5107d079804244ed89bd227b80..f534a4823789285336b8e042cbd9d6bf2d388457 |
| c6429ca | https://github.com/nodejs/node/commit/c6429ca85159ff5107d079804244ed89bd227b80 |
| f534a48 | https://github.com/nodejs/node/commit/f534a4823789285336b8e042cbd9d6bf2d388457 |
|
Compare
| https://github.com/nodejs/node/compare/c6429ca85159ff5107d079804244ed89bd227b80..f534a4823789285336b8e042cbd9d6bf2d388457 |
| April 6, 2015 07:35 | https://github.com/nodejs/node/pull/1331#event-273935427 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Apr 6, 2015 | https://github.com/nodejs/node/pull/1331#issuecomment-89960176 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/1331 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
|
Apr 6, 2015
| https://github.com/nodejs/node/pull/1331#ref-pullrequest-66075984 |
|
build: validate options passed to configure
#1335
| https://github.com/nodejs/node/pull/1335 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Apr 6, 2015 | https://github.com/nodejs/node/pull/1331#issuecomment-90282758 |
| https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/449/ | https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/449/ |
| Please reload this page | https://github.com/nodejs/node/pull/1331 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Apr 7, 2015 | https://github.com/nodejs/node/pull/1331#issuecomment-90361516 |
| Please reload this page | https://github.com/nodejs/node/pull/1331 |
| https://github.com/chrisdickinson |
| chrisdickinson | https://github.com/chrisdickinson |
| Apr 7, 2015 | https://github.com/nodejs/node/pull/1331#issuecomment-90371253 |
| EPEL | http://pkgs.fedoraproject.org/cgit/nodejs.git/tree/nodejs.spec#n130 |
| Please reload this page | https://github.com/nodejs/node/pull/1331 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Apr 7, 2015 | https://github.com/nodejs/node/pull/1331#issuecomment-90374067 |
| @chrisdickinson | https://github.com/chrisdickinson |
| Please reload this page | https://github.com/nodejs/node/pull/1331 |
| jbergstroem | https://github.com/jbergstroem |
|
Apr 7, 2015
| https://github.com/nodejs/node/pull/1331#ref-commit-d726a17 |
|
| https://github.com/jbergstroem |
| build: Remove building against a shared V8 | https://github.com/nodejs/node/commit/d726a177ed59c37cf5306983ed00ecd858cfbbef |
| d726a17 | https://github.com/nodejs/node/commit/d726a177ed59c37cf5306983ed00ecd858cfbbef |
| #1331 | https://github.com/nodejs/node/pull/1331 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Apr 7, 2015 | https://github.com/nodejs/node/pull/1331#issuecomment-90476335 |
| d726a17 | https://github.com/nodejs/node/commit/d726a177ed59c37cf5306983ed00ecd858cfbbef |
| Please reload this page | https://github.com/nodejs/node/pull/1331 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Apr 7, 2015 | https://github.com/nodejs/node/pull/1331#event-275026064 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Apr 7, 2015 | https://github.com/nodejs/node/pull/1331#issuecomment-90602459 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/1331 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Apr 7, 2015 | https://github.com/nodejs/node/pull/1331#issuecomment-90686576 |
| here | https://github.com/iojs/io.js/pull/1329#issuecomment-89059795 |
| Please reload this page | https://github.com/nodejs/node/pull/1331 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Apr 7, 2015 | https://github.com/nodejs/node/pull/1331#event-275546512 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
|
Apr 11, 2015
| https://github.com/nodejs/node/pull/1331#ref-issue-67769134 |
|
Release proposal: v1.7.0
#1396
| https://github.com/nodejs/node/issues/1396 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Oct 8, 2021
| https://github.com/nodejs/node/pull/1331#ref-issue-850437675 |
|
Building NodeJS with a shared v8
nodejs/help#3302
| https://github.com/nodejs/help/issues/3302 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1331 |
| Please reload this page | https://github.com/nodejs/node/pull/1331 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Please reload this page | https://github.com/nodejs/node/pull/1331 |
|
| https://github.com/jbergstroem |
|
| https://github.com/mscdex |
|
| https://github.com/bnoordhuis |
|
| https://github.com/chrisdickinson |
|
| https://github.com/Fishrock123 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |