René's URL Explorer Experiment


Title: vm: remove CopyProperties()- code review by AnnaMag · Pull Request #13265 · nodejs/node · GitHub

Open Graph Title: vm: remove CopyProperties()- code review by AnnaMag · Pull Request #13265 · nodejs/node

X Title: vm: remove CopyProperties()- code review by AnnaMag · Pull Request #13265 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This patch removes the CP() function, replacing callbacks with ones that allow the ES6 syntax. This is a code review patch and it is not meant to land yet for 2 reasons: It works for named propert...

X Description: This patch removes the CP() function, replacing callbacks with ones that allow the ES6 syntax. This is a code review patch and it is not meant to land yet for 2 reasons: It works for named propert...

Opengraph URL: https://github.com/nodejs/node/pull/13265

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f1f36f22-6533-bbbd-7548-f291cea694df
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE0EC:1FD988:25C529C:30091A7:6991BA51
html-safe-nonce5bc0f035be07dbf37c9a63261a3832124a80031968c92cdb2374c81ce6b467ef
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMEVDOjFGRDk4ODoyNUM1MjlDOjMwMDkxQTc6Njk5MUJBNTEiLCJ2aXNpdG9yX2lkIjoiMTY2NzU1MDkwODc2MDgzMjU5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6490ea090919329e1017d1d45f0831d85c047e296839dc26dc6dfdea317b4599
hovercard-subject-tagpull_request:122792315
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/13265/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/22d3f2a9f2d81073ccd58b1c2c6cd0b7f69708a7c8a8a34caf147f9e6d7582ef/nodejs/node/pull/13265
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/22d3f2a9f2d81073ccd58b1c2c6cd0b7f69708a7c8a8a34caf147f9e6d7582ef/nodejs/node/pull/13265
og:image:altThis patch removes the CP() function, replacing callbacks with ones that allow the ES6 syntax. This is a code review patch and it is not meant to land yet for 2 reasons: It works for named propert...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAnnaMag
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/13265#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13265
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13265
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/13265
Reloadhttps://github.com/nodejs/node/pull/13265
Reloadhttps://github.com/nodejs/node/pull/13265
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/13265
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 713 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
AnnaMaghttps://github.com/AnnaMag
nodejs:masterhttps://github.com/nodejs/node/tree/master
AnnaMag:v8-5_removeCP_reviewhttps://github.com/AnnaMag/node/tree/v8-5_removeCP_review
Conversationhttps://github.com/nodejs/node/pull/13265
Commits1 (1)https://github.com/nodejs/node/pull/13265/commits
Checkshttps://github.com/nodejs/node/pull/13265/checks
Files changedhttps://github.com/nodejs/node/pull/13265/files
vm: remove CopyProperties()- code reviewhttps://github.com/nodejs/node/pull/13265#top
AnnaMaghttps://github.com/AnnaMag
nodejs:masterhttps://github.com/nodejs/node/tree/master
AnnaMag:v8-5_removeCP_reviewhttps://github.com/AnnaMag/node/tree/v8-5_removeCP_review
https://github.com/AnnaMag
AnnaMaghttps://github.com/AnnaMag
May 28, 2017https://github.com/nodejs/node/pull/13265#issue-231862789
Please reload this pagehttps://github.com/nodejs/node/pull/13265
https://codereview.chromium.org/2807333003/https://codereview.chromium.org/2807333003/
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/13265
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
May 28, 2017https://github.com/nodejs/node/pull/13265#event-1100148135
https://github.com/AnnaMag
AnnaMaghttps://github.com/AnnaMag
May 28, 2017https://github.com/nodejs/node/pull/13265#issuecomment-304507987
@fhinkelhttps://github.com/fhinkel
Please reload this pagehttps://github.com/nodejs/node/pull/13265
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
May 28, 2017https://github.com/nodejs/node/pull/13265#event-1100148401
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 28, 2017 https://github.com/nodejs/node/pull/13265#pullrequestreview-40670160
View reviewed changes https://github.com/nodejs/node/pull/13265/files
src/node_contextify.cchttps://github.com/nodejs/node/pull/13265/files#diff-d194c6f9fca3e3c031ecc5b7bd91a53c8881641cd4d1df1ff169312971955c50
addaleaxhttps://github.com/addaleax
May 28, 2017https://github.com/nodejs/node/pull/13265#discussion_r118839090
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13265
AnnaMaghttps://github.com/AnnaMag
May 28, 2017https://github.com/nodejs/node/pull/13265#discussion_r118839289
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13265
src/node_contextify.cchttps://github.com/nodejs/node/pull/13265/files#diff-d194c6f9fca3e3c031ecc5b7bd91a53c8881641cd4d1df1ff169312971955c50
addaleaxhttps://github.com/addaleax
May 28, 2017https://github.com/nodejs/node/pull/13265#discussion_r118839127
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13265
AnnaMaghttps://github.com/AnnaMag
May 28, 2017https://github.com/nodejs/node/pull/13265#discussion_r118839363
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13265
src/node_contextify.cchttps://github.com/nodejs/node/pull/13265/files#diff-d194c6f9fca3e3c031ecc5b7bd91a53c8881641cd4d1df1ff169312971955c50
addaleaxhttps://github.com/addaleax
May 28, 2017https://github.com/nodejs/node/pull/13265#discussion_r118839143
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13265
AnnaMaghttps://github.com/AnnaMag
May 28, 2017https://github.com/nodejs/node/pull/13265#discussion_r118839479
Please reload this pagehttps://github.com/nodejs/node/pull/13265
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13265
AnnaMaghttps://github.com/AnnaMag
May 28, 2017https://github.com/nodejs/node/pull/13265#discussion_r118839728
Please reload this pagehttps://github.com/nodejs/node/pull/13265
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
@fhinkelhttps://github.com/fhinkel
Please reload this pagehttps://github.com/nodejs/node/pull/13265
src/node_contextify.cchttps://github.com/nodejs/node/pull/13265/files#diff-d194c6f9fca3e3c031ecc5b7bd91a53c8881641cd4d1df1ff169312971955c50
addaleaxhttps://github.com/addaleax
May 28, 2017https://github.com/nodejs/node/pull/13265#discussion_r118839154
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13265
AnnaMaghttps://github.com/AnnaMag
May 28, 2017https://github.com/nodejs/node/pull/13265#discussion_r118839365
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13265
src/node_contextify.cchttps://github.com/nodejs/node/pull/13265/files#diff-d194c6f9fca3e3c031ecc5b7bd91a53c8881641cd4d1df1ff169312971955c50
addaleaxhttps://github.com/addaleax
May 28, 2017https://github.com/nodejs/node/pull/13265#discussion_r118839180
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13265
AnnaMaghttps://github.com/AnnaMag
May 28, 2017https://github.com/nodejs/node/pull/13265#discussion_r118839369
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13265
https://github.com/AnnaMag
AnnaMaghttps://github.com/AnnaMag
force-pushedhttps://github.com/nodejs/node/compare/027facd38080ef3dc973926e1ef52c755ec2fd68..89ed92dc58d1492cf2a81e2377d19f095bdc1ff0
027facdhttps://github.com/nodejs/node/commit/027facd38080ef3dc973926e1ef52c755ec2fd68
89ed92dhttps://github.com/nodejs/node/commit/89ed92dc58d1492cf2a81e2377d19f095bdc1ff0
Compare https://github.com/nodejs/node/compare/027facd38080ef3dc973926e1ef52c755ec2fd68..89ed92dc58d1492cf2a81e2377d19f095bdc1ff0
May 28, 2017 12:03https://github.com/nodejs/node/pull/13265#event-1100155356
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
May 29, 2017 https://github.com/nodejs/node/pull/13265#pullrequestreview-40708280
View reviewed changes https://github.com/nodejs/node/pull/13265/files
test/known_issues/test-vm-attributes-property-not-on-sandbox.jshttps://github.com/nodejs/node/pull/13265/files#diff-3f5bfe0c6a21b95e4fadab2243a3f0d05117a0beb66c83e38e571199d1f7b0f0
fhinkelhttps://github.com/fhinkel
May 29, 2017https://github.com/nodejs/node/pull/13265#discussion_r118876073
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13265
AnnaMaghttps://github.com/AnnaMag
May 29, 2017https://github.com/nodejs/node/pull/13265#discussion_r118940986
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13265
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
May 29, 2017https://github.com/nodejs/node/pull/13265#issuecomment-304587633
@cpojerhttps://github.com/cpojer
Please reload this pagehttps://github.com/nodejs/node/pull/13265
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
May 29, 2017 https://github.com/nodejs/node/pull/13265#pullrequestreview-40708707
View reviewed changes https://github.com/nodejs/node/pull/13265/files
src/node_contextify.cchttps://github.com/nodejs/node/pull/13265/files#diff-d194c6f9fca3e3c031ecc5b7bd91a53c8881641cd4d1df1ff169312971955c50
fhinkelhttps://github.com/fhinkel
May 29, 2017https://github.com/nodejs/node/pull/13265#discussion_r118876465
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13265
https://github.com/cpojer
cpojerhttps://github.com/cpojer
May 29, 2017https://github.com/nodejs/node/pull/13265#issuecomment-304726351
Please reload this pagehttps://github.com/nodejs/node/pull/13265
https://github.com/AnnaMag
AnnaMaghttps://github.com/AnnaMag
May 29, 2017https://github.com/nodejs/node/pull/13265#issuecomment-304736165
Please reload this pagehttps://github.com/nodejs/node/pull/13265
@fhinkelhttps://github.com/fhinkel
@cpojerhttps://github.com/cpojer
Please reload this pagehttps://github.com/nodejs/node/pull/13265
VM context object silently fails on Object.defineProperty #5679 https://github.com/nodejs/node/issues/5679
node_contextify tracking issue #6283 https://github.com/nodejs/node/issues/6283
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Jun 6, 2017https://github.com/nodejs/node/pull/13265#issuecomment-306510722
@AnnaMaghttps://github.com/AnnaMag
Please reload this pagehttps://github.com/nodejs/node/pull/13265
https://github.com/AnnaMag
AnnaMaghttps://github.com/AnnaMag
Jul 16, 2017https://github.com/nodejs/node/pull/13265#issuecomment-315619855
Please reload this pagehttps://github.com/nodejs/node/pull/13265
@cpojerhttps://github.com/cpojer
@fhinkelhttps://github.com/fhinkel
Please reload this pagehttps://github.com/nodejs/node/pull/13265
https://github.com/refack
refackhttps://github.com/refack
Jul 16, 2017https://github.com/nodejs/node/pull/13265#issuecomment-315631977
#13804https://github.com/nodejs/node/issues/13804
#14188https://github.com/nodejs/node/pull/14188
Please reload this pagehttps://github.com/nodejs/node/pull/13265
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 16, 2017https://github.com/nodejs/node/pull/13265#issuecomment-315637654
@refackhttps://github.com/refack
Please reload this pagehttps://github.com/nodejs/node/pull/13265
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jul 18, 2017 https://github.com/nodejs/node/pull/13265#ref-pullrequest-243062265
[wip] src, inspector: support opted-in VM contexts #14231 https://github.com/nodejs/node/pull/14231
https://github.com/AnnaMag
AnnaMaghttps://github.com/AnnaMag
Jul 18, 2017https://github.com/nodejs/node/pull/13265#issuecomment-316111482
Please reload this pagehttps://github.com/nodejs/node/pull/13265
@refackhttps://github.com/refack
jestjs/jest#4062https://github.com/jestjs/jest/issues/4062
Please reload this pagehttps://github.com/nodejs/node/pull/13265
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Jul 19, 2017https://github.com/nodejs/node/pull/13265#issuecomment-316289414
Please reload this pagehttps://github.com/nodejs/node/pull/13265
@AnnaMaghttps://github.com/AnnaMag
Please reload this pagehttps://github.com/nodejs/node/pull/13265
https://github.com/AnnaMag
AnnaMaghttps://github.com/AnnaMag
Jul 19, 2017https://github.com/nodejs/node/pull/13265#issuecomment-316340406
@TimothyGuhttps://github.com/TimothyGu
Please reload this pagehttps://github.com/nodejs/node/pull/13265
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Aug 3, 2017https://github.com/nodejs/node/pull/13265#issuecomment-319937682
@AnnaMaghttps://github.com/AnnaMag
Please reload this pagehttps://github.com/nodejs/node/pull/13265
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Aug 7, 2017 https://github.com/nodejs/node/pull/13265#ref-issue-248355598
VM module doesn't handle undefined/NaN/null correctly #14660 https://github.com/nodejs/node/issues/14660
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
Aug 17, 2017https://github.com/nodejs/node/pull/13265#event-1210178879
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 17, 2017https://github.com/nodejs/node/pull/13265#issuecomment-323079828
@AnnaMaghttps://github.com/AnnaMag
Please reload this pagehttps://github.com/nodejs/node/pull/13265
https://github.com/AnnaMag
AnnaMaghttps://github.com/AnnaMag
Aug 17, 2017https://github.com/nodejs/node/pull/13265#issuecomment-323188567
Please reload this pagehttps://github.com/nodejs/node/pull/13265
@bnoordhuishttps://github.com/bnoordhuis
https://codereview.chromium.org/2807333003/https://codereview.chromium.org/2807333003/
@fhinkelhttps://github.com/fhinkel
Please reload this pagehttps://github.com/nodejs/node/pull/13265
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Sep 12, 2017https://github.com/nodejs/node/pull/13265#issuecomment-328966416
@fhinkelhttps://github.com/fhinkel
Please reload this pagehttps://github.com/nodejs/node/pull/13265
https://github.com/AnnaMag
AnnaMaghttps://github.com/AnnaMag
Sep 15, 2017https://github.com/nodejs/node/pull/13265#issuecomment-329771099
Please reload this pagehttps://github.com/nodejs/node/pull/13265
@BridgeARhttps://github.com/BridgeAR
Please reload this pagehttps://github.com/nodejs/node/pull/13265
targoshttps://github.com/targos
Dec 6, 2017 https://github.com/nodejs/node/pull/13265#ref-commit-3038d53
https://github.com/fhinkel
https://github.com/targos
deps: cherry-pick 37a3a15c3 from V8 upstreamhttps://github.com/targos/node/commit/3038d5364cd241c54d16852d222b3fbeca9abe6d
3038d53https://github.com/targos/node/commit/3038d5364cd241c54d16852d222b3fbeca9abe6d
nodejs#13265https://github.com/nodejs/node/pull/13265
https://chromium-review.googlesource.com/725295https://chromium-review.googlesource.com/725295
nodejs#16294https://github.com/nodejs/node/pull/16294
targoshttps://github.com/targos
Dec 6, 2017 https://github.com/nodejs/node/pull/13265#ref-commit-e01a210
https://github.com/fhinkel
https://github.com/targos
deps: cherry-pick 37a3a15c3 from V8 upstreamhttps://github.com/nodejs/node/commit/e01a210c7f40f7cffe2db608707f717fb3cb5e29
e01a210https://github.com/nodejs/node/commit/e01a210c7f40f7cffe2db608707f717fb3cb5e29
#13265https://github.com/nodejs/node/pull/13265
https://chromium-review.googlesource.com/725295https://chromium-review.googlesource.com/725295
#16294https://github.com/nodejs/node/pull/16294
addaleaxhttps://github.com/addaleax
Dec 7, 2017 https://github.com/nodejs/node/pull/13265#ref-commit-8326b78
https://github.com/fhinkel
https://github.com/addaleax
deps: cherry-pick 37a3a15c3 from V8 upstreamhttps://github.com/ayojs/ayo/commit/8326b789679ba2c8daf54b604f1ddc9409045653
8326b78https://github.com/ayojs/ayo/commit/8326b789679ba2c8daf54b604f1ddc9409045653
nodejs/node#13265https://github.com/nodejs/node/pull/13265
https://chromium-review.googlesource.com/725295https://chromium-review.googlesource.com/725295
nodejs/node#16294https://github.com/nodejs/node/pull/16294
addaleaxhttps://github.com/addaleax
Dec 7, 2017 https://github.com/nodejs/node/pull/13265#ref-commit-4502da1
https://github.com/fhinkel
https://github.com/addaleax
src: use new V8 API in vm modulehttps://github.com/ayojs/ayo/commit/4502da176a7813a5ca1986b96969b0ea2a8d3cfc
4502da1https://github.com/ayojs/ayo/commit/4502da176a7813a5ca1986b96969b0ea2a8d3cfc
nodejs/node#10223https://github.com/nodejs/node/issues/10223
https://github.com/AnnaMaghttps://github.com/AnnaMag
nodejs/node#13265https://github.com/nodejs/node/pull/13265
https://chromium.googlesource.com/v8/v8/+/37a3a15c3e52e2146e45f41c427f24414e4d7f6fhttps://chromium.googlesource.com/v8/v8/+/37a3a15c3e52e2146e45f41c427f24414e4d7f6f
nodejs/node#16293https://github.com/nodejs/node/pull/16293
nodejs/node#2734https://github.com/nodejs/node/issues/2734
nodejs/node#10223https://github.com/nodejs/node/issues/10223
nodejs/node#11803https://github.com/nodejs/node/issues/11803
nodejs/node#11902https://github.com/nodejs/node/issues/11902
nodejs/node#6283https://github.com/nodejs/node/issues/6283
nodejs/node#15114https://github.com/nodejs/node/pull/15114
nodejs/node#13265https://github.com/nodejs/node/pull/13265
targoshttps://github.com/targos
Jan 15, 2018 https://github.com/nodejs/node/pull/13265#ref-commit-2c8d93a
https://github.com/fhinkel
https://github.com/targos
deps: cherry-pick 37a3a15c3 from V8 upstreamhttps://github.com/targos/node/commit/2c8d93ac68bf442125357ef6c6c74aff622939c1
2c8d93ahttps://github.com/targos/node/commit/2c8d93ac68bf442125357ef6c6c74aff622939c1
nodejs#13265https://github.com/nodejs/node/pull/13265
https://chromium-review.googlesource.com/725295https://chromium-review.googlesource.com/725295
nodejs#16294https://github.com/nodejs/node/pull/16294
gibfahnhttps://github.com/gibfahn
Jan 16, 2018 https://github.com/nodejs/node/pull/13265#ref-commit-3c99f39
https://github.com/fhinkel
https://github.com/gibfahn
deps: cherry-pick 37a3a15c3 from V8 upstreamhttps://github.com/gibfahn/node/commit/3c99f390d7c6c08b6ac7789b2e216abffc526dc3
3c99f39https://github.com/gibfahn/node/commit/3c99f390d7c6c08b6ac7789b2e216abffc526dc3
nodejs#13265https://github.com/nodejs/node/pull/13265
https://chromium-review.googlesource.com/725295https://chromium-review.googlesource.com/725295
nodejs#16294https://github.com/nodejs/node/pull/16294
nodejs#16413https://github.com/nodejs/node/pull/16413
gibfahnhttps://github.com/gibfahn
Jan 22, 2018 https://github.com/nodejs/node/pull/13265#ref-commit-91dc965
https://github.com/fhinkel
https://github.com/gibfahn
deps: cherry-pick 37a3a15c3 from V8 upstreamhttps://github.com/gibfahn/node/commit/91dc965ed1685dc611d851c65d9741be39609518
91dc965https://github.com/gibfahn/node/commit/91dc965ed1685dc611d851c65d9741be39609518
nodejs#13265https://github.com/nodejs/node/pull/13265
https://chromium-review.googlesource.com/725295https://chromium-review.googlesource.com/725295
nodejs#16294https://github.com/nodejs/node/pull/16294
nodejs#16413https://github.com/nodejs/node/pull/16413
MylesBorinshttps://github.com/MylesBorins
Feb 7, 2018 https://github.com/nodejs/node/pull/13265#ref-commit-21bfde6
https://github.com/fhinkel
https://github.com/MylesBorins
deps: cherry-pick 37a3a15c3 from V8 upstreamhttps://github.com/targos/node/commit/21bfde6c245479f980918f0da54bb59037597209
21bfde6https://github.com/targos/node/commit/21bfde6c245479f980918f0da54bb59037597209
nodejs#13265https://github.com/nodejs/node/pull/13265
https://chromium-review.googlesource.com/725295https://chromium-review.googlesource.com/725295
nodejs#16294https://github.com/nodejs/node/pull/16294
gibfahnhttps://github.com/gibfahn
Feb 18, 2018 https://github.com/nodejs/node/pull/13265#ref-commit-0b690a9
https://github.com/fhinkel
https://github.com/gibfahn
deps: cherry-pick 37a3a15c3 from V8 upstreamhttps://github.com/nodejs/node/commit/0b690a9ce3a10aa68aefbb50398758e52f50a331
0b690a9https://github.com/nodejs/node/commit/0b690a9ce3a10aa68aefbb50398758e52f50a331
#13265https://github.com/nodejs/node/pull/13265
https://chromium-review.googlesource.com/725295https://chromium-review.googlesource.com/725295
#16294https://github.com/nodejs/node/pull/16294
#16413https://github.com/nodejs/node/pull/16413
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13265
https://github.com/fhinkel
fhinkel https://github.com/fhinkel
https://github.com/nodejs/node/pull/13265/files/89ed92dc58d1492cf2a81e2377d19f095bdc1ff0
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/13265/files/5e5cd96edf3b31cf5805afc3d11503f86a512af3
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/13265/files/2b7fe69e23d2f023383bf5114b0d72a3165cca79
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Please reload this pagehttps://github.com/nodejs/node/pull/13265
https://github.com/AnnaMag
https://github.com/fhinkel
https://github.com/cpojer
https://github.com/refack
https://github.com/addaleax
https://github.com/TimothyGu
https://github.com/bnoordhuis
https://github.com/BridgeAR
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.