René's URL Explorer Experiment


Title: WIP src: don't check closing handles on beforeExit by trevnorris · Pull Request #1317 · nodejs/node · GitHub

Open Graph Title: WIP src: don't check closing handles on beforeExit by trevnorris · Pull Request #1317 · nodejs/node

X Title: WIP src: don't check closing handles on beforeExit by trevnorris · Pull Request #1317 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: uv_loop_alive() returns true if there are closing handles. This causes an issue running the beforeExit event and a timer has been unref'd: process.on('beforeExit', function() { setTim...

X Description: uv_loop_alive() returns true if there are closing handles. This causes an issue running the beforeExit event and a timer has been unref'd: process.on('beforeExit', function(...

Opengraph URL: https://github.com/nodejs/node/pull/1317

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9ce4dea1-60cd-34cf-b5fb-0ce9ab164752
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id955E:4FAAE:235452D:32ABBDE:6A4FE157
html-safe-nonce76733e2ecd1a9d68f37b5f0b44589a3c0a491176c574a5105040d38bc46c999b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTVFOjRGQUFFOjIzNTQ1MkQ6MzJBQkJERTo2QTRGRTE1NyIsInZpc2l0b3JfaWQiOiIzNTg3MzEzMDY3MTYyMDY3Mjg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac897231439fe56389a050416985fafcd75cead309d1670aa81ef63196ef181545
hovercard-subject-tagpull_request:32453961
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1317/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bb061329690b2b619e9db0164816ba0b9ce07bc19f3120ddb0b313b408d8f2e7/nodejs/node/pull/1317
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bb061329690b2b619e9db0164816ba0b9ce07bc19f3120ddb0b313b408d8f2e7/nodejs/node/pull/1317
og:image:altuv_loop_alive() returns true if there are closing handles. This causes an issue running the beforeExit event and a timer has been unref'd: process.on('beforeExit', function() { setTim...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrevnorris
hostnamegithub.com
expected-hostnamegithub.com
None19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release142593e66413bbae27fd485859993597d5a3b104
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/1317#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1317
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1317
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/1317
Reloadhttps://github.com/nodejs/node/pull/1317
Reloadhttps://github.com/nodejs/node/pull/1317
Please reload this pagehttps://github.com/nodejs/node/pull/1317
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/1317
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 974 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
trevnorrishttps://github.com/trevnorris
nodejs:v1.xhttps://github.com/nodejs/node/tree/v1.x
trevnorris:loop-alive-closing-handleshttps://github.com/trevnorris/node/tree/loop-alive-closing-handles
Conversationhttps://github.com/nodejs/node/pull/1317
Commits1 (1)https://github.com/nodejs/node/pull/1317/commits
Checkshttps://github.com/nodejs/node/pull/1317/checks
Files changedhttps://github.com/nodejs/node/pull/1317/files
WIP src: don't check closing handles on beforeExithttps://github.com/nodejs/node/pull/1317#top
trevnorrishttps://github.com/trevnorris
nodejs:v1.xhttps://github.com/nodejs/node/tree/v1.x
trevnorris:loop-alive-closing-handleshttps://github.com/trevnorris/node/tree/loop-alive-closing-handles
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Apr 1, 2015https://github.com/nodejs/node/pull/1317#issue-65765504
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/1317
https://github.com/mscdex
mscdexhttps://github.com/mscdex
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Apr 1, 2015https://github.com/nodejs/node/pull/1317#event-271006403
https://github.com/thlorenz
thlorenzhttps://github.com/thlorenz
Apr 1, 2015https://github.com/nodejs/node/pull/1317#issuecomment-88613059
Please reload this pagehttps://github.com/nodejs/node/pull/1317
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
force-pushedhttps://github.com/nodejs/node/compare/8b9cc254440ea28b438eb8e5561967d483643bef..583b570cfc763ef31da97f75e54d659e150f0079
8b9cc25https://github.com/nodejs/node/commit/8b9cc254440ea28b438eb8e5561967d483643bef
583b570https://github.com/nodejs/node/commit/583b570cfc763ef31da97f75e54d659e150f0079
Compare https://github.com/nodejs/node/compare/8b9cc254440ea28b438eb8e5561967d483643bef..583b570cfc763ef31da97f75e54d659e150f0079
April 1, 2015 19:57https://github.com/nodejs/node/pull/1317#event-271010312
https://github.com/thlorenz
thlorenzhttps://github.com/thlorenz
Apr 1, 2015https://github.com/nodejs/node/pull/1317#issuecomment-88616480
libuv a bit https://gist.github.com/thlorenz/8dd5d3a50ee14457afce
unrefhttps://gist.github.com/thlorenz/8dd5d3a50ee14457afce#uv__handle_unref
uv_loop_alivehttps://github.com/libuv/libuv/blob/f2bb8d394c06d06ee45e884600466321455751b6/src/unix/core.c#L293
@saghulhttps://github.com/saghul
Please reload this pagehttps://github.com/nodejs/node/pull/1317
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Apr 1, 2015https://github.com/nodejs/node/pull/1317#issuecomment-88619083
@thlorenzhttps://github.com/thlorenz
Please reload this pagehttps://github.com/nodejs/node/pull/1317
bnoordhuishttps://github.com/bnoordhuis
Apr 1, 2015 https://github.com/nodejs/node/pull/1317#discussion-diff-27607374
View reviewed changes https://github.com/nodejs/node/pull/1317/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
src/node.cchttps://github.com/nodejs/node/pull/1317/files#diff-6c1386cbc6e4a11941649af31a0257d5c3e40b5f41223cdddf87ab2e984b705a
bnoordhuishttps://github.com/bnoordhuis
Apr 1, 2015https://github.com/nodejs/node/pull/1317#discussion_r27607374
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1317
trevnorrishttps://github.com/trevnorris
Apr 1, 2015https://github.com/nodejs/node/pull/1317#discussion_r27607621
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1317
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
force-pushedhttps://github.com/nodejs/node/compare/583b570cfc763ef31da97f75e54d659e150f0079..4339d83e46f70511dd096eed10f422242da4c025
583b570https://github.com/nodejs/node/commit/583b570cfc763ef31da97f75e54d659e150f0079
4339d83https://github.com/nodejs/node/commit/4339d83e46f70511dd096eed10f422242da4c025
Compare https://github.com/nodejs/node/compare/583b570cfc763ef31da97f75e54d659e150f0079..4339d83e46f70511dd096eed10f422242da4c025
April 1, 2015 20:27https://github.com/nodejs/node/pull/1317#event-271036470
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 1, 2015https://github.com/nodejs/node/pull/1317#issuecomment-88621938
#1151https://github.com/nodejs/node/issues/1151
Please reload this pagehttps://github.com/nodejs/node/pull/1317
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
timers https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers
Apr 1, 2015https://github.com/nodejs/node/pull/1317#event-271037382
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 1, 2015https://github.com/nodejs/node/pull/1317#issuecomment-88624731
#1152https://github.com/nodejs/node/pull/1152
@thlorenzhttps://github.com/thlorenz
Please reload this pagehttps://github.com/nodejs/node/pull/1317
https://github.com/trevnorris
src: don't check closing handles on beforeExithttps://github.com/nodejs/node/pull/1317/commits/190af5eda3d6dac3b0b8c314968c5fe1f9a81137
190af5ehttps://github.com/nodejs/node/pull/1317/commits/190af5eda3d6dac3b0b8c314968c5fe1f9a81137
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
force-pushedhttps://github.com/nodejs/node/compare/4339d83e46f70511dd096eed10f422242da4c025..190af5eda3d6dac3b0b8c314968c5fe1f9a81137
4339d83https://github.com/nodejs/node/commit/4339d83e46f70511dd096eed10f422242da4c025
190af5ehttps://github.com/nodejs/node/commit/190af5eda3d6dac3b0b8c314968c5fe1f9a81137
Compare https://github.com/nodejs/node/compare/4339d83e46f70511dd096eed10f422242da4c025..190af5eda3d6dac3b0b8c314968c5fe1f9a81137
April 1, 2015 20:50https://github.com/nodejs/node/pull/1317#event-271056193
https://github.com/thlorenz
thlorenzhttps://github.com/thlorenz
Apr 1, 2015https://github.com/nodejs/node/pull/1317#issuecomment-88630635
this patchhttps://github.com/thlorenz/io.js/commit/73a7b30d3853536290e9e81caa7677da0342a976
Please reload this pagehttps://github.com/nodejs/node/pull/1317
https://github.com/thlorenz
thlorenzhttps://github.com/thlorenz
Apr 1, 2015https://github.com/nodejs/node/pull/1317#issuecomment-88631882
@bnoordhuishttps://github.com/bnoordhuis
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/1317
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Apr 1, 2015https://github.com/nodejs/node/pull/1317#issuecomment-88647075
Please reload this pagehttps://github.com/nodejs/node/pull/1317
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Apr 2, 2015https://github.com/nodejs/node/pull/1317#issuecomment-89065379
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/1317
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Apr 2, 2015https://github.com/nodejs/node/pull/1317#event-272168963
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
March 28, 2016 22:20https://github.com/nodejs/node/pull/1317#event-605847346
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1317
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
timers https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers
Please reload this pagehttps://github.com/nodejs/node/pull/1317
https://github.com/trevnorris
https://github.com/thlorenz
https://github.com/bnoordhuis
https://github.com/Fishrock123
https://github.com/mscdex
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.