René's URL Explorer Experiment


Title: test: add override to ServerDone function by danbev · Pull Request #13166 · nodejs/node · GitHub

Open Graph Title: test: add override to ServerDone function by danbev · Pull Request #13166 · nodejs/node

X Title: test: add override to ServerDone function by danbev · Pull Request #13166 · nodejs/node

Description: Currently the following compiler warning is displayed when building: ../test/cctest/test_inspector_socket_server.cc:142:8: warning: 'ServerDone' overrides a member function but is not marked 'overr...

Open Graph Description: Currently the following compiler warning is displayed when building: ../test/cctest/test_inspector_socket_server.cc:142:8: warning: 'ServerDone' overrides a member function but is not marke...

X Description: Currently the following compiler warning is displayed when building: ../test/cctest/test_inspector_socket_server.cc:142:8: warning: 'ServerDone' overrides a member function but is n...

Opengraph URL: https://github.com/nodejs/node/pull/13166

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0968d9cd-81b2-613b-5365-2c2f68b1d3c8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC44:3484C0:13A3BEA:1B7557E:696A3631
html-safe-nonce028a97175cc1d64b60211467573a6131f78b7490200bb3972a4cbd36271dec1e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzQ0OjM0ODRDMDoxM0EzQkVBOjFCNzU1N0U6Njk2QTM2MzEiLCJ2aXNpdG9yX2lkIjoiODA0MjcyODIzMzgxMjc2ODMwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1f37beeb7e0b9d04f2a6857ad08f71028206a575f2c41c8366d78a904dc9efb0
hovercard-subject-tagpull_request:121922655
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/13166/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5be53200ce903f48a58f35605c87b3b302a0d02f47907cb96eb953e4a80b8162/nodejs/node/pull/13166
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5be53200ce903f48a58f35605c87b3b302a0d02f47907cb96eb953e4a80b8162/nodejs/node/pull/13166
og:image:altCurrently the following compiler warning is displayed when building: ../test/cctest/test_inspector_socket_server.cc:142:8: warning: 'ServerDone' overrides a member function but is not marke...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedanbev
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7a9163cefd1ea4bd06f8eb7c082f43e4e53f626f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/13166#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13166
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13166
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/13166
Reloadhttps://github.com/nodejs/node/pull/13166
Reloadhttps://github.com/nodejs/node/pull/13166
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/13166
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/13166
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/13166#issue-comment-box
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:serverdone-overridehttps://github.com/danbev/node/tree/serverdone-override
test: add override to ServerDone function https://github.com/nodejs/node/pull/13166#top
danbevhttps://github.com/danbev
nodejs:masterhttps://github.com/nodejs/node/tree/master
danbev:serverdone-overridehttps://github.com/danbev/node/tree/serverdone-override
Conversation 3 https://github.com/nodejs/node/pull/13166
Commits 1 https://github.com/nodejs/node/pull/13166/commits
Checks 0 https://github.com/nodejs/node/pull/13166/checks
Files changed https://github.com/nodejs/node/pull/13166/files
Please reload this pagehttps://github.com/nodejs/node/pull/13166
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/danbev
danbevhttps://github.com/danbev
May 23, 2017https://github.com/nodejs/node/pull/13166#issue-230600623
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/13166
https://github.com/danbev
test: add override to ServerDone functionhttps://github.com/nodejs/node/pull/13166/commits/1ab70933770a071956d0558bd58367d27dd6fbe5
1ab7093https://github.com/nodejs/node/pull/13166/commits/1ab70933770a071956d0558bd58367d27dd6fbe5
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
inspector https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainspector
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
May 23, 2017https://github.com/nodejs/node/pull/13166#event-1093034214
https://github.com/danbev
danbevhttps://github.com/danbev
May 23, 2017https://github.com/nodejs/node/pull/13166#issuecomment-303306664
https://ci.nodejs.org/job/node-test-pull-request/8243/https://ci.nodejs.org/job/node-test-pull-request/8243/
Please reload this pagehttps://github.com/nodejs/node/pull/13166
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 23, 2017 https://github.com/nodejs/node/pull/13166#pullrequestreview-39748011
View reviewed changes https://github.com/nodejs/node/pull/13166/files/1ab70933770a071956d0558bd58367d27dd6fbe5
https://github.com/refack
refackhttps://github.com/refack
May 23, 2017 https://github.com/nodejs/node/pull/13166#pullrequestreview-39752652
View reviewed changes https://github.com/nodejs/node/pull/13166/files/1ab70933770a071956d0558bd58367d27dd6fbe5
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 23, 2017 https://github.com/nodejs/node/pull/13166#pullrequestreview-39761332
View reviewed changes https://github.com/nodejs/node/pull/13166/files/1ab70933770a071956d0558bd58367d27dd6fbe5
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 25, 2017 https://github.com/nodejs/node/pull/13166#pullrequestreview-40317524
View reviewed changes https://github.com/nodejs/node/pull/13166/files/1ab70933770a071956d0558bd58367d27dd6fbe5
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 25, 2017https://github.com/nodejs/node/pull/13166#issuecomment-304047108
25ade76https://github.com/nodejs/node/commit/25ade76fb01258d8a789a9cd893b284542827efd
Please reload this pagehttps://github.com/nodejs/node/pull/13166
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 25, 2017https://github.com/nodejs/node/pull/13166#event-1097538744
addaleaxhttps://github.com/addaleax
May 25, 2017 https://github.com/nodejs/node/pull/13166#ref-commit-25ade76
https://github.com/danbev
https://github.com/addaleax
test: add override to ServerDone functionhttps://github.com/nodejs/node/commit/25ade76fb01258d8a789a9cd893b284542827efd
25ade76https://github.com/nodejs/node/commit/25ade76fb01258d8a789a9cd893b284542827efd
#13166https://github.com/nodejs/node/pull/13166
jasnellhttps://github.com/jasnell
May 25, 2017 https://github.com/nodejs/node/pull/13166#ref-commit-443f12d
https://github.com/danbev
https://github.com/jasnell
test: add override to ServerDone functionhttps://github.com/nodejs/node/commit/443f12db0adcd43d6a06ee00a58648faf80bea1f
443f12dhttps://github.com/nodejs/node/commit/443f12db0adcd43d6a06ee00a58648faf80bea1f
#13166https://github.com/nodejs/node/pull/13166
jasnellhttps://github.com/jasnell
May 28, 2017 https://github.com/nodejs/node/pull/13166#ref-commit-b781fa7
https://github.com/danbev
https://github.com/jasnell
test: add override to ServerDone functionhttps://github.com/nodejs/node/commit/b781fa7b06530b586f6c5a2aeecd33de86be0b97
b781fa7https://github.com/nodejs/node/commit/b781fa7b06530b586f6c5a2aeecd33de86be0b97
#13166https://github.com/nodejs/node/pull/13166
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 28, 2017 https://github.com/nodejs/node/pull/13166#ref-pullrequest-219383958
8.0.0 Release Proposal #12220 https://github.com/nodejs/node/pull/12220
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Jun 15, 2017 https://github.com/nodejs/node/pull/13166#ref-issue-235404028
Auditing for 6.11.1 nodejs/Release#230 https://github.com/nodejs/Release/issues/230
https://github.com/danbev
danbevhttps://github.com/danbev
June 28, 2017 05:41https://github.com/nodejs/node/pull/13166#event-1141737253
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
Jul 17, 2017https://github.com/nodejs/node/pull/13166#event-1166787206
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jul 17, 2017https://github.com/nodejs/node/pull/13166#issuecomment-315807900
Please reload this pagehttps://github.com/nodejs/node/pull/13166
https://github.com/aliscco
alisccohttps://github.com/aliscco
Apr 27, 2023 https://github.com/nodejs/node/pull/13166#ref-pullrequest-1687210823
[Snyk] Fix for 30 vulnerabilities aliscco/alisco-node#279 https://github.com/aliscco/alisco-node/pull/279
https://github.com/leonardoadame
leonardoadamehttps://github.com/leonardoadame
Nov 30, 2023 https://github.com/nodejs/node/pull/13166#ref-pullrequest-2019632659
[Snyk] Fix for 1 vulnerabilities leonardoadame/node#332 https://github.com/leonardoadame/node/pull/332
https://github.com/aliscco
alisccohttps://github.com/aliscco
Dec 1, 2023 https://github.com/nodejs/node/pull/13166#ref-pullrequest-2019998312
[Snyk] Security upgrade jest from 26.4.2 to 29.0.0 aliscco/alisco-node#924 https://github.com/aliscco/alisco-node/pull/924
[Snyk] Fix for 1 vulnerabilities leonardoadame/node#371 https://github.com/leonardoadame/node/pull/371
[Snyk] Security upgrade jest from 26.4.2 to 29.0.0 leonardoadame/node#384 https://github.com/leonardoadame/node/pull/384
[Snyk] Fix for 1 vulnerabilities leonardoadame/node#427 https://github.com/leonardoadame/node/pull/427
[Snyk] Security upgrade jest from 26.6.3 to 29.0.0 leonardoadame/node#438 https://github.com/leonardoadame/node/pull/438
https://github.com/aliscco
alisccohttps://github.com/aliscco
Dec 2, 2023 https://github.com/nodejs/node/pull/13166#ref-pullrequest-2021895787
[Snyk] Fix for 6 vulnerabilities aliscco/alisco-node#1050 https://github.com/aliscco/alisco-node/pull/1050
https://github.com/leonardoadame
leonardoadamehttps://github.com/leonardoadame
Dec 3, 2023 https://github.com/nodejs/node/pull/13166#ref-pullrequest-2022259462
[Snyk] Fix for 1 vulnerabilities leonardoadame/node#477 https://github.com/leonardoadame/node/pull/477
[Snyk] Fix for 2 vulnerabilities leonardoadame/node#879 https://github.com/leonardoadame/node/pull/879
[Snyk] Security upgrade jest from 28.1.3 to 29.0.0 leonardoadame/node#918 https://github.com/leonardoadame/node/pull/918
https://github.com/aliscco
alisccohttps://github.com/aliscco
May 15, 2024 https://github.com/nodejs/node/pull/13166#ref-pullrequest-2297195510
[Snyk] Security upgrade jest from 26.4.2 to 29.0.0 aliscco/alisco-node#1535 https://github.com/aliscco/alisco-node/pull/1535
[Snyk] Security upgrade jest from 27.5.1 to 29.0.0 leonardoadame/node#946 https://github.com/leonardoadame/node/pull/946
[Snyk] Fix for 4 vulnerabilities leonardoadame/node#966 https://github.com/leonardoadame/node/pull/966
https://github.com/aliscco
alisccohttps://github.com/aliscco
May 17, 2024 https://github.com/nodejs/node/pull/13166#ref-pullrequest-2301592207
[Snyk] Security upgrade jest from 26.4.2 to 29.0.0 aliscco/alisco-node#1603 https://github.com/aliscco/alisco-node/pull/1603
https://github.com/apps/snyk-io
snyk-iohttps://github.com/apps/snyk-io
Oct 23, 2024 https://github.com/nodejs/node/pull/13166#ref-pullrequest-2609231653
[Snyk] Fix for 5 vulnerabilities Graybar-codespace/node#93 https://github.com/Graybar-codespace/node/pull/93
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13166
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/13166/files/1ab70933770a071956d0558bd58367d27dd6fbe5
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/13166/files/1ab70933770a071956d0558bd58367d27dd6fbe5
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/13166/files/1ab70933770a071956d0558bd58367d27dd6fbe5
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/13166/files/1ab70933770a071956d0558bd58367d27dd6fbe5
inspector https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ainspector
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/13166
https://github.com/danbev
https://github.com/addaleax
https://github.com/MylesBorins
https://github.com/refack
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.