| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:915e6eb7-b5d3-0bb7-cc5c-b5d9a64758d9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C55E:19638B:25B917:357446:696A0772 |
| html-safe-nonce | 79d1d57c3e3ed67b8631a3ec9e61cc36c8e9d4f3353025a83772ecd1afe0c2e5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTVFOjE5NjM4QjoyNUI5MTc6MzU3NDQ2OjY5NkEwNzcyIiwidmlzaXRvcl9pZCI6IjM5NTQxMzUwMDU0NDM3ODY2MTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1ebef886c428305d4eb1c5246fb6d385b138b4246647169b0738d33fe7659805 |
| hovercard-subject-tag | pull_request:121413011 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/13111/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7857b098feb6e081393ba261ef6d9e406fb7d8aacba5abe2aa95588fabb4c2a3/nodejs/node/pull/13111 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7857b098feb6e081393ba261ef6d9e406fb7d8aacba5abe2aa95588fabb4c2a3/nodejs/node/pull/13111 |
| og:image:alt | macOS is not currently listed as a supported os for the fs.watch filename argument, but it does work. This commit updates the documentation to reflect that.
Fixes: #13108
Checklist
make -j4 tes... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | chris--young |
| hostname | github.com |
| expected-hostname | github.com |
| None | 578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 671c2f67171dbced24284331f3133a613d08c366 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/13111#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13111 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13111 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/13111 |
| Reload | https://github.com/nodejs/node/pull/13111 |
| Reload | https://github.com/nodejs/node/pull/13111 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/13111#issue-comment-box |
| chris--young | https://github.com/chris--young |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| chris--young:watch-filename | https://github.com/chris--young/node/tree/watch-filename |
|
doc: list macOS as supporting filename argument
| https://github.com/nodejs/node/pull/13111#top |
| chris--young | https://github.com/chris--young |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| chris--young:watch-filename | https://github.com/chris--young/node/tree/watch-filename |
|
Conversation
30
| https://github.com/nodejs/node/pull/13111 |
|
Commits
3
| https://github.com/nodejs/node/pull/13111/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/13111/checks |
|
Files changed
| https://github.com/nodejs/node/pull/13111/files |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/chris--young |
| chris--young | https://github.com/chris--young |
| May 19, 2017 | https://github.com/nodejs/node/pull/13111#issue-229852532 |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| #13108 | https://github.com/nodejs/node/issues/13108 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
| May 19, 2017 | https://github.com/nodejs/node/pull/13111#event-1088837050 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
macos
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amacos |
| May 19, 2017 | https://github.com/nodejs/node/pull/13111#event-1088854692 |
| https://github.com/refack |
| refack | https://github.com/refack |
| May 19, 2017 | https://github.com/nodejs/node/pull/13111#issuecomment-302594097 |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| https://github.com/refack |
| refack | https://github.com/refack |
| May 19, 2017 | https://github.com/nodejs/node/pull/13111#issuecomment-302596610 |
| @chris--young | https://github.com/chris--young |
| test/parallel/test-fs-watchfile.js | https://github.com/nodejs/node/blob/master/test/parallel/test-fs-watchfile.js |
| common | https://github.com/nodejs/node/blob/master/test/common/README.md |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| https://github.com/chris--young |
| chris--young | https://github.com/chris--young |
| force-pushed | https://github.com/nodejs/node/compare/710747f1e83438fb9373632ae56f1719d557fb24..364720ec73e7d2e9b5848e9612fcdca5b3958317 |
| 710747f | https://github.com/nodejs/node/commit/710747f1e83438fb9373632ae56f1719d557fb24 |
| 364720e | https://github.com/nodejs/node/commit/364720ec73e7d2e9b5848e9612fcdca5b3958317 |
|
Compare
| https://github.com/nodejs/node/compare/710747f1e83438fb9373632ae56f1719d557fb24..364720ec73e7d2e9b5848e9612fcdca5b3958317 |
| May 19, 2017 06:33 | https://github.com/nodejs/node/pull/13111#event-1089002609 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
| May 19, 2017 | https://github.com/nodejs/node/pull/13111#issuecomment-302629178 |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
May 19, 2017
| https://github.com/nodejs/node/pull/13111#pullrequestreview-39125335 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13111/files |
| gireeshpunathil | https://github.com/gireeshpunathil |
| https://github.com/nodejs/node/pull/13111#pullrequestreview-39125335 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| https://github.com/aashil |
| aashil | https://github.com/aashil |
|
May 19, 2017
| https://github.com/nodejs/node/pull/13111#pullrequestreview-39199619 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13111/files |
| test/parallel/test-fs-watchfile.js | https://github.com/nodejs/node/pull/13111/files#diff-6cf404215c88151caea93963d279e4a4630e3e70bbea1ffb49900819c70f5885 |
| aashil | https://github.com/aashil |
| May 19, 2017 | https://github.com/nodejs/node/pull/13111#discussion_r117485137 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @gireeshpunathil | https://github.com/gireeshpunathil |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| refack | https://github.com/refack |
| May 19, 2017 | https://github.com/nodejs/node/pull/13111#discussion_r117503462 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
May 19, 2017
| https://github.com/nodejs/node/pull/13111#pullrequestreview-39220442 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13111/files |
| refack | https://github.com/refack |
| https://github.com/nodejs/node/pull/13111#pullrequestreview-39220442 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| test/parallel/test-fs-watchfile.js | https://github.com/nodejs/node/pull/13111/files#diff-6cf404215c88151caea93963d279e4a4630e3e70bbea1ffb49900819c70f5885 |
| refack | https://github.com/refack |
| May 19, 2017 | https://github.com/nodejs/node/pull/13111#discussion_r117503462 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| test/parallel/test-fs-watchfile.js | https://github.com/nodejs/node/pull/13111/files#diff-6cf404215c88151caea93963d279e4a4630e3e70bbea1ffb49900819c70f5885 |
| refack | https://github.com/refack |
| May 19, 2017 | https://github.com/nodejs/node/pull/13111#discussion_r117504385 |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| test/parallel/test-fs-watchfile.js | https://github.com/nodejs/node/pull/13111/files#diff-6cf404215c88151caea93963d279e4a4630e3e70bbea1ffb49900819c70f5885 |
| refack | https://github.com/refack |
| May 19, 2017 | https://github.com/nodejs/node/pull/13111#discussion_r117504754 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| test/parallel/test-fs-watchfile.js | https://github.com/nodejs/node/pull/13111/files#diff-6cf404215c88151caea93963d279e4a4630e3e70bbea1ffb49900819c70f5885 |
| refack | https://github.com/refack |
| May 19, 2017 | https://github.com/nodejs/node/pull/13111#discussion_r117506280 |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #13092 (comment) | https://github.com/nodejs/node/pull/13092#discussion_r117273934 |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| refack | https://github.com/refack |
| May 19, 2017 | https://github.com/nodejs/node/pull/13111#discussion_r117512397 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #13115 | https://github.com/nodejs/node/issues/13115 |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| https://github.com/refack |
| refack | https://github.com/refack |
| May 19, 2017 | https://github.com/nodejs/node/pull/13111#issuecomment-302731924 |
| @chris--young | https://github.com/chris--young |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
May 19, 2017
| https://github.com/nodejs/node/pull/13111#pullrequestreview-39285459 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13111/files |
| https://github.com/refack |
| refack | https://github.com/refack |
| May 19, 2017 | https://github.com/nodejs/node/pull/13111#event-1090122227 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
aix
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaix |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
| May 19, 2017 | https://github.com/nodejs/node/pull/13111#event-1090122751 |
| https://github.com/refack |
| refack | https://github.com/refack |
| May 19, 2017 | https://github.com/nodejs/node/pull/13111#issuecomment-302796302 |
| https://ci.nodejs.org/job/node-test-commit/10021/ | https://ci.nodejs.org/job/node-test-commit/10021/ |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| https://github.com/chris--young |
| chris--young | https://github.com/chris--young |
| May 19, 2017 | https://github.com/nodejs/node/pull/13111#issuecomment-302805507 |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| https://github.com/refack |
| refack | https://github.com/refack |
| May 19, 2017 | https://github.com/nodejs/node/pull/13111#issuecomment-302816708 |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| https://github.com/refack |
| refack | https://github.com/refack |
| May 19, 2017 | https://github.com/nodejs/node/pull/13111#issuecomment-302817227 |
| @chris--young | https://github.com/chris--young |
| https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-8-landing | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-8-landing |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| https://github.com/chris--young |
| chris--young | https://github.com/chris--young |
| May 19, 2017 | https://github.com/nodejs/node/pull/13111#issuecomment-302817797 |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
May 20, 2017
| https://github.com/nodejs/node/pull/13111#pullrequestreview-39329800 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13111/files |
| test/parallel/test-fs-watchfile.js | https://github.com/nodejs/node/pull/13111/files#diff-6cf404215c88151caea93963d279e4a4630e3e70bbea1ffb49900819c70f5885 |
| lpinca | https://github.com/lpinca |
| May 20, 2017 | https://github.com/nodejs/node/pull/13111#discussion_r117603881 |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| refack | https://github.com/refack |
| May 20, 2017 | https://github.com/nodejs/node/pull/13111#discussion_r117607735 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @refack | https://github.com/refack |
| #12820 | https://github.com/nodejs/node/pull/12820 |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| https://github.com/gireeshpunathil |
| gireeshpunathil | https://github.com/gireeshpunathil |
|
May 20, 2017
| https://github.com/nodejs/node/pull/13111#pullrequestreview-39331523 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13111/files |
| gireeshpunathil | https://github.com/gireeshpunathil |
| https://github.com/nodejs/node/pull/13111#pullrequestreview-39331523 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @chris--young | https://github.com/chris--young |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| https://github.com/aqrln |
| aqrln | https://github.com/aqrln |
|
May 20, 2017
| https://github.com/nodejs/node/pull/13111#pullrequestreview-39343238 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13111/files |
| aqrln | https://github.com/aqrln |
| https://github.com/nodejs/node/pull/13111#pullrequestreview-39343238 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| May 21, 2017 15:13 | https://github.com/nodejs/node/pull/13111#commits-pushed-5fee2e8 |
| doc: list macOS as supporting filename argument | https://github.com/nodejs/node/pull/13111/commits/5fee2e89987a0e56230868b020cbd9c693e74fe6 |
| 5fee2e8 | https://github.com/nodejs/node/pull/13111/commits/5fee2e89987a0e56230868b020cbd9c693e74fe6 |
| nodejs#13108 | https://github.com/nodejs/node/issues/13108 |
| test: check fs.watch filename on Linux and macOS | https://github.com/nodejs/node/pull/13111/commits/9bd40124d7d7bf6f1ddb93ef9092fdfa49f83f95 |
| 9bd4012 | https://github.com/nodejs/node/pull/13111/commits/9bd40124d7d7bf6f1ddb93ef9092fdfa49f83f95 |
| nodejs#13108 | https://github.com/nodejs/node/issues/13108 |
| https://github.com/chris--young |
| chris--young | https://github.com/chris--young |
| force-pushed | https://github.com/nodejs/node/compare/a89bfd169fe0103a85d771b697fe9c8b2d517058..21535c38a3f800117089872f890e9d1f336024e0 |
| a89bfd1 | https://github.com/nodejs/node/commit/a89bfd169fe0103a85d771b697fe9c8b2d517058 |
| 21535c3 | https://github.com/nodejs/node/commit/21535c38a3f800117089872f890e9d1f336024e0 |
|
Compare
| https://github.com/nodejs/node/compare/a89bfd169fe0103a85d771b697fe9c8b2d517058..21535c38a3f800117089872f890e9d1f336024e0 |
| May 21, 2017 22:13 | https://github.com/nodejs/node/pull/13111#event-1090977293 |
| https://github.com/chris--young |
| chris--young | https://github.com/chris--young |
| May 21, 2017 | https://github.com/nodejs/node/pull/13111#event-1090977945 |
| https://github.com/refack |
| refack | https://github.com/refack |
| May 22, 2017 | https://github.com/nodejs/node/pull/13111#issuecomment-303115000 |
| https://ci.nodejs.org/job/node-test-commit/10067/ | https://ci.nodejs.org/job/node-test-commit/10067/ |
| @lpinca | https://github.com/lpinca |
| @aqrln | https://github.com/aqrln |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
May 22, 2017
| https://github.com/nodejs/node/pull/13111#pullrequestreview-39491669 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13111/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 22, 2017
| https://github.com/nodejs/node/pull/13111#pullrequestreview-39491968 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13111/files |
| https://github.com/aqrln |
| aqrln | https://github.com/aqrln |
|
May 22, 2017
| https://github.com/nodejs/node/pull/13111#pullrequestreview-39497346 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13111/files |
| test/parallel/test-fs-watchfile.js | https://github.com/nodejs/node/pull/13111/files#diff-6cf404215c88151caea93963d279e4a4630e3e70bbea1ffb49900819c70f5885 |
| aqrln | https://github.com/aqrln |
| May 22, 2017 | https://github.com/nodejs/node/pull/13111#discussion_r117763910 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| cjihrig | https://github.com/cjihrig |
| May 22, 2017 | https://github.com/nodejs/node/pull/13111#discussion_r117764266 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| refack | https://github.com/refack |
| May 22, 2017 | https://github.com/nodejs/node/pull/13111#discussion_r117764345 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| https://github.com/aqrln |
| aqrln | https://github.com/aqrln |
|
May 22, 2017
| https://github.com/nodejs/node/pull/13111#pullrequestreview-39497541 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13111/files |
| test/parallel/test-fs-watchfile.js | https://github.com/nodejs/node/pull/13111/files#diff-6cf404215c88151caea93963d279e4a4630e3e70bbea1ffb49900819c70f5885 |
| aqrln | https://github.com/aqrln |
| May 22, 2017 | https://github.com/nodejs/node/pull/13111#discussion_r117764113 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| https://github.com/refack |
| refack | https://github.com/refack |
| May 22, 2017 | https://github.com/nodejs/node/pull/13111#issuecomment-303123077 |
| @chris--young | https://github.com/chris--young |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| https://github.com/aashil |
| aashil | https://github.com/aashil |
|
May 22, 2017
| https://github.com/nodejs/node/pull/13111#pullrequestreview-39499689 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/13111/files |
| test: fs.watch filename check for Windows & AIX | https://github.com/nodejs/node/pull/13111/commits/64884c2a5c1371a645215a0caec8fdcd39e994d2 |
| 64884c2 | https://github.com/nodejs/node/pull/13111/commits/64884c2a5c1371a645215a0caec8fdcd39e994d2 |
| nodejs#13108 | https://github.com/nodejs/node/issues/13108 |
| https://github.com/chris--young |
| chris--young | https://github.com/chris--young |
| force-pushed | https://github.com/nodejs/node/compare/21535c38a3f800117089872f890e9d1f336024e0..64884c2a5c1371a645215a0caec8fdcd39e994d2 |
| 21535c3 | https://github.com/nodejs/node/commit/21535c38a3f800117089872f890e9d1f336024e0 |
| 64884c2 | https://github.com/nodejs/node/commit/64884c2a5c1371a645215a0caec8fdcd39e994d2 |
|
Compare
| https://github.com/nodejs/node/compare/21535c38a3f800117089872f890e9d1f336024e0..64884c2a5c1371a645215a0caec8fdcd39e994d2 |
| May 22, 2017 17:57 | https://github.com/nodejs/node/pull/13111#event-1092278063 |
| https://github.com/chris--young |
| chris--young | https://github.com/chris--young |
| May 22, 2017 | https://github.com/nodejs/node/pull/13111#issuecomment-303197758 |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| https://github.com/refack |
| refack | https://github.com/refack |
| May 22, 2017 | https://github.com/nodejs/node/pull/13111#issuecomment-303202423 |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| refack | https://github.com/refack |
|
May 22, 2017
| https://github.com/nodejs/node/pull/13111#ref-commit-c470f04 |
|
| https://github.com/refack |
| doc: list macOS as supporting filename argument | https://github.com/refack/node/commit/c470f04f22eb34cf50a65b384f59d60209b1bf1d |
| c470f04 | https://github.com/refack/node/commit/c470f04f22eb34cf50a65b384f59d60209b1bf1d |
| nodejs#13111 | https://github.com/nodejs/node/pull/13111 |
| nodejs#13108 | https://github.com/nodejs/node/issues/13108 |
| https://github.com/refack |
| refack | https://github.com/refack |
| May 22, 2017 | https://github.com/nodejs/node/pull/13111#issuecomment-303203157 |
| c470f04 | https://github.com/nodejs/node/commit/c470f04f22eb34cf50a65b384f59d60209b1bf1d |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
| https://github.com/refack |
| refack | https://github.com/refack |
| May 22, 2017 | https://github.com/nodejs/node/pull/13111#event-1092454384 |
| jasnell | https://github.com/jasnell |
|
May 23, 2017
| https://github.com/nodejs/node/pull/13111#ref-commit-f47c6f7 |
|
| https://github.com/jasnell |
| doc: list macOS as supporting filename argument | https://github.com/nodejs/node/commit/f47c6f7fde57de83b4ee0ecd7ec3c136da462aee |
| f47c6f7 | https://github.com/nodejs/node/commit/f47c6f7fde57de83b4ee0ecd7ec3c136da462aee |
| #13111 | https://github.com/nodejs/node/pull/13111 |
| #13108 | https://github.com/nodejs/node/issues/13108 |
| jasnell | https://github.com/jasnell |
|
May 23, 2017
| https://github.com/nodejs/node/pull/13111#ref-commit-1aa68f9 |
|
| https://github.com/jasnell |
| doc: list macOS as supporting filename argument | https://github.com/nodejs/node/commit/1aa68f9a8dcf50d76399374ca3cccfa0888fdd4f |
| 1aa68f9 | https://github.com/nodejs/node/commit/1aa68f9a8dcf50d76399374ca3cccfa0888fdd4f |
| #13111 | https://github.com/nodejs/node/pull/13111 |
| #13108 | https://github.com/nodejs/node/issues/13108 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
May 26, 2017
| https://github.com/nodejs/node/pull/13111#ref-issue-231728322 |
|
test-fs-watchfile failure on OSX - intermittent ?
#13248
| https://github.com/nodejs/node/issues/13248 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 28, 2017
| https://github.com/nodejs/node/pull/13111#ref-pullrequest-219383958 |
|
8.0.0 Release Proposal
#12220
| https://github.com/nodejs/node/pull/12220 |
|
test: make test-fs-watchfile reliable
#13385
| https://github.com/nodejs/node/pull/13385 |
|
Intermittent failure in parallel/test-fs-watchfile on AIX
#13377
| https://github.com/nodejs/node/issues/13377 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Jun 15, 2017
| https://github.com/nodejs/node/pull/13111#ref-issue-235404028 |
|
Auditing for 6.11.1
nodejs/Release#230
| https://github.com/nodejs/Release/issues/230 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Jul 17, 2017 | https://github.com/nodejs/node/pull/13111#event-1166663927 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Oct 20, 2018 | https://github.com/nodejs/node/pull/13111#event-1916393833 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13111 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/13111/files/21535c38a3f800117089872f890e9d1f336024e0 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/13111/files/21535c38a3f800117089872f890e9d1f336024e0 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/13111/files/21535c38a3f800117089872f890e9d1f336024e0 |
|
| https://github.com/gireeshpunathil |
|
gireeshpunathil
| https://github.com/gireeshpunathil |
|
| https://github.com/nodejs/node/pull/13111/files/a89bfd169fe0103a85d771b697fe9c8b2d517058 |
|
| https://github.com/refack |
|
refack
| https://github.com/refack |
|
| https://github.com/nodejs/node/pull/13111/files/21535c38a3f800117089872f890e9d1f336024e0 |
|
| https://github.com/aqrln |
|
aqrln
| https://github.com/aqrln |
|
| https://github.com/nodejs/node/pull/13111/files/21535c38a3f800117089872f890e9d1f336024e0 |
|
| https://github.com/aashil |
|
aashil
| https://github.com/aashil |
|
| https://github.com/nodejs/node/pull/13111/files/21535c38a3f800117089872f890e9d1f336024e0 |
|
aix
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaix |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
macos
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amacos |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
|
Documentation for fs.watch needs to say that filename is also available for macOS
| https://github.com/nodejs/node/issues/13108 |
| Please reload this page | https://github.com/nodejs/node/pull/13111 |
|
| https://github.com/chris--young |
|
| https://github.com/refack |
|
| https://github.com/gireeshpunathil |
|
| https://github.com/jasnell |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/aqrln |
|
| https://github.com/aashil |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |