René's URL Explorer Experiment


Title: n-api: Retain last code when getting error info by jasongin · Pull Request #13087 · nodejs/node · GitHub

Open Graph Title: n-api: Retain last code when getting error info by jasongin · Pull Request #13087 · nodejs/node

X Title: n-api: Retain last code when getting error info by jasongin · Pull Request #13087 · nodejs/node

Description: Unlike most N-API functions, napi_get_last_error_info() should not clear the last error code when successful, because a pointer to (not a copy of) the error info structure is returned via an out pa...

Open Graph Description: Unlike most N-API functions, napi_get_last_error_info() should not clear the last error code when successful, because a pointer to (not a copy of) the error info structure is returned via an out pa...

X Description: Unlike most N-API functions, napi_get_last_error_info() should not clear the last error code when successful, because a pointer to (not a copy of) the error info structure is returned via an out pa...

Opengraph URL: https://github.com/nodejs/node/pull/13087

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:e69f54d6-7a48-953a-1d76-4c0f9c38a377
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id959C:13F356:2E3AA9:4137B1:696A07A4
html-safe-nonced6ccca9f60a1eed8bbecaf11612b5a207e1dd4f60b85f1450b637d08c63ad4a2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTlDOjEzRjM1NjoyRTNBQTk6NDEzN0IxOjY5NkEwN0E0IiwidmlzaXRvcl9pZCI6IjQzNTQ4MDk4NDU5MDI4NzA0MzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0415aee8b0526abb5c11dd7a0db810d495b5a8cb86ef35dc4f5bc0ce98f56683
hovercard-subject-tagpull_request:121180514
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/13087
twitter:imagehttps://opengraph.githubassets.com/c5ce21ae2a14e920496c08acb8e41d50b1bf23e9a0c79652627e3179b97b9280/nodejs/node/pull/13087
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c5ce21ae2a14e920496c08acb8e41d50b1bf23e9a0c79652627e3179b97b9280/nodejs/node/pull/13087
og:image:altUnlike most N-API functions, napi_get_last_error_info() should not clear the last error code when successful, because a pointer to (not a copy of) the error info structure is returned via an out pa...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasongin
hostnamegithub.com
expected-hostnamegithub.com
None578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release671c2f67171dbced24284331f3133a613d08c366
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/13087#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13087
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13087
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/13087
Reloadhttps://github.com/nodejs/node/pull/13087
Reloadhttps://github.com/nodejs/node/pull/13087
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/13087
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/13087
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/13087#issue-comment-box
jasonginhttps://github.com/jasongin
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasongin:last_errorhttps://github.com/jasongin/nodejs/tree/last_error
n-api: Retain last code when getting error info https://github.com/nodejs/node/pull/13087#top
jasonginhttps://github.com/jasongin
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasongin:last_errorhttps://github.com/jasongin/nodejs/tree/last_error
Conversation 4 https://github.com/nodejs/node/pull/13087
Commits 1 https://github.com/nodejs/node/pull/13087/commits
Checks 0 https://github.com/nodejs/node/pull/13087/checks
Files changed https://github.com/nodejs/node/pull/13087/files
Please reload this pagehttps://github.com/nodejs/node/pull/13087
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/jasongin
jasonginhttps://github.com/jasongin
May 18, 2017https://github.com/nodejs/node/pull/13087#issue-229525252
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/13087
https://github.com/jasongin
n-api: Retain last code when getting error infohttps://github.com/nodejs/node/pull/13087/commits/0d489c8e04b83d58e638b1251e4a6636b8743146
0d489c8https://github.com/nodejs/node/pull/13087/commits/0d489c8e04b83d58e638b1251e4a6636b8743146
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
May 18, 2017https://github.com/nodejs/node/pull/13087#event-1086977018
jasonginhttps://github.com/jasongin
May 18, 2017 https://github.com/nodejs/node/pull/13087#ref-commit-fff4990
https://github.com/jasongin
Fix reporting of API error messageshttps://github.com/nodejs/node-addon-api/commit/fff49908c9267da6b7e5d254b03d3513359d648c
fff4990https://github.com/nodejs/node-addon-api/commit/fff49908c9267da6b7e5d254b03d3513359d648c
nodejs/node#13087https://github.com/nodejs/node/pull/13087
https://github.com/jasongin
jasonginhttps://github.com/jasongin
May 18, 2017 https://github.com/nodejs/node/pull/13087#ref-pullrequest-229525560
Fix reporting of API error messages nodejs/node-addon-api#43 https://github.com/nodejs/node-addon-api/pull/43
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
May 18, 2017https://github.com/nodejs/node/pull/13087#event-1087776595
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 18, 2017 https://github.com/nodejs/node/pull/13087#pullrequestreview-38933782
View reviewed changes https://github.com/nodejs/node/pull/13087/files/0d489c8e04b83d58e638b1251e4a6636b8743146
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 18, 2017 https://github.com/nodejs/node/pull/13087#pullrequestreview-38940037
View reviewed changes https://github.com/nodejs/node/pull/13087/files/0d489c8e04b83d58e638b1251e4a6636b8743146
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 19, 2017 https://github.com/nodejs/node/pull/13087#pullrequestreview-39093206
View reviewed changes https://github.com/nodejs/node/pull/13087/files/0d489c8e04b83d58e638b1251e4a6636b8743146
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/13087#pullrequestreview-39093206
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/13087
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 19, 2017https://github.com/nodejs/node/pull/13087#issuecomment-302767979
https://ci.nodejs.org/job/node-test-pull-request/8186/https://ci.nodejs.org/job/node-test-pull-request/8186/
Please reload this pagehttps://github.com/nodejs/node/pull/13087
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 19, 2017https://github.com/nodejs/node/pull/13087#issuecomment-302810755
Please reload this pagehttps://github.com/nodejs/node/pull/13087
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 19, 2017https://github.com/nodejs/node/pull/13087#issuecomment-302811127
a63b245https://github.com/nodejs/node/commit/a63b245b0a0d15e9a494b3a4602031bfc6a51ff8
Please reload this pagehttps://github.com/nodejs/node/pull/13087
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 19, 2017https://github.com/nodejs/node/pull/13087#event-1090216561
mhdawsonhttps://github.com/mhdawson
May 19, 2017 https://github.com/nodejs/node/pull/13087#ref-commit-a63b245
https://github.com/jasongin
https://github.com/mhdawson
n-api: Retain last code when getting error infohttps://github.com/nodejs/node/commit/a63b245b0a0d15e9a494b3a4602031bfc6a51ff8
a63b245https://github.com/nodejs/node/commit/a63b245b0a0d15e9a494b3a4602031bfc6a51ff8
#13087https://github.com/nodejs/node/pull/13087
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 28, 2017 https://github.com/nodejs/node/pull/13087#ref-pullrequest-219383958
8.0.0 Release Proposal #12220 https://github.com/nodejs/node/pull/12220
jasonginhttps://github.com/jasongin
Jun 6, 2017 https://github.com/nodejs/node/pull/13087#ref-commit-92f362a
https://github.com/jasongin
Fix reporting of API error messageshttps://github.com/nodejs/node-addon-api/commit/92f362a9b7063c91cb56b315c2a52accceee1a63
92f362ahttps://github.com/nodejs/node-addon-api/commit/92f362a9b7063c91cb56b315c2a52accceee1a63
nodejs/node#13087https://github.com/nodejs/node/pull/13087
gabrielschulhofhttps://github.com/gabrielschulhof
Apr 10, 2018 https://github.com/nodejs/node/pull/13087#ref-commit-726d584
https://github.com/jasongin
n-api: Retain last code when getting error infohttps://github.com/gabrielschulhof/node/commit/726d5849777a155dcc788fbbc4a993da7c43fe90
726d584https://github.com/gabrielschulhof/node/commit/726d5849777a155dcc788fbbc4a993da7c43fe90
nodejs#13087https://github.com/nodejs/node/pull/13087
MylesBorinshttps://github.com/MylesBorins
Apr 16, 2018 https://github.com/nodejs/node/pull/13087#ref-commit-70281ba
https://github.com/jasongin
https://github.com/MylesBorins
n-api: Retain last code when getting error infohttps://github.com/nodejs/node/commit/70281ba1be8d4bc067ac9ec6b5a50f0936eb06fc
70281bahttps://github.com/nodejs/node/commit/70281ba1be8d4bc067ac9ec6b5a50f0936eb06fc
#19447https://github.com/nodejs/node/pull/19447
#13087https://github.com/nodejs/node/pull/13087
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 16, 2018 https://github.com/nodejs/node/pull/13087#ref-pullrequest-313968187
v6.14.2 proposal #19996 https://github.com/nodejs/node/pull/19996
kevindavies8https://github.com/kevindavies8
Aug 24, 2022 https://github.com/nodejs/node/pull/13087#ref-commit-1a9b43b
https://github.com/kevindavies8
Fix reporting of API error messageshttps://github.com/kevindavies8/node-addon-api-Develop/commit/1a9b43ba4d8d6d982801f83161c8d250182a423d
1a9b43bhttps://github.com/kevindavies8/node-addon-api-Develop/commit/1a9b43ba4d8d6d982801f83161c8d250182a423d
nodejs/node#13087https://github.com/nodejs/node/pull/13087
Marlyfleitashttps://github.com/Marlyfleitas
Aug 26, 2022 https://github.com/nodejs/node/pull/13087#ref-commit-5f8738a
https://github.com/Marlyfleitas
Fix reporting of API error messageshttps://github.com/Marlyfleitas/node-api-addon-Development/commit/5f8738a1155ad40abf521c2cccf5b4736b68efe8
5f8738ahttps://github.com/Marlyfleitas/node-api-addon-Development/commit/5f8738a1155ad40abf521c2cccf5b4736b68efe8
nodejs/node#13087https://github.com/nodejs/node/pull/13087
wroy7860https://github.com/wroy7860
Sep 19, 2022 https://github.com/nodejs/node/pull/13087#ref-commit-4b4b708
https://github.com/wroy7860
Fix reporting of API error messageshttps://github.com/wroy7860/addon-api-benchmark-node/commit/4b4b7083a1811ddda895fcaa821148e2ea4e988d
4b4b708https://github.com/wroy7860/addon-api-benchmark-node/commit/4b4b7083a1811ddda895fcaa821148e2ea4e988d
nodejs/node#13087https://github.com/nodejs/node/pull/13087
johnfrench3https://github.com/johnfrench3
Aug 11, 2023 https://github.com/nodejs/node/pull/13087#ref-commit-3f2b1d7
Fix reporting of API error messageshttps://github.com/johnfrench3/node-addon-api-git/commit/3f2b1d722b86cfd901caec3e0c093674ecd6ddf6
3f2b1d7https://github.com/johnfrench3/node-addon-api-git/commit/3f2b1d722b86cfd901caec3e0c093674ecd6ddf6
nodejs/node#13087https://github.com/nodejs/node/pull/13087
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F13087
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/13087/files/0d489c8e04b83d58e638b1251e4a6636b8743146
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/13087/files/0d489c8e04b83d58e638b1251e4a6636b8743146
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/13087/files/0d489c8e04b83d58e638b1251e4a6636b8743146
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Please reload this pagehttps://github.com/nodejs/node/pull/13087
https://github.com/jasongin
https://github.com/mhdawson
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.