| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5efca1d3-5855-188d-92be-cf78d97adf01 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C224:2EA598:292C1A:3A3548:696A0705 |
| html-safe-nonce | 84625ef83b01f87c317da3b5d08826902f4357c1bd4716ac65867d9fdd8052f5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjI0OjJFQTU5ODoyOTJDMUE6M0EzNTQ4OjY5NkEwNzA1IiwidmlzaXRvcl9pZCI6IjY2NTk5MzExODAzNTE3NTE5NDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a9cf4c413e5d1a9108a7827653b2c3ffa970cd4eb9f1ed8cb77b7b4326a5b973 |
| hovercard-subject-tag | pull_request:120275411 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/12992/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9ed509882e872e5e348b7bc80af5fb40cf33f0835de231eed37c021adfd8dc45/nodejs/node/pull/12992 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9ed509882e872e5e348b7bc80af5fb40cf33f0835de231eed37c021adfd8dc45/nodejs/node/pull/12992 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
test
Some more readability with low overheads. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | vsemozhetbyt |
| hostname | github.com |
| expected-hostname | github.com |
| None | 578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 671c2f67171dbced24284331f3133a613d08c366 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/12992#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12992 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12992 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/12992 |
| Reload | https://github.com/nodejs/node/pull/12992 |
| Reload | https://github.com/nodejs/node/pull/12992 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/12992 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/12992 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/12992#issue-comment-box |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
test: remove unneeded string splitting
| https://github.com/nodejs/node/pull/12992#top |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
Conversation
3
| https://github.com/nodejs/node/pull/12992 |
|
Commits
1
| https://github.com/nodejs/node/pull/12992/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/12992/checks |
|
Files changed
| https://github.com/nodejs/node/pull/12992/files |
| Please reload this page | https://github.com/nodejs/node/pull/12992 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| May 12, 2017 | https://github.com/nodejs/node/pull/12992#issue-228226489 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/12992 |
|
| https://github.com/vsemozhetbyt |
| test: remove unneeded string splitting | https://github.com/nodejs/node/pull/12992/commits/076bd96816c25cc3a2f79b51c0ac943802f573c0 |
| 076bd96 | https://github.com/nodejs/node/pull/12992/commits/076bd96816c25cc3a2f79b51c0ac943802f573c0 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| May 12, 2017 | https://github.com/nodejs/node/pull/12992#event-1079606940 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| May 12, 2017 | https://github.com/nodejs/node/pull/12992#issuecomment-301021086 |
| Please reload this page | https://github.com/nodejs/node/pull/12992 |
| https://ci.nodejs.org/job/node-test-pull-request/8040/ | https://ci.nodejs.org/job/node-test-pull-request/8040/ |
| Please reload this page | https://github.com/nodejs/node/pull/12992 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
May 12, 2017
| https://github.com/nodejs/node/pull/12992#pullrequestreview-37795250 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12992/files/076bd96816c25cc3a2f79b51c0ac943802f573c0 |
| https://github.com/lucamaraschi |
| lucamaraschi | https://github.com/lucamaraschi |
|
May 12, 2017
| https://github.com/nodejs/node/pull/12992#pullrequestreview-37834853 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12992/files/076bd96816c25cc3a2f79b51c0ac943802f573c0 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
May 12, 2017
| https://github.com/nodejs/node/pull/12992#pullrequestreview-37835119 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12992/files/076bd96816c25cc3a2f79b51c0ac943802f573c0 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
|
May 12, 2017
| https://github.com/nodejs/node/pull/12992#pullrequestreview-37835821 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12992/files/076bd96816c25cc3a2f79b51c0ac943802f573c0 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 12, 2017
| https://github.com/nodejs/node/pull/12992#pullrequestreview-37869217 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12992/files/076bd96816c25cc3a2f79b51c0ac943802f573c0 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
May 12, 2017
| https://github.com/nodejs/node/pull/12992#pullrequestreview-37896269 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12992/files/076bd96816c25cc3a2f79b51c0ac943802f573c0 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| May 15, 2017 | https://github.com/nodejs/node/pull/12992#issuecomment-301424630 |
| https://ci.nodejs.org/job/node-test-pull-request/8079/ | https://ci.nodejs.org/job/node-test-pull-request/8079/ |
| Please reload this page | https://github.com/nodejs/node/pull/12992 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 15, 2017 | https://github.com/nodejs/node/pull/12992#issuecomment-301454386 |
| 88d2e69 | https://github.com/nodejs/node/commit/88d2e699d8287218cc6cd4cc80e13e1055e07fce |
| Please reload this page | https://github.com/nodejs/node/pull/12992 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 15, 2017 | https://github.com/nodejs/node/pull/12992#event-1082105028 |
| addaleax | https://github.com/addaleax |
|
May 15, 2017
| https://github.com/nodejs/node/pull/12992#ref-commit-88d2e69 |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/addaleax |
| test: remove unneeded string splitting | https://github.com/nodejs/node/commit/88d2e699d8287218cc6cd4cc80e13e1055e07fce |
| 88d2e69 | https://github.com/nodejs/node/commit/88d2e699d8287218cc6cd4cc80e13e1055e07fce |
| #12992 | https://github.com/nodejs/node/pull/12992 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| May 15, 2017 12:20 | https://github.com/nodejs/node/pull/12992#event-1082132825 |
| anchnk | https://github.com/anchnk |
|
May 19, 2017
| https://github.com/nodejs/node/pull/12992#ref-commit-147fa3c |
|
| https://github.com/vsemozhetbyt |
| test: remove unneeded string splitting | https://github.com/anchnk/node/commit/147fa3c71cc557a1f179ce1387a2adf975e6b943 |
| 147fa3c | https://github.com/anchnk/node/commit/147fa3c71cc557a1f179ce1387a2adf975e6b943 |
| nodejs#12992 | https://github.com/nodejs/node/pull/12992 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 28, 2017
| https://github.com/nodejs/node/pull/12992#ref-pullrequest-219383958 |
|
8.0.0 Release Proposal
#12220
| https://github.com/nodejs/node/pull/12220 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Jun 15, 2017
| https://github.com/nodejs/node/pull/12992#ref-issue-235404028 |
|
Auditing for 6.11.1
nodejs/Release#230
| https://github.com/nodejs/Release/issues/230 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x |
| Jun 22, 2017 | https://github.com/nodejs/node/pull/12992#event-1135324462 |
| MylesBorins | https://github.com/MylesBorins |
|
Jun 22, 2017
| https://github.com/nodejs/node/pull/12992#ref-commit-6b7ba30 |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/MylesBorins |
| test: remove unneeded string splitting | https://github.com/nodejs/node/commit/6b7ba308335807148db79ad6fcfd3d29026a0dc0 |
| 6b7ba30 | https://github.com/nodejs/node/commit/6b7ba308335807148db79ad6fcfd3d29026a0dc0 |
| #12992 | https://github.com/nodejs/node/pull/12992 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 11, 2017
| https://github.com/nodejs/node/pull/12992#ref-commit-0cf3e10 |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/MylesBorins |
| test: remove unneeded string splitting | https://github.com/nodejs/node/commit/0cf3e10ce238d23b78b9f73704db5a510fc7ffdd |
| 0cf3e10 | https://github.com/nodejs/node/commit/0cf3e10ce238d23b78b9f73704db5a510fc7ffdd |
| #12992 | https://github.com/nodejs/node/pull/12992 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 18, 2017
| https://github.com/nodejs/node/pull/12992#ref-pullrequest-243856504 |
|
v6.11.2 proposal
#14356
| https://github.com/nodejs/node/pull/14356 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12992 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/12992/files/076bd96816c25cc3a2f79b51c0ac943802f573c0 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/12992/files/076bd96816c25cc3a2f79b51c0ac943802f573c0 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/12992/files/076bd96816c25cc3a2f79b51c0ac943802f573c0 |
|
| https://github.com/lucamaraschi |
|
lucamaraschi
| https://github.com/lucamaraschi |
|
| https://github.com/nodejs/node/pull/12992/files/076bd96816c25cc3a2f79b51c0ac943802f573c0 |
|
| https://github.com/danbev |
|
danbev
| https://github.com/danbev |
|
| https://github.com/nodejs/node/pull/12992/files/076bd96816c25cc3a2f79b51c0ac943802f573c0 |
|
| https://github.com/gibfahn |
|
gibfahn
| https://github.com/gibfahn |
|
| https://github.com/nodejs/node/pull/12992/files/076bd96816c25cc3a2f79b51c0ac943802f573c0 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/12992 |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/addaleax |
|
| https://github.com/lucamaraschi |
|
| https://github.com/danbev |
|
| https://github.com/jasnell |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/gibfahn |
|
| https://github.com/MylesBorins |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |