René's URL Explorer Experiment


Title: promises: improve unhandledrejection warnings by jasnell · Pull Request #12982 · nodejs/node · GitHub

Open Graph Title: promises: improve unhandledrejection warnings by jasnell · Pull Request #12982 · nodejs/node

X Title: promises: improve unhandledrejection warnings by jasnell · Pull Request #12982 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Per the CTC discussion around #12734 ... This takes an alternative approach than #12734. Rather than adding a throw, it improves the warnings that are already there such that the stack trace for th...

X Description: Per the CTC discussion around #12734 ... This takes an alternative approach than #12734. Rather than adding a throw, it improves the warnings that are already there such that the stack trace for th...

Opengraph URL: https://github.com/nodejs/node/pull/12982

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b355ec60-11e4-6fff-2f3f-046db5ec771a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA126:3FD636:677D18A:9103BF6:6A504980
html-safe-noncee97272bfe0a43e74b1f225a426162b50ed7952089859e1486d4448f68aab25fd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTI2OjNGRDYzNjo2NzdEMThBOjkxMDNCRjY6NkE1MDQ5ODAiLCJ2aXNpdG9yX2lkIjoiNjk0MzgzMTcxODM4MzA3Nzc2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8afcbfce94ed4576e49d20291044a2071a17b836e40c2ef21804256328adf6ca
hovercard-subject-tagpull_request:120196813
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/12982/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7668fe58162cb1b5cdda13eacc650202e76e17c24a8e044f19ba1d9850dc32f1/nodejs/node/pull/12982
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7668fe58162cb1b5cdda13eacc650202e76e17c24a8e044f19ba1d9850dc32f1/nodejs/node/pull/12982
og:image:altPer the CTC discussion around #12734 ... This takes an alternative approach than #12734. Rather than adding a throw, it improves the warnings that are already there such that the stack trace for th...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5741a45fe07e5f377d0d4c524a92e3056acc51bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/12982#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12982
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12982
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/12982
Reloadhttps://github.com/nodejs/node/pull/12982
Reloadhttps://github.com/nodejs/node/pull/12982
Please reload this pagehttps://github.com/nodejs/node/pull/12982
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/12982
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 978 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:improve-unhandled-rejectionhttps://github.com/jasnell/node/tree/improve-unhandled-rejection
Conversationhttps://github.com/nodejs/node/pull/12982
Commits3 (3)https://github.com/nodejs/node/pull/12982/commits
Checkshttps://github.com/nodejs/node/pull/12982/checks
Files changedhttps://github.com/nodejs/node/pull/12982/files
promises: improve unhandledrejection warningshttps://github.com/nodejs/node/pull/12982#top
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:improve-unhandled-rejectionhttps://github.com/jasnell/node/tree/improve-unhandled-rejection
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 11, 2017https://github.com/nodejs/node/pull/12982#issue-228114975
#12734https://github.com/nodejs/node/pull/12734
#12734https://github.com/nodejs/node/pull/12734
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/12982
jasnellhttps://github.com/jasnell
May 11, 2017 11:51https://github.com/nodejs/node/pull/12982#commits-pushed-4624b52
https://github.com/jasnell
promises: use Symbols for state instead of WeakMaphttps://github.com/nodejs/node/pull/12982/commits/4624b52bba5c47cf7c4dc4dbdbec70ace55adc77
4624b52https://github.com/nodejs/node/pull/12982/commits/4624b52bba5c47cf7c4dc4dbdbec70ace55adc77
https://github.com/jasnell
promises: use a linked list for trackinghttps://github.com/nodejs/node/pull/12982/commits/4c471ab90ebcf147122ac926b4fb64a672bb74a0
4c471abhttps://github.com/nodejs/node/pull/12982/commits/4c471ab90ebcf147122ac926b4fb64a672bb74a0
https://github.com/jasnell
promises: improve unhandled reject warningshttps://github.com/nodejs/node/pull/12982/commits/c2c3aedafcbdbb5d947d027757b0156da628336f
c2c3aedhttps://github.com/nodejs/node/pull/12982/commits/c2c3aedafcbdbb5d947d027757b0156da628336f
https://github.com/mscdex
mscdexhttps://github.com/mscdex
promises https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apromises
May 11, 2017https://github.com/nodejs/node/pull/12982#event-1079051726
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
May 12, 2017https://github.com/nodejs/node/pull/12982#issuecomment-300949578
Please reload this pagehttps://github.com/nodejs/node/pull/12982
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 15, 2017https://github.com/nodejs/node/pull/12982#issuecomment-301455677
Please reload this pagehttps://github.com/nodejs/node/pull/12982
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 15, 2017https://github.com/nodejs/node/pull/12982#issuecomment-301508047
Please reload this pagehttps://github.com/nodejs/node/pull/12982
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 16, 2017https://github.com/nodejs/node/pull/12982#issuecomment-301808344
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/12982
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 16, 2017https://github.com/nodejs/node/pull/12982#issuecomment-301808492
Please reload this pagehttps://github.com/nodejs/node/pull/12982
https://github.com/mcollina
mcollinahttps://github.com/mcollina
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
notable-change https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change
May 16, 2017https://github.com/nodejs/node/pull/12982#event-1084302129
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 16, 2017https://github.com/nodejs/node/pull/12982#issuecomment-301809500
Please reload this pagehttps://github.com/nodejs/node/pull/12982
Please reload this pagehttps://github.com/nodejs/node/pull/12982
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jul 8, 2017 https://github.com/nodejs/node/pull/12982#pullrequestreview-48765339
View reviewed changes https://github.com/nodejs/node/pull/12982/files/c2c3aedafcbdbb5d947d027757b0156da628336f
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 10, 2017https://github.com/nodejs/node/pull/12982#issuecomment-314159774
Please reload this pagehttps://github.com/nodejs/node/pull/12982
https://github.com/refack
refackhttps://github.com/refack
Jul 10, 2017 https://github.com/nodejs/node/pull/12982#pullrequestreview-48972847
View reviewed changes https://github.com/nodejs/node/pull/12982/files/c2c3aedafcbdbb5d947d027757b0156da628336f
lib/internal/process/promises.jshttps://github.com/nodejs/node/pull/12982/files/c2c3aedafcbdbb5d947d027757b0156da628336f#diff-04f0a68c4bc76396de863bbe0982c85d70a5b71432bdc26bc503e3ac317c6f82
refackhttps://github.com/refack
Jul 10, 2017https://github.com/nodejs/node/pull/12982#discussion_r126484193
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/12982
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 12, 2017https://github.com/nodejs/node/pull/12982#issuecomment-328821345
Please reload this pagehttps://github.com/nodejs/node/pull/12982
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 12, 2017https://github.com/nodejs/node/pull/12982#event-1245062833
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12982
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/12982/files/c2c3aedafcbdbb5d947d027757b0156da628336f
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/12982/files/c2c3aedafcbdbb5d947d027757b0156da628336f
notable-change https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change
promises https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apromises
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Please reload this pagehttps://github.com/nodejs/node/pull/12982
https://github.com/jasnell
https://github.com/Fishrock123
https://github.com/addaleax
https://github.com/mcollina
https://github.com/refack
https://github.com/benjamingr
https://github.com/mscdex
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.