| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:842b8539-5e40-59bf-7b6f-ee17d85d319e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 97E2:4D95E:1079B5E:173435B:696A2AB6 |
| html-safe-nonce | 8fa1651ea1cf9cfd2c8318197d3f7b255e00e35e2fef5fda13cb03ec1164ebb8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0UyOjREOTVFOjEwNzlCNUU6MTczNDM1Qjo2OTZBMkFCNiIsInZpc2l0b3JfaWQiOiI1NjUzNDk4Mjc1NjMzNDQxNDYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 3cfddf830d18e636890847a029a86703cbec429fbcb090d6d580f7eb7bd7b4ba |
| hovercard-subject-tag | pull_request:120092325 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/12972/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/821ad49a2e3219f313b820791910c35c1fae8aecb93c655c6aa8207d983c4a21/nodejs/node/pull/12972 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/821ad49a2e3219f313b820791910c35c1fae8aecb93c655c6aa8207d983c4a21/nodejs/node/pull/12972 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
test
Permit spaces in paths to a Node.js executable and test... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | vsemozhetbyt |
| hostname | github.com |
| expected-hostname | github.com |
| None | a1022f03e4f0d91ea173e4e5dac892c982e0588c62f1ce56121d755a320a3569 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f472b8e6c7b3fdd5d0354972a3f4c516289bf0be |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/12972#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12972 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12972 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/12972 |
| Reload | https://github.com/nodejs/node/pull/12972 |
| Reload | https://github.com/nodejs/node/pull/12972 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/12972 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/12972 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/12972#issue-comment-box |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
test: make the rest of tests path-independent
| https://github.com/nodejs/node/pull/12972#top |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
Conversation
7
| https://github.com/nodejs/node/pull/12972 |
|
Commits
1
| https://github.com/nodejs/node/pull/12972/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/12972/checks |
|
Files changed
| https://github.com/nodejs/node/pull/12972/files |
| Please reload this page | https://github.com/nodejs/node/pull/12972 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| May 11, 2017 | https://github.com/nodejs/node/pull/12972#issue-227972156 |
| Please reload this page | https://github.com/nodejs/node/pull/12972 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| #12773 | https://github.com/nodejs/node/issues/12773 |
| Please reload this page | https://github.com/nodejs/node/pull/12972 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| May 11, 2017 | https://github.com/nodejs/node/pull/12972#event-1078129592 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| May 11, 2017 | https://github.com/nodejs/node/pull/12972#issuecomment-300772344 |
| https://ci.nodejs.org/job/node-test-pull-request/8014/ | https://ci.nodejs.org/job/node-test-pull-request/8014/ |
| Please reload this page | https://github.com/nodejs/node/pull/12972 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
May 11, 2017
| https://github.com/nodejs/node/pull/12972#ref-issue-225398910 |
|
test: tests fails on Windows with spaces in paths
#12773
| https://github.com/nodejs/node/issues/12773 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
May 11, 2017
| https://github.com/nodejs/node/pull/12972#pullrequestreview-37666067 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12972/files |
| Trott | https://github.com/Trott |
| https://github.com/nodejs/node/pull/12972#pullrequestreview-37666067 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12972 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| May 11, 2017 | https://github.com/nodejs/node/pull/12972#issuecomment-300881529 |
| Please reload this page | https://github.com/nodejs/node/pull/12972 |
|
| https://github.com/vsemozhetbyt |
| test: make the rest of tests path-independent | https://github.com/nodejs/node/pull/12972/commits/5e73b3ec7ed7eec0da3b7947281dd130bd7779b9 |
| 5e73b3e | https://github.com/nodejs/node/pull/12972/commits/5e73b3ec7ed7eec0da3b7947281dd130bd7779b9 |
| #12773 | https://github.com/nodejs/node/issues/12773 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| May 11, 2017 | https://github.com/nodejs/node/pull/12972#issuecomment-300884262 |
| https://ci.nodejs.org/job/node-test-pull-request/8022/ | https://ci.nodejs.org/job/node-test-pull-request/8022/ |
| Please reload this page | https://github.com/nodejs/node/pull/12972 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
May 11, 2017
| https://github.com/nodejs/node/pull/12972#pullrequestreview-37669599 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12972/files/5e73b3ec7ed7eec0da3b7947281dd130bd7779b9 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| May 14, 2017 | https://github.com/nodejs/node/pull/12972#issuecomment-301311655 |
| 945f208 | https://github.com/nodejs/node/commit/945f20808143d954fea73e4ac3a0d71cf73c9b2c |
| Please reload this page | https://github.com/nodejs/node/pull/12972 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| May 14, 2017 | https://github.com/nodejs/node/pull/12972#event-1081280268 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| May 14, 2017 13:07 | https://github.com/nodejs/node/pull/12972#event-1081280294 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
May 14, 2017
| https://github.com/nodejs/node/pull/12972#ref-commit-945f208 |
|
| https://github.com/vsemozhetbyt |
| test: make the rest of tests path-independent | https://github.com/nodejs/node/commit/945f20808143d954fea73e4ac3a0d71cf73c9b2c |
| 945f208 | https://github.com/nodejs/node/commit/945f20808143d954fea73e4ac3a0d71cf73c9b2c |
| #12972 | https://github.com/nodejs/node/pull/12972 |
| #12773 | https://github.com/nodejs/node/issues/12773 |
| anchnk | https://github.com/anchnk |
|
May 19, 2017
| https://github.com/nodejs/node/pull/12972#ref-commit-ecc7cbe |
|
| https://github.com/vsemozhetbyt |
| test: make the rest of tests path-independent | https://github.com/anchnk/node/commit/ecc7cbebdad05d3139655d650b7d560c1041ddd2 |
| ecc7cbe | https://github.com/anchnk/node/commit/ecc7cbebdad05d3139655d650b7d560c1041ddd2 |
| nodejs#12972 | https://github.com/nodejs/node/pull/12972 |
| nodejs#12773 | https://github.com/nodejs/node/issues/12773 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 28, 2017
| https://github.com/nodejs/node/pull/12972#ref-pullrequest-219383958 |
|
8.0.0 Release Proposal
#12220
| https://github.com/nodejs/node/pull/12220 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Jun 15, 2017
| https://github.com/nodejs/node/pull/12972#ref-issue-235404028 |
|
Auditing for 6.11.1
nodejs/Release#230
| https://github.com/nodejs/Release/issues/230 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
backport-requested-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v6.x |
| Jun 22, 2017 | https://github.com/nodejs/node/pull/12972#event-1135316539 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jun 22, 2017 | https://github.com/nodejs/node/pull/12972#issuecomment-310470267 |
| Please reload this page | https://github.com/nodejs/node/pull/12972 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Jun 22, 2017
| https://github.com/nodejs/node/pull/12972#ref-pullrequest-237963284 |
|
(v6.x backport) test: make the rest of tests path-independent
#13880
| https://github.com/nodejs/node/pull/13880 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Jun 22, 2017 | https://github.com/nodejs/node/pull/12972#issuecomment-310492692 |
| @MylesBorins | https://github.com/MylesBorins |
| #13880 | https://github.com/nodejs/node/pull/13880 |
| Please reload this page | https://github.com/nodejs/node/pull/12972 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 10, 2017
| https://github.com/nodejs/node/pull/12972#ref-commit-43fcb8f |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/MylesBorins |
| test: make the rest of tests path-independent | https://github.com/nodejs/node/commit/43fcb8f65e2e9ba87e9f250af5f57d4cd313e9f8 |
| 43fcb8f | https://github.com/nodejs/node/commit/43fcb8f65e2e9ba87e9f250af5f57d4cd313e9f8 |
| #12972 | https://github.com/nodejs/node/pull/12972 |
| #12773 | https://github.com/nodejs/node/issues/12773 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 11, 2017
| https://github.com/nodejs/node/pull/12972#ref-commit-7419338 |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/MylesBorins |
| test: make the rest of tests path-independent | https://github.com/nodejs/node/commit/7419338b331c32ef15b3ad11e2d963b45857c6e7 |
| 7419338 | https://github.com/nodejs/node/commit/7419338b331c32ef15b3ad11e2d963b45857c6e7 |
| #12972 | https://github.com/nodejs/node/pull/12972 |
| #12773 | https://github.com/nodejs/node/issues/12773 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 18, 2017
| https://github.com/nodejs/node/pull/12972#ref-pullrequest-243856504 |
|
v6.11.2 proposal
#14356
| https://github.com/nodejs/node/pull/14356 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12972 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/12972/files/e2a0b26e04d6bb83c16268a11622a00e6e010dac |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/12972/files/5e73b3ec7ed7eec0da3b7947281dd130bd7779b9 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/12972 |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
|
| https://github.com/cjihrig |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |