| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a6cefee7-7341-05d4-314b-1d774da4d5e8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CBF0:2780A3:1313F19:1A433BE:696A921D |
| html-safe-nonce | 9961b24baf63fd5f4bcf92851b541da3ce2c160b50156b80db91f6acbc8ec2be |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQkYwOjI3ODBBMzoxMzEzRjE5OjFBNDMzQkU6Njk2QTkyMUQiLCJ2aXNpdG9yX2lkIjoiMjE3NDExNDY3MTc5Njg1MTIyOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 98dbffc24ce28ad590ee4835b57d5fecc244583868a811cae9cdca265da9ba8b |
| hovercard-subject-tag | pull_request:119798405 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/12944/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b5b394b16fc87cedca2934eb1f9933ef6795d2ded13eed213c1fffee485989f0/nodejs/node/pull/12944 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b5b394b16fc87cedca2934eb1f9933ef6795d2ded13eed213c1fffee485989f0/nodejs/node/pull/12944 |
| og:image:alt | Replaced common.PORT in the following test.
test-dgram-send-callback-buffer-length-empty-address.js
Ref: #12376
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation i... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | arturgvieira-zz |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 31496a13b80a2f6ad77d6c617ee2255a3545b539 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/12944#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12944 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12944 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/12944 |
| Reload | https://github.com/nodejs/node/pull/12944 |
| Reload | https://github.com/nodejs/node/pull/12944 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/12944 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/12944 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/12944#issue-comment-box |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
test: replace port in dgram cb address test
| https://github.com/nodejs/node/pull/12944#top |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
Conversation
7
| https://github.com/nodejs/node/pull/12944 |
|
Commits
1
| https://github.com/nodejs/node/pull/12944/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/12944/checks |
|
Files changed
| https://github.com/nodejs/node/pull/12944/files |
| Please reload this page | https://github.com/nodejs/node/pull/12944 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/arturgvieira-zz |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| May 10, 2017 | https://github.com/nodejs/node/pull/12944#issue-227560731 |
| Please reload this page | https://github.com/nodejs/node/pull/12944 |
| #12376 | https://github.com/nodejs/node/issues/12376 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/12944 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| May 10, 2017 | https://github.com/nodejs/node/pull/12944#event-1075725363 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
dgram
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adgram |
| May 10, 2017 | https://github.com/nodejs/node/pull/12944#event-1075732608 |
| https://github.com/arturgvieira-zz |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| May 10, 2017 | https://github.com/nodejs/node/pull/12944#event-1075815676 |
| https://github.com/arturgvieira-zz |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| May 10, 2017 | https://github.com/nodejs/node/pull/12944#event-1077338001 |
| https://github.com/arturgvieira-zz |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| May 11, 2017 | https://github.com/nodejs/node/pull/12944#event-1077621383 |
| https://github.com/arturgvieira-zz |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| May 11, 2017 05:52 | https://github.com/nodejs/node/pull/12944#event-1077621428 |
| https://github.com/arturgvieira-zz |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| May 11, 2017 05:55 | https://github.com/nodejs/node/pull/12944#event-1077623677 |
| https://github.com/arturgvieira-zz |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| May 11, 2017 | https://github.com/nodejs/node/pull/12944#event-1077623698 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| May 11, 2017 | https://github.com/nodejs/node/pull/12944#issuecomment-300750178 |
| #12929 | https://github.com/nodejs/node/pull/12929 |
| Please reload this page | https://github.com/nodejs/node/pull/12944 |
| https://github.com/arturgvieira-zz |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| May 11, 2017 | https://github.com/nodejs/node/pull/12944#event-1078751271 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
May 12, 2017
| https://github.com/nodejs/node/pull/12944#pullrequestreview-37752412 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12944/files |
| test/parallel/test-dgram-send-callback-buffer-length-empty-address.js | https://github.com/nodejs/node/pull/12944/files#diff-052d4e2d59631363c11657a554b57d0ef81b36788704aec9aa795c4d9c0ae8fd |
| lpinca | https://github.com/lpinca |
| May 12, 2017 | https://github.com/nodejs/node/pull/12944#discussion_r116151916 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12944 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
May 12, 2017
| https://github.com/nodejs/node/pull/12944#pullrequestreview-37752419 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12944/files |
| https://github.com/arturgvieira-zz |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| May 12, 2017 | https://github.com/nodejs/node/pull/12944#issuecomment-300983372 |
| Please reload this page | https://github.com/nodejs/node/pull/12944 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| May 12, 2017 | https://github.com/nodejs/node/pull/12944#issuecomment-301010174 |
| https://ci.nodejs.org/job/node-test-pull-request/8034/ | https://ci.nodejs.org/job/node-test-pull-request/8034/ |
| Please reload this page | https://github.com/nodejs/node/pull/12944 |
|
| https://github.com/vieiraarturg |
| test: replace port in dgram cb address test | https://github.com/nodejs/node/pull/12944/commits/3aa58f9ca089e9b5027f65cbd78aa9b9289070b1 |
| 3aa58f9 | https://github.com/nodejs/node/pull/12944/commits/3aa58f9ca089e9b5027f65cbd78aa9b9289070b1 |
| #12376 | https://github.com/nodejs/node/issues/12376 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| May 12, 2017 | https://github.com/nodejs/node/pull/12944#issuecomment-301018206 |
| https://ci.nodejs.org/job/node-test-pull-request/8039/ | https://ci.nodejs.org/job/node-test-pull-request/8039/ |
| Please reload this page | https://github.com/nodejs/node/pull/12944 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
May 12, 2017
| https://github.com/nodejs/node/pull/12944#pullrequestreview-37834798 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12944/files/3aa58f9ca089e9b5027f65cbd78aa9b9289070b1 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
May 12, 2017
| https://github.com/nodejs/node/pull/12944#pullrequestreview-37865117 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12944/files/3aa58f9ca089e9b5027f65cbd78aa9b9289070b1 |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/12944#pullrequestreview-37865117 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12944 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| May 22, 2017 | https://github.com/nodejs/node/pull/12944#issuecomment-303066484 |
| ad4765a | https://github.com/nodejs/node/commit/ad4765a32641277a91efb565e2056abaa6b6a70b |
| Please reload this page | https://github.com/nodejs/node/pull/12944 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| May 22, 2017 | https://github.com/nodejs/node/pull/12944#event-1091587223 |
| lpinca | https://github.com/lpinca |
|
May 22, 2017
| https://github.com/nodejs/node/pull/12944#ref-commit-ad4765a |
|
| https://github.com/vieiraarturg |
|
| https://github.com/lpinca |
| test: remove common.PORT from dgram test | https://github.com/nodejs/node/commit/ad4765a32641277a91efb565e2056abaa6b6a70b |
| ad4765a | https://github.com/nodejs/node/commit/ad4765a32641277a91efb565e2056abaa6b6a70b |
| #12944 | https://github.com/nodejs/node/pull/12944 |
| #12376 | https://github.com/nodejs/node/issues/12376 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
May 22, 2017
| https://github.com/nodejs/node/pull/12944#ref-issue-221404911 |
|
Remove common.PORT usage from parallel tests
#12376
| https://github.com/nodejs/node/issues/12376 |
| jasnell | https://github.com/jasnell |
|
May 23, 2017
| https://github.com/nodejs/node/pull/12944#ref-commit-d27c0cf |
|
| https://github.com/vieiraarturg |
|
| https://github.com/jasnell |
| test: remove common.PORT from dgram test | https://github.com/nodejs/node/commit/d27c0cf1867bffdc21c3f456ac7049155258cbd0 |
| d27c0cf | https://github.com/nodejs/node/commit/d27c0cf1867bffdc21c3f456ac7049155258cbd0 |
| #12944 | https://github.com/nodejs/node/pull/12944 |
| #12376 | https://github.com/nodejs/node/issues/12376 |
| jasnell | https://github.com/jasnell |
|
May 23, 2017
| https://github.com/nodejs/node/pull/12944#ref-commit-511ee24 |
|
| https://github.com/vieiraarturg |
|
| https://github.com/jasnell |
| test: remove common.PORT from dgram test | https://github.com/nodejs/node/commit/511ee24310532a90b297bb05bf07f3307ac7d5c5 |
| 511ee24 | https://github.com/nodejs/node/commit/511ee24310532a90b297bb05bf07f3307ac7d5c5 |
| #12944 | https://github.com/nodejs/node/pull/12944 |
| #12376 | https://github.com/nodejs/node/issues/12376 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 28, 2017
| https://github.com/nodejs/node/pull/12944#ref-pullrequest-219383958 |
|
8.0.0 Release Proposal
#12220
| https://github.com/nodejs/node/pull/12220 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Jun 15, 2017
| https://github.com/nodejs/node/pull/12944#ref-issue-235404028 |
|
Auditing for 6.11.1
nodejs/Release#230
| https://github.com/nodejs/Release/issues/230 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Jul 17, 2017 | https://github.com/nodejs/node/pull/12944#event-1166662417 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12944 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/12944/files/193715ec76b6b4f8afcdeb8d5b8dcbcd5245f108 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/12944/files/3aa58f9ca089e9b5027f65cbd78aa9b9289070b1 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/12944/files/3aa58f9ca089e9b5027f65cbd78aa9b9289070b1 |
|
dgram
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adgram |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/12944 |
|
| https://github.com/arturgvieira-zz |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/mhdawson |
|
| https://github.com/mscdex |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/vieiraarturg |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |