| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b893e3a2-624e-d9ed-72c0-3ed58c63d3c3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A6A0:9F9DA:112759D:17A833F:696A8E01 |
| html-safe-nonce | 77160816929b866149be29b34f4ab9d6235bd5c4d0d50ee2477ce7f450b310bd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNkEwOjlGOURBOjExMjc1OUQ6MTdBODMzRjo2OTZBOEUwMSIsInZpc2l0b3JfaWQiOiI2NDM2OTUzMTEyNzUxODAzOTA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 618ffba28c2b62ddb141ddbf37cca6c20ad00463e150488afebcd79b089d5a7d |
| hovercard-subject-tag | pull_request:119791969 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/12943/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1c43b9f1a44260f0eaa7475de5d4e16ff54900013fd0a368546f09ed8d8164b4/nodejs/node/pull/12943 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1c43b9f1a44260f0eaa7475de5d4e16ff54900013fd0a368546f09ed8d8164b4/nodejs/node/pull/12943 |
| og:image:alt | Replaced common.PORT in the following test.
test-dgram-send-callback-buffer-length.js
Ref: #12376
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or a... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | arturgvieira-zz |
| hostname | github.com |
| expected-hostname | github.com |
| None | d2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c1dbca8981c5e3d6a69bce2f1d289e732b86241d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/12943#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12943 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12943 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/12943 |
| Reload | https://github.com/nodejs/node/pull/12943 |
| Reload | https://github.com/nodejs/node/pull/12943 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/12943 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/12943 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/12943#issue-comment-box |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
test: replace port in dgram cb length test
| https://github.com/nodejs/node/pull/12943#top |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
Conversation
8
| https://github.com/nodejs/node/pull/12943 |
|
Commits
1
| https://github.com/nodejs/node/pull/12943/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/12943/checks |
|
Files changed
| https://github.com/nodejs/node/pull/12943/files |
| Please reload this page | https://github.com/nodejs/node/pull/12943 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/arturgvieira-zz |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| May 10, 2017 | https://github.com/nodejs/node/pull/12943#issue-227550992 |
| Please reload this page | https://github.com/nodejs/node/pull/12943 |
| #12376 | https://github.com/nodejs/node/issues/12376 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/12943 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| May 10, 2017 | https://github.com/nodejs/node/pull/12943#event-1075671465 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
dgram
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adgram |
| May 10, 2017 | https://github.com/nodejs/node/pull/12943#event-1075686397 |
| https://github.com/arturgvieira-zz |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| May 10, 2017 | https://github.com/nodejs/node/pull/12943#event-1075796082 |
| https://github.com/arturgvieira-zz |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| May 10, 2017 | https://github.com/nodejs/node/pull/12943#event-1075815155 |
| https://github.com/arturgvieira-zz |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| May 10, 2017 | https://github.com/nodejs/node/pull/12943#event-1077338376 |
| https://github.com/arturgvieira-zz |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| May 11, 2017 | https://github.com/nodejs/node/pull/12943#event-1077621674 |
| https://github.com/arturgvieira-zz |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| May 11, 2017 05:52 | https://github.com/nodejs/node/pull/12943#event-1077621721 |
| https://github.com/arturgvieira-zz |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| May 11, 2017 05:54 | https://github.com/nodejs/node/pull/12943#event-1077623502 |
| https://github.com/arturgvieira-zz |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| May 11, 2017 | https://github.com/nodejs/node/pull/12943#event-1077623526 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| May 11, 2017 | https://github.com/nodejs/node/pull/12943#issuecomment-300750008 |
| #12929 | https://github.com/nodejs/node/pull/12929 |
| Please reload this page | https://github.com/nodejs/node/pull/12943 |
| https://github.com/arturgvieira-zz |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| May 11, 2017 | https://github.com/nodejs/node/pull/12943#event-1078753176 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
May 12, 2017
| https://github.com/nodejs/node/pull/12943#pullrequestreview-37752369 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12943/files |
| test/parallel/test-dgram-send-callback-buffer-length.js | https://github.com/nodejs/node/pull/12943/files#diff-85cb0e8b12fe0f8b29909cdd32182f2b617140a9a739315c716accafb74d0148 |
| lpinca | https://github.com/lpinca |
| May 12, 2017 | https://github.com/nodejs/node/pull/12943#discussion_r116151884 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12943 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
May 12, 2017
| https://github.com/nodejs/node/pull/12943#pullrequestreview-37752371 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12943/files |
| https://github.com/arturgvieira-zz |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| May 12, 2017 | https://github.com/nodejs/node/pull/12943#issuecomment-300983342 |
| Please reload this page | https://github.com/nodejs/node/pull/12943 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| May 12, 2017 | https://github.com/nodejs/node/pull/12943#issuecomment-301009529 |
| https://ci.nodejs.org/job/node-test-pull-request/8032/ | https://ci.nodejs.org/job/node-test-pull-request/8032/ |
| Please reload this page | https://github.com/nodejs/node/pull/12943 |
| https://github.com/arturgvieira-zz |
| arturgvieira-zz | https://github.com/arturgvieira-zz |
| May 12, 2017 | https://github.com/nodejs/node/pull/12943#issuecomment-301010298 |
| Please reload this page | https://github.com/nodejs/node/pull/12943 |
|
| https://github.com/vieiraarturg |
| test: replace port in dgram cb length test | https://github.com/nodejs/node/pull/12943/commits/0a9a215e04867ad36203a8f8d41ebecc476e38f1 |
| 0a9a215 | https://github.com/nodejs/node/pull/12943/commits/0a9a215e04867ad36203a8f8d41ebecc476e38f1 |
| #12376 | https://github.com/nodejs/node/issues/12376 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| May 12, 2017 | https://github.com/nodejs/node/pull/12943#issuecomment-301017404 |
| Please reload this page | https://github.com/nodejs/node/pull/12943 |
| https://ci.nodejs.org/job/node-test-pull-request/8038/ | https://ci.nodejs.org/job/node-test-pull-request/8038/ |
| Please reload this page | https://github.com/nodejs/node/pull/12943 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
May 12, 2017
| https://github.com/nodejs/node/pull/12943#pullrequestreview-37836439 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12943/files/0a9a215e04867ad36203a8f8d41ebecc476e38f1 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
May 12, 2017
| https://github.com/nodejs/node/pull/12943#pullrequestreview-37864979 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12943/files/0a9a215e04867ad36203a8f8d41ebecc476e38f1 |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/12943#pullrequestreview-37864979 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12943 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| May 22, 2017 | https://github.com/nodejs/node/pull/12943#issuecomment-303062002 |
| dd3c227 | https://github.com/nodejs/node/commit/dd3c22779690d2f1449d7989c8173d59c650746a |
| Please reload this page | https://github.com/nodejs/node/pull/12943 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| May 22, 2017 | https://github.com/nodejs/node/pull/12943#event-1091556717 |
| lpinca | https://github.com/lpinca |
|
May 22, 2017
| https://github.com/nodejs/node/pull/12943#ref-commit-dd3c227 |
|
| https://github.com/vieiraarturg |
|
| https://github.com/lpinca |
| test: bind to 0 in dgram-send-callback-buffer-length | https://github.com/nodejs/node/commit/dd3c22779690d2f1449d7989c8173d59c650746a |
| dd3c227 | https://github.com/nodejs/node/commit/dd3c22779690d2f1449d7989c8173d59c650746a |
| #12943 | https://github.com/nodejs/node/pull/12943 |
| #12376 | https://github.com/nodejs/node/issues/12376 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
May 22, 2017
| https://github.com/nodejs/node/pull/12943#ref-issue-221404911 |
|
Remove common.PORT usage from parallel tests
#12376
| https://github.com/nodejs/node/issues/12376 |
| jasnell | https://github.com/jasnell |
|
May 23, 2017
| https://github.com/nodejs/node/pull/12943#ref-commit-d714861 |
|
| https://github.com/vieiraarturg |
|
| https://github.com/jasnell |
| test: bind to 0 in dgram-send-callback-buffer-length | https://github.com/nodejs/node/commit/d714861842f328c06d3b28a38b5bad422ca9e147 |
| d714861 | https://github.com/nodejs/node/commit/d714861842f328c06d3b28a38b5bad422ca9e147 |
| #12943 | https://github.com/nodejs/node/pull/12943 |
| #12376 | https://github.com/nodejs/node/issues/12376 |
| jasnell | https://github.com/jasnell |
|
May 23, 2017
| https://github.com/nodejs/node/pull/12943#ref-commit-8a4f3b7 |
|
| https://github.com/vieiraarturg |
|
| https://github.com/jasnell |
| test: bind to 0 in dgram-send-callback-buffer-length | https://github.com/nodejs/node/commit/8a4f3b7dfc59a4bcb759d9898fea6b9220f3ece2 |
| 8a4f3b7 | https://github.com/nodejs/node/commit/8a4f3b7dfc59a4bcb759d9898fea6b9220f3ece2 |
| #12943 | https://github.com/nodejs/node/pull/12943 |
| #12376 | https://github.com/nodejs/node/issues/12376 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 28, 2017
| https://github.com/nodejs/node/pull/12943#ref-pullrequest-219383958 |
|
8.0.0 Release Proposal
#12220
| https://github.com/nodejs/node/pull/12220 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Jun 15, 2017
| https://github.com/nodejs/node/pull/12943#ref-issue-235404028 |
|
Auditing for 6.11.1
nodejs/Release#230
| https://github.com/nodejs/Release/issues/230 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 17, 2017
| https://github.com/nodejs/node/pull/12943#ref-commit-1d35965 |
|
| https://github.com/vieiraarturg |
|
| https://github.com/MylesBorins |
| test: bind to 0 in dgram-send-callback-buffer-length | https://github.com/nodejs/node/commit/1d3596561b3fa326d86692ef20816345190eafe6 |
| 1d35965 | https://github.com/nodejs/node/commit/1d3596561b3fa326d86692ef20816345190eafe6 |
| #12943 | https://github.com/nodejs/node/pull/12943 |
| #12376 | https://github.com/nodejs/node/issues/12376 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x |
| Jul 17, 2017 | https://github.com/nodejs/node/pull/12943#event-1166659186 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 18, 2017
| https://github.com/nodejs/node/pull/12943#ref-pullrequest-243856504 |
|
v6.11.2 proposal
#14356
| https://github.com/nodejs/node/pull/14356 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12943 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/12943/files/cd0be1e9f9b203003cca438ed0fe2bc31d41cac2 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/12943/files/0a9a215e04867ad36203a8f8d41ebecc476e38f1 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/12943/files/0a9a215e04867ad36203a8f8d41ebecc476e38f1 |
|
dgram
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adgram |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/12943 |
|
| https://github.com/arturgvieira-zz |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/mhdawson |
|
| https://github.com/mscdex |
|
| https://github.com/MylesBorins |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/vieiraarturg |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |