| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a5a52fea-a7df-5bff-86da-e4b8c75e347d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 961E:D0E56:11A079D:187D600:696A91EA |
| html-safe-nonce | d9309f00e6a19e9d80ab415e2274a5759faa30e72e42f737b80618aa74cf254e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjFFOkQwRTU2OjExQTA3OUQ6MTg3RDYwMDo2OTZBOTFFQSIsInZpc2l0b3JfaWQiOiIyOTYxNTM1NjU3ODA5OTczNzM4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 77f4400f97e64213dc5782292d4f8e2e62d4a6bf1cbf2add457314bd4c4c62e0 |
| hovercard-subject-tag | pull_request:119736019 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/12930/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f082413cca9308058b852214e83f83e2184fa0257d6c762f22f4c3fb8340e0b4/nodejs/node/pull/12930 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f082413cca9308058b852214e83f83e2184fa0257d6c762f22f4c3fb8340e0b4/nodejs/node/pull/12930 |
| og:image:alt | Minor refactoring in a number of http tests. I've been going through an auditing the existing http tests to identify which we will need equivalents for on the http2 implementation and spotted a... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jasnell |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 31496a13b80a2f6ad77d6c617ee2255a3545b539 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/12930#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12930 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12930 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/12930 |
| Reload | https://github.com/nodejs/node/pull/12930 |
| Reload | https://github.com/nodejs/node/pull/12930 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/12930 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/12930 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/12930#issue-comment-box |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:improve-http-tests | https://github.com/jasnell/node/tree/improve-http-tests |
|
test: improve numerous http tests
| https://github.com/nodejs/node/pull/12930#top |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:improve-http-tests | https://github.com/jasnell/node/tree/improve-http-tests |
|
Conversation
13
| https://github.com/nodejs/node/pull/12930 |
|
Commits
1
| https://github.com/nodejs/node/pull/12930/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/12930/checks |
|
Files changed
| https://github.com/nodejs/node/pull/12930/files |
| Please reload this page | https://github.com/nodejs/node/pull/12930 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| May 9, 2017 | https://github.com/nodejs/node/pull/12930#issue-227474100 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/12930 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| May 9, 2017 | https://github.com/nodejs/node/pull/12930#event-1075231237 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/95e23cdbce2ea18cb67030e1920b41a50c24980d..2489dfededed77d1396aafa5969357ea581bce80 |
| 95e23cd | https://github.com/nodejs/node/commit/95e23cdbce2ea18cb67030e1920b41a50c24980d |
| 2489dfe | https://github.com/nodejs/node/commit/2489dfededed77d1396aafa5969357ea581bce80 |
|
Compare
| https://github.com/nodejs/node/compare/95e23cdbce2ea18cb67030e1920b41a50c24980d..2489dfededed77d1396aafa5969357ea581bce80 |
| May 9, 2017 19:36 | https://github.com/nodejs/node/pull/12930#event-1075231843 |
|
| https://github.com/jasnell |
| test: refactor http tests | https://github.com/nodejs/node/pull/12930/commits/b23ec7c097f51f0b40a4f110921894b82e3dc2cb |
| b23ec7c | https://github.com/nodejs/node/pull/12930/commits/b23ec7c097f51f0b40a4f110921894b82e3dc2cb |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/2489dfededed77d1396aafa5969357ea581bce80..b23ec7c097f51f0b40a4f110921894b82e3dc2cb |
| 2489dfe | https://github.com/nodejs/node/commit/2489dfededed77d1396aafa5969357ea581bce80 |
| b23ec7c | https://github.com/nodejs/node/commit/b23ec7c097f51f0b40a4f110921894b82e3dc2cb |
|
Compare
| https://github.com/nodejs/node/compare/2489dfededed77d1396aafa5969357ea581bce80..b23ec7c097f51f0b40a4f110921894b82e3dc2cb |
| May 9, 2017 19:39 | https://github.com/nodejs/node/pull/12930#event-1075236562 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
May 9, 2017
| https://github.com/nodejs/node/pull/12930#pullrequestreview-37133622 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12930/files |
| cjihrig | https://github.com/cjihrig |
| https://github.com/nodejs/node/pull/12930#pullrequestreview-37133622 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12930 |
| test/parallel/test-http-1.0.js | https://github.com/nodejs/node/pull/12930/files#diff-3d5a92d4c234ab249737f52aca841886a9c0f8d5acb53d6664b734fc6ccd764a |
| cjihrig | https://github.com/cjihrig |
| May 9, 2017 | https://github.com/nodejs/node/pull/12930#discussion_r115583050 |
| Please reload this page | https://github.com/nodejs/node/pull/12930 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12930 |
| jasnell | https://github.com/jasnell |
| May 9, 2017 | https://github.com/nodejs/node/pull/12930#discussion_r115599949 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12930 |
| refack | https://github.com/refack |
| May 9, 2017 | https://github.com/nodejs/node/pull/12930#discussion_r115601135 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12930 |
| cjihrig | https://github.com/cjihrig |
| May 9, 2017 | https://github.com/nodejs/node/pull/12930#discussion_r115601313 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12930 |
| refack | https://github.com/refack |
| May 9, 2017 | https://github.com/nodejs/node/pull/12930#discussion_r115609803 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @jasnell | https://github.com/jasnell |
| #12935 | https://github.com/nodejs/node/pull/12935 |
| Please reload this page | https://github.com/nodejs/node/pull/12930 |
| Trott | https://github.com/Trott |
| May 9, 2017 | https://github.com/nodejs/node/pull/12930#discussion_r115627578 |
| Please reload this page | https://github.com/nodejs/node/pull/12930 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12930 |
| lpinca | https://github.com/lpinca |
| May 10, 2017 | https://github.com/nodejs/node/pull/12930#discussion_r115703408 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/12930 |
| refack | https://github.com/refack |
| May 19, 2017 | https://github.com/nodejs/node/pull/12930#discussion_r117557783 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| fccc0bf | https://github.com/nodejs/node/commit/fccc0bf6e68981f6225315875524e1a0b56fcc20 |
| Please reload this page | https://github.com/nodejs/node/pull/12930 |
| test/parallel/test-http-abort-client.js | https://github.com/nodejs/node/pull/12930/files#diff-5ccf5fbb303881639b8fd07b20d7fe7f098fdb0ba0288b611e4767a94677d514 |
| cjihrig | https://github.com/cjihrig |
| May 9, 2017 | https://github.com/nodejs/node/pull/12930#discussion_r115583327 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12930 |
| Trott | https://github.com/Trott |
| May 9, 2017 | https://github.com/nodejs/node/pull/12930#discussion_r115628523 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12930 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
May 9, 2017
| https://github.com/nodejs/node/pull/12930#pullrequestreview-37152504 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12930/files/b23ec7c097f51f0b40a4f110921894b82e3dc2cb |
| test/parallel/test-http-1.0-keep-alive.js | https://github.com/nodejs/node/pull/12930/files/b23ec7c097f51f0b40a4f110921894b82e3dc2cb#diff-5c908be8d683d6d65a7677739bb184d9981e19e0edc9126c45457af7a13b5892 |
| refack | https://github.com/refack |
| May 9, 2017 | https://github.com/nodejs/node/pull/12930#discussion_r115599958 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12930 |
| test/parallel/test-http-1.0.js | https://github.com/nodejs/node/pull/12930/files#diff-3d5a92d4c234ab249737f52aca841886a9c0f8d5acb53d6664b734fc6ccd764a |
| refack | https://github.com/refack |
| May 9, 2017 | https://github.com/nodejs/node/pull/12930#discussion_r115601135 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12930 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
May 9, 2017
| https://github.com/nodejs/node/pull/12930#ref-pullrequest-227502678 |
|
test: added common.mustCallAtLeast
#12935
| https://github.com/nodejs/node/pull/12935 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
| May 9, 2017 | https://github.com/nodejs/node/pull/12930#event-1075481703 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jul 24, 2017 | https://github.com/nodejs/node/pull/12930#issuecomment-317476596 |
| #14315 | https://github.com/nodejs/node/pull/14315 |
| Please reload this page | https://github.com/nodejs/node/pull/12930 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jul 24, 2017 | https://github.com/nodejs/node/pull/12930#event-1176450682 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12930 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/12930/files/b23ec7c097f51f0b40a4f110921894b82e3dc2cb |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/12930/files/b23ec7c097f51f0b40a4f110921894b82e3dc2cb |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/12930/files/2489dfededed77d1396aafa5969357ea581bce80 |
|
| https://github.com/refack |
|
refack
| https://github.com/refack |
|
| https://github.com/nodejs/node/pull/12930/files/2489dfededed77d1396aafa5969357ea581bce80 |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/12930 |
|
| https://github.com/jasnell |
|
| https://github.com/refack |
|
| https://github.com/Trott |
|
| https://github.com/lpinca |
|
| https://github.com/cjihrig |
|
| https://github.com/mscdex |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |