René's URL Explorer Experiment


Title: test: improve numerous http tests by jasnell · Pull Request #12930 · nodejs/node · GitHub

Open Graph Title: test: improve numerous http tests by jasnell · Pull Request #12930 · nodejs/node

X Title: test: improve numerous http tests by jasnell · Pull Request #12930 · nodejs/node

Description: Minor refactoring in a number of http tests. I've been going through an auditing the existing http tests to identify which we will need equivalents for on the http2 implementation and spotted a num...

Open Graph Description: Minor refactoring in a number of http tests. I've been going through an auditing the existing http tests to identify which we will need equivalents for on the http2 implementation and spotted a...

X Description: Minor refactoring in a number of http tests. I've been going through an auditing the existing http tests to identify which we will need equivalents for on the http2 implementation and spott...

Opengraph URL: https://github.com/nodejs/node/pull/12930

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a5a52fea-a7df-5bff-86da-e4b8c75e347d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id961E:D0E56:11A079D:187D600:696A91EA
html-safe-nonced9309f00e6a19e9d80ab415e2274a5759faa30e72e42f737b80618aa74cf254e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjFFOkQwRTU2OjExQTA3OUQ6MTg3RDYwMDo2OTZBOTFFQSIsInZpc2l0b3JfaWQiOiIyOTYxNTM1NjU3ODA5OTczNzM4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac77f4400f97e64213dc5782292d4f8e2e62d4a6bf1cbf2add457314bd4c4c62e0
hovercard-subject-tagpull_request:119736019
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/12930/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f082413cca9308058b852214e83f83e2184fa0257d6c762f22f4c3fb8340e0b4/nodejs/node/pull/12930
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f082413cca9308058b852214e83f83e2184fa0257d6c762f22f4c3fb8340e0b4/nodejs/node/pull/12930
og:image:altMinor refactoring in a number of http tests. I've been going through an auditing the existing http tests to identify which we will need equivalents for on the http2 implementation and spotted a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/12930#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12930
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12930
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/12930
Reloadhttps://github.com/nodejs/node/pull/12930
Reloadhttps://github.com/nodejs/node/pull/12930
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/12930
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/12930
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/12930#issue-comment-box
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:improve-http-testshttps://github.com/jasnell/node/tree/improve-http-tests
test: improve numerous http tests https://github.com/nodejs/node/pull/12930#top
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:improve-http-testshttps://github.com/jasnell/node/tree/improve-http-tests
Conversation 13 https://github.com/nodejs/node/pull/12930
Commits 1 https://github.com/nodejs/node/pull/12930/commits
Checks 0 https://github.com/nodejs/node/pull/12930/checks
Files changed https://github.com/nodejs/node/pull/12930/files
Please reload this pagehttps://github.com/nodejs/node/pull/12930
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 9, 2017https://github.com/nodejs/node/pull/12930#issue-227474100
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/12930
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
May 9, 2017https://github.com/nodejs/node/pull/12930#event-1075231237
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/95e23cdbce2ea18cb67030e1920b41a50c24980d..2489dfededed77d1396aafa5969357ea581bce80
95e23cdhttps://github.com/nodejs/node/commit/95e23cdbce2ea18cb67030e1920b41a50c24980d
2489dfehttps://github.com/nodejs/node/commit/2489dfededed77d1396aafa5969357ea581bce80
Compare https://github.com/nodejs/node/compare/95e23cdbce2ea18cb67030e1920b41a50c24980d..2489dfededed77d1396aafa5969357ea581bce80
May 9, 2017 19:36https://github.com/nodejs/node/pull/12930#event-1075231843
https://github.com/jasnell
test: refactor http testshttps://github.com/nodejs/node/pull/12930/commits/b23ec7c097f51f0b40a4f110921894b82e3dc2cb
b23ec7chttps://github.com/nodejs/node/pull/12930/commits/b23ec7c097f51f0b40a4f110921894b82e3dc2cb
https://github.com/jasnell
jasnellhttps://github.com/jasnell
force-pushedhttps://github.com/nodejs/node/compare/2489dfededed77d1396aafa5969357ea581bce80..b23ec7c097f51f0b40a4f110921894b82e3dc2cb
2489dfehttps://github.com/nodejs/node/commit/2489dfededed77d1396aafa5969357ea581bce80
b23ec7chttps://github.com/nodejs/node/commit/b23ec7c097f51f0b40a4f110921894b82e3dc2cb
Compare https://github.com/nodejs/node/compare/2489dfededed77d1396aafa5969357ea581bce80..b23ec7c097f51f0b40a4f110921894b82e3dc2cb
May 9, 2017 19:39https://github.com/nodejs/node/pull/12930#event-1075236562
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 9, 2017 https://github.com/nodejs/node/pull/12930#pullrequestreview-37133622
View reviewed changes https://github.com/nodejs/node/pull/12930/files
cjihrighttps://github.com/cjihrig
https://github.com/nodejs/node/pull/12930#pullrequestreview-37133622
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/12930
test/parallel/test-http-1.0.jshttps://github.com/nodejs/node/pull/12930/files#diff-3d5a92d4c234ab249737f52aca841886a9c0f8d5acb53d6664b734fc6ccd764a
cjihrighttps://github.com/cjihrig
May 9, 2017https://github.com/nodejs/node/pull/12930#discussion_r115583050
Please reload this pagehttps://github.com/nodejs/node/pull/12930
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/12930
jasnellhttps://github.com/jasnell
May 9, 2017https://github.com/nodejs/node/pull/12930#discussion_r115599949
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/12930
refackhttps://github.com/refack
May 9, 2017https://github.com/nodejs/node/pull/12930#discussion_r115601135
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/12930
cjihrighttps://github.com/cjihrig
May 9, 2017https://github.com/nodejs/node/pull/12930#discussion_r115601313
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/12930
refackhttps://github.com/refack
May 9, 2017https://github.com/nodejs/node/pull/12930#discussion_r115609803
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@jasnellhttps://github.com/jasnell
#12935https://github.com/nodejs/node/pull/12935
Please reload this pagehttps://github.com/nodejs/node/pull/12930
Trotthttps://github.com/Trott
May 9, 2017https://github.com/nodejs/node/pull/12930#discussion_r115627578
Please reload this pagehttps://github.com/nodejs/node/pull/12930
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/12930
lpincahttps://github.com/lpinca
May 10, 2017https://github.com/nodejs/node/pull/12930#discussion_r115703408
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/12930
refackhttps://github.com/refack
May 19, 2017https://github.com/nodejs/node/pull/12930#discussion_r117557783
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
fccc0bfhttps://github.com/nodejs/node/commit/fccc0bf6e68981f6225315875524e1a0b56fcc20
Please reload this pagehttps://github.com/nodejs/node/pull/12930
test/parallel/test-http-abort-client.jshttps://github.com/nodejs/node/pull/12930/files#diff-5ccf5fbb303881639b8fd07b20d7fe7f098fdb0ba0288b611e4767a94677d514
cjihrighttps://github.com/cjihrig
May 9, 2017https://github.com/nodejs/node/pull/12930#discussion_r115583327
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/12930
Trotthttps://github.com/Trott
May 9, 2017https://github.com/nodejs/node/pull/12930#discussion_r115628523
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/12930
https://github.com/refack
refackhttps://github.com/refack
May 9, 2017 https://github.com/nodejs/node/pull/12930#pullrequestreview-37152504
View reviewed changes https://github.com/nodejs/node/pull/12930/files/b23ec7c097f51f0b40a4f110921894b82e3dc2cb
test/parallel/test-http-1.0-keep-alive.jshttps://github.com/nodejs/node/pull/12930/files/b23ec7c097f51f0b40a4f110921894b82e3dc2cb#diff-5c908be8d683d6d65a7677739bb184d9981e19e0edc9126c45457af7a13b5892
refackhttps://github.com/refack
May 9, 2017https://github.com/nodejs/node/pull/12930#discussion_r115599958
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/12930
test/parallel/test-http-1.0.jshttps://github.com/nodejs/node/pull/12930/files#diff-3d5a92d4c234ab249737f52aca841886a9c0f8d5acb53d6664b734fc6ccd764a
refackhttps://github.com/refack
May 9, 2017https://github.com/nodejs/node/pull/12930#discussion_r115601135
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/12930
https://github.com/refack
refackhttps://github.com/refack
May 9, 2017 https://github.com/nodejs/node/pull/12930#ref-pullrequest-227502678
test: added common.mustCallAtLeast #12935 https://github.com/nodejs/node/pull/12935
https://github.com/mscdex
mscdexhttps://github.com/mscdex
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
May 9, 2017https://github.com/nodejs/node/pull/12930#event-1075481703
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 24, 2017https://github.com/nodejs/node/pull/12930#issuecomment-317476596
#14315https://github.com/nodejs/node/pull/14315
Please reload this pagehttps://github.com/nodejs/node/pull/12930
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 24, 2017https://github.com/nodejs/node/pull/12930#event-1176450682
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12930
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/12930/files/b23ec7c097f51f0b40a4f110921894b82e3dc2cb
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/12930/files/b23ec7c097f51f0b40a4f110921894b82e3dc2cb
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/12930/files/2489dfededed77d1396aafa5969357ea581bce80
https://github.com/refack
refack https://github.com/refack
https://github.com/nodejs/node/pull/12930/files/2489dfededed77d1396aafa5969357ea581bce80
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/12930
https://github.com/jasnell
https://github.com/refack
https://github.com/Trott
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/mscdex
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.