| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:10d0a1ca-4e2e-6b90-a09a-3a163c194c59 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9F5A:290BB0:31862:443E7:696A378D |
| html-safe-nonce | 9af06ee1b45262b91a84c138fb70054e1ad352d5d5aa89b05cb5b73d0daf819e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjVBOjI5MEJCMDozMTg2Mjo0NDNFNzo2OTZBMzc4RCIsInZpc2l0b3JfaWQiOiI1ODg0Mzg2ODQ4MzU4OTM4NTA5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ff0b19763d032683a53dc23d2a82851db3c5e27ed31c7223d482af68230ce232 |
| hovercard-subject-tag | pull_request:119525548 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/12906/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/641832d69130ff3c77643309fe2cb91a1acb77533f4e2c78f68f815fb4aae935/nodejs/node/pull/12906 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/641832d69130ff3c77643309fe2cb91a1acb77533f4e2c78f68f815fb4aae935/nodejs/node/pull/12906 |
| og:image:alt | AssertionError class is moved to internal/error
in reference to the TODO in assert.js. This was
suggested to get rid of the cyclic dependency
between assert.js and internal/error.js
Checklist
ma... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | fhalde |
| hostname | github.com |
| expected-hostname | github.com |
| None | 321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7a9163cefd1ea4bd06f8eb7c082f43e4e53f626f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/12906#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12906 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12906 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/12906 |
| Reload | https://github.com/nodejs/node/pull/12906 |
| Reload | https://github.com/nodejs/node/pull/12906 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/12906#issue-comment-box |
| fhalde | https://github.com/fhalde |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| fhalde:improv | https://github.com/fhalde/node/tree/improv |
|
lib: AssertionError moved to internal/error
| https://github.com/nodejs/node/pull/12906#top |
| fhalde | https://github.com/fhalde |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| fhalde:improv | https://github.com/fhalde/node/tree/improv |
|
Conversation
21
| https://github.com/nodejs/node/pull/12906 |
|
Commits
2
| https://github.com/nodejs/node/pull/12906/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/12906/checks |
|
Files changed
| https://github.com/nodejs/node/pull/12906/files |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/fhalde |
| fhalde | https://github.com/fhalde |
| May 8, 2017 | https://github.com/nodejs/node/pull/12906#issue-227160954 |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
assert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
| May 8, 2017 | https://github.com/nodejs/node/pull/12906#event-1073461054 |
| https://github.com/fhalde |
| fhalde | https://github.com/fhalde |
| force-pushed | https://github.com/nodejs/node/compare/697f67160337f38cc5273ee217ccbd6de8a3f1f9..7efc70e53a76b9e56657a7e17989a02480660d58 |
| 697f671 | https://github.com/nodejs/node/commit/697f67160337f38cc5273ee217ccbd6de8a3f1f9 |
| 7efc70e | https://github.com/nodejs/node/commit/7efc70e53a76b9e56657a7e17989a02480660d58 |
|
Compare
| https://github.com/nodejs/node/compare/697f67160337f38cc5273ee217ccbd6de8a3f1f9..7efc70e53a76b9e56657a7e17989a02480660d58 |
| May 8, 2017 20:17 | https://github.com/nodejs/node/pull/12906#event-1073465019 |
| https://github.com/fhalde |
| fhalde | https://github.com/fhalde |
| May 8, 2017 | https://github.com/nodejs/node/pull/12906#issuecomment-299978977 |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| https://github.com/watilde |
| watilde | https://github.com/watilde |
|
May 8, 2017
| https://github.com/nodejs/node/pull/12906#pullrequestreview-36896137 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12906/files |
| lib/internal/errors.js | https://github.com/nodejs/node/pull/12906/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c |
| watilde | https://github.com/watilde |
| May 8, 2017 | https://github.com/nodejs/node/pull/12906#discussion_r115363289 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| https://github.com/fhalde |
| fhalde | https://github.com/fhalde |
| force-pushed | https://github.com/nodejs/node/compare/7efc70e53a76b9e56657a7e17989a02480660d58..c68cab444dccee796f7cbb8c342a4f4cbf957897 |
| 7efc70e | https://github.com/nodejs/node/commit/7efc70e53a76b9e56657a7e17989a02480660d58 |
| c68cab4 | https://github.com/nodejs/node/commit/c68cab444dccee796f7cbb8c342a4f4cbf957897 |
|
Compare
| https://github.com/nodejs/node/compare/7efc70e53a76b9e56657a7e17989a02480660d58..c68cab444dccee796f7cbb8c342a4f4cbf957897 |
| May 9, 2017 06:38 | https://github.com/nodejs/node/pull/12906#event-1074017199 |
| https://github.com/hiroppy |
| hiroppy | https://github.com/hiroppy |
|
May 9, 2017
| https://github.com/nodejs/node/pull/12906#pullrequestreview-37009294 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12906/files |
| lib/internal/errors.js | https://github.com/nodejs/node/pull/12906/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c |
| hiroppy | https://github.com/hiroppy |
| May 9, 2017 | https://github.com/nodejs/node/pull/12906#discussion_r115470542 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| https://github.com/fhalde |
| fhalde | https://github.com/fhalde |
| force-pushed | https://github.com/nodejs/node/compare/c68cab444dccee796f7cbb8c342a4f4cbf957897..707aea97cfa59756fefa58dab3347fc3a065bd51 |
| c68cab4 | https://github.com/nodejs/node/commit/c68cab444dccee796f7cbb8c342a4f4cbf957897 |
| 707aea9 | https://github.com/nodejs/node/commit/707aea97cfa59756fefa58dab3347fc3a065bd51 |
|
Compare
| https://github.com/nodejs/node/compare/c68cab444dccee796f7cbb8c342a4f4cbf957897..707aea97cfa59756fefa58dab3347fc3a065bd51 |
| May 9, 2017 17:16 | https://github.com/nodejs/node/pull/12906#event-1075003390 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 9, 2017
| https://github.com/nodejs/node/pull/12906#pullrequestreview-37140964 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12906/files |
| lib/internal/errors.js | https://github.com/nodejs/node/pull/12906/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c |
| jasnell | https://github.com/jasnell |
| May 9, 2017 | https://github.com/nodejs/node/pull/12906#discussion_r115589714 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| fhalde | https://github.com/fhalde |
| May 10, 2017 | https://github.com/nodejs/node/pull/12906#discussion_r115663551 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| fhalde | https://github.com/fhalde |
| May 10, 2017 | https://github.com/nodejs/node/pull/12906#discussion_r115663615 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| https://github.com/fhalde |
| fhalde | https://github.com/fhalde |
| force-pushed | https://github.com/nodejs/node/compare/707aea97cfa59756fefa58dab3347fc3a065bd51..f3f1a86094fcfa50b3e00aa888b088bccf0fef1e |
| 707aea9 | https://github.com/nodejs/node/commit/707aea97cfa59756fefa58dab3347fc3a065bd51 |
| f3f1a86 | https://github.com/nodejs/node/commit/f3f1a86094fcfa50b3e00aa888b088bccf0fef1e |
|
Compare
| https://github.com/nodejs/node/compare/707aea97cfa59756fefa58dab3347fc3a065bd51..f3f1a86094fcfa50b3e00aa888b088bccf0fef1e |
| May 10, 2017 06:18 | https://github.com/nodejs/node/pull/12906#event-1075820700 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 10, 2017
| https://github.com/nodejs/node/pull/12906#pullrequestreview-37403385 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12906/files |
| lib/internal/errors.js | https://github.com/nodejs/node/pull/12906/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c |
| jasnell | https://github.com/jasnell |
| May 10, 2017 | https://github.com/nodejs/node/pull/12906#discussion_r115829834 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| fhalde | https://github.com/fhalde |
| May 10, 2017 | https://github.com/nodejs/node/pull/12906#discussion_r115832251 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| jasnell | https://github.com/jasnell |
| May 10, 2017 | https://github.com/nodejs/node/pull/12906#discussion_r115832905 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 10, 2017
| https://github.com/nodejs/node/pull/12906#pullrequestreview-37403559 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12906/files |
| lib/internal/errors.js | https://github.com/nodejs/node/pull/12906/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c |
| jasnell | https://github.com/jasnell |
| May 10, 2017 | https://github.com/nodejs/node/pull/12906#discussion_r115829998 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
|
| https://github.com/fhalde |
| lib: AssertionError moved to internal/error | https://github.com/nodejs/node/pull/12906/commits/cd70341bcb6f32ab643a76b9bf0ba3b5162a5d73 |
| cd70341 | https://github.com/nodejs/node/pull/12906/commits/cd70341bcb6f32ab643a76b9bf0ba3b5162a5d73 |
| https://github.com/fhalde |
| fhalde | https://github.com/fhalde |
| force-pushed | https://github.com/nodejs/node/compare/f3f1a86094fcfa50b3e00aa888b088bccf0fef1e..cd70341bcb6f32ab643a76b9bf0ba3b5162a5d73 |
| f3f1a86 | https://github.com/nodejs/node/commit/f3f1a86094fcfa50b3e00aa888b088bccf0fef1e |
| cd70341 | https://github.com/nodejs/node/commit/cd70341bcb6f32ab643a76b9bf0ba3b5162a5d73 |
|
Compare
| https://github.com/nodejs/node/compare/f3f1a86094fcfa50b3e00aa888b088bccf0fef1e..cd70341bcb6f32ab643a76b9bf0ba3b5162a5d73 |
| May 10, 2017 19:53 | https://github.com/nodejs/node/pull/12906#event-1077086708 |
| https://github.com/fhalde |
| fhalde | https://github.com/fhalde |
| May 10, 2017 | https://github.com/nodejs/node/pull/12906#issuecomment-300594423 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| May 11, 2017 | https://github.com/nodejs/node/pull/12906#issuecomment-300650869 |
| https://ci.nodejs.org/job/node-test-pull-request/8002/ | https://ci.nodejs.org/job/node-test-pull-request/8002/ |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| https://github.com/fhalde |
| fhalde | https://github.com/fhalde |
| May 11, 2017 | https://github.com/nodejs/node/pull/12906#issuecomment-300721858 |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 19, 2017 | https://github.com/nodejs/node/pull/12906#issuecomment-302817866 |
| @fhalde | https://github.com/fhalde |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
|
| https://github.com/fhalde |
| error message changed in error_exit.out | https://github.com/nodejs/node/pull/12906/commits/a9bd3f10a44104d72fe4b9294bb069c735feb160 |
| a9bd3f1 | https://github.com/nodejs/node/pull/12906/commits/a9bd3f10a44104d72fe4b9294bb069c735feb160 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
May 22, 2017
| https://github.com/nodejs/node/pull/12906#pullrequestreview-39442319 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12906/files/a9bd3f10a44104d72fe4b9294bb069c735feb160 |
| lib/assert.js | https://github.com/nodejs/node/pull/12906/files/a9bd3f10a44104d72fe4b9294bb069c735feb160#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f |
| thefourtheye | https://github.com/thefourtheye |
| May 22, 2017 | https://github.com/nodejs/node/pull/12906#discussion_r117714807 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| fhalde | https://github.com/fhalde |
| May 22, 2017 | https://github.com/nodejs/node/pull/12906#discussion_r117727554 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
| May 22, 2017 | https://github.com/nodejs/node/pull/12906#issuecomment-303065142 |
| https://ci.nodejs.org/job/node-test-pull-request/8224/ | https://ci.nodejs.org/job/node-test-pull-request/8224/ |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 22, 2017
| https://github.com/nodejs/node/pull/12906#pullrequestreview-39494233 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12906/files/a9bd3f10a44104d72fe4b9294bb069c735feb160 |
| https://github.com/fhalde |
| fhalde | https://github.com/fhalde |
| May 23, 2017 | https://github.com/nodejs/node/pull/12906#issuecomment-303378493 |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| May 23, 2017 | https://github.com/nodejs/node/pull/12906#issuecomment-303419902 |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| jasnell | https://github.com/jasnell |
|
May 23, 2017
| https://github.com/nodejs/node/pull/12906#ref-commit-425aba4 |
|
| https://github.com/fhalde |
|
| https://github.com/jasnell |
| errors: AssertionError moved to internal/error | https://github.com/nodejs/node/commit/425aba4f3630ca06e08c55a14de3e7a553e3c34d |
| 425aba4 | https://github.com/nodejs/node/commit/425aba4f3630ca06e08c55a14de3e7a553e3c34d |
| #12906 | https://github.com/nodejs/node/pull/12906 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| May 23, 2017 | https://github.com/nodejs/node/pull/12906#issuecomment-303429913 |
| 425aba4 | https://github.com/nodejs/node/commit/425aba4f3630ca06e08c55a14de3e7a553e3c34d |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| May 23, 2017 | https://github.com/nodejs/node/pull/12906#event-1093879631 |
| jasnell | https://github.com/jasnell |
|
May 23, 2017
| https://github.com/nodejs/node/pull/12906#ref-commit-8c87498 |
|
| https://github.com/fhalde |
|
| https://github.com/jasnell |
| errors: AssertionError moved to internal/error | https://github.com/nodejs/node/commit/8c8749814f102eba7d01f267c547bcc685b92a99 |
| 8c87498 | https://github.com/nodejs/node/commit/8c8749814f102eba7d01f267c547bcc685b92a99 |
| #12906 | https://github.com/nodejs/node/pull/12906 |
| jasnell | https://github.com/jasnell |
|
May 23, 2017
| https://github.com/nodejs/node/pull/12906#ref-commit-d250e3d |
|
| https://github.com/fhalde |
|
| https://github.com/jasnell |
| errors: AssertionError moved to internal/error | https://github.com/nodejs/node/commit/d250e3d8390c85d2fd2b068230c4c534df045de9 |
| d250e3d | https://github.com/nodejs/node/commit/d250e3d8390c85d2fd2b068230c4c534df045de9 |
| #12906 | https://github.com/nodejs/node/pull/12906 |
| jasnell | https://github.com/jasnell |
|
May 28, 2017
| https://github.com/nodejs/node/pull/12906#ref-commit-50af2b9 |
|
| https://github.com/fhalde |
|
| https://github.com/jasnell |
| errors: AssertionError moved to internal/error | https://github.com/nodejs/node/commit/50af2b95e0904012d53fa972ba3228bf0e085400 |
| 50af2b9 | https://github.com/nodejs/node/commit/50af2b95e0904012d53fa972ba3228bf0e085400 |
| #12906 | https://github.com/nodejs/node/pull/12906 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 28, 2017
| https://github.com/nodejs/node/pull/12906#ref-pullrequest-219383958 |
|
8.0.0 Release Proposal
#12220
| https://github.com/nodejs/node/pull/12220 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Jun 15, 2017
| https://github.com/nodejs/node/pull/12906#ref-issue-235404028 |
|
Auditing for 6.11.1
nodejs/Release#230
| https://github.com/nodejs/Release/issues/230 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x |
| Jul 17, 2017 | https://github.com/nodejs/node/pull/12906#event-1166682097 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jul 17, 2017 | https://github.com/nodejs/node/pull/12906#issuecomment-315792287 |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12906 |
|
| https://github.com/watilde |
|
watilde
| https://github.com/watilde |
|
| https://github.com/nodejs/node/pull/12906/files/7efc70e53a76b9e56657a7e17989a02480660d58 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/12906/files/a9bd3f10a44104d72fe4b9294bb069c735feb160 |
|
| https://github.com/thefourtheye |
|
thefourtheye
| https://github.com/thefourtheye |
|
| https://github.com/nodejs/node/pull/12906/files/a9bd3f10a44104d72fe4b9294bb069c735feb160 |
|
| https://github.com/hiroppy |
|
hiroppy
| https://github.com/hiroppy |
|
| https://github.com/nodejs/node/pull/12906/files/c68cab444dccee796f7cbb8c342a4f4cbf957897 |
|
assert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
| Please reload this page | https://github.com/nodejs/node/pull/12906 |
|
| https://github.com/fhalde |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/thefourtheye |
|
| https://github.com/MylesBorins |
|
| https://github.com/watilde |
|
| https://github.com/hiroppy |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |