René's URL Explorer Experiment


Title: timers: make Timer.close idempotent by petkaantonov · Pull Request #1288 · nodejs/node · GitHub

Open Graph Title: timers: make Timer.close idempotent by petkaantonov · Pull Request #1288 · nodejs/node

X Title: timers: make Timer.close idempotent by petkaantonov · Pull Request #1288 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: fixes #1287 R=@bnoordhuis ?

X Description: fixes #1287 R=@bnoordhuis ?

Opengraph URL: https://github.com/nodejs/node/pull/1288

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1406dfd9-0d65-7014-a966-e40eb7c94f37
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB668:3BD8F2:18DD610:223C9FE:6A4F25A5
html-safe-noncec24afcb2ce4f004638925b8b9c0c9160590f1fff60d763df031484b9880f2b15
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjY4OjNCRDhGMjoxOERENjEwOjIyM0M5RkU6NkE0RjI1QTUiLCJ2aXNpdG9yX2lkIjoiNjM0OTIzOTM1MzYxNzYyMjQzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7ea8b85ba51499582c38be50e9e63315b0c298b2c948bb8d46bee35e66e75778
hovercard-subject-tagpull_request:32134212
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1288/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/41cb5c2884392076ceaa7c061e3b45d58f538edabb560693df2d14fc703924a1/nodejs/node/pull/1288
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/41cb5c2884392076ceaa7c061e3b45d58f538edabb560693df2d14fc703924a1/nodejs/node/pull/1288
og:image:altfixes #1287 R=@bnoordhuis ?
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepetkaantonov
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/1288#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1288
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1288
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/1288
Reloadhttps://github.com/nodejs/node/pull/1288
Reloadhttps://github.com/nodejs/node/pull/1288
Please reload this pagehttps://github.com/nodejs/node/pull/1288
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/1288
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 969 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
petkaantonovhttps://github.com/petkaantonov
nodejs:v1.xhttps://github.com/nodejs/node/tree/v1.x
petkaantonov:make-timer-close-idempotenthttps://github.com/petkaantonov/io.js/tree/make-timer-close-idempotent
Conversationhttps://github.com/nodejs/node/pull/1288
Commits1 (1)https://github.com/nodejs/node/pull/1288/commits
Checkshttps://github.com/nodejs/node/pull/1288/checks
Files changedhttps://github.com/nodejs/node/pull/1288/files
timers: make Timer.close idempotenthttps://github.com/nodejs/node/pull/1288#top
petkaantonovhttps://github.com/petkaantonov
nodejs:v1.xhttps://github.com/nodejs/node/tree/v1.x
petkaantonov:make-timer-close-idempotenthttps://github.com/petkaantonov/io.js/tree/make-timer-close-idempotent
https://github.com/petkaantonov
petkaantonovhttps://github.com/petkaantonov
Mar 27, 2015https://github.com/nodejs/node/pull/1288#issue-64827279
#1287https://github.com/nodejs/node/issues/1287
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/1288
bnoordhuishttps://github.com/bnoordhuis
Mar 27, 2015 https://github.com/nodejs/node/pull/1288#discussion-diff-27320948
View reviewed changes https://github.com/nodejs/node/pull/1288/files#diff-38700b47119f02907da7f03a341bf5dfe59727ef698b78246872888071102cf2
test/parallel/test-timer-close.jshttps://github.com/nodejs/node/pull/1288/files#diff-38700b47119f02907da7f03a341bf5dfe59727ef698b78246872888071102cf2
bnoordhuishttps://github.com/bnoordhuis
Mar 27, 2015https://github.com/nodejs/node/pull/1288#discussion_r27320948
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1288
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Mar 27, 2015https://github.com/nodejs/node/pull/1288#issuecomment-87050282
Please reload this pagehttps://github.com/nodejs/node/pull/1288
https://github.com/petkaantonov
timers: make Timer.close idempotenthttps://github.com/nodejs/node/pull/1288/commits/f1dbd36db04eb5ce6c7245dcc4504f4887df4ed8
f1dbd36https://github.com/nodejs/node/pull/1288/commits/f1dbd36db04eb5ce6c7245dcc4504f4887df4ed8
nodejs#1287https://github.com/nodejs/node/issues/1287
https://github.com/petkaantonov
petkaantonovhttps://github.com/petkaantonov
force-pushedhttps://github.com/nodejs/node/compare/3bfb72f3639f389c9190196b8e857a75e5f6269d..f1dbd36db04eb5ce6c7245dcc4504f4887df4ed8
3bfb72fhttps://github.com/nodejs/node/commit/3bfb72f3639f389c9190196b8e857a75e5f6269d
f1dbd36https://github.com/nodejs/node/commit/f1dbd36db04eb5ce6c7245dcc4504f4887df4ed8
Compare https://github.com/nodejs/node/compare/3bfb72f3639f389c9190196b8e857a75e5f6269d..f1dbd36db04eb5ce6c7245dcc4504f4887df4ed8
March 27, 2015 18:48https://github.com/nodejs/node/pull/1288#event-267178820
https://github.com/petkaantonov
petkaantonovhttps://github.com/petkaantonov
Mar 27, 2015https://github.com/nodejs/node/pull/1288#issuecomment-87050747
Please reload this pagehttps://github.com/nodejs/node/pull/1288
petkaantonovhttps://github.com/petkaantonov
Mar 27, 2015 https://github.com/nodejs/node/pull/1288#ref-commit-77c2da1
https://github.com/petkaantonov
timers: make Timer.close idempotenthttps://github.com/nodejs/node/commit/77c2da10fd437c1b68b28b5b25e165140e198b31
77c2da1https://github.com/nodejs/node/commit/77c2da10fd437c1b68b28b5b25e165140e198b31
#1287https://github.com/nodejs/node/issues/1287
#1288https://github.com/nodejs/node/pull/1288
https://github.com/petkaantonov
petkaantonovhttps://github.com/petkaantonov
Mar 27, 2015https://github.com/nodejs/node/pull/1288#issuecomment-87051849
77c2da1https://github.com/nodejs/node/commit/77c2da10fd437c1b68b28b5b25e165140e198b31
Please reload this pagehttps://github.com/nodejs/node/pull/1288
https://github.com/petkaantonov
petkaantonovhttps://github.com/petkaantonov
Mar 27, 2015https://github.com/nodejs/node/pull/1288#event-267181773
https://github.com/petkaantonov
petkaantonovhttps://github.com/petkaantonov
March 27, 2015 18:52https://github.com/nodejs/node/pull/1288#event-267182323
https://github.com/rvagg
rvagghttps://github.com/rvagg
Mar 28, 2015 https://github.com/nodejs/node/pull/1288#ref-issue-64148220
Release proposal: v1.6.3 #1252 https://github.com/nodejs/node/issues/1252
rvagghttps://github.com/rvagg
Mar 31, 2015 https://github.com/nodejs/node/pull/1288#ref-commit-4845f9c
https://github.com/rvagg
2015-03-31 io.js v1.6.3 Releasehttps://github.com/nodejs/node/commit/4845f9c2095aada773af5bf3044dc240d656c278
4845f9chttps://github.com/nodejs/node/commit/4845f9c2095aada773af5bf3044dc240d656c278
#1058https://github.com/nodejs/node/issues/1058
#1063https://github.com/nodejs/node/pull/1063
#848https://github.com/nodejs/node/pull/848
#1288https://github.com/nodejs/node/pull/1288
#1231https://github.com/nodejs/node/pull/1231
#1251https://github.com/nodejs/node/pull/1251
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1288
Please reload this pagehttps://github.com/nodejs/node/pull/1288
https://github.com/petkaantonov
https://github.com/bnoordhuis
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.