René's URL Explorer Experiment


Title: test: fix napi test_reference for recent V8 by targos · Pull Request #12864 · nodejs/node · GitHub

Open Graph Title: test: fix napi test_reference for recent V8 by targos · Pull Request #12864 · nodejs/node

X Title: test: fix napi test_reference for recent V8 by targos · Pull Request #12864 · nodejs/node

Description: Ref: #12551 (comment) /cc @jasongin @nodejs/n-api Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines Affected core subsystem(s) test

Open Graph Description: Ref: #12551 (comment) /cc @jasongin @nodejs/n-api Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines Affected core subsystem(s) test

X Description: Ref: #12551 (comment) /cc @jasongin @nodejs/n-api Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines Affected core subsystem(s) test

Opengraph URL: https://github.com/nodejs/node/pull/12864

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4aa793e4-1ec3-57b4-978b-f4451d3a0734
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id96D0:3C747C:26FCDD:36819B:696A0793
html-safe-nonceba7729b3f104593b07f575d8d0c8b5569be6885f7a6f238e6dbee2f07e825281
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkQwOjNDNzQ3QzoyNkZDREQ6MzY4MTlCOjY5NkEwNzkzIiwidmlzaXRvcl9pZCI6IjI4Njc5NzUzMjcxODQ0NTU1NzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7b1ef40b2d1de87de7c63503a4c539df8b3329bf531be1b157675d6d85b62b5d
hovercard-subject-tagpull_request:119254328
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/12864/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a026a3042dc3e6b2ac603a6572456232c9e6a4c5b1fd10eb051be32db83305bf/nodejs/node/pull/12864
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a026a3042dc3e6b2ac603a6572456232c9e6a4c5b1fd10eb051be32db83305bf/nodejs/node/pull/12864
og:image:altRef: #12551 (comment) /cc @jasongin @nodejs/n-api Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines Affected core subsystem(s) test
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametargos
hostnamegithub.com
expected-hostnamegithub.com
None578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release671c2f67171dbced24284331f3133a613d08c366
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/12864#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12864
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12864
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/12864
Reloadhttps://github.com/nodejs/node/pull/12864
Reloadhttps://github.com/nodejs/node/pull/12864
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/12864
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/12864
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/12864#issue-comment-box
targoshttps://github.com/targos
nodejs:masterhttps://github.com/nodejs/node/tree/master
targos:fix-napi-test-referencehttps://github.com/targos/node/tree/fix-napi-test-reference
test: fix napi test_reference for recent V8 https://github.com/nodejs/node/pull/12864#top
targoshttps://github.com/targos
nodejs:masterhttps://github.com/nodejs/node/tree/master
targos:fix-napi-test-referencehttps://github.com/targos/node/tree/fix-napi-test-reference
Conversation 4 https://github.com/nodejs/node/pull/12864
Commits 1 https://github.com/nodejs/node/pull/12864/commits
Checks 0 https://github.com/nodejs/node/pull/12864/checks
Files changed https://github.com/nodejs/node/pull/12864/files
Please reload this pagehttps://github.com/nodejs/node/pull/12864
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/targos
targoshttps://github.com/targos
May 5, 2017https://github.com/nodejs/node/pull/12864#issue-226685911
#12551 (comment)https://github.com/nodejs/node/pull/12551#issuecomment-297949361
@jasonginhttps://github.com/jasongin
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/12864
https://github.com/targos
test: fix napi test_reference for recent V8https://github.com/nodejs/node/pull/12864/commits/4ee040964bfa78f1a28d299a3c8432fcd5629393
4ee0409https://github.com/nodejs/node/pull/12864/commits/4ee040964bfa78f1a28d299a3c8432fcd5629393
https://github.com/targos
targoshttps://github.com/targos
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
May 5, 2017https://github.com/nodejs/node/pull/12864#event-1071210434
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
May 5, 2017https://github.com/nodejs/node/pull/12864#event-1071210540
https://github.com/jasongin
jasonginhttps://github.com/jasongin
May 5, 2017 https://github.com/nodejs/node/pull/12864#pullrequestreview-36613934
View reviewed changes https://github.com/nodejs/node/pull/12864/files/4ee040964bfa78f1a28d299a3c8432fcd5629393
https://github.com/boingoing
boingoinghttps://github.com/boingoing
May 5, 2017 https://github.com/nodejs/node/pull/12864#pullrequestreview-36619882
View reviewed changes https://github.com/nodejs/node/pull/12864/files/4ee040964bfa78f1a28d299a3c8432fcd5629393
boingoinghttps://github.com/boingoing
https://github.com/nodejs/node/pull/12864#pullrequestreview-36619882
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/12864
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 7, 2017 https://github.com/nodejs/node/pull/12864#pullrequestreview-36657135
View reviewed changes https://github.com/nodejs/node/pull/12864/files/4ee040964bfa78f1a28d299a3c8432fcd5629393
https://github.com/targos
targoshttps://github.com/targos
May 7, 2017https://github.com/nodejs/node/pull/12864#issuecomment-299685999
https://ci.nodejs.org/job/node-test-pull-request/7923/https://ci.nodejs.org/job/node-test-pull-request/7923/
Please reload this pagehttps://github.com/nodejs/node/pull/12864
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 7, 2017 https://github.com/nodejs/node/pull/12864#pullrequestreview-36673486
View reviewed changes https://github.com/nodejs/node/pull/12864/files/4ee040964bfa78f1a28d299a3c8432fcd5629393
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/12864#pullrequestreview-36673486
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/12864
https://github.com/targos
targoshttps://github.com/targos
May 7, 2017https://github.com/nodejs/node/pull/12864#issuecomment-299742549
0a734fehttps://github.com/nodejs/node/commit/0a734fec885409a09b9d18319e4ea7f6f25e6a3e
Please reload this pagehttps://github.com/nodejs/node/pull/12864
https://github.com/targos
targoshttps://github.com/targos
May 7, 2017https://github.com/nodejs/node/pull/12864#event-1072036831
https://github.com/targos
targoshttps://github.com/targos
May 7, 2017 23:13https://github.com/nodejs/node/pull/12864#event-1072036848
targoshttps://github.com/targos
May 7, 2017 https://github.com/nodejs/node/pull/12864#ref-commit-0a734fe
https://github.com/targos
test: fix napi test_reference for recent V8https://github.com/nodejs/node/commit/0a734fec885409a09b9d18319e4ea7f6f25e6a3e
0a734fehttps://github.com/nodejs/node/commit/0a734fec885409a09b9d18319e4ea7f6f25e6a3e
#12864https://github.com/nodejs/node/pull/12864
#12551 (comment)https://github.com/nodejs/node/pull/12551#issuecomment-297949361
anchnkhttps://github.com/anchnk
May 19, 2017 https://github.com/nodejs/node/pull/12864#ref-commit-ffa7a1d
https://github.com/targos
test: fix napi test_reference for recent V8https://github.com/anchnk/node/commit/ffa7a1d9dd138c7125fd6aa8586e44e4e3345ace
ffa7a1dhttps://github.com/anchnk/node/commit/ffa7a1d9dd138c7125fd6aa8586e44e4e3345ace
nodejs#12864https://github.com/nodejs/node/pull/12864
nodejs#12551 (comment)https://github.com/nodejs/node/pull/12551#issuecomment-297949361
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 11, 2017 https://github.com/nodejs/node/pull/12864#ref-pullrequest-219383958
8.0.0 Release Proposal #12220 https://github.com/nodejs/node/pull/12220
jasonginhttps://github.com/jasongin
May 30, 2017 https://github.com/nodejs/node/pull/12864#ref-commit-bb91879
https://github.com/jasongin
test: Make N-API weak-ref GC tests asynchronoushttps://github.com/jasongin/nodejs/commit/bb91879f316088d165a79ee5d992796fdbc879e3
bb91879https://github.com/jasongin/nodejs/commit/bb91879f316088d165a79ee5d992796fdbc879e3
nodejs#12864https://github.com/nodejs/node/pull/12864
nodejs/node-chakracore#246https://github.com/nodejs/node-chakracore/issues/246
nodejs#13121https://github.com/nodejs/node/pull/13121
jasnellhttps://github.com/jasnell
Jun 5, 2017 https://github.com/nodejs/node/pull/12864#ref-commit-5369359
https://github.com/jasongin
https://github.com/jasnell
test: Make N-API weak-ref GC tests asynchronoushttps://github.com/nodejs/node/commit/5369359d523ea85e4df1352076ed16981b926e7c
5369359https://github.com/nodejs/node/commit/5369359d523ea85e4df1352076ed16981b926e7c
#12864https://github.com/nodejs/node/pull/12864
nodejs/node-chakracore#246https://github.com/nodejs/node-chakracore/issues/246
#13121https://github.com/nodejs/node/pull/13121
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Jun 15, 2017 https://github.com/nodejs/node/pull/12864#ref-issue-235404028
Auditing for 6.11.1 nodejs/Release#230 https://github.com/nodejs/Release/issues/230
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Jun 18, 2017https://github.com/nodejs/node/pull/12864#event-1128265566
https://github.com/targos
targoshttps://github.com/targos
Aug 29, 2017 https://github.com/nodejs/node/pull/12864#ref-pullrequest-253699961
test: fix tests after V8 6.0 GC changes TooTallNate/ref#85 https://github.com/TooTallNate/ref/pull/85
gabrielschulhofhttps://github.com/gabrielschulhof
Apr 10, 2018 https://github.com/nodejs/node/pull/12864#ref-commit-7491cee
https://github.com/targos
test: fix napi test_reference for recent V8https://github.com/gabrielschulhof/node/commit/7491cee8611b63eb95eb7bbde8335f37d229b7ab
7491ceehttps://github.com/gabrielschulhof/node/commit/7491cee8611b63eb95eb7bbde8335f37d229b7ab
nodejs#12864https://github.com/nodejs/node/pull/12864
nodejs#12551 (comment)https://github.com/nodejs/node/pull/12551#issuecomment-297949361
gabrielschulhofhttps://github.com/gabrielschulhof
Apr 10, 2018 https://github.com/nodejs/node/pull/12864#ref-commit-8653a1b
https://github.com/jasongin
test: Make N-API weak-ref GC tests asynchronoushttps://github.com/gabrielschulhof/node/commit/8653a1bad4bea81504bf49f8c36d25831e6587e4
8653a1bhttps://github.com/gabrielschulhof/node/commit/8653a1bad4bea81504bf49f8c36d25831e6587e4
nodejs#12864https://github.com/nodejs/node/pull/12864
nodejs/node-chakracore#246https://github.com/nodejs/node-chakracore/issues/246
nodejs#13121https://github.com/nodejs/node/pull/13121
MylesBorinshttps://github.com/MylesBorins
Apr 16, 2018 https://github.com/nodejs/node/pull/12864#ref-commit-ce03977
https://github.com/targos
https://github.com/MylesBorins
test: fix napi test_reference for recent V8https://github.com/nodejs/node/commit/ce03977f30b8959817cd4d160e63572d5ea32a58
ce03977https://github.com/nodejs/node/commit/ce03977f30b8959817cd4d160e63572d5ea32a58
#19447https://github.com/nodejs/node/pull/19447
#12864https://github.com/nodejs/node/pull/12864
#12551 (comment)https://github.com/nodejs/node/pull/12551#issuecomment-297949361
MylesBorinshttps://github.com/MylesBorins
Apr 16, 2018 https://github.com/nodejs/node/pull/12864#ref-commit-652d321
https://github.com/jasongin
https://github.com/MylesBorins
test: Make N-API weak-ref GC tests asynchronoushttps://github.com/nodejs/node/commit/652d3218fee63147c91e225c7db94e6d71f6e26c
652d321https://github.com/nodejs/node/commit/652d3218fee63147c91e225c7db94e6d71f6e26c
#12864https://github.com/nodejs/node/pull/12864
nodejs/node-chakracore#246https://github.com/nodejs/node-chakracore/issues/246
#19447https://github.com/nodejs/node/pull/19447
#13121https://github.com/nodejs/node/pull/13121
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 16, 2018 https://github.com/nodejs/node/pull/12864#ref-pullrequest-313968187
v6.14.2 proposal #19996 https://github.com/nodejs/node/pull/19996
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12864
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/12864/files/4ee040964bfa78f1a28d299a3c8432fcd5629393
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/12864/files/4ee040964bfa78f1a28d299a3c8432fcd5629393
https://github.com/boingoing
boingoing https://github.com/boingoing
https://github.com/nodejs/node/pull/12864/files/4ee040964bfa78f1a28d299a3c8432fcd5629393
https://github.com/jasongin
jasongin https://github.com/jasongin
https://github.com/nodejs/node/pull/12864/files/4ee040964bfa78f1a28d299a3c8432fcd5629393
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Please reload this pagehttps://github.com/nodejs/node/pull/12864
https://github.com/targos
https://github.com/jasnell
https://github.com/boingoing
https://github.com/mhdawson
https://github.com/jasongin
https://github.com/gibfahn
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.