René's URL Explorer Experiment


Title: Revert "net: don't normalize twice in Socket#connect()" by cjihrig · Pull Request #12852 · nodejs/node · GitHub

Open Graph Title: Revert "net: don't normalize twice in Socket#connect()" by cjihrig · Pull Request #12852 · nodejs/node

X Title: Revert "net: don't normalize twice in Socket#connect()" by cjihrig · Pull Request #12852 · nodejs/node

Description: This reverts commit bb06add. This commit was causing failures in the async-listener module, which monkey patches Socket.prototype.connect(). cc: @watson @jasnell Checklist make -j4 test (UNIX), o...

Open Graph Description: This reverts commit bb06add. This commit was causing failures in the async-listener module, which monkey patches Socket.prototype.connect(). cc: @watson @jasnell Checklist make -j4 test (UNIX), o...

X Description: This reverts commit bb06add. This commit was causing failures in the async-listener module, which monkey patches Socket.prototype.connect(). cc: @watson @jasnell Checklist make -j4 test (UNIX), o...

Opengraph URL: https://github.com/nodejs/node/pull/12852

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:57cd7261-a9d0-b846-18e5-e7660a9a51ba
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB562:296AF5:20A16FE:2CCF0DF:696ABA05
html-safe-nonce77395f56920f19489f328feb03e6aee5c576d6c56306c981ac78f52c8ec3f5ea
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTYyOjI5NkFGNToyMEExNkZFOjJDQ0YwREY6Njk2QUJBMDUiLCJ2aXNpdG9yX2lkIjoiNTU1OTUxNzU1MzYwOTA2MjkxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdaa762dbe5796813ad1b6e762450a3842d73584feba42f5e2196f73271ac13ec
hovercard-subject-tagpull_request:119140776
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/12852/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/38d572986d226231d4ebb69af4cfa04edcad78f29189f62474483ba1fa0a8ed0/nodejs/node/pull/12852
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/38d572986d226231d4ebb69af4cfa04edcad78f29189f62474483ba1fa0a8ed0/nodejs/node/pull/12852
og:image:altThis reverts commit bb06add. This commit was causing failures in the async-listener module, which monkey patches Socket.prototype.connect(). cc: @watson @jasnell Checklist make -j4 test (UNIX), o...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/12852#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12852
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12852
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/12852
Reloadhttps://github.com/nodejs/node/pull/12852
Reloadhttps://github.com/nodejs/node/pull/12852
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/12852
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/12852
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/12852#issue-comment-box
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:reverthttps://github.com/cjihrig/node/tree/revert
Revert "net: don't normalize twice in Socket#connect()" https://github.com/nodejs/node/pull/12852#top
cjihrighttps://github.com/cjihrig
nodejs:masterhttps://github.com/nodejs/node/tree/master
cjihrig:reverthttps://github.com/cjihrig/node/tree/revert
Conversation 10 https://github.com/nodejs/node/pull/12852
Commits 2 https://github.com/nodejs/node/pull/12852/commits
Checks 0 https://github.com/nodejs/node/pull/12852/checks
Files changed https://github.com/nodejs/node/pull/12852/files
Please reload this pagehttps://github.com/nodejs/node/pull/12852
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 5, 2017https://github.com/nodejs/node/pull/12852#issue-226522842
bb06addhttps://github.com/nodejs/node/commit/bb06add4d78535f10d1dc8f0c8c3210fecb96c8a
@watsonhttps://github.com/watson
@jasnellhttps://github.com/jasnell
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/12852
https://github.com/cjihrig
Revert "net: don't normalize twice in Socket#connect()"https://github.com/nodejs/node/pull/12852/commits/44de1fc7de122988d59bc785f01d87f0d766e6ea
44de1fchttps://github.com/nodejs/node/pull/12852/commits/44de1fc7de122988d59bc785f01d87f0d766e6ea
bb06addhttps://github.com/cjihrig/node/commit/bb06add4d78535f10d1dc8f0c8c3210fecb96c8a
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
May 5, 2017https://github.com/nodejs/node/pull/12852#event-1070293929
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 5, 2017https://github.com/nodejs/node/pull/12852#issuecomment-299424645
Please reload this pagehttps://github.com/nodejs/node/pull/12852
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 5, 2017 https://github.com/nodejs/node/pull/12852#ref-pullrequest-221039259
net: micro cleanups #12342 https://github.com/nodejs/node/pull/12342
https://github.com/watson
watsonhttps://github.com/watson
May 5, 2017 https://github.com/nodejs/node/pull/12852#ref-issue-226523973
net.connect issue with Node.js 7.10.0 othiym23/async-listener#109 https://github.com/othiym23/async-listener/issues/109
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 5, 2017https://github.com/nodejs/node/pull/12852#issuecomment-299425907
@watsonhttps://github.com/watson
Please reload this pagehttps://github.com/nodejs/node/pull/12852
https://github.com/watson
watsonhttps://github.com/watson
May 5, 2017https://github.com/nodejs/node/pull/12852#issuecomment-299435198
Please reload this pagehttps://github.com/nodejs/node/pull/12852
https://github.com/watson
watsonhttps://github.com/watson
force-pushedhttps://github.com/nodejs/node/compare/40e1e7d9c0bbab7e067337f13c118e16842c4289..bbbfa0a5eec368fa47f7b6367cc2da7dffdeb27b
40e1e7dhttps://github.com/nodejs/node/commit/40e1e7d9c0bbab7e067337f13c118e16842c4289
bbbfa0ahttps://github.com/nodejs/node/commit/bbbfa0a5eec368fa47f7b6367cc2da7dffdeb27b
Compare https://github.com/nodejs/node/compare/40e1e7d9c0bbab7e067337f13c118e16842c4289..bbbfa0a5eec368fa47f7b6367cc2da7dffdeb27b
May 5, 2017 12:57https://github.com/nodejs/node/pull/12852#event-1070516575
https://github.com/watson
https://github.com/cjihrig
test: test net.connect monkey patchinghttps://github.com/nodejs/node/pull/12852/commits/33918ed5a0cd2029c9dbfef00659b8c43787c4c9
33918edhttps://github.com/nodejs/node/pull/12852/commits/33918ed5a0cd2029c9dbfef00659b8c43787c4c9
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/bbbfa0a5eec368fa47f7b6367cc2da7dffdeb27b..33918ed5a0cd2029c9dbfef00659b8c43787c4c9
bbbfa0ahttps://github.com/nodejs/node/commit/bbbfa0a5eec368fa47f7b6367cc2da7dffdeb27b
33918edhttps://github.com/nodejs/node/commit/33918ed5a0cd2029c9dbfef00659b8c43787c4c9
Compare https://github.com/nodejs/node/compare/bbbfa0a5eec368fa47f7b6367cc2da7dffdeb27b..33918ed5a0cd2029c9dbfef00659b8c43787c4c9
May 5, 2017 13:06https://github.com/nodejs/node/pull/12852#event-1070528109
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 5, 2017https://github.com/nodejs/node/pull/12852#issuecomment-299459648
Please reload this pagehttps://github.com/nodejs/node/pull/12852
https://github.com/watson
watsonhttps://github.com/watson
May 5, 2017 https://github.com/nodejs/node/pull/12852#ref-issue-226573988
net.connect issue with Node.js 7.10.0 othiym23/node-continuation-local-storage#117 https://github.com/othiym23/node-continuation-local-storage/issues/117
https://github.com/watson
watsonhttps://github.com/watson
May 5, 2017 https://github.com/nodejs/node/pull/12852#ref-pullrequest-226590286
net: ensure net.connect calls Socket connect #12861 https://github.com/nodejs/node/pull/12861
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
May 7, 2017https://github.com/nodejs/node/pull/12852#issuecomment-299687025
@watsonhttps://github.com/watson
Please reload this pagehttps://github.com/nodejs/node/pull/12852
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
May 7, 2017https://github.com/nodejs/node/pull/12852#issuecomment-299690554
…https://github.com/nodejs/node/pull/12852
@watsonhttps://github.com/watson
https://github.com/watsonhttps://github.com/watson
#12852 (comment)https://github.com/nodejs/node/pull/12852#issuecomment-299687025
https://github.com/notifications/unsubscribe-auth/AEGanJjYdMph7vgnwM1OrFGYD1cZx_Ffks5r3W3CgaJpZM4NRs4Ehttps://github.com/notifications/unsubscribe-auth/AEGanJjYdMph7vgnwM1OrFGYD1cZx_Ffks5r3W3CgaJpZM4NRs4E
Please reload this pagehttps://github.com/nodejs/node/pull/12852
watsonhttps://github.com/watson
May 7, 2017 https://github.com/nodejs/node/pull/12852#ref-commit-ab7457a
https://github.com/watson
net: ensure net.connect calls Socket connecthttps://github.com/watson/node/commit/ab7457a2c680a90040dab56558ee94dd2c52b392
ab7457ahttps://github.com/watson/node/commit/ab7457a2c680a90040dab56558ee94dd2c52b392
nodejs#12342https://github.com/nodejs/node/pull/12342
nodejs#12852https://github.com/nodejs/node/pull/12852
https://github.com/watson
watsonhttps://github.com/watson
May 7, 2017https://github.com/nodejs/node/pull/12852#issuecomment-299696674
#12861https://github.com/nodejs/node/pull/12861
bb06addhttps://github.com/nodejs/node/commit/bb06add4d78535f10d1dc8f0c8c3210fecb96c8a
Please reload this pagehttps://github.com/nodejs/node/pull/12852
https://github.com/watson
watsonhttps://github.com/watson
May 7, 2017https://github.com/nodejs/node/pull/12852#issuecomment-299697663
@bnoordhuishttps://github.com/bnoordhuis
#12861https://github.com/nodejs/node/pull/12861
bb06addhttps://github.com/nodejs/node/commit/bb06add4d78535f10d1dc8f0c8c3210fecb96c8a
Please reload this pagehttps://github.com/nodejs/node/pull/12852
https://github.com/hybrist
hybristhttps://github.com/hybrist
May 7, 2017https://github.com/nodejs/node/pull/12852#issuecomment-299722296
Please reload this pagehttps://github.com/nodejs/node/pull/12852
#12861https://github.com/nodejs/node/pull/12861
Please reload this pagehttps://github.com/nodejs/node/pull/12852
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 8, 2017https://github.com/nodejs/node/pull/12852#issuecomment-299774476
#12861https://github.com/nodejs/node/pull/12861
Please reload this pagehttps://github.com/nodejs/node/pull/12852
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
May 8, 2017https://github.com/nodejs/node/pull/12852#event-1072205657
sam-githubhttps://github.com/sam-github
May 8, 2017 https://github.com/nodejs/node/pull/12852#ref-commit-212a7a6
https://github.com/watson
https://github.com/sam-github
net: ensure net.connect calls Socket connecthttps://github.com/nodejs/node/commit/212a7a609d605c13294034f2f403632b626edf4c
212a7a6https://github.com/nodejs/node/commit/212a7a609d605c13294034f2f403632b626edf4c
#12342https://github.com/nodejs/node/pull/12342
#12852https://github.com/nodejs/node/pull/12852
#12861https://github.com/nodejs/node/pull/12861
anchnkhttps://github.com/anchnk
May 19, 2017 https://github.com/nodejs/node/pull/12852#ref-commit-f816e6a
https://github.com/watson
net: ensure net.connect calls Socket connecthttps://github.com/anchnk/node/commit/f816e6a82294b28d1d2c4bb8608e67ca9495c898
f816e6ahttps://github.com/anchnk/node/commit/f816e6a82294b28d1d2c4bb8608e67ca9495c898
nodejs#12342https://github.com/nodejs/node/pull/12342
nodejs#12852https://github.com/nodejs/node/pull/12852
nodejs#12861https://github.com/nodejs/node/pull/12861
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12852
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
Please reload this pagehttps://github.com/nodejs/node/pull/12852
https://github.com/cjihrig
https://github.com/addaleax
https://github.com/watson
https://github.com/bnoordhuis
https://github.com/joyeecheung
https://github.com/hybrist
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.