René's URL Explorer Experiment


Title: test: improved type checking with regex by b6t · Pull Request #12591 · nodejs/node · GitHub

Open Graph Title: test: improved type checking with regex by b6t · Pull Request #12591 · nodejs/node

X Title: test: improved type checking with regex by b6t · Pull Request #12591 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Removed generic check of TypeError and replaced with a regular expression of the expected error message. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows...

X Description: Removed generic check of TypeError and replaced with a regular expression of the expected error message. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows...

Opengraph URL: https://github.com/nodejs/node/pull/12591

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9b1cf239-a085-43f6-fec8-34a28f97e55d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEDCA:446DE:31F4F7F:46B705D:6A501056
html-safe-nonce719a697a9e408a89bb32daf70b334572469d9436cf9a119c07a63bf279e02a17
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRENBOjQ0NkRFOjMxRjRGN0Y6NDZCNzA1RDo2QTUwMTA1NiIsInZpc2l0b3JfaWQiOiI3Nzk0ODk5NzgxODA1OTM2NzI2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac31157faaf2420345d517888e1a414e027294cdd74965dead3f9af99fe89d6ef9
hovercard-subject-tagpull_request:117120354
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/12591/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/38f3ab58e9c83b56d878295386906c006ccd1f4425c8bbe37bec346d92d1541c/nodejs/node/pull/12591
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/38f3ab58e9c83b56d878295386906c006ccd1f4425c8bbe37bec346d92d1541c/nodejs/node/pull/12591
og:image:altRemoved generic check of TypeError and replaced with a regular expression of the expected error message. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameb6t
hostnamegithub.com
expected-hostnamegithub.com
Nonefe4f38b24922a1ce81c1708c3793b47c185599b9144ab94f6ca846b00698058d
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release42b6390c91978a16f9196c38c7a00e9bf21f37e7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/12591#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12591
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12591
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/12591
Reloadhttps://github.com/nodejs/node/pull/12591
Reloadhttps://github.com/nodejs/node/pull/12591
Please reload this pagehttps://github.com/nodejs/node/pull/12591
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/12591
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 977 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
b6thttps://github.com/b6t
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/12591
Commits1 (1)https://github.com/nodejs/node/pull/12591/commits
Checkshttps://github.com/nodejs/node/pull/12591/checks
Files changedhttps://github.com/nodejs/node/pull/12591/files
test: improved type checking with regexhttps://github.com/nodejs/node/pull/12591#top
b6thttps://github.com/b6t
nodejs:masterhttps://github.com/nodejs/node/tree/master
https://github.com/b6t
b6thttps://github.com/b6t
Apr 22, 2017https://github.com/nodejs/node/pull/12591#issue-223583768
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/12591
test: improved type checking with regexhttps://github.com/nodejs/node/pull/12591/commits/095f5528b4d236660b9480035303693f86131dfd
095f552https://github.com/nodejs/node/pull/12591/commits/095f5528b4d236660b9480035303693f86131dfd
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Apr 22, 2017https://github.com/nodejs/node/pull/12591#event-1053510153
https://github.com/Trott
Trotthttps://github.com/Trott
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
Apr 22, 2017https://github.com/nodejs/node/pull/12591#event-1053510234
https://github.com/Trott
Trotthttps://github.com/Trott
Apr 22, 2017https://github.com/nodejs/node/pull/12591#issuecomment-296392831
https://ci.nodejs.org/job/node-test-pull-request/7590/https://ci.nodejs.org/job/node-test-pull-request/7590/
Please reload this pagehttps://github.com/nodejs/node/pull/12591
https://github.com/mscdex
mscdexhttps://github.com/mscdex
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
Apr 22, 2017https://github.com/nodejs/node/pull/12591#event-1053510480
https://github.com/Trott
Trotthttps://github.com/Trott
Apr 22, 2017 https://github.com/nodejs/node/pull/12591#pullrequestreview-34163250
View reviewed changes https://github.com/nodejs/node/pull/12591/files/095f5528b4d236660b9480035303693f86131dfd
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/12591#pullrequestreview-34163250
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/12591
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Apr 22, 2017 https://github.com/nodejs/node/pull/12591#pullrequestreview-34163691
View reviewed changes https://github.com/nodejs/node/pull/12591/files/095f5528b4d236660b9480035303693f86131dfd
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Apr 22, 2017 https://github.com/nodejs/node/pull/12591#pullrequestreview-34164084
View reviewed changes https://github.com/nodejs/node/pull/12591/files/095f5528b4d236660b9480035303693f86131dfd
https://github.com/santigimeno
santigimenohttps://github.com/santigimeno
Apr 24, 2017 https://github.com/nodejs/node/pull/12591#pullrequestreview-34247579
View reviewed changes https://github.com/nodejs/node/pull/12591/files/095f5528b4d236660b9480035303693f86131dfd
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Apr 24, 2017 https://github.com/nodejs/node/pull/12591#pullrequestreview-34250925
View reviewed changes https://github.com/nodejs/node/pull/12591/files/095f5528b4d236660b9480035303693f86131dfd
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 24, 2017 https://github.com/nodejs/node/pull/12591#pullrequestreview-34361023
View reviewed changes https://github.com/nodejs/node/pull/12591/files/095f5528b4d236660b9480035303693f86131dfd
Trotthttps://github.com/Trott
Apr 26, 2017 https://github.com/nodejs/node/pull/12591#ref-commit-e8004db
https://github.com/Trott
test: improved type checking with regexhttps://github.com/Trott/io.js/commit/e8004dbdd5dc12389a67479f195d240871f37ba4
e8004dbhttps://github.com/Trott/io.js/commit/e8004dbdd5dc12389a67479f195d240871f37ba4
nodejs#12591https://github.com/nodejs/node/pull/12591
https://github.com/Trott
Trotthttps://github.com/Trott
Apr 26, 2017https://github.com/nodejs/node/pull/12591#issuecomment-297233634
e8004dbhttps://github.com/nodejs/node/commit/e8004dbdd5dc12389a67479f195d240871f37ba4
Please reload this pagehttps://github.com/nodejs/node/pull/12591
https://github.com/Trott
Trotthttps://github.com/Trott
Apr 26, 2017https://github.com/nodejs/node/pull/12591#event-1057820463
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
May 1, 2017 https://github.com/nodejs/node/pull/12591#ref-pullrequest-225452651
v7.10.0 proposal #12775 https://github.com/nodejs/node/pull/12775
evanlucashttps://github.com/evanlucas
May 1, 2017 https://github.com/nodejs/node/pull/12591#ref-commit-37c0f27
https://github.com/evanlucas
test: improved type checking with regexhttps://github.com/nodejs/node/commit/37c0f2702774644a6e4a1911c2c39b1924f17d99
37c0f27https://github.com/nodejs/node/commit/37c0f2702774644a6e4a1911c2c39b1924f17d99
#12591https://github.com/nodejs/node/pull/12591
evanlucashttps://github.com/evanlucas
May 2, 2017 https://github.com/nodejs/node/pull/12591#ref-commit-1a84f06
https://github.com/evanlucas
test: improved type checking with regexhttps://github.com/nodejs/node/commit/1a84f0666b4212becde4e7dc52c43c3483880f79
1a84f06https://github.com/nodejs/node/commit/1a84f0666b4212becde4e7dc52c43c3483880f79
#12591https://github.com/nodejs/node/pull/12591
evanlucashttps://github.com/evanlucas
May 2, 2017 https://github.com/nodejs/node/pull/12591#ref-commit-660e58c
https://github.com/evanlucas
test: improved type checking with regexhttps://github.com/nodejs/node/commit/660e58c7ebf98ca4a05570aeffe12e5940ffdc3b
660e58chttps://github.com/nodejs/node/commit/660e58c7ebf98ca4a05570aeffe12e5940ffdc3b
#12591https://github.com/nodejs/node/pull/12591
MylesBorinshttps://github.com/MylesBorins
May 15, 2017 https://github.com/nodejs/node/pull/12591#ref-commit-89e76e8
https://github.com/MylesBorins
test: improved type checking with regexhttps://github.com/nodejs/node/commit/89e76e8e4d93f37bbbb2249cf6ef22d4bd261abd
89e76e8https://github.com/nodejs/node/commit/89e76e8e4d93f37bbbb2249cf6ef22d4bd261abd
#12591https://github.com/nodejs/node/pull/12591
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x
May 15, 2017https://github.com/nodejs/node/pull/12591#event-1082962305
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
May 23, 2017 https://github.com/nodejs/node/pull/12591#ref-pullrequest-229121369
v6.11.0 proposal #13059 https://github.com/nodejs/node/pull/13059
https://github.com/shigeki
shigekihttps://github.com/shigeki
Jun 16, 2017 https://github.com/nodejs/node/pull/12591#ref-pullrequest-236148722
Upgrade to OpenSSL-1.0.2l for Node-v4 #13696 https://github.com/nodejs/node/pull/13696
andrew749https://github.com/andrew749
Jul 19, 2017 https://github.com/nodejs/node/pull/12591#ref-commit-d7402d6
https://github.com/andrew749
test: improved type checking with regexhttps://github.com/michielbaird/node/commit/d7402d606d7655452b667653359899ac8022a6a3
d7402d6https://github.com/michielbaird/node/commit/d7402d606d7655452b667653359899ac8022a6a3
nodejs/node#12591https://github.com/nodejs/node/pull/12591
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Mar 18, 2020 https://github.com/nodejs/node/pull/12591#ref-pullrequest-583404464
[Snyk] Upgrade eslint from 6.3.0 to 6.8.0 O330oei/node#4 https://github.com/O330oei/node/pull/4
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Apr 1, 2020 https://github.com/nodejs/node/pull/12591#ref-pullrequest-591557250
[Snyk] Upgrade eslint from 6.3.0 to 6.8.0 O330oei/node#11 https://github.com/O330oei/node/pull/11
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12591
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/12591/files/095f5528b4d236660b9480035303693f86131dfd
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/12591/files/095f5528b4d236660b9480035303693f86131dfd
https://github.com/santigimeno
santigimeno https://github.com/santigimeno
https://github.com/nodejs/node/pull/12591/files/095f5528b4d236660b9480035303693f86131dfd
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/12591/files/095f5528b4d236660b9480035303693f86131dfd
https://github.com/Fishrock123
Fishrock123 https://github.com/Fishrock123
https://github.com/nodejs/node/pull/12591/files/095f5528b4d236660b9480035303693f86131dfd
https://github.com/gibfahn
gibfahn https://github.com/gibfahn
https://github.com/nodejs/node/pull/12591/files/095f5528b4d236660b9480035303693f86131dfd
code-and-learn https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/12591
https://github.com/b6t
https://github.com/Trott
https://github.com/jasnell
https://github.com/santigimeno
https://github.com/Fishrock123
https://github.com/cjihrig
https://github.com/gibfahn
https://github.com/mscdex
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.