| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7a241b0f-4c5a-069e-c03b-1e91d6a010f0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 91D2:3569F3:23FA24:328BA1:696A077D |
| html-safe-nonce | 5850f2f12cd76ac25ef93119a007c62c5c0060d6024fe988b9bdaf5346fbda1e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MUQyOjM1NjlGMzoyM0ZBMjQ6MzI4QkExOjY5NkEwNzdEIiwidmlzaXRvcl9pZCI6IjczNjYzMjc1OTExNDU5NjU0MzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9bd67a4b99ded29f1f654fec647ef23971349da87c12bce61d27210968373ca1 |
| hovercard-subject-tag | pull_request:117072186 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/12574/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6a10f0b385a8b7eca680ad086ba886a83c5eb071f7e3a3aeb59fa7034499c35e/nodejs/node/pull/12574 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6a10f0b385a8b7eca680ad086ba886a83c5eb071f7e3a3aeb59fa7034499c35e/nodejs/node/pull/12574 |
| og:image:alt | Refs: #11273
Refs: #11299
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | TimothyGu |
| hostname | github.com |
| expected-hostname | github.com |
| None | 578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 671c2f67171dbced24284331f3133a613d08c366 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/12574#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12574 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12574 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/12574 |
| Reload | https://github.com/nodejs/node/pull/12574 |
| Reload | https://github.com/nodejs/node/pull/12574 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/12574#issue-comment-box |
| TimothyGu | https://github.com/TimothyGu |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| TimothyGu:url-errors | https://github.com/TimothyGu/node/tree/url-errors |
|
url: port WHATWG URL API to internal/errors
| https://github.com/nodejs/node/pull/12574#top |
| TimothyGu | https://github.com/TimothyGu |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| TimothyGu:url-errors | https://github.com/TimothyGu/node/tree/url-errors |
|
Conversation
20
| https://github.com/nodejs/node/pull/12574 |
|
Commits
3
| https://github.com/nodejs/node/pull/12574/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/12574/checks |
|
Files changed
| https://github.com/nodejs/node/pull/12574/files |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
| Apr 21, 2017 | https://github.com/nodejs/node/pull/12574#issue-223503983 |
| #11273 | https://github.com/nodejs/node/issues/11273 |
| #11299 | https://github.com/nodejs/node/issues/11299 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
| jasnell | https://github.com/jasnell |
| joyeecheung | https://github.com/joyeecheung |
| April 21, 2017 21:38 | https://github.com/nodejs/node/pull/12574#event-1053133667 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
|
whatwg-url
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url |
| Apr 21, 2017 | https://github.com/nodejs/node/pull/12574#event-1053133705 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Apr 21, 2017
| https://github.com/nodejs/node/pull/12574#ref-issue-206642170 |
|
Tracking Issue: Migrate errors to internal/errors.js
#11273
| https://github.com/nodejs/node/issues/11273 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
dont-land-on-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x |
| Apr 21, 2017 | https://github.com/nodejs/node/pull/12574#event-1053134504 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Apr 24, 2017
| https://github.com/nodejs/node/pull/12574#pullrequestreview-34213309 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12574/files |
| doc/api/errors.md | https://github.com/nodejs/node/pull/12574/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| joyeecheung | https://github.com/joyeecheung |
| Apr 24, 2017 | https://github.com/nodejs/node/pull/12574#discussion_r112867846 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| jasnell | https://github.com/jasnell |
| Apr 24, 2017 | https://github.com/nodejs/node/pull/12574#discussion_r113047995 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| lib/internal/url.js | https://github.com/nodejs/node/pull/12574/files#diff-26e6b1e2a90040b1ce20e7f305b2ff3140b483f863ee2573b4c6af9b696ad31e |
| joyeecheung | https://github.com/joyeecheung |
| Apr 24, 2017 | https://github.com/nodejs/node/pull/12574#discussion_r112868256 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| doc/api/errors.md | https://github.com/nodejs/node/pull/12574/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| joyeecheung | https://github.com/joyeecheung |
| Apr 24, 2017 | https://github.com/nodejs/node/pull/12574#discussion_r112868531 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| doc/api/errors.md | https://github.com/nodejs/node/pull/12574/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| joyeecheung | https://github.com/joyeecheung |
| Apr 24, 2017 | https://github.com/nodejs/node/pull/12574#discussion_r112868906 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| TimothyGu | https://github.com/TimothyGu |
| Apr 24, 2017 | https://github.com/nodejs/node/pull/12574#discussion_r113081670 |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| doc/api/errors.md | https://github.com/nodejs/node/pull/12574/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| joyeecheung | https://github.com/joyeecheung |
| Apr 24, 2017 | https://github.com/nodejs/node/pull/12574#discussion_r112869181 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| TimothyGu | https://github.com/TimothyGu |
| Apr 24, 2017 | https://github.com/nodejs/node/pull/12574#discussion_r113081900 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| doc/api/errors.md | https://github.com/nodejs/node/pull/12574/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8 |
| joyeecheung | https://github.com/joyeecheung |
| Apr 24, 2017 | https://github.com/nodejs/node/pull/12574#discussion_r112872097 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| TimothyGu | https://github.com/TimothyGu |
| Apr 24, 2017 | https://github.com/nodejs/node/pull/12574#discussion_r113082210 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| lib/internal/errors.js | https://github.com/nodejs/node/pull/12574/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c |
| joyeecheung | https://github.com/joyeecheung |
| Apr 24, 2017 | https://github.com/nodejs/node/pull/12574#discussion_r112872358 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| TimothyGu | https://github.com/TimothyGu |
| Apr 25, 2017 | https://github.com/nodejs/node/pull/12574#discussion_r113083273 |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| lib/internal/errors.js | https://github.com/nodejs/node/pull/12574/files#diff-670bf55805b781d9a3579f8bca9104c04d94af87cc33220149fd7d37b095ca1c |
| joyeecheung | https://github.com/joyeecheung |
| Apr 24, 2017 | https://github.com/nodejs/node/pull/12574#discussion_r112872787 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| lib/internal/url.js | https://github.com/nodejs/node/pull/12574/files#diff-26e6b1e2a90040b1ce20e7f305b2ff3140b483f863ee2573b4c6af9b696ad31e |
| joyeecheung | https://github.com/joyeecheung |
| Apr 24, 2017 | https://github.com/nodejs/node/pull/12574#discussion_r112873575 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| test/common.js | https://github.com/nodejs/node/pull/12574/files#diff-5c1ae2b5e56dedb8288bbde987415e6c63f6805f2e1d07e8c04cbf4e1b5fcc4b |
| joyeecheung | https://github.com/joyeecheung |
| Apr 24, 2017 | https://github.com/nodejs/node/pull/12574#discussion_r112874433 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| TimothyGu | https://github.com/TimothyGu |
| Apr 25, 2017 | https://github.com/nodejs/node/pull/12574#discussion_r113084816 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| testharness.js | https://github.com/w3c/web-platform-tests/blob/e1dcc277e0b0d1d51684c9e0bace2b253a7d1ac3/resources/testharness.js#L1184 |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Apr 24, 2017
| https://github.com/nodejs/node/pull/12574#pullrequestreview-34409192 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12574/files |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/12574#pullrequestreview-34409192 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| TimothyGu | https://github.com/TimothyGu |
| April 24, 2017 17:21 | https://github.com/nodejs/node/pull/12574#commits-pushed-c02820a |
|
| https://github.com/TimothyGu |
| errors: factor out "of type" text generation | https://github.com/nodejs/node/pull/12574/commits/c02820afb2093e8f96f123c21cb1272f7e0fe11d |
| c02820a | https://github.com/nodejs/node/pull/12574/commits/c02820afb2093e8f96f123c21cb1272f7e0fe11d |
|
| https://github.com/TimothyGu |
| url: port WHATWG URL API to internal/errors | https://github.com/nodejs/node/pull/12574/commits/71a31ff28c777ed58fad51dfa0ec534049ada621 |
| 71a31ff | https://github.com/nodejs/node/pull/12574/commits/71a31ff28c777ed58fad51dfa0ec534049ada621 |
|
| https://github.com/TimothyGu |
| Address comments | https://github.com/nodejs/node/pull/12574/commits/b43cdee7acf9f6f10d761d3f41c90b49df4bef8d |
| b43cdee | https://github.com/nodejs/node/pull/12574/commits/b43cdee7acf9f6f10d761d3f41c90b49df4bef8d |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
| force-pushed | https://github.com/nodejs/node/compare/04a25a2de61eeafcdc7d6c889594d450296f7737..b43cdee7acf9f6f10d761d3f41c90b49df4bef8d |
| 04a25a2 | https://github.com/nodejs/node/commit/04a25a2de61eeafcdc7d6c889594d450296f7737 |
| b43cdee | https://github.com/nodejs/node/commit/b43cdee7acf9f6f10d761d3f41c90b49df4bef8d |
|
Compare
| https://github.com/nodejs/node/compare/04a25a2de61eeafcdc7d6c889594d450296f7737..b43cdee7acf9f6f10d761d3f41c90b49df4bef8d |
| April 25, 2017 00:27 | https://github.com/nodejs/node/pull/12574#event-1055768548 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
| Apr 25, 2017 | https://github.com/nodejs/node/pull/12574#issuecomment-296857766 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Apr 25, 2017
| https://github.com/nodejs/node/pull/12574#pullrequestreview-34455076 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12574/files/b43cdee7acf9f6f10d761d3f41c90b49df4bef8d |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Apr 25, 2017 | https://github.com/nodejs/node/pull/12574#issuecomment-296869164 |
| https://ci.nodejs.org/job/node-test-pull-request/7660/ | https://ci.nodejs.org/job/node-test-pull-request/7660/ |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Apr 25, 2017
| https://github.com/nodejs/node/pull/12574#pullrequestreview-34614861 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12574/files/b43cdee7acf9f6f10d761d3f41c90b49df4bef8d |
| https://github.com/watilde |
| watilde | https://github.com/watilde |
|
Apr 25, 2017
| https://github.com/nodejs/node/pull/12574#pullrequestreview-34653391 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12574/files/b43cdee7acf9f6f10d761d3f41c90b49df4bef8d |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
| Apr 25, 2017 | https://github.com/nodejs/node/pull/12574#issuecomment-297195143 |
| d457a98 | https://github.com/nodejs/node/commit/d457a986a01b84c4cee3a952082caac3f118e1db |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
| Apr 25, 2017 | https://github.com/nodejs/node/pull/12574#event-1057614677 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
| April 25, 2017 23:34 | https://github.com/nodejs/node/pull/12574#event-1057614735 |
| TimothyGu | https://github.com/TimothyGu |
|
Apr 25, 2017
| https://github.com/nodejs/node/pull/12574#ref-commit-d457a98 |
|
| https://github.com/TimothyGu |
| url: port WHATWG URL API to internal/errors | https://github.com/nodejs/node/commit/d457a986a01b84c4cee3a952082caac3f118e1db |
| d457a98 | https://github.com/nodejs/node/commit/d457a986a01b84c4cee3a952082caac3f118e1db |
| #12574 | https://github.com/nodejs/node/pull/12574 |
| #11273 | https://github.com/nodejs/node/issues/11273 |
| #11299 | https://github.com/nodejs/node/issues/11299 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 11, 2017
| https://github.com/nodejs/node/pull/12574#ref-pullrequest-219383958 |
|
8.0.0 Release Proposal
#12220
| https://github.com/nodejs/node/pull/12220 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12574 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/12574/files/b43cdee7acf9f6f10d761d3f41c90b49df4bef8d |
|
| https://github.com/watilde |
|
watilde
| https://github.com/watilde |
|
| https://github.com/nodejs/node/pull/12574/files/b43cdee7acf9f6f10d761d3f41c90b49df4bef8d |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/12574/files/b43cdee7acf9f6f10d761d3f41c90b49df4bef8d |
|
errors
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors |
|
whatwg-url
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url |
| Please reload this page | https://github.com/nodejs/node/pull/12574 |
|
| https://github.com/TimothyGu |
|
| https://github.com/joyeecheung |
|
| https://github.com/jasnell |
|
| https://github.com/watilde |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |