| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:dc5b6c7d-e446-7897-807a-c1bfc73d77ea |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CCD0:BB9B6:11BAC01:183554C:6969F942 |
| html-safe-nonce | c5d8d85740e6c9ec44718d2a52ea9eac022d1b5c1d9a6cbcb020f15a16141ba8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0QwOkJCOUI2OjExQkFDMDE6MTgzNTU0Qzo2OTY5Rjk0MiIsInZpc2l0b3JfaWQiOiIxMTY3NjU5MDkzOTQ2MTM2ODk4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 2378bdabee39e04b408d7840b8c5519bc4256f25880b99c3e03a23ddf3c389d5 |
| hovercard-subject-tag | pull_request:116762641 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/12535/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b5030caf4c3c0c5badf2261f7408541f47681780aa6f926656e5ef7a6ed78c78/nodejs/node/pull/12535 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b5030caf4c3c0c5badf2261f7408541f47681780aa6f926656e5ef7a6ed78c78/nodejs/node/pull/12535 |
| og:image:alt | Original commit message:
Don't treat catch scopes as possibly-shadowing for sloppy eval
Scope analysis is over-conservative when treating variable
resolutions as possibly-shadowed by a sloppy ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hashseed |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/12535#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12535 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12535 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/12535 |
| Reload | https://github.com/nodejs/node/pull/12535 |
| Reload | https://github.com/nodejs/node/pull/12535 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/12535 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/12535 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/12535#issue-comment-box |
| hashseed | https://github.com/hashseed |
| nodejs:v6.x-staging | https://github.com/nodejs/node/tree/v6.x-staging |
| hashseed:fix-12308 | https://github.com/hashseed/node/tree/fix-12308 |
|
deps: backport 75f2d65f00 from upstream V8
| https://github.com/nodejs/node/pull/12535#top |
| hashseed | https://github.com/hashseed |
| nodejs:v6.x-staging | https://github.com/nodejs/node/tree/v6.x-staging |
| hashseed:fix-12308 | https://github.com/hashseed/node/tree/fix-12308 |
|
Conversation
6
| https://github.com/nodejs/node/pull/12535 |
|
Commits
1
| https://github.com/nodejs/node/pull/12535/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/12535/checks |
|
Files changed
| https://github.com/nodejs/node/pull/12535/files |
| Please reload this page | https://github.com/nodejs/node/pull/12535 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/hashseed |
| hashseed | https://github.com/hashseed |
| Apr 20, 2017 | https://github.com/nodejs/node/pull/12535#issue-223055753 |
| #12308 | https://github.com/nodejs/node/issues/12308 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/12535 |
|
| https://github.com/hashseed |
| deps: backport 75f2d65f00 from upstream V8 | https://github.com/nodejs/node/pull/12535/commits/e15d3c05dee74068fa903207237f6f041ab93e64 |
| e15d3c0 | https://github.com/nodejs/node/pull/12535/commits/e15d3c05dee74068fa903207237f6f041ab93e64 |
| https://crrev.com/75f2d65f003ebb22815489e9970913ba37234f1b | https://crrev.com/75f2d65f003ebb22815489e9970913ba37234f1b |
| nodejs#36046 | https://github.com/nodejs/node/pull/36046 |
| nodejs#12308 | https://github.com/nodejs/node/issues/12308 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av6.x |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Apr 20, 2017 | https://github.com/nodejs/node/pull/12535#event-1050467621 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Apr 20, 2017
| https://github.com/nodejs/node/pull/12535#pullrequestreview-33764294 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12535/files/e15d3c05dee74068fa903207237f6f041ab93e64 |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/12535#pullrequestreview-33764294 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12535 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Apr 20, 2017 | https://github.com/nodejs/node/pull/12535#issuecomment-295736353 |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/661/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/661/ |
| Please reload this page | https://github.com/nodejs/node/pull/12535 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Apr 20, 2017
| https://github.com/nodejs/node/pull/12535#pullrequestreview-33789639 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12535/files/e15d3c05dee74068fa903207237f6f041ab93e64 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Apr 20, 2017
| https://github.com/nodejs/node/pull/12535#pullrequestreview-33829830 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12535/files/e15d3c05dee74068fa903207237f6f041ab93e64 |
| bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/node/pull/12535#pullrequestreview-33829830 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12535 |
| https://github.com/hashseed |
| hashseed | https://github.com/hashseed |
| Apr 20, 2017 | https://github.com/nodejs/node/pull/12535#issuecomment-295822828 |
| Please reload this page | https://github.com/nodejs/node/pull/12535 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| April 24, 2017 01:23 | https://github.com/nodejs/node/pull/12535#event-1053965741 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 24, 2017
| https://github.com/nodejs/node/pull/12535#pullrequestreview-34363503 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12535/files/e15d3c05dee74068fa903207237f6f041ab93e64 |
| MylesBorins | https://github.com/MylesBorins |
| https://github.com/nodejs/node/pull/12535#pullrequestreview-34363503 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12535 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Apr 24, 2017 | https://github.com/nodejs/node/pull/12535#issuecomment-296758339 |
| Please reload this page | https://github.com/nodejs/node/pull/12535 |
| 404d1bc | https://github.com/nodejs/node/commit/404d1bc8af683be8ddf5ae981e83d8e5ff387257 |
| Please reload this page | https://github.com/nodejs/node/pull/12535 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Apr 24, 2017 | https://github.com/nodejs/node/pull/12535#event-1055216438 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 24, 2017
| https://github.com/nodejs/node/pull/12535#ref-commit-404d1bc |
|
| https://github.com/hashseed |
|
| https://github.com/MylesBorins |
| deps: backport 75f2d65f00 from upstream V8 | https://github.com/nodejs/node/commit/404d1bc8af683be8ddf5ae981e83d8e5ff387257 |
| 404d1bc | https://github.com/nodejs/node/commit/404d1bc8af683be8ddf5ae981e83d8e5ff387257 |
| chromium:608279 | https://bugs.chromium.org/p/chromium/issues/detail?id=608279 |
| https://crrev.com/75f2d65f003ebb22815489e9970913ba37234f1b | https://crrev.com/75f2d65f003ebb22815489e9970913ba37234f1b |
| #36046 | https://github.com/nodejs/node/pull/36046 |
| #12308 | https://github.com/nodejs/node/issues/12308 |
| #12535 | https://github.com/nodejs/node/pull/12535 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x |
| Apr 24, 2017 | https://github.com/nodejs/node/pull/12535#event-1055217073 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 24, 2017
| https://github.com/nodejs/node/pull/12535#ref-commit-cd78a2b |
|
| https://github.com/hashseed |
|
| https://github.com/MylesBorins |
| deps: backport 75f2d65f00 from upstream V8 | https://github.com/nodejs/node/commit/cd78a2bd07e269347af2c23b4b5e26c17b68a261 |
| cd78a2b | https://github.com/nodejs/node/commit/cd78a2bd07e269347af2c23b4b5e26c17b68a261 |
| chromium:608279 | https://bugs.chromium.org/p/chromium/issues/detail?id=608279 |
| https://crrev.com/75f2d65f003ebb22815489e9970913ba37234f1b | https://crrev.com/75f2d65f003ebb22815489e9970913ba37234f1b |
| #36046 | https://github.com/nodejs/node/pull/36046 |
| #12308 | https://github.com/nodejs/node/issues/12308 |
| #12535 | https://github.com/nodejs/node/pull/12535 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 24, 2017
| https://github.com/nodejs/node/pull/12535#ref-commit-99dab5b |
|
| https://github.com/hashseed |
|
| https://github.com/MylesBorins |
| deps: backport 75f2d65f00 from upstream V8 | https://github.com/nodejs/node/commit/99dab5bc2c10d2ce56b532a54d307b5f5cda1dc0 |
| 99dab5b | https://github.com/nodejs/node/commit/99dab5bc2c10d2ce56b532a54d307b5f5cda1dc0 |
| chromium:608279 | https://bugs.chromium.org/p/chromium/issues/detail?id=608279 |
| https://crrev.com/75f2d65f003ebb22815489e9970913ba37234f1b | https://crrev.com/75f2d65f003ebb22815489e9970913ba37234f1b |
| #36046 | https://github.com/nodejs/node/pull/36046 |
| #12308 | https://github.com/nodejs/node/issues/12308 |
| #12535 | https://github.com/nodejs/node/pull/12535 |
| https://github.com/hashseed |
| hashseed | https://github.com/hashseed |
| April 25, 2017 05:08 | https://github.com/nodejs/node/pull/12535#event-1055980310 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 29, 2017
| https://github.com/nodejs/node/pull/12535#ref-pullrequest-222580733 |
|
v6.10.3 proposal
#12498
| https://github.com/nodejs/node/pull/12498 |
| andrew749 | https://github.com/andrew749 |
|
Jul 19, 2017
| https://github.com/nodejs/node/pull/12535#ref-commit-43d93fa |
|
| https://github.com/hashseed |
|
| https://github.com/andrew749 |
| deps: backport 75f2d65f00 from upstream V8 | https://github.com/michielbaird/node/commit/43d93fa72c3140d4279747264abf955d4223fa90 |
| 43d93fa | https://github.com/michielbaird/node/commit/43d93fa72c3140d4279747264abf955d4223fa90 |
| https://crrev.com/75f2d65f003ebb22815489e9970913ba37234f1b | https://crrev.com/75f2d65f003ebb22815489e9970913ba37234f1b |
| nodejs#12308 | https://github.com/nodejs/node-v0.x-archive/issues/12308 |
| nodejs/node#12535 | https://github.com/nodejs/node/pull/12535 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12535 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/12535/files/e15d3c05dee74068fa903207237f6f041ab93e64 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/12535/files/e15d3c05dee74068fa903207237f6f041ab93e64 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/12535/files/e15d3c05dee74068fa903207237f6f041ab93e64 |
|
| https://github.com/MylesBorins |
|
MylesBorins
| https://github.com/MylesBorins |
|
| https://github.com/nodejs/node/pull/12535/files/e15d3c05dee74068fa903207237f6f041ab93e64 |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Please reload this page | https://github.com/nodejs/node/pull/12535 |
|
| https://github.com/hashseed |
|
| https://github.com/mhdawson |
|
| https://github.com/MylesBorins |
|
| https://github.com/bnoordhuis |
|
| https://github.com/cjihrig |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |