René's URL Explorer Experiment


Title: Revert "benchmark: fix CLI arguments check in common.js" by jasnell · Pull Request #12474 · nodejs/node · GitHub

Open Graph Title: Revert "benchmark: fix CLI arguments check in common.js" by jasnell · Pull Request #12474 · nodejs/node

X Title: Revert "benchmark: fix CLI arguments check in common.js" by jasnell · Pull Request #12474 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Ugh. I goofed. I landed #12429, then realized it never went through CI and it breaks one of the tests in sequential. This reverts commit e34f8e1. Need to get this landed quickly so we unbreak CI Ch...

X Description: Ugh. I goofed. I landed #12429, then realized it never went through CI and it breaks one of the tests in sequential. This reverts commit e34f8e1. Need to get this landed quickly so we unbreak CI Ch...

Opengraph URL: https://github.com/nodejs/node/pull/12474

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bc10380b-4536-a203-9c95-133dc829876b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE57A:2BFA45:290DBF2:371B713:6992F162
html-safe-nonce3055043afc44502f5d6100a68bbdb5ceb05ab09427d87da9d482ea50dfbce79a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTdBOjJCRkE0NToyOTBEQkYyOjM3MUI3MTM6Njk5MkYxNjIiLCJ2aXNpdG9yX2lkIjoiODk0NjI0ODcwOTg5NDc2Mjg1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac36fdc77fe554f87f288d37178f606c52c7926c1cb301ed596d7ed03ee863b05d
hovercard-subject-tagpull_request:116213593
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/12474/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8af43daab7bb3251ffa53e31a3fc6d2afd545a36ac7e0ae747ee03d3b37e8701/nodejs/node/pull/12474
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8af43daab7bb3251ffa53e31a3fc6d2afd545a36ac7e0ae747ee03d3b37e8701/nodejs/node/pull/12474
og:image:altUgh. I goofed. I landed #12429, then realized it never went through CI and it breaks one of the tests in sequential. This reverts commit e34f8e1. Need to get this landed quickly so we unbreak CI Ch...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
None01ab16879a3159e6f0717ab948b9b562e162a6aafd1f4393b786b07b747df244
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb1570f3928bef80fa5fc7890ce0942e9b696ad9d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/12474#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12474
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12474
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/12474
Reloadhttps://github.com/nodejs/node/pull/12474
Reloadhttps://github.com/nodejs/node/pull/12474
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/12474
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 714 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:revert-12429https://github.com/jasnell/node/tree/revert-12429
Conversationhttps://github.com/nodejs/node/pull/12474
Commits1 (1)https://github.com/nodejs/node/pull/12474/commits
Checkshttps://github.com/nodejs/node/pull/12474/checks
Files changedhttps://github.com/nodejs/node/pull/12474/files
Revert "benchmark: fix CLI arguments check in common.js"https://github.com/nodejs/node/pull/12474#top
jasnellhttps://github.com/jasnell
nodejs:masterhttps://github.com/nodejs/node/tree/master
jasnell:revert-12429https://github.com/jasnell/node/tree/revert-12429
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 17, 2017https://github.com/nodejs/node/pull/12474#issue-222245951
#12429https://github.com/nodejs/node/pull/12429
e34f8e1https://github.com/nodejs/node/commit/e34f8e1444d1e52f4501ccc289cdb83da93e48f0
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/12474
https://github.com/jasnell
Revert "benchmark: fix CLI arguments check in common.js"https://github.com/nodejs/node/pull/12474/commits/356fca4fbe66e1088bbf3a5476a545c84095c834
356fca4https://github.com/nodejs/node/pull/12474/commits/356fca4fbe66e1088bbf3a5476a545c84095c834
e34f8e1https://github.com/jasnell/node/commit/e34f8e1444d1e52f4501ccc289cdb83da93e48f0
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
benchmark https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark
Apr 17, 2017https://github.com/nodejs/node/pull/12474#event-1045660760
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 17, 2017https://github.com/nodejs/node/pull/12474#issuecomment-294609771
https://ci.nodejs.org/job/node-test-pull-request/7460/https://ci.nodejs.org/job/node-test-pull-request/7460/
Please reload this pagehttps://github.com/nodejs/node/pull/12474
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 17, 2017 https://github.com/nodejs/node/pull/12474#pullrequestreview-33105229
View reviewed changes https://github.com/nodejs/node/pull/12474/files/356fca4fbe66e1088bbf3a5476a545c84095c834
MylesBorinshttps://github.com/MylesBorins
https://github.com/nodejs/node/pull/12474#pullrequestreview-33105229
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/12474
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Apr 17, 2017 https://github.com/nodejs/node/pull/12474#pullrequestreview-33105741
View reviewed changes https://github.com/nodejs/node/pull/12474/files/356fca4fbe66e1088bbf3a5476a545c84095c834
jasnellhttps://github.com/jasnell
Apr 17, 2017 https://github.com/nodejs/node/pull/12474#ref-commit-0227571
https://github.com/jasnell
Revert "benchmark: fix CLI arguments check in common.js"https://github.com/nodejs/node/commit/0227571c172fa042cfab50e6521698123469f8cb
0227571https://github.com/nodejs/node/commit/0227571c172fa042cfab50e6521698123469f8cb
e34f8e1https://github.com/nodejs/node/commit/e34f8e1444d1e52f4501ccc289cdb83da93e48f0
#12474https://github.com/nodejs/node/pull/12474
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 17, 2017https://github.com/nodejs/node/pull/12474#issuecomment-294619186
Please reload this pagehttps://github.com/nodejs/node/pull/12474
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 17, 2017https://github.com/nodejs/node/pull/12474#event-1045707456
evanlucashttps://github.com/evanlucas
Apr 25, 2017 https://github.com/nodejs/node/pull/12474#ref-commit-14b4205
https://github.com/jasnell
https://github.com/evanlucas
Revert "benchmark: fix CLI arguments check in common.js"https://github.com/nodejs/node/commit/14b42055dd46f7f5da2e83d3112ae2be8575ae95
14b4205https://github.com/nodejs/node/commit/14b42055dd46f7f5da2e83d3112ae2be8575ae95
e34f8e1https://github.com/nodejs/node/commit/e34f8e1444d1e52f4501ccc289cdb83da93e48f0
#12474https://github.com/nodejs/node/pull/12474
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
May 1, 2017 https://github.com/nodejs/node/pull/12474#ref-pullrequest-225452651
v7.10.0 proposal #12775 https://github.com/nodejs/node/pull/12775
evanlucashttps://github.com/evanlucas
May 1, 2017 https://github.com/nodejs/node/pull/12474#ref-commit-443147d
https://github.com/jasnell
https://github.com/evanlucas
Revert "benchmark: fix CLI arguments check in common.js"https://github.com/nodejs/node/commit/443147d5343cc882eedcc68ba732e93c02cfb2d3
443147dhttps://github.com/nodejs/node/commit/443147d5343cc882eedcc68ba732e93c02cfb2d3
e34f8e1https://github.com/nodejs/node/commit/e34f8e1444d1e52f4501ccc289cdb83da93e48f0
#12474https://github.com/nodejs/node/pull/12474
evanlucashttps://github.com/evanlucas
May 2, 2017 https://github.com/nodejs/node/pull/12474#ref-commit-440f4d4
https://github.com/jasnell
https://github.com/evanlucas
Revert "benchmark: fix CLI arguments check in common.js"https://github.com/nodejs/node/commit/440f4d4eefa0ea82e2909820c10d95a06fcd2fcf
440f4d4https://github.com/nodejs/node/commit/440f4d4eefa0ea82e2909820c10d95a06fcd2fcf
e34f8e1https://github.com/nodejs/node/commit/e34f8e1444d1e52f4501ccc289cdb83da93e48f0
#12474https://github.com/nodejs/node/pull/12474
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
dont-land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v6.x
May 16, 2017https://github.com/nodejs/node/pull/12474#event-1083982823
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
May 16, 2017https://github.com/nodejs/node/pull/12474#issuecomment-301836469
#7094https://github.com/nodejs/node/pull/7094
#12429https://github.com/nodejs/node/pull/12429
Please reload this pagehttps://github.com/nodejs/node/pull/12474
https://github.com/baby636
baby636https://github.com/baby636
Jun 22, 2022 https://github.com/nodejs/node/pull/12474#ref-pullrequest-1279752484
[Snyk] Security upgrade eslint from 5.16.0 to 6.6.0 baby636/node#59 https://github.com/baby636/node/pull/59
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12474
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/12474/files/356fca4fbe66e1088bbf3a5476a545c84095c834
https://github.com/MylesBorins
MylesBorins https://github.com/MylesBorins
https://github.com/nodejs/node/pull/12474/files/356fca4fbe66e1088bbf3a5476a545c84095c834
benchmark https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark
Please reload this pagehttps://github.com/nodejs/node/pull/12474
https://github.com/jasnell
https://github.com/gibfahn
https://github.com/MylesBorins
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.