| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b1b1df2e-d3fa-80d4-be60-c48ab9825da5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EA06:13F356:2E3914:41356D:696A07A4 |
| html-safe-nonce | fc2f1fbdcb8a231085539a76e28af8969ac90d4fa40061aeac7c4c3dbd0a03c9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTA2OjEzRjM1NjoyRTM5MTQ6NDEzNTZEOjY5NkEwN0E0IiwidmlzaXRvcl9pZCI6IjE2OTcwNzUzNjQzNTQ0NTk1NTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4adb2621c44cb06116ae6ae946614c55ab9fd4425e970923314506d13028f9c5 |
| hovercard-subject-tag | pull_request:116081542 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/12455/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c117889ca0c3df520e466c9110758025b18737d5da99133025ca4a8a775a7e7d/nodejs/node/pull/12455 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c117889ca0c3df520e466c9110758025b18737d5da99133025ca4a8a775a7e7d/nodejs/node/pull/12455 |
| og:image:alt | Checklist
tests and/or benchmarks are included
commit message follows commit guidelines
Affected core subsystem(s)
benchmark
I. Presupposition
String concatenations usually increase syntax nois... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | vsemozhetbyt |
| hostname | github.com |
| expected-hostname | github.com |
| None | 578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 671c2f67171dbced24284331f3133a613d08c366 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/12455#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12455 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12455 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/12455 |
| Reload | https://github.com/nodejs/node/pull/12455 |
| Reload | https://github.com/nodejs/node/pull/12455 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/12455#issue-comment-box |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
benchmark: reduce string concatenations
| https://github.com/nodejs/node/pull/12455#top |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
Conversation
24
| https://github.com/nodejs/node/pull/12455 |
|
Commits
4
| https://github.com/nodejs/node/pull/12455/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/12455/checks |
|
Files changed
| https://github.com/nodejs/node/pull/12455/files |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12455#issue-222050749 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines |
| evident typo | https://github.com/nodejs/node/blob/a3e71a8901bc326bcc701820d10e10d9de4d338a/benchmark/_http-benchmarkers.js#L176 |
| a previous call | https://github.com/nodejs/node/blob/a3e71a8901bc326bcc701820d10e10d9de4d338a/benchmark/_http-benchmarkers.js#L169 |
| signature | https://github.com/nodejs/node/blob/master/benchmark/common.js#L118-L119 |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
benchmark
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12455#event-1044538452 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
assert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert |
|
benchmark
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
module
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12455#event-1044538483 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
assert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
module
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12455#event-1044539350 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12455#issuecomment-294392769 |
| https://ci.nodejs.org/job/node-test-pull-request/7434/ | https://ci.nodejs.org/job/node-test-pull-request/7434/ |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Apr 17, 2017
| https://github.com/nodejs/node/pull/12455#pullrequestreview-32959490 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12455/files |
| benchmark/assert/deepequal-typedarrays.js | https://github.com/nodejs/node/pull/12455/files#diff-c465aee8b78eb2995c81338c87a603da3e35c016a18d1581b72a5a4a9171bbac |
| mscdex | https://github.com/mscdex |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12455#discussion_r111700078 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Apr 17, 2017
| https://github.com/nodejs/node/pull/12455#pullrequestreview-32959515 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12455/files |
| benchmark/_http-benchmarkers.js | https://github.com/nodejs/node/pull/12455/files#diff-0271511cd35298b3597ef905a40159adfe9394a5ca09fb5cc9624ab72018e788 |
| mscdex | https://github.com/mscdex |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12455#discussion_r111700101 |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12455#discussion_r111700607 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Apr 17, 2017
| https://github.com/nodejs/node/pull/12455#pullrequestreview-32959618 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12455/files |
| benchmark/_benchmark_progress.js | https://github.com/nodejs/node/pull/12455/files#diff-9cb54419374a2e31b2e1429073a1b43becd44e245dfda26acb4737e263c2bd3d |
| mscdex | https://github.com/mscdex |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12455#discussion_r111700213 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12455#discussion_r111700890 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| mscdex | https://github.com/mscdex |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12455#discussion_r111703650 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12455#issuecomment-294397207 |
| https://ci.nodejs.org/job/node-test-pull-request/7435/ | https://ci.nodejs.org/job/node-test-pull-request/7435/ |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Apr 17, 2017
| https://github.com/nodejs/node/pull/12455#pullrequestreview-32981313 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12455/files |
| benchmark/buffers/buffer-bytelength.js | https://github.com/nodejs/node/pull/12455/files#diff-a5939143405ce0b82a18ffcf6d48e977cfdab8b250204625db80886db9d5ee74 |
| benjamingr | https://github.com/benjamingr |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12455#discussion_r111721192 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12455#discussion_r111733830 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Apr 17, 2017
| https://github.com/nodejs/node/pull/12455#pullrequestreview-32981420 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12455/files |
| benchmark/buffers/buffer-write.js | https://github.com/nodejs/node/pull/12455/files#diff-75dc2e37137d9c1bc36ea2c87d53e6e6202fd96e535cb68f44e779b94ac0d6cc |
| benjamingr | https://github.com/benjamingr |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12455#discussion_r111721297 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Apr 17, 2017
| https://github.com/nodejs/node/pull/12455#pullrequestreview-32981502 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12455/files |
| benchmark/common.js | https://github.com/nodejs/node/pull/12455/files#diff-e326fe00e30ce0a71be8ef7751c791f7ebcdd0cab2e67827bcf7e5210ab0747c |
| benjamingr | https://github.com/benjamingr |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12455#discussion_r111721385 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12455#discussion_r111733614 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Apr 17, 2017
| https://github.com/nodejs/node/pull/12455#pullrequestreview-32981634 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12455/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Apr 17, 2017
| https://github.com/nodejs/node/pull/12455#pullrequestreview-33054084 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12455/files |
| benchmark/buffers/buffer-read.js | https://github.com/nodejs/node/pull/12455/files#diff-9ed46ac7a5cb81dd393611912309d84a0fc92deac71d2146c72bfe0662af53b9 |
| jasnell | https://github.com/jasnell |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12455#discussion_r111788210 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12455#discussion_r111790340 |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| mscdex | https://github.com/mscdex |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12455#discussion_r111791842 |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| jasnell | https://github.com/jasnell |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12455#discussion_r111793140 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| joyeecheung | https://github.com/joyeecheung |
| Apr 21, 2017 | https://github.com/nodejs/node/pull/12455#discussion_r112620881 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Apr 17, 2017
| https://github.com/nodejs/node/pull/12455#pullrequestreview-33054515 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12455/files |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/12455#pullrequestreview-33054515 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| benchmark/buffers/buffer-swap.js | https://github.com/nodejs/node/pull/12455/files#diff-3feb683a9a824ce684aef969509f297a617a99dd0dc4f31738283f4eb5aeb0d4 |
| jasnell | https://github.com/jasnell |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12455#discussion_r111788609 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 19, 2017 | https://github.com/nodejs/node/pull/12455#issuecomment-295313029 |
| https://ci.nodejs.org/job/node-test-pull-request/7520/ | https://ci.nodejs.org/job/node-test-pull-request/7520/ |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 19, 2017 | https://github.com/nodejs/node/pull/12455#issuecomment-295341083 |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| https://ci.nodejs.org/job/node-test-pull-request/7522/ | https://ci.nodejs.org/job/node-test-pull-request/7522/ |
| #12518 | https://github.com/nodejs/node/pull/12518 |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 19, 2017 | https://github.com/nodejs/node/pull/12455#issuecomment-295483917 |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| https://ci.nodejs.org/job/node-test-pull-request/7538/ | https://ci.nodejs.org/job/node-test-pull-request/7538/ |
| https://ci.nodejs.org/job/node-test-pull-request/7539/ | https://ci.nodejs.org/job/node-test-pull-request/7539/ |
| https://ci.nodejs.org/job/node-test-pull-request/7540/ | https://ci.nodejs.org/job/node-test-pull-request/7540/ |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| April 20, 2017 03:51 | https://github.com/nodejs/node/pull/12455#commits-pushed-cbfa141 |
|
| https://github.com/vsemozhetbyt |
| benchmark: reduce string concatenations | https://github.com/nodejs/node/pull/12455/commits/cbfa1417e74b0344fdf5de14a8f8f5c5f84dcd37 |
| cbfa141 | https://github.com/nodejs/node/pull/12455/commits/cbfa1417e74b0344fdf5de14a8f8f5c5f84dcd37 |
|
| https://github.com/vsemozhetbyt |
| benchmark: add benchmark for string concatenations | https://github.com/nodejs/node/pull/12455/commits/3c800ef8c2428f6ed115004ddd8b7befb350c44e |
| 3c800ef | https://github.com/nodejs/node/pull/12455/commits/3c800ef8c2428f6ed115004ddd8b7befb350c44e |
|
| https://github.com/vsemozhetbyt |
| benchmark: fix URL in _http-benchmarkers.js | https://github.com/nodejs/node/pull/12455/commits/c61bdd70882ea5a23a7a0e6e0e5fb3bbdd4aa5fc |
| c61bdd7 | https://github.com/nodejs/node/pull/12455/commits/c61bdd70882ea5a23a7a0e6e0e5fb3bbdd4aa5fc |
|
| https://github.com/vsemozhetbyt |
| benchmark: fix typo in _http-benchmarkers.js | https://github.com/nodejs/node/pull/12455/commits/620a87c5aff1ea5972dca0bcdd5d7d1aed5f6acb |
| 620a87c | https://github.com/nodejs/node/pull/12455/commits/620a87c5aff1ea5972dca0bcdd5d7d1aed5f6acb |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Apr 20, 2017
| https://github.com/nodejs/node/pull/12455#ref-commit-22aa3d4 |
|
| https://github.com/vsemozhetbyt |
| benchmark: reduce string concatenations | https://github.com/nodejs/node/commit/22aa3d48997f1fc31e9c9cc08ec76a5436c93fe3 |
| 22aa3d4 | https://github.com/nodejs/node/commit/22aa3d48997f1fc31e9c9cc08ec76a5436c93fe3 |
| #12455 | https://github.com/nodejs/node/pull/12455 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Apr 20, 2017
| https://github.com/nodejs/node/pull/12455#ref-commit-3b1e837 |
|
| https://github.com/vsemozhetbyt |
| benchmark: add benchmark for string concatenations | https://github.com/nodejs/node/commit/3b1e837c270b4b540705b7c447db850e48cc2bf3 |
| 3b1e837 | https://github.com/nodejs/node/commit/3b1e837c270b4b540705b7c447db850e48cc2bf3 |
| #12455 | https://github.com/nodejs/node/pull/12455 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Apr 20, 2017
| https://github.com/nodejs/node/pull/12455#ref-commit-a3778cb |
|
| https://github.com/vsemozhetbyt |
| benchmark: fix URL in _http-benchmarkers.js | https://github.com/nodejs/node/commit/a3778cb9b1fcd91d06a449af5f6bd166f3d36bee |
| a3778cb | https://github.com/nodejs/node/commit/a3778cb9b1fcd91d06a449af5f6bd166f3d36bee |
| #12455 | https://github.com/nodejs/node/pull/12455 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Apr 20, 2017
| https://github.com/nodejs/node/pull/12455#ref-commit-d8965d5 |
|
| https://github.com/vsemozhetbyt |
| benchmark: fix typo in _http-benchmarkers.js | https://github.com/nodejs/node/commit/d8965d5b0ec57d628e11bba17d0ff14aad28bf78 |
| d8965d5 | https://github.com/nodejs/node/commit/d8965d5b0ec57d628e11bba17d0ff14aad28bf78 |
| #12455 | https://github.com/nodejs/node/pull/12455 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 20, 2017 | https://github.com/nodejs/node/pull/12455#issuecomment-295539205 |
| bbbb1f6...d8965d5 | https://github.com/nodejs/node/compare/bbbb1f6078...d8965d5b0e |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 20, 2017 | https://github.com/nodejs/node/pull/12455#event-1049700372 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| April 20, 2017 01:51 | https://github.com/nodejs/node/pull/12455#event-1049700449 |
| evanlucas | https://github.com/evanlucas |
|
Apr 25, 2017
| https://github.com/nodejs/node/pull/12455#ref-commit-ebc9593 |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/evanlucas |
| benchmark: add benchmark for string concatenations | https://github.com/nodejs/node/commit/ebc959389d0612c5e2e9ea28de6f6e8dc45f9ef7 |
| ebc9593 | https://github.com/nodejs/node/commit/ebc959389d0612c5e2e9ea28de6f6e8dc45f9ef7 |
| #12455 | https://github.com/nodejs/node/pull/12455 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Apr 28, 2017
| https://github.com/nodejs/node/pull/12455#ref-pullrequest-225209667 |
|
test: reduce string concatenations
#12735
| https://github.com/nodejs/node/pull/12735 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
May 1, 2017
| https://github.com/nodejs/node/pull/12455#ref-pullrequest-225452651 |
|
v7.10.0 proposal
#12775
| https://github.com/nodejs/node/pull/12775 |
| evanlucas | https://github.com/evanlucas |
|
May 1, 2017
| https://github.com/nodejs/node/pull/12455#ref-commit-ec32e01 |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/evanlucas |
| benchmark: add benchmark for string concatenations | https://github.com/nodejs/node/commit/ec32e01bb4de9ac0a1e887e824d408a0c662dafc |
| ec32e01 | https://github.com/nodejs/node/commit/ec32e01bb4de9ac0a1e887e824d408a0c662dafc |
| #12455 | https://github.com/nodejs/node/pull/12455 |
| evanlucas | https://github.com/evanlucas |
|
May 2, 2017
| https://github.com/nodejs/node/pull/12455#ref-commit-7d87edc |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/evanlucas |
| benchmark: add benchmark for string concatenations | https://github.com/nodejs/node/commit/7d87edc1ba7acc8290a508edd3970aa9244de6df |
| 7d87edc | https://github.com/nodejs/node/commit/7d87edc1ba7acc8290a508edd3970aa9244de6df |
| #12455 | https://github.com/nodejs/node/pull/12455 |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
May 5, 2017
| https://github.com/nodejs/node/pull/12455#ref-commit-8b76c3e |
|
| https://github.com/vsemozhetbyt |
| test: reduce string concatenations | https://github.com/nodejs/node/commit/8b76c3e60c7b5c274c757257580a2c0faae69097 |
| 8b76c3e | https://github.com/nodejs/node/commit/8b76c3e60c7b5c274c757257580a2c0faae69097 |
| #12735 | https://github.com/nodejs/node/pull/12735 |
| #12455 | https://github.com/nodejs/node/pull/12455 |
| anchnk | https://github.com/anchnk |
|
May 6, 2017
| https://github.com/nodejs/node/pull/12455#ref-commit-50d2298 |
|
| https://github.com/vsemozhetbyt |
| test: reduce string concatenations | https://github.com/anchnk/node/commit/50d22980f5ac4b0797ff3a34b5c6782b926611b3 |
| 50d2298 | https://github.com/anchnk/node/commit/50d22980f5ac4b0797ff3a34b5c6782b926611b3 |
| nodejs#12735 | https://github.com/nodejs/node/pull/12735 |
| nodejs#12455 | https://github.com/nodejs/node/pull/12455 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
baking-for-lts
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abaking-for-lts |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| May 16, 2017 | https://github.com/nodejs/node/pull/12455#event-1084069172 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 11, 2017
| https://github.com/nodejs/node/pull/12455#ref-pullrequest-219383958 |
|
8.0.0 Release Proposal
#12220
| https://github.com/nodejs/node/pull/12220 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 10, 2017
| https://github.com/nodejs/node/pull/12455#ref-commit-0dfb19d |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/MylesBorins |
| test: reduce string concatenations | https://github.com/nodejs/node/commit/0dfb19d6493e14a95f8376836b26dc0fceb5a6dd |
| 0dfb19d | https://github.com/nodejs/node/commit/0dfb19d6493e14a95f8376836b26dc0fceb5a6dd |
| #12735 | https://github.com/nodejs/node/pull/12735 |
| #12455 | https://github.com/nodejs/node/pull/12455 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 10, 2017
| https://github.com/nodejs/node/pull/12455#ref-commit-35b55bf |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/MylesBorins |
| test: reduce string concatenations | https://github.com/nodejs/node/commit/35b55bf3d6b13e06a1fea01cb17c1c5094aa86f7 |
| 35b55bf | https://github.com/nodejs/node/commit/35b55bf3d6b13e06a1fea01cb17c1c5094aa86f7 |
| #13835 | https://github.com/nodejs/node/pull/13835 |
| #12735 | https://github.com/nodejs/node/pull/12735 |
| #12455 | https://github.com/nodejs/node/pull/12455 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 11, 2017
| https://github.com/nodejs/node/pull/12455#ref-commit-5b74e63 |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/MylesBorins |
| test: reduce string concatenations | https://github.com/nodejs/node/commit/5b74e635e556eb4f3baa2898800e76567d3f3fca |
| 5b74e63 | https://github.com/nodejs/node/commit/5b74e635e556eb4f3baa2898800e76567d3f3fca |
| #13835 | https://github.com/nodejs/node/pull/13835 |
| #12735 | https://github.com/nodejs/node/pull/12735 |
| #12455 | https://github.com/nodejs/node/pull/12455 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
baking-for-lts
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abaking-for-lts |
| Aug 17, 2018 | https://github.com/nodejs/node/pull/12455#event-1795357308 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12455 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/12455/files/449c098012027504a1ea19dfbefcf006f16cee82 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/12455/files/449c098012027504a1ea19dfbefcf006f16cee82 |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/12455/files/449c098012027504a1ea19dfbefcf006f16cee82 |
|
| https://github.com/mscdex |
|
mscdex
| https://github.com/mscdex |
|
| https://github.com/nodejs/node/pull/12455/files/449c098012027504a1ea19dfbefcf006f16cee82 |
|
benchmark
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark |
| Please reload this page | https://github.com/nodejs/node/pull/12455 |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/mscdex |
|
| https://github.com/jasnell |
|
| https://github.com/benjamingr |
|
| https://github.com/joyeecheung |
|
| https://github.com/MylesBorins |
|
| https://github.com/gibfahn |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |