| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6fe50442-bb07-04cf-dc2c-f560d98640a0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A6A6:1DCD:D6F7A3:126A1D5:6992F1AE |
| html-safe-nonce | 80924685b2fcc3294acdca31a2f62291978a5c69d849ccfddf624f70bbb03b50 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNkE2OjFEQ0Q6RDZGN0EzOjEyNkExRDU6Njk5MkYxQUUiLCJ2aXNpdG9yX2lkIjoiNDM0NTUwOTY1MjU3MTgxMjI3MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e8ea79ebabc85a02fc14538b506fe8b784bafaa316a9b1ad889602f4cee0007e |
| hovercard-subject-tag | pull_request:116047936 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/12437/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/aa41dda4767ef2fcc751436c004ffd364b88834a3ef6f0dae445786da21e150a/nodejs/node/pull/12437 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/aa41dda4767ef2fcc751436c004ffd364b88834a3ef6f0dae445786da21e150a/nodejs/node/pull/12437 |
| og:image:alt | Our docs contain a mixture of make -j4, make -j8, and make without
a -j option at all.
Standardize on not specifying a -j option, but include information in
BUILDING.md (where people are likely to ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 01ab16879a3159e6f0717ab948b9b562e162a6aafd1f4393b786b07b747df244 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b1570f3928bef80fa5fc7890ce0942e9b696ad9d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/12437#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12437 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12437 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/12437 |
| Reload | https://github.com/nodejs/node/pull/12437 |
| Reload | https://github.com/nodejs/node/pull/12437 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/12437 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.7k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
714
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:makeflags | https://github.com/Trott/io.js/tree/makeflags |
| Conversation | https://github.com/nodejs/node/pull/12437 |
| Commits1 (1) | https://github.com/nodejs/node/pull/12437/commits |
| Checks | https://github.com/nodejs/node/pull/12437/checks |
| Files changed | https://github.com/nodejs/node/pull/12437/files |
| doc: consolidate -j information for make | https://github.com/nodejs/node/pull/12437#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:makeflags | https://github.com/Trott/io.js/tree/makeflags |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Apr 16, 2017 | https://github.com/nodejs/node/pull/12437#issue-221989207 |
| Please reload this page | https://github.com/nodejs/node/pull/12437 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/12437 |
|
| https://github.com/Trott |
| doc: consolidate -j information for make | https://github.com/nodejs/node/pull/12437/commits/22c6fa0234c2d5e11d67eecd9d57a7c29de2d1e5 |
| 22c6fa0 | https://github.com/nodejs/node/pull/12437/commits/22c6fa0234c2d5e11d67eecd9d57a7c29de2d1e5 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Apr 16, 2017 | https://github.com/nodejs/node/pull/12437#event-1044269660 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
| Apr 16, 2017 | https://github.com/nodejs/node/pull/12437#event-1044269675 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
Apr 16, 2017
| https://github.com/nodejs/node/pull/12437#pullrequestreview-32938579 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12437/files/22c6fa0234c2d5e11d67eecd9d57a7c29de2d1e5 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Apr 16, 2017 | https://github.com/nodejs/node/pull/12437#issuecomment-294341224 |
| Please reload this page | https://github.com/nodejs/node/pull/12437 |
| @Trott | https://github.com/Trott |
| #9961 | https://github.com/nodejs/node/pull/9961 |
| #8286 | https://github.com/nodejs/node/issues/8286 |
| Please reload this page | https://github.com/nodejs/node/pull/12437 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Apr 16, 2017
| https://github.com/nodejs/node/pull/12437#ref-pullrequest-221927241 |
|
doc: run tests before landing changes
#12416
| https://github.com/nodejs/node/pull/12416 |
| https://github.com/ghost |
| ghost | https://github.com/ghost |
|
Apr 16, 2017
| https://github.com/nodejs/node/pull/12437#pullrequestreview-32943780 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12437/files/22c6fa0234c2d5e11d67eecd9d57a7c29de2d1e5 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Apr 17, 2017
| https://github.com/nodejs/node/pull/12437#pullrequestreview-33027856 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12437/files/22c6fa0234c2d5e11d67eecd9d57a7c29de2d1e5 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Apr 18, 2017 | https://github.com/nodejs/node/pull/12437#issuecomment-294957307 |
| Please reload this page | https://github.com/nodejs/node/pull/12437 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Apr 18, 2017 | https://github.com/nodejs/node/pull/12437#event-1047313791 |
| https://github.com/chrismilleruk |
| chrismilleruk | https://github.com/chrismilleruk |
|
Apr 11, 2018
| https://github.com/nodejs/node/pull/12437#ref-issue-313034460 |
|
doc: make test commands a little more consistent
#19919
| https://github.com/nodejs/node/issues/19919 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| January 13, 2022 22:45 | https://github.com/nodejs/node/pull/12437#event-5890945901 |
| https://github.com/baby636 |
| baby636 | https://github.com/baby636 |
|
Jun 22, 2022
| https://github.com/nodejs/node/pull/12437#ref-pullrequest-1279752484 |
|
[Snyk] Security upgrade eslint from 5.16.0 to 6.6.0
baby636/node#59
| https://github.com/baby636/node/pull/59 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12437 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/12437/files/22c6fa0234c2d5e11d67eecd9d57a7c29de2d1e5 |
|
| https://github.com/thefourtheye |
|
thefourtheye
| https://github.com/thefourtheye |
|
| https://github.com/nodejs/node/pull/12437/files/22c6fa0234c2d5e11d67eecd9d57a7c29de2d1e5 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
| Please reload this page | https://github.com/nodejs/node/pull/12437 |
|
| https://github.com/Trott |
|
| https://github.com/gibfahn |
|
| https://github.com/jasnell |
|
| https://github.com/thefourtheye |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |