| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8429578f-1b1d-ce84-9264-54e940d6715e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D870:25FEA8:1CB832E:2848E49:696A53B5 |
| html-safe-nonce | 61c399a177521bb09fe397956bf6183e57f37f275150248bce9fea7fe9c4a64c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODcwOjI1RkVBODoxQ0I4MzJFOjI4NDhFNDk6Njk2QTUzQjUiLCJ2aXNpdG9yX2lkIjoiNDAwNDQ5MDUzMzQ2MTk3MTg5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2c498ae01956c90f4724551236740edff3d8ca71d466ca6bb880934cf96af527 |
| hovercard-subject-tag | pull_request:115879260 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/12409/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4ffbe1a17fe905a3496dcbfa31c8cf59e57625f3b3762797c48f2329cfbfece9/nodejs/node/pull/12409 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4ffbe1a17fe905a3496dcbfa31c8cf59e57625f3b3762797c48f2329cfbfece9/nodejs/node/pull/12409 |
| og:image:alt | Improved test coverage for napi_make_callback by porting the
existing addons/make_callback test to napi
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | digitalinfinity |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 63c426b30d262aba269ef14c40e3c817b384cd61 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/12409#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12409 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12409 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/12409 |
| Reload | https://github.com/nodejs/node/pull/12409 |
| Reload | https://github.com/nodejs/node/pull/12409 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/12409#issue-comment-box |
| digitalinfinity | https://github.com/digitalinfinity |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| digitalinfinity:napi_makecb_test | https://github.com/digitalinfinity/node/tree/napi_makecb_test |
|
n-api: port test for make_callback
| https://github.com/nodejs/node/pull/12409#top |
| digitalinfinity | https://github.com/digitalinfinity |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| digitalinfinity:napi_makecb_test | https://github.com/digitalinfinity/node/tree/napi_makecb_test |
|
Conversation
38
| https://github.com/nodejs/node/pull/12409 |
|
Commits
1
| https://github.com/nodejs/node/pull/12409/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/12409/checks |
|
Files changed
| https://github.com/nodejs/node/pull/12409/files |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/digitalinfinity |
| digitalinfinity | https://github.com/digitalinfinity |
| Apr 14, 2017 | https://github.com/nodejs/node/pull/12409#issue-221733754 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Apr 14, 2017 | https://github.com/nodejs/node/pull/12409#event-1042907104 |
| https://github.com/digitalinfinity |
| digitalinfinity | https://github.com/digitalinfinity |
| Apr 14, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-294077189 |
| @jasongin | https://github.com/jasongin |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/16073c083efdcaf70aef1e490679457dd0f624bd..fbe946bb6316f1e1083ec47baaf812fc98d60f00 |
| 16073c0 | https://github.com/nodejs/node/commit/16073c083efdcaf70aef1e490679457dd0f624bd |
| fbe946b | https://github.com/nodejs/node/commit/fbe946bb6316f1e1083ec47baaf812fc98d60f00 |
|
Compare
| https://github.com/nodejs/node/compare/16073c083efdcaf70aef1e490679457dd0f624bd..fbe946bb6316f1e1083ec47baaf812fc98d60f00 |
| April 14, 2017 04:12 | https://github.com/nodejs/node/pull/12409#event-1042929061 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 14, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-294109563 |
| https://ci.nodejs.org/job/node-test-pull-request/7395/ | https://ci.nodejs.org/job/node-test-pull-request/7395/ |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/digitalinfinity |
| digitalinfinity | https://github.com/digitalinfinity |
| Apr 14, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-294111538 |
| @vsemozhetbyt | https://github.com/vsemozhetbyt |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Apr 14, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-294112846 |
| https://ci.nodejs.org/job/node-test-pull-request/7396/ | https://ci.nodejs.org/job/node-test-pull-request/7396/ |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Apr 14, 2017
| https://github.com/nodejs/node/pull/12409#pullrequestreview-32812913 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12409/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/12409#pullrequestreview-32812913 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| test/addons-napi/test_make_callback/binding.cc | https://github.com/nodejs/node/pull/12409/files#diff-17c66751a674cb22e945551ad035632402132e62179cd9db4bb9bf05a22e46c8 |
| addaleax | https://github.com/addaleax |
| Apr 14, 2017 | https://github.com/nodejs/node/pull/12409#discussion_r111558267 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| digitalinfinity | https://github.com/digitalinfinity |
| Apr 14, 2017 | https://github.com/nodejs/node/pull/12409#discussion_r111602790 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Apr 14, 2017 | https://github.com/nodejs/node/pull/12409#event-1043196754 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Apr 14, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-294134235 |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Apr 14, 2017
| https://github.com/nodejs/node/pull/12409#pullrequestreview-32831610 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12409/files |
| https://github.com/digitalinfinity |
| digitalinfinity | https://github.com/digitalinfinity |
| Apr 14, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-294192863 |
| @addaleax | https://github.com/addaleax |
| @benjamingr | https://github.com/benjamingr |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Apr 14, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-294193223 |
| @digitalinfinity | https://github.com/digitalinfinity |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/digitalinfinity |
| digitalinfinity | https://github.com/digitalinfinity |
| force-pushed | https://github.com/nodejs/node/compare/b77207ac41da50c1939013f0eda7e086754d6e6c..ed5a502f3c8d2ad866951d4d652d900d380f0cba |
| b77207a | https://github.com/nodejs/node/commit/b77207ac41da50c1939013f0eda7e086754d6e6c |
| ed5a502 | https://github.com/nodejs/node/commit/ed5a502f3c8d2ad866951d4d652d900d380f0cba |
|
Compare
| https://github.com/nodejs/node/compare/b77207ac41da50c1939013f0eda7e086754d6e6c..ed5a502f3c8d2ad866951d4d652d900d380f0cba |
| April 14, 2017 21:28 | https://github.com/nodejs/node/pull/12409#event-1043822134 |
| https://github.com/digitalinfinity |
| digitalinfinity | https://github.com/digitalinfinity |
| Apr 14, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-294240364 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/digitalinfinity |
| digitalinfinity | https://github.com/digitalinfinity |
| force-pushed | https://github.com/nodejs/node/compare/ed5a502f3c8d2ad866951d4d652d900d380f0cba..a8808931e23928624caddf52d6760b4926fd0336 |
| ed5a502 | https://github.com/nodejs/node/commit/ed5a502f3c8d2ad866951d4d652d900d380f0cba |
| a880893 | https://github.com/nodejs/node/commit/a8808931e23928624caddf52d6760b4926fd0336 |
|
Compare
| https://github.com/nodejs/node/compare/ed5a502f3c8d2ad866951d4d652d900d380f0cba..a8808931e23928624caddf52d6760b4926fd0336 |
| April 14, 2017 23:23 | https://github.com/nodejs/node/pull/12409#event-1043908103 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Apr 17, 2017
| https://github.com/nodejs/node/pull/12409#pullrequestreview-33100627 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12409/files |
| jasnell | https://github.com/jasnell |
|
Apr 17, 2017
| https://github.com/nodejs/node/pull/12409#ref-commit-70b51c8 |
|
| https://github.com/digitalinfinity |
|
| https://github.com/jasnell |
| test: port test for make_callback to n-api | https://github.com/nodejs/node/commit/70b51c8cc32f87dd016c02ac72fd998fa54e2f06 |
| 70b51c8 | https://github.com/nodejs/node/commit/70b51c8cc32f87dd016c02ac72fd998fa54e2f06 |
| #12409 | https://github.com/nodejs/node/pull/12409 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-294607463 |
| 70b51c8 | https://github.com/nodejs/node/commit/70b51c8cc32f87dd016c02ac72fd998fa54e2f06 |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12409#event-1045651708 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12409#event-1045710049 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-294619742 |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 17, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-294629420 |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Apr 27, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-297811090 |
| @digitalinfinity | https://github.com/digitalinfinity |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Apr 29, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-298201201 |
| https://ci.nodejs.org/job/node-test-commit/9514/ | https://ci.nodejs.org/job/node-test-commit/9514/ |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Apr 30, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-298202789 |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Apr 30, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-298205127 |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Apr 30, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-298207178 |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/digitalinfinity |
| digitalinfinity | https://github.com/digitalinfinity |
| May 4, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-299318890 |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/digitalinfinity |
| digitalinfinity | https://github.com/digitalinfinity |
| force-pushed | https://github.com/nodejs/node/compare/a8808931e23928624caddf52d6760b4926fd0336..3d917f9061b6b18908902b2a1d6da4bedfcebe85 |
| a880893 | https://github.com/nodejs/node/commit/a8808931e23928624caddf52d6760b4926fd0336 |
| 3d917f9 | https://github.com/nodejs/node/commit/3d917f9061b6b18908902b2a1d6da4bedfcebe85 |
|
Compare
| https://github.com/nodejs/node/compare/a8808931e23928624caddf52d6760b4926fd0336..3d917f9061b6b18908902b2a1d6da4bedfcebe85 |
| May 5, 2017 01:41 | https://github.com/nodejs/node/pull/12409#event-1069922986 |
| https://github.com/digitalinfinity |
| digitalinfinity | https://github.com/digitalinfinity |
| May 5, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-299352302 |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/refack |
| refack | https://github.com/refack |
| May 5, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-299374695 |
| https://ci.nodejs.org/job/node-test-commit/9652/ | https://ci.nodejs.org/job/node-test-commit/9652/ |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/digitalinfinity |
| digitalinfinity | https://github.com/digitalinfinity |
| May 5, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-299534088 |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
|
| https://github.com/digitalinfinity |
| test: port test for make_callback to n-api | https://github.com/nodejs/node/pull/12409/commits/7372a5c77d8969ecb94514246bb62691f6583b6c |
| 7372a5c | https://github.com/nodejs/node/pull/12409/commits/7372a5c77d8969ecb94514246bb62691f6583b6c |
| https://github.com/digitalinfinity |
| digitalinfinity | https://github.com/digitalinfinity |
| force-pushed | https://github.com/nodejs/node/compare/3d917f9061b6b18908902b2a1d6da4bedfcebe85..7372a5c77d8969ecb94514246bb62691f6583b6c |
| 3d917f9 | https://github.com/nodejs/node/commit/3d917f9061b6b18908902b2a1d6da4bedfcebe85 |
| 7372a5c | https://github.com/nodejs/node/commit/7372a5c77d8969ecb94514246bb62691f6583b6c |
|
Compare
| https://github.com/nodejs/node/compare/3d917f9061b6b18908902b2a1d6da4bedfcebe85..7372a5c77d8969ecb94514246bb62691f6583b6c |
| May 5, 2017 18:21 | https://github.com/nodejs/node/pull/12409#event-1071021645 |
| https://github.com/digitalinfinity |
| digitalinfinity | https://github.com/digitalinfinity |
| May 5, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-299539922 |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/kunalspathak |
| kunalspathak | https://github.com/kunalspathak |
| May 5, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-299541681 |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://ci.nodejs.org/job/node-test-pull-request/7904/ | https://ci.nodejs.org/job/node-test-pull-request/7904/ |
| https://ci.nodejs.org/job/node-test-pull-request/7905/ | https://ci.nodejs.org/job/node-test-pull-request/7905/ |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/seishun |
| seishun | https://github.com/seishun |
| May 5, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-299541782 |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/refack |
| refack | https://github.com/refack |
| May 5, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-299544979 |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/digitalinfinity |
| digitalinfinity | https://github.com/digitalinfinity |
| May 5, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-299591332 |
| @kunalspathak | https://github.com/kunalspathak |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/refack |
| refack | https://github.com/refack |
| May 6, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-299639958 |
| @jasnell | https://github.com/jasnell |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| May 6, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-299644589 |
| @refack | https://github.com/refack |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| refack | https://github.com/refack |
|
May 6, 2017
| https://github.com/nodejs/node/pull/12409#ref-commit-73d9c0f |
|
| https://github.com/digitalinfinity |
|
| https://github.com/refack |
| test: port test for make_callback to n-api | https://github.com/refack/node/commit/73d9c0f903ae371cd5011af64c3a6f69a1bda978 |
| 73d9c0f | https://github.com/refack/node/commit/73d9c0f903ae371cd5011af64c3a6f69a1bda978 |
| nodejs#12409 | https://github.com/nodejs/node/pull/12409 |
| https://github.com/refack |
| refack | https://github.com/refack |
| May 6, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-299650661 |
| 73d9c0f | https://github.com/nodejs/node/commit/73d9c0f903ae371cd5011af64c3a6f69a1bda978 |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/refack |
| refack | https://github.com/refack |
| May 6, 2017 | https://github.com/nodejs/node/pull/12409#event-1071619872 |
| https://github.com/refack |
| refack | https://github.com/refack |
| May 6, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-299650712 |
| https://ci.nodejs.org/job/node-test-commit/9698/ | https://ci.nodejs.org/job/node-test-commit/9698/ |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| https://github.com/joaocgreis |
| joaocgreis | https://github.com/joaocgreis |
| May 9, 2017 | https://github.com/nodejs/node/pull/12409#issuecomment-300132917 |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
| anchnk | https://github.com/anchnk |
|
May 19, 2017
| https://github.com/nodejs/node/pull/12409#ref-commit-799c596 |
|
| https://github.com/digitalinfinity |
| test: port test for make_callback to n-api | https://github.com/anchnk/node/commit/799c596bbb4a4137ca2c04ac8d2e20f1b004b66d |
| 799c596 | https://github.com/anchnk/node/commit/799c596bbb4a4137ca2c04ac8d2e20f1b004b66d |
| nodejs#12409 | https://github.com/nodejs/node/pull/12409 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 11, 2017
| https://github.com/nodejs/node/pull/12409#ref-pullrequest-219383958 |
|
8.0.0 Release Proposal
#12220
| https://github.com/nodejs/node/pull/12220 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Apr 10, 2018
| https://github.com/nodejs/node/pull/12409#ref-commit-476b4ff |
|
| https://github.com/digitalinfinity |
| test: port test for make_callback to n-api | https://github.com/gabrielschulhof/node/commit/476b4ff9a9fddd5cc5dd91098a099687b8e8f3f4 |
| 476b4ff | https://github.com/gabrielschulhof/node/commit/476b4ff9a9fddd5cc5dd91098a099687b8e8f3f4 |
| nodejs#12409 | https://github.com/nodejs/node/pull/12409 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Apr 10, 2018
| https://github.com/nodejs/node/pull/12409#ref-commit-ed2ef69 |
|
| https://github.com/digitalinfinity |
| test: port test for make_callback to n-api | https://github.com/gabrielschulhof/node/commit/ed2ef69c55fd2a5ea40a2086820dde1278b294e7 |
| ed2ef69 | https://github.com/gabrielschulhof/node/commit/ed2ef69c55fd2a5ea40a2086820dde1278b294e7 |
| nodejs#12409 | https://github.com/nodejs/node/pull/12409 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 16, 2018
| https://github.com/nodejs/node/pull/12409#ref-commit-a003777 |
|
| https://github.com/digitalinfinity |
|
| https://github.com/MylesBorins |
| test: port test for make_callback to n-api | https://github.com/nodejs/node/commit/a003777d96c3b0308de4c33bbc5b4c3d902b4e88 |
| a003777 | https://github.com/nodejs/node/commit/a003777d96c3b0308de4c33bbc5b4c3d902b4e88 |
| #19447 | https://github.com/nodejs/node/pull/19447 |
| #12409 | https://github.com/nodejs/node/pull/12409 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 16, 2018
| https://github.com/nodejs/node/pull/12409#ref-commit-dd7665a |
|
| https://github.com/digitalinfinity |
|
| https://github.com/MylesBorins |
| test: port test for make_callback to n-api | https://github.com/nodejs/node/commit/dd7665a68eabf4d10e8fb33e8a1cca1db27dbfd5 |
| dd7665a | https://github.com/nodejs/node/commit/dd7665a68eabf4d10e8fb33e8a1cca1db27dbfd5 |
| #19447 | https://github.com/nodejs/node/pull/19447 |
| #12409 | https://github.com/nodejs/node/pull/12409 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 16, 2018
| https://github.com/nodejs/node/pull/12409#ref-pullrequest-313968187 |
|
v6.14.2 proposal
#19996
| https://github.com/nodejs/node/pull/19996 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12409 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/12409/files/a8808931e23928624caddf52d6760b4926fd0336 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/12409/files/b77207ac41da50c1939013f0eda7e086754d6e6c |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/12409/files/b77207ac41da50c1939013f0eda7e086754d6e6c |
|
| https://github.com/refack |
|
refack
| https://github.com/refack |
|
| https://github.com/nodejs/node/pull/12409/files/a8808931e23928624caddf52d6760b4926fd0336 |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/12409 |
|
| https://github.com/digitalinfinity |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/addaleax |
|
| https://github.com/jasnell |
|
| https://github.com/mhdawson |
|
| https://github.com/refack |
|
| https://github.com/benjamingr |
|
| https://github.com/kunalspathak |
|
| https://github.com/seishun |
|
| https://github.com/joaocgreis |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |