| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:bfef70ca-b54a-2693-c1f7-9a771800f5e5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B98A:166D49:11D06CB:189445A:696A8DDF |
| html-safe-nonce | 8af65877857bc1515a504483a372e56747160702dd5e2f38b85304867eeeb926 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOThBOjE2NkQ0OToxMUQwNkNCOjE4OTQ0NUE6Njk2QThEREYiLCJ2aXNpdG9yX2lkIjoiMzIxMzQyODU0MDQ2MzI4Nzc3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 35131d832043c71911a68276b2e292797c06ff34cad36e022e453a628b8b8a02 |
| hovercard-subject-tag | pull_request:114995179 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/12293/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/aa41dda4767ef2fcc751436c004ffd364b88834a3ef6f0dae445786da21e150a/nodejs/node/pull/12293 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/aa41dda4767ef2fcc751436c004ffd364b88834a3ef6f0dae445786da21e150a/nodejs/node/pull/12293 |
| og:image:alt | First commit:
assert.fail() has two possible function signatures, both of which are
not intuitive. It virtually guarantees that people who try to use
assert.fail() without carefully reading the doc... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | d2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c1dbca8981c5e3d6a69bce2f1d289e732b86241d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/12293#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12293 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12293 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/12293 |
| Reload | https://github.com/nodejs/node/pull/12293 |
| Reload | https://github.com/nodejs/node/pull/12293 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/12293#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:assert-fail-fix | https://github.com/Trott/io.js/tree/assert-fail-fix |
|
assert.fail() accept a single argument or two arguments
| https://github.com/nodejs/node/pull/12293#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:assert-fail-fix | https://github.com/Trott/io.js/tree/assert-fail-fix |
|
Conversation
30
| https://github.com/nodejs/node/pull/12293 |
|
Commits
3
| https://github.com/nodejs/node/pull/12293/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/12293/checks |
|
Files changed
| https://github.com/nodejs/node/pull/12293/files |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Apr 9, 2017 | https://github.com/nodejs/node/pull/12293#issue-220487143 |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
assert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Apr 9, 2017 | https://github.com/nodejs/node/pull/12293#event-1035542243 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
assert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Apr 9, 2017 | https://github.com/nodejs/node/pull/12293#event-1035542252 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Apr 9, 2017
| https://github.com/nodejs/node/pull/12293#ref-pullrequest-220442834 |
|
tools: replace custom assert.fail lint rule
#12287
| https://github.com/nodejs/node/pull/12287 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Apr 9, 2017 | https://github.com/nodejs/node/pull/12293#issuecomment-292801677 |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Apr 9, 2017 | https://github.com/nodejs/node/pull/12293#issuecomment-292802038 |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Apr 9, 2017 | https://github.com/nodejs/node/pull/12293#issuecomment-292802316 |
| https://ci.nodejs.org/job/node-test-pull-request/7294/ | https://ci.nodejs.org/job/node-test-pull-request/7294/ |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| https://github.com/aqrln |
| aqrln | https://github.com/aqrln |
| Apr 9, 2017 | https://github.com/nodejs/node/pull/12293#issuecomment-292802538 |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Apr 9, 2017 | https://github.com/nodejs/node/pull/12293#issuecomment-292803271 |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Apr 9, 2017 | https://github.com/nodejs/node/pull/12293#issuecomment-292803712 |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Apr 9, 2017 | https://github.com/nodejs/node/pull/12293#issuecomment-292804302 |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Apr 9, 2017 | https://github.com/nodejs/node/pull/12293#issuecomment-292808518 |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Apr 9, 2017 | https://github.com/nodejs/node/pull/12293#issuecomment-292811826 |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/5ee2e1f871523f8a2514e4b5ab28a235ab35bfe9..9ce64f3f6737eeaeda0d2c2da3dd55b1dc0f4efd |
| 5ee2e1f | https://github.com/nodejs/node/commit/5ee2e1f871523f8a2514e4b5ab28a235ab35bfe9 |
| 9ce64f3 | https://github.com/nodejs/node/commit/9ce64f3f6737eeaeda0d2c2da3dd55b1dc0f4efd |
|
Compare
| https://github.com/nodejs/node/compare/5ee2e1f871523f8a2514e4b5ab28a235ab35bfe9..9ce64f3f6737eeaeda0d2c2da3dd55b1dc0f4efd |
| April 9, 2017 20:48 | https://github.com/nodejs/node/pull/12293#event-1035589829 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Apr 9, 2017 | https://github.com/nodejs/node/pull/12293#issuecomment-292811909 |
| @aqrln | https://github.com/aqrln |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| https://github.com/refack |
| refack | https://github.com/refack |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Apr 9, 2017 | https://github.com/nodejs/node/pull/12293#event-1035590634 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Apr 10, 2017
| https://github.com/nodejs/node/pull/12293#pullrequestreview-31883508 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12293/files |
| lib/assert.js | https://github.com/nodejs/node/pull/12293/files#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f |
| addaleax | https://github.com/addaleax |
| Apr 10, 2017 | https://github.com/nodejs/node/pull/12293#discussion_r110693535 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| Trott | https://github.com/Trott |
| Apr 11, 2017 | https://github.com/nodejs/node/pull/12293#discussion_r110811539 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| test/parallel/test-assert-fail.js | https://github.com/nodejs/node/pull/12293/files#diff-78591e25325bcc391fd677b770f66a94a611990ea9ff67d372717280f0a55b02 |
| addaleax | https://github.com/addaleax |
| Apr 10, 2017 | https://github.com/nodejs/node/pull/12293#discussion_r110693773 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| Trott | https://github.com/Trott |
| Apr 11, 2017 | https://github.com/nodejs/node/pull/12293#discussion_r110811580 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/9ce64f3f6737eeaeda0d2c2da3dd55b1dc0f4efd..d86a5534b2cfca7300b778a94b329f87c2ce7d11 |
| 9ce64f3 | https://github.com/nodejs/node/commit/9ce64f3f6737eeaeda0d2c2da3dd55b1dc0f4efd |
| d86a553 | https://github.com/nodejs/node/commit/d86a5534b2cfca7300b778a94b329f87c2ce7d11 |
|
Compare
| https://github.com/nodejs/node/compare/9ce64f3f6737eeaeda0d2c2da3dd55b1dc0f4efd..d86a5534b2cfca7300b778a94b329f87c2ce7d11 |
| April 11, 2017 04:11 | https://github.com/nodejs/node/pull/12293#event-1037601864 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Apr 11, 2017
| https://github.com/nodejs/node/pull/12293#ref-pullrequest-219383958 |
|
8.0.0 Release Proposal
#12220
| https://github.com/nodejs/node/pull/12220 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Apr 12, 2017
| https://github.com/nodejs/node/pull/12293#pullrequestreview-32316988 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12293/files |
| https://github.com/targos |
| targos | https://github.com/targos |
|
ctc-review
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Actc-review |
| Apr 12, 2017 | https://github.com/nodejs/node/pull/12293#event-1039768162 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Apr 12, 2017
| https://github.com/nodejs/node/pull/12293#pullrequestreview-32342593 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/12293/files |
| Trott | https://github.com/Trott |
| April 12, 2017 13:35 | https://github.com/nodejs/node/pull/12293#commits-pushed-e4e98ba |
|
| https://github.com/Trott |
| assert: improve assert.fail() API | https://github.com/nodejs/node/pull/12293/commits/e4e98ba7e8ff3118973a1f9516fe16c0c7b8e19a |
| e4e98ba | https://github.com/nodejs/node/pull/12293/commits/e4e98ba7e8ff3118973a1f9516fe16c0c7b8e19a |
|
| https://github.com/Trott |
| tools: remove assert.fail() lint rule | https://github.com/nodejs/node/pull/12293/commits/00bbb98aa99821100ff231a7c2e521b4a7afce8b |
| 00bbb98 | https://github.com/nodejs/node/pull/12293/commits/00bbb98aa99821100ff231a7c2e521b4a7afce8b |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Sep 19, 2017 | https://github.com/nodejs/node/pull/12293#issuecomment-330639817 |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Sep 19, 2017 | https://github.com/nodejs/node/pull/12293#issuecomment-330651680 |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
| Sep 19, 2017 | https://github.com/nodejs/node/pull/12293#issuecomment-330652878 |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Sep 19, 2017
| https://github.com/nodejs/node/pull/12293#ref-pullrequest-244866731 |
|
[v6.x backport] doc,assert: document stackStartFunction in fail
#14427
| https://github.com/nodejs/node/pull/14427 |
| https://github.com/refack |
| refack | https://github.com/refack |
| Sep 19, 2017 | https://github.com/nodejs/node/pull/12293#issuecomment-330659928 |
| @BridgeAR | https://github.com/BridgeAR |
| #14427 | https://github.com/nodejs/node/pull/14427 |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Sep 19, 2017
| https://github.com/nodejs/node/pull/12293#ref-pullrequest-258985407 |
|
[v6.x backport] assert.fail() accept a single argument or two arguments
#15479
| https://github.com/nodejs/node/pull/15479 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 19, 2017 | https://github.com/nodejs/node/pull/12293#issuecomment-330693435 |
| #15479 | https://github.com/nodejs/node/pull/15479 |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
| Trott | https://github.com/Trott |
|
Sep 29, 2017
| https://github.com/nodejs/node/pull/12293#ref-commit-d25b8de |
|
| https://github.com/Trott |
| assert: improve assert.fail() API | https://github.com/Trott/io.js/commit/d25b8de37c478bcf8d5df8912c7bc4e6c8e666bc |
| d25b8de | https://github.com/Trott/io.js/commit/d25b8de37c478bcf8d5df8912c7bc4e6c8e666bc |
| nodejs#12293 | https://github.com/nodejs/node/pull/12293 |
| Trott | https://github.com/Trott |
|
Sep 29, 2017
| https://github.com/nodejs/node/pull/12293#ref-commit-7c10194 |
|
| https://github.com/Trott |
| tools: remove assert.fail() lint rule | https://github.com/Trott/io.js/commit/7c10194299694fb29c4c6b0a00d6d5041419e42c |
| 7c10194 | https://github.com/Trott/io.js/commit/7c10194299694fb29c4c6b0a00d6d5041419e42c |
| nodejs#12293 | https://github.com/nodejs/node/pull/12293 |
| Trott | https://github.com/Trott |
|
Sep 29, 2017
| https://github.com/nodejs/node/pull/12293#ref-commit-e5b11f8 |
|
| https://github.com/Trott |
| test: remove common.fail() | https://github.com/Trott/io.js/commit/e5b11f812efadc5025013337da12a79490ff9ae6 |
| e5b11f8 | https://github.com/Trott/io.js/commit/e5b11f812efadc5025013337da12a79490ff9ae6 |
| nodejs#12293 | https://github.com/nodejs/node/pull/12293 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
backported-to-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v6.x |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Oct 10, 2017 | https://github.com/nodejs/node/pull/12293#event-1286028705 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 10, 2017
| https://github.com/nodejs/node/pull/12293#ref-commit-ddae3ca |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| assert: improve assert.fail() API | https://github.com/nodejs/node/commit/ddae3ca8595d7841acaa03a73016a5b8c9d2777a |
| ddae3ca | https://github.com/nodejs/node/commit/ddae3ca8595d7841acaa03a73016a5b8c9d2777a |
| #15479 | https://github.com/nodejs/node/pull/15479 |
| #12293 | https://github.com/nodejs/node/pull/12293 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 10, 2017
| https://github.com/nodejs/node/pull/12293#ref-commit-8eab173 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| tools: remove assert.fail() lint rule | https://github.com/nodejs/node/commit/8eab17308ec432b3bdedce63dfc385aaa78e7ff6 |
| 8eab173 | https://github.com/nodejs/node/commit/8eab17308ec432b3bdedce63dfc385aaa78e7ff6 |
| #15479 | https://github.com/nodejs/node/pull/15479 |
| #12293 | https://github.com/nodejs/node/pull/12293 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 10, 2017
| https://github.com/nodejs/node/pull/12293#ref-commit-ae485a7 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: remove common.fail() | https://github.com/nodejs/node/commit/ae485a7add138c01d0af3f94a4bb4b21c575f16a |
| ae485a7 | https://github.com/nodejs/node/commit/ae485a7add138c01d0af3f94a4bb4b21c575f16a |
| #15479 | https://github.com/nodejs/node/pull/15479 |
| #12293 | https://github.com/nodejs/node/pull/12293 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 17, 2017
| https://github.com/nodejs/node/pull/12293#ref-pullrequest-266277912 |
|
v6.12.0 proposal
#16263
| https://github.com/nodejs/node/pull/16263 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 25, 2017
| https://github.com/nodejs/node/pull/12293#ref-commit-4917d8c |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| assert: improve assert.fail() API | https://github.com/nodejs/node/commit/4917d8cfef828b77bdd8f15cb4cdb7f5ee6babb3 |
| 4917d8c | https://github.com/nodejs/node/commit/4917d8cfef828b77bdd8f15cb4cdb7f5ee6babb3 |
| #15479 | https://github.com/nodejs/node/pull/15479 |
| #12293 | https://github.com/nodejs/node/pull/12293 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 25, 2017
| https://github.com/nodejs/node/pull/12293#ref-commit-44cc39d |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| tools: remove assert.fail() lint rule | https://github.com/nodejs/node/commit/44cc39d278b20ec94b8516ee084350970cc5ea28 |
| 44cc39d | https://github.com/nodejs/node/commit/44cc39d278b20ec94b8516ee084350970cc5ea28 |
| #15479 | https://github.com/nodejs/node/pull/15479 |
| #12293 | https://github.com/nodejs/node/pull/12293 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 25, 2017
| https://github.com/nodejs/node/pull/12293#ref-commit-1091b86 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: remove common.fail() | https://github.com/nodejs/node/commit/1091b862900d69e340aa17d46ba191a3737d65a6 |
| 1091b86 | https://github.com/nodejs/node/commit/1091b862900d69e340aa17d46ba191a3737d65a6 |
| #15479 | https://github.com/nodejs/node/pull/15479 |
| #12293 | https://github.com/nodejs/node/pull/12293 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 3, 2017
| https://github.com/nodejs/node/pull/12293#ref-pullrequest-268557105 |
|
v4.8.6 proposal
#16500
| https://github.com/nodejs/node/pull/16500 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 6, 2017
| https://github.com/nodejs/node/pull/12293#ref-commit-c6a2ec5 |
|
| https://github.com/MylesBorins |
| 2017-11-07, Version 6.12.0 'Boron' (LTS) | https://github.com/nodejs/node/commit/c6a2ec5a408cb5d32f0dce161288be7a837c6943 |
| c6a2ec5 | https://github.com/nodejs/node/commit/c6a2ec5a408cb5d32f0dce161288be7a837c6943 |
| #12293 | https://github.com/nodejs/node/pull/12293 |
| #11705 | https://github.com/nodejs/node/pull/11705 |
| #16691 | https://github.com/nodejs/node/pull/16691 |
| #15745 | https://github.com/nodejs/node/pull/15745 |
| #14866 | https://github.com/nodejs/node/pull/14866 |
| #14117 | https://github.com/nodejs/node/pull/14117 |
| #13306 | https://github.com/nodejs/node/pull/13306 |
| #7856 | https://github.com/nodejs/node/pull/7856 |
| #12615 | https://github.com/nodejs/node/pull/12615 |
| #10116 | https://github.com/nodejs/node/pull/10116 |
| #12028 | https://github.com/nodejs/node/pull/12028 |
| #13932 | https://github.com/nodejs/node/pull/13932 |
| #13172 | https://github.com/nodejs/node/pull/13172 |
| #12677 | https://github.com/nodejs/node/pull/12677 |
| #12293 | https://github.com/nodejs/node/pull/12293 |
| #16263 | https://github.com/nodejs/node/pull/16263 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 7, 2017
| https://github.com/nodejs/node/pull/12293#ref-commit-70dc6d5 |
|
| https://github.com/MylesBorins |
| 2017-11-07, Version 6.12.0 'Boron' (LTS) | https://github.com/nodejs/node/commit/70dc6d5072023b9746c98361d34a60658c5fe9c3 |
| 70dc6d5 | https://github.com/nodejs/node/commit/70dc6d5072023b9746c98361d34a60658c5fe9c3 |
| #12293 | https://github.com/nodejs/node/pull/12293 |
| #11705 | https://github.com/nodejs/node/pull/11705 |
| #16691 | https://github.com/nodejs/node/pull/16691 |
| #15745 | https://github.com/nodejs/node/pull/15745 |
| #14866 | https://github.com/nodejs/node/pull/14866 |
| #14117 | https://github.com/nodejs/node/pull/14117 |
| #13306 | https://github.com/nodejs/node/pull/13306 |
| #7856 | https://github.com/nodejs/node/pull/7856 |
| #12615 | https://github.com/nodejs/node/pull/12615 |
| #10116 | https://github.com/nodejs/node/pull/10116 |
| #12028 | https://github.com/nodejs/node/pull/12028 |
| #13932 | https://github.com/nodejs/node/pull/13932 |
| #13172 | https://github.com/nodejs/node/pull/13172 |
| #12677 | https://github.com/nodejs/node/pull/12677 |
| #12293 | https://github.com/nodejs/node/pull/12293 |
| #16263 | https://github.com/nodejs/node/pull/16263 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| January 13, 2022 22:45 | https://github.com/nodejs/node/pull/12293#event-5890945919 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12293 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/12293/files/d86a5534b2cfca7300b778a94b329f87c2ce7d11 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/12293/files/9ce64f3f6737eeaeda0d2c2da3dd55b1dc0f4efd |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/12293/files/d86a5534b2cfca7300b778a94b329f87c2ce7d11 |
|
assert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/12293 |
|
| https://github.com/Trott |
|
| https://github.com/refack |
|
| https://github.com/aqrln |
|
| https://github.com/gibfahn |
|
| https://github.com/sam-github |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
|
| https://github.com/BridgeAR |
|
| https://github.com/jasnell |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |