René's URL Explorer Experiment


Title: test: fix misleading comment by fhinkel · Pull Request #12048 · nodejs/node · GitHub

Open Graph Title: test: fix misleading comment by fhinkel · Pull Request #12048 · nodejs/node

X Title: test: fix misleading comment by fhinkel · Pull Request #12048 · nodejs/node

Description: Tiny cleanup. The comment is outdated, function declarations have nothing to do with defineProperties. Checklist commit message follows commit guidelines Affected core subsystem(s) test

Open Graph Description: Tiny cleanup. The comment is outdated, function declarations have nothing to do with defineProperties. Checklist commit message follows commit guidelines Affected core subsystem(s) test

X Description: Tiny cleanup. The comment is outdated, function declarations have nothing to do with defineProperties. Checklist commit message follows commit guidelines Affected core subsystem(s) test

Opengraph URL: https://github.com/nodejs/node/pull/12048

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a49b545b-c2cd-4dbf-8307-88fbf6c470ae
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8E90:95B65:C638B6:10E2D38:6969EFD8
html-safe-nonce67a181ee0e310a62e264cb3bca1282e8eb36db8fbb3220641ebfb812ea08edc0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTkwOjk1QjY1OkM2MzhCNjoxMEUyRDM4OjY5NjlFRkQ4IiwidmlzaXRvcl9pZCI6IjM2Njc4NjM4NjMyNjA1NjkyMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca6c743af2793d297ec967287605c963df03bb8cf46ac7cfe82ba86c956c55b4a
hovercard-subject-tagpull_request:112620678
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/12048/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7be9d17ea44c4d5aff56c4febf236af23ffd6b7ba32c698b55bb987836cb9291/nodejs/node/pull/12048
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7be9d17ea44c4d5aff56c4febf236af23ffd6b7ba32c698b55bb987836cb9291/nodejs/node/pull/12048
og:image:altTiny cleanup. The comment is outdated, function declarations have nothing to do with defineProperties. Checklist commit message follows commit guidelines Affected core subsystem(s) test
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefhinkel
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/12048#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12048
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12048
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/12048
Reloadhttps://github.com/nodejs/node/pull/12048
Reloadhttps://github.com/nodejs/node/pull/12048
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/12048
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/12048
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/12048#issue-comment-box
fhinkelhttps://github.com/fhinkel
nodejs:masterhttps://github.com/nodejs/node/tree/master
fhinkel:fix-comment-in-vm-testhttps://github.com/fhinkel/node/tree/fix-comment-in-vm-test
test: fix misleading comment https://github.com/nodejs/node/pull/12048#top
fhinkelhttps://github.com/fhinkel
nodejs:masterhttps://github.com/nodejs/node/tree/master
fhinkel:fix-comment-in-vm-testhttps://github.com/fhinkel/node/tree/fix-comment-in-vm-test
Conversation 2 https://github.com/nodejs/node/pull/12048
Commits 1 https://github.com/nodejs/node/pull/12048/commits
Checks 0 https://github.com/nodejs/node/pull/12048/checks
Files changed https://github.com/nodejs/node/pull/12048/files
Please reload this pagehttps://github.com/nodejs/node/pull/12048
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Mar 26, 2017https://github.com/nodejs/node/pull/12048#issue-217039288
commit guidelineshttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/12048
https://github.com/fhinkel
test: fix misleading commenthttps://github.com/nodejs/node/pull/12048/commits/3be5bc7fce1d982d13855cbba434f08033188197
3be5bc7https://github.com/nodejs/node/pull/12048/commits/3be5bc7fce1d982d13855cbba434f08033188197
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Mar 26, 2017https://github.com/nodejs/node/pull/12048#event-1015617906
https://github.com/hiroppy
hiroppyhttps://github.com/hiroppy
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
Mar 26, 2017https://github.com/nodejs/node/pull/12048#event-1015620138
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Mar 26, 2017 https://github.com/nodejs/node/pull/12048#pullrequestreview-29069229
View reviewed changes https://github.com/nodejs/node/pull/12048/files/3be5bc7fce1d982d13855cbba434f08033188197
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Mar 26, 2017 https://github.com/nodejs/node/pull/12048#pullrequestreview-29071339
View reviewed changes https://github.com/nodejs/node/pull/12048/files/3be5bc7fce1d982d13855cbba434f08033188197
https://github.com/targos
targoshttps://github.com/targos
Mar 26, 2017 https://github.com/nodejs/node/pull/12048#pullrequestreview-29071394
View reviewed changes https://github.com/nodejs/node/pull/12048/files/3be5bc7fce1d982d13855cbba434f08033188197
https://github.com/hiroppy
hiroppyhttps://github.com/hiroppy
Mar 26, 2017 https://github.com/nodejs/node/pull/12048#pullrequestreview-29074636
View reviewed changes https://github.com/nodejs/node/pull/12048/files/3be5bc7fce1d982d13855cbba434f08033188197
https://github.com/hiroppy
hiroppyhttps://github.com/hiroppy
Mar 26, 2017https://github.com/nodejs/node/pull/12048#issuecomment-289299672
https://ci.nodejs.org/job/node-test-pull-request/7044/https://ci.nodejs.org/job/node-test-pull-request/7044/
Please reload this pagehttps://github.com/nodejs/node/pull/12048
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 26, 2017 https://github.com/nodejs/node/pull/12048#pullrequestreview-29077534
View reviewed changes https://github.com/nodejs/node/pull/12048/files/3be5bc7fce1d982d13855cbba434f08033188197
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Mar 28, 2017https://github.com/nodejs/node/pull/12048#issuecomment-289828697
fd18243https://github.com/nodejs/node/commit/fd18243a50cba987063187b3ff95a2407ed348fa
Please reload this pagehttps://github.com/nodejs/node/pull/12048
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Mar 28, 2017https://github.com/nodejs/node/pull/12048#event-1018906059
fhinkelhttps://github.com/fhinkel
Mar 28, 2017 https://github.com/nodejs/node/pull/12048#ref-commit-fd18243
https://github.com/fhinkel
test: fix misleading commenthttps://github.com/nodejs/node/commit/fd18243a50cba987063187b3ff95a2407ed348fa
fd18243https://github.com/nodejs/node/commit/fd18243a50cba987063187b3ff95a2407ed348fa
#12048https://github.com/nodejs/node/pull/12048
MylesBorinshttps://github.com/MylesBorins
Mar 28, 2017 https://github.com/nodejs/node/pull/12048#ref-commit-d8b71be
https://github.com/fhinkel
https://github.com/MylesBorins
test: fix misleading commenthttps://github.com/nodejs/node/commit/d8b71be1836db18c18793841f2debdf5bde494eb
d8b71behttps://github.com/nodejs/node/commit/d8b71be1836db18c18793841f2debdf5bde494eb
#12048https://github.com/nodejs/node/pull/12048
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 28, 2017 https://github.com/nodejs/node/pull/12048#ref-pullrequest-217725272
V7.8.0 proposal #12104 https://github.com/nodejs/node/pull/12104
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
Apr 10, 2017 https://github.com/nodejs/node/pull/12048#ref-pullrequest-220788961
v7.9.0 Release Proposal #12319 https://github.com/nodejs/node/pull/12319
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x
Apr 18, 2017https://github.com/nodejs/node/pull/12048#event-1047590983
MylesBorinshttps://github.com/MylesBorins
Apr 18, 2017 https://github.com/nodejs/node/pull/12048#ref-commit-c33e4af
https://github.com/fhinkel
https://github.com/MylesBorins
test: fix misleading commenthttps://github.com/nodejs/node/commit/c33e4af12cca95f5b2ef04efc49cb873c1ec5e33
c33e4afhttps://github.com/nodejs/node/commit/c33e4af12cca95f5b2ef04efc49cb873c1ec5e33
#12048https://github.com/nodejs/node/pull/12048
MylesBorinshttps://github.com/MylesBorins
Apr 19, 2017 https://github.com/nodejs/node/pull/12048#ref-commit-eb19acb
https://github.com/fhinkel
https://github.com/MylesBorins
test: fix misleading commenthttps://github.com/nodejs/node/commit/eb19acb84e5cb2c6ef81df67c7699c4452d096dd
eb19acbhttps://github.com/nodejs/node/commit/eb19acb84e5cb2c6ef81df67c7699c4452d096dd
#12048https://github.com/nodejs/node/pull/12048
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 19, 2017 https://github.com/nodejs/node/pull/12048#ref-pullrequest-222580733
v6.10.3 proposal #12498 https://github.com/nodejs/node/pull/12498
andrew749https://github.com/andrew749
Jul 19, 2017 https://github.com/nodejs/node/pull/12048#ref-commit-304cf29
https://github.com/fhinkel
https://github.com/andrew749
test: fix misleading commenthttps://github.com/michielbaird/node/commit/304cf298a6abf99370ffd522a776633c1013221d
304cf29https://github.com/michielbaird/node/commit/304cf298a6abf99370ffd522a776633c1013221d
nodejs/node#12048https://github.com/nodejs/node/pull/12048
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F12048
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/12048/files/3be5bc7fce1d982d13855cbba434f08033188197
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/12048/files/3be5bc7fce1d982d13855cbba434f08033188197
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/12048/files/3be5bc7fce1d982d13855cbba434f08033188197
https://github.com/hiroppy
hiroppy https://github.com/hiroppy
https://github.com/nodejs/node/pull/12048/files/3be5bc7fce1d982d13855cbba434f08033188197
https://github.com/gibfahn
gibfahn https://github.com/gibfahn
https://github.com/nodejs/node/pull/12048/files/3be5bc7fce1d982d13855cbba434f08033188197
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
Please reload this pagehttps://github.com/nodejs/node/pull/12048
https://github.com/fhinkel
https://github.com/hiroppy
https://github.com/jasnell
https://github.com/targos
https://github.com/cjihrig
https://github.com/gibfahn
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.