René's URL Explorer Experiment


Title: buffer: add buf.mask for ws by chrisdickinson · Pull Request #1202 · nodejs/node · GitHub

Open Graph Title: buffer: add buf.mask for ws by chrisdickinson · Pull Request #1202 · nodejs/node

X Title: buffer: add buf.mask for ws by chrisdickinson · Pull Request #1202 · nodejs/node

Description: This patch adds buf.mask(maskValue, targetBuffer, targetOffset, sourceStart, sourceEnd), needed by the ws package for masking and unmasking websocket frames. The original implementation is here. It is implemented as a partially unrolled loop, operating on 32-bit values and dealing with the 0-3 byte remainder at the end – I'm not sure if we want to retain this optimization, since the sourceStart and targetOffset params make it possible to trigger non-8-byte-aligned copies. I didn't implement Unmask: it should be equivalent to buf.mask(mask, buf). Merge is also omitted. I'll have another PR up for Utf8Validate tomorrow. R=@trevnorris, @piscisaureus

Open Graph Description: This patch adds buf.mask(maskValue, targetBuffer, targetOffset, sourceStart, sourceEnd), needed by the ws package for masking and unmasking websocket frames. The original implementation is here. It...

X Description: This patch adds buf.mask(maskValue, targetBuffer, targetOffset, sourceStart, sourceEnd), needed by the ws package for masking and unmasking websocket frames. The original implementation is here. It...

Opengraph URL: https://github.com/nodejs/node/pull/1202

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:68add96f-5cde-0acf-a4a5-a823ad09c70d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC3C:2F339D:96270C:C7C0CD:6AED2E60
html-safe-nonce6a5cf893c4023c50fc4117b0b8bcf0379349f59ed41567f66b05592180a4aa59
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzNDOjJGMzM5RDo5NjI3MEM6QzdDMENEOjZBRUQyRTYwIiwidmlzaXRvcl9pZCI6Ijc4MTYyNzAxNzMyODE1Mjk0NDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6d56b9bb2b161a56672e3d6809353741c19aebfe5f8fc865c5afda163ada567e
hovercard-subject-tagpull_request:31506599
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/1202/files
twitter:imagehttps://avatars.githubusercontent.com/u/37303?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/37303?s=400&v=4
og:image:altThis patch adds buf.mask(maskValue, targetBuffer, targetOffset, sourceStart, sourceEnd), needed by the ws package for masking and unmasking websocket frames. The original implementation is here. It...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/1202/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1202%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1202%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/1202/files
Reloadhttps://github.com/nodejs/node/pull/1202/files
Reloadhttps://github.com/nodejs/node/pull/1202/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
chrisdickinsonhttps://github.com/chrisdickinson
nodejs:v1.xhttps://github.com/nodejs/node/tree/v1.x
Conversation 33 https://github.com/nodejs/node/pull/1202
Commits 8 https://github.com/nodejs/node/pull/1202/commits
Checks 0 https://github.com/nodejs/node/pull/1202/checks
Files changed https://github.com/nodejs/node/pull/1202/files
Please reload this pagehttps://github.com/nodejs/node/pull/1202/files
buffer: add buf.mask for ws https://github.com/nodejs/node/pull/1202/files#top
Show all changes 8 commits https://github.com/nodejs/node/pull/1202/files
914dc46 initial commit chrisdickinson Mar 19, 2015 https://github.com/nodejs/node/pull/1202/commits/914dc465bccf55b8dc039f4a05225f371188ea42
3e425fc rework to adhere more closely to buf.copy chrisdickinson Mar 19, 2015 https://github.com/nodejs/node/pull/1202/commits/3e425fcc87ca3b89394a650e5d83910a58e8e762
7bf9a2d test style fixes chrisdickinson Mar 19, 2015 https://github.com/nodejs/node/pull/1202/commits/7bf9a2dfaef0e7ab2fb09c25c89aa2b509e08d4b
e92f4b7 fixup whitespace chrisdickinson Mar 19, 2015 https://github.com/nodejs/node/pull/1202/commits/e92f4b7a47e663a03563cfef1617e8de386a725a
7ef29ac document and add rough tests for return value chrisdickinson Mar 19, 2015 https://github.com/nodejs/node/pull/1202/commits/7ef29aca42e02b7e2ed887d66daf88fc60e5832c
fb4ac8a test: nix cleverness chrisdickinson Mar 19, 2015 https://github.com/nodejs/node/pull/1202/commits/fb4ac8a628fe673a8dc90db94105a3fd7e2eaa71
0f7b918 src: move to union to avoid pointer aliasing chrisdickinson Mar 19, 2015 https://github.com/nodejs/node/pull/1202/commits/0f7b918126881f11eaed49ca0ad79fe856844ef3
8c72550 src: fix style chrisdickinson Mar 19, 2015 https://github.com/nodejs/node/pull/1202/commits/8c72550a0f5ea369485c9015c96f3070394a2eb2
Clear filters https://github.com/nodejs/node/pull/1202/files
Please reload this pagehttps://github.com/nodejs/node/pull/1202/files
Please reload this pagehttps://github.com/nodejs/node/pull/1202/files
buffer.markdown https://github.com/nodejs/node/pull/1202/files#diff-3189ab514bcaa7854e04fde65c8e83d0590ad8b3457724e0f56621f31377b284
node_buffer.cc https://github.com/nodejs/node/pull/1202/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
test-buffer-mask.js https://github.com/nodejs/node/pull/1202/files#diff-58bca3d2c0235c36b77934a96848dddf7bf0633d47e8b1d0314f7078674c4c90
doc/api/buffer.markdownhttps://github.com/nodejs/node/pull/1202/files#diff-3189ab514bcaa7854e04fde65c8e83d0590ad8b3457724e0f56621f31377b284
View file https://github.com/nodejs/node/blob/8c72550a0f5ea369485c9015c96f3070394a2eb2/doc/api/buffer.markdown
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/1202/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/1202/files#diff-3189ab514bcaa7854e04fde65c8e83d0590ad8b3457724e0f56621f31377b284
https://github.com/nodejs/node/pull/1202/files#diff-3189ab514bcaa7854e04fde65c8e83d0590ad8b3457724e0f56621f31377b284
src/node_buffer.cchttps://github.com/nodejs/node/pull/1202/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
View file https://github.com/nodejs/node/blob/8c72550a0f5ea369485c9015c96f3070394a2eb2/src/node_buffer.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/1202/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/1202/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
https://github.com/nodejs/node/pull/1202/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
https://github.com/nodejs/node/pull/1202/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
bnoordhuishttps://github.com/bnoordhuis
Mar 25, 2015https://github.com/nodejs/node/pull/1202/files#r27114319
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1202/files
bnoordhuishttps://github.com/bnoordhuis
Mar 19, 2015https://github.com/nodejs/node/pull/1202/files#r26743089
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1202/files
chrisdickinsonhttps://github.com/chrisdickinson
Mar 19, 2015https://github.com/nodejs/node/pull/1202/files#r26777876
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
buffer.copyhttps://github.com/iojs/io.js/blob/v1.x/src/node_buffer.cc#L303
Please reload this pagehttps://github.com/nodejs/node/pull/1202/files
bnoordhuishttps://github.com/bnoordhuis
Mar 19, 2015https://github.com/nodejs/node/pull/1202/files#r26779537
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1202/files
bnoordhuishttps://github.com/bnoordhuis
Mar 25, 2015https://github.com/nodejs/node/pull/1202/files#r27114588
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1202/files
bnoordhuishttps://github.com/bnoordhuis
Mar 25, 2015https://github.com/nodejs/node/pull/1202/files#r27114730
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1202/files
bnoordhuishttps://github.com/bnoordhuis
Mar 25, 2015https://github.com/nodejs/node/pull/1202/files#r27114806
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1202/files
https://github.com/nodejs/node/pull/1202/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
https://github.com/nodejs/node/pull/1202/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
https://github.com/nodejs/node/pull/1202/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
test/parallel/test-buffer-mask.jshttps://github.com/nodejs/node/pull/1202/files#diff-58bca3d2c0235c36b77934a96848dddf7bf0633d47e8b1d0314f7078674c4c90
View file https://github.com/nodejs/node/blob/8c72550a0f5ea369485c9015c96f3070394a2eb2/test/parallel/test-buffer-mask.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/1202/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.