René's URL Explorer Experiment


Title: buffer: add buf.mask for ws by chrisdickinson · Pull Request #1202 · nodejs/node · GitHub

Open Graph Title: buffer: add buf.mask for ws by chrisdickinson · Pull Request #1202 · nodejs/node

X Title: buffer: add buf.mask for ws by chrisdickinson · Pull Request #1202 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This patch adds buf.mask(maskValue, targetBuffer, targetOffset, sourceStart, sourceEnd), needed by the ws package for masking and unmasking websocket frames. The original implementation is here. It...

X Description: This patch adds buf.mask(maskValue, targetBuffer, targetOffset, sourceStart, sourceEnd), needed by the ws package for masking and unmasking websocket frames. The original implementation is here. It...

Opengraph URL: https://github.com/nodejs/node/pull/1202

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7dd5b96c-d730-5107-c2aa-9f17e81c277c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8E22:36D84F:461972:5E085D:6AED16B5
html-safe-nonce127c407f46f74dd954966b900a76ada588bdfe7ac26698aa3b0f487faf593ad4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTIyOjM2RDg0Rjo0NjE5NzI6NUUwODVEOjZBRUQxNkI1IiwidmlzaXRvcl9pZCI6Ijc4ODM3ODM0ODU3NjE4NTMxMDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf5005ccc3f93397fbd352b4859ac1a6203d182423c6a6bba6c83a75928fe4611
hovercard-subject-tagpull_request:31506599
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1202/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cd3b57692ca5366f7082eee2ca1928140eab39cb3d305ad388d36b29782476c2/nodejs/node/pull/1202
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cd3b57692ca5366f7082eee2ca1928140eab39cb3d305ad388d36b29782476c2/nodejs/node/pull/1202
og:image:altThis patch adds buf.mask(maskValue, targetBuffer, targetOffset, sourceStart, sourceEnd), needed by the ws package for masking and unmasking websocket frames. The original implementation is here. It...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamechrisdickinson
hostnamegithub.com
expected-hostnamegithub.com
None120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee12fd03aa775dceadc5a793c3a0791e43ca256bb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/1202#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1202
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1202
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/1202
Reloadhttps://github.com/nodejs/node/pull/1202
Reloadhttps://github.com/nodejs/node/pull/1202
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
chrisdickinsonhttps://github.com/chrisdickinson
nodejs:v1.xhttps://github.com/nodejs/node/tree/v1.x
Conversationhttps://github.com/nodejs/node/pull/1202
Commits8 (8)https://github.com/nodejs/node/pull/1202/commits
Checkshttps://github.com/nodejs/node/pull/1202/checks
Files changedhttps://github.com/nodejs/node/pull/1202/files
buffer: add buf.mask for wshttps://github.com/nodejs/node/pull/1202#top
chrisdickinsonhttps://github.com/chrisdickinson
nodejs:v1.xhttps://github.com/nodejs/node/tree/v1.x
https://github.com/chrisdickinson
chrisdickinsonhttps://github.com/chrisdickinson
Mar 19, 2015https://github.com/nodejs/node/pull/1202#issue-62927791
maskinghttps://github.com/websockets/ws/blob/ac283f0368375e674fa370cd4b64cef42add2968/lib/Sender.js#L194
herehttps://github.com/websockets/bufferutil/blob/3bbb6f23193fae7683b61e2cae1f85ede5fb4469/src/bufferutil.cc#L85
Unmaskhttps://github.com/websockets/bufferutil/blob/3bbb6f23193fae7683b61e2cae1f85ede5fb4469/src/bufferutil.cc#L64
Mergehttps://github.com/websockets/bufferutil/blob/3bbb6f23193fae7683b61e2cae1f85ede5fb4469/src/bufferutil.cc#L46
Utf8Validatehttps://github.com/websockets/utf-8-validate/blob/master/src/validation.cc
@trevnorrishttps://github.com/trevnorris
@piscisaureushttps://github.com/piscisaureus
Please reload this pagehttps://github.com/nodejs/node/pull/1202
chrisdickinsonhttps://github.com/chrisdickinson
March 18, 2015 20:48https://github.com/nodejs/node/pull/1202#commits-pushed-914dc46
https://github.com/chrisdickinson
initial commithttps://github.com/nodejs/node/pull/1202/commits/914dc465bccf55b8dc039f4a05225f371188ea42
914dc46https://github.com/nodejs/node/pull/1202/commits/914dc465bccf55b8dc039f4a05225f371188ea42
https://github.com/chrisdickinson
rework to adhere more closely to buf.copyhttps://github.com/nodejs/node/pull/1202/commits/3e425fcc87ca3b89394a650e5d83910a58e8e762
3e425fchttps://github.com/nodejs/node/pull/1202/commits/3e425fcc87ca3b89394a650e5d83910a58e8e762
https://github.com/chrisdickinson
test style fixeshttps://github.com/nodejs/node/pull/1202/commits/7bf9a2dfaef0e7ab2fb09c25c89aa2b509e08d4b
7bf9a2dhttps://github.com/nodejs/node/pull/1202/commits/7bf9a2dfaef0e7ab2fb09c25c89aa2b509e08d4b
https://github.com/chrisdickinson
fixup whitespacehttps://github.com/nodejs/node/pull/1202/commits/e92f4b7a47e663a03563cfef1617e8de386a725a
e92f4b7https://github.com/nodejs/node/pull/1202/commits/e92f4b7a47e663a03563cfef1617e8de386a725a
https://github.com/chrisdickinson
document and add rough tests for return valuehttps://github.com/nodejs/node/pull/1202/commits/7ef29aca42e02b7e2ed887d66daf88fc60e5832c
7ef29achttps://github.com/nodejs/node/pull/1202/commits/7ef29aca42e02b7e2ed887d66daf88fc60e5832c
https://github.com/chrisdickinson
chrisdickinsonhttps://github.com/chrisdickinson
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Mar 19, 2015https://github.com/nodejs/node/pull/1202#event-259138839
bnoordhuishttps://github.com/bnoordhuis
Mar 19, 2015 https://github.com/nodejs/node/pull/1202#discussion-diff-26741907
View reviewed changes https://github.com/nodejs/node/pull/1202/files/7ef29aca42e02b7e2ed887d66daf88fc60e5832c#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
src/node_buffer.cchttps://github.com/nodejs/node/pull/1202/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
bnoordhuishttps://github.com/bnoordhuis
Mar 19, 2015https://github.com/nodejs/node/pull/1202#discussion_r26741907
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1202
piscisaureushttps://github.com/piscisaureus
Mar 19, 2015https://github.com/nodejs/node/pull/1202#discussion_r26795084
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/1202
bnoordhuishttps://github.com/bnoordhuis
Mar 19, 2015https://github.com/nodejs/node/pull/1202#discussion_r26796912
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1202
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Mar 19, 2015https://github.com/nodejs/node/pull/1202#issuecomment-83603525
Please reload this pagehttps://github.com/nodejs/node/pull/1202
trevnorrishttps://github.com/trevnorris
Mar 19, 2015 https://github.com/nodejs/node/pull/1202#discussion-diff-26771652
View reviewed changes https://github.com/nodejs/node/pull/1202/files/7ef29aca42e02b7e2ed887d66daf88fc60e5832c#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
src/node_buffer.cchttps://github.com/nodejs/node/pull/1202/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
trevnorrishttps://github.com/trevnorris
Mar 19, 2015https://github.com/nodejs/node/pull/1202#discussion_r26771652
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1202
chrisdickinsonhttps://github.com/chrisdickinson
Mar 19, 2015https://github.com/nodejs/node/pull/1202#discussion_r26777955
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
buffer.copyhttps://github.com/iojs/io.js/blob/v1.x/src/node_buffer.cc#L306
Please reload this pagehttps://github.com/nodejs/node/pull/1202
trevnorrishttps://github.com/trevnorris
Mar 19, 2015https://github.com/nodejs/node/pull/1202#discussion_r26784876
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1202
chrisdickinsonhttps://github.com/chrisdickinson
Mar 19, 2015https://github.com/nodejs/node/pull/1202#discussion_r26808064
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1202
trevnorrishttps://github.com/trevnorris
Mar 19, 2015https://github.com/nodejs/node/pull/1202#discussion_r26808693
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1202
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Mar 19, 2015 https://github.com/nodejs/node/pull/1202#ref-issue-59362433
Ship websockets in core #1010 https://github.com/nodejs/node/issues/1010
chrisdickinsonhttps://github.com/chrisdickinson
March 19, 2015 12:54https://github.com/nodejs/node/pull/1202#commits-pushed-fb4ac8a
https://github.com/chrisdickinson
test: nix clevernesshttps://github.com/nodejs/node/pull/1202/commits/fb4ac8a628fe673a8dc90db94105a3fd7e2eaa71
fb4ac8ahttps://github.com/nodejs/node/pull/1202/commits/fb4ac8a628fe673a8dc90db94105a3fd7e2eaa71
https://github.com/chrisdickinson
src: move to union to avoid pointer aliasinghttps://github.com/nodejs/node/pull/1202/commits/0f7b918126881f11eaed49ca0ad79fe856844ef3
0f7b918https://github.com/nodejs/node/pull/1202/commits/0f7b918126881f11eaed49ca0ad79fe856844ef3
https://github.com/chrisdickinson
src: fix stylehttps://github.com/nodejs/node/pull/1202/commits/8c72550a0f5ea369485c9015c96f3070394a2eb2
8c72550https://github.com/nodejs/node/pull/1202/commits/8c72550a0f5ea369485c9015c96f3070394a2eb2
https://github.com/chrisdickinson
chrisdickinsonhttps://github.com/chrisdickinson
Mar 19, 2015https://github.com/nodejs/node/pull/1202#issuecomment-83803444
@3rd-Edenhttps://github.com/3rd-Eden
Please reload this pagehttps://github.com/nodejs/node/pull/1202
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Mar 23, 2015https://github.com/nodejs/node/pull/1202#issuecomment-85050359
@chrisdickinsonhttps://github.com/chrisdickinson
#1010 (comment)https://github.com/nodejs/node/issues/1010#issuecomment-85048624
Please reload this pagehttps://github.com/nodejs/node/pull/1202
https://github.com/chrisdickinson
chrisdickinsonhttps://github.com/chrisdickinson
Mar 23, 2015https://github.com/nodejs/node/pull/1202#issuecomment-85161248
@Fishrock123https://github.com/Fishrock123
@3rd-Edenhttps://github.com/3rd-Eden
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/1202
https://github.com/theturtle32
theturtle32https://github.com/theturtle32
Mar 25, 2015https://github.com/nodejs/node/pull/1202#issuecomment-85769095
websocket modulehttps://github.com/theturtle32/WebSocket-Node
comment on iojs/io.js#1010https://github.com/iojs/io.js/issues/1010#issuecomment-85237198
Please reload this pagehttps://github.com/nodejs/node/pull/1202
bnoordhuishttps://github.com/bnoordhuis
Mar 25, 2015 https://github.com/nodejs/node/pull/1202#discussion-diff-27114319
View reviewed changes https://github.com/nodejs/node/pull/1202/files/8c72550a0f5ea369485c9015c96f3070394a2eb2#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
src/node_buffer.cchttps://github.com/nodejs/node/pull/1202/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
bnoordhuishttps://github.com/bnoordhuis
Mar 25, 2015https://github.com/nodejs/node/pull/1202#discussion_r27114319
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/1202
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Mar 25, 2015https://github.com/nodejs/node/pull/1202#issuecomment-86001732
#1010https://github.com/nodejs/node/issues/1010
@theturtle32https://github.com/theturtle32
Please reload this pagehttps://github.com/nodejs/node/pull/1202
https://github.com/chrisdickinson
chrisdickinsonhttps://github.com/chrisdickinson
Mar 25, 2015https://github.com/nodejs/node/pull/1202#issuecomment-86174755
@theturtle32https://github.com/theturtle32
Please reload this pagehttps://github.com/nodejs/node/pull/1202
https://github.com/theturtle32
theturtle32https://github.com/theturtle32
Mar 25, 2015https://github.com/nodejs/node/pull/1202#issuecomment-86204304
@bnoordhuishttps://github.com/bnoordhuis
@chrisdickinsonhttps://github.com/chrisdickinson
@3rd-Edenhttps://github.com/3rd-Eden
websockethttps://github.com/theturtle32/WebSocket-Node
Please reload this pagehttps://github.com/nodejs/node/pull/1202
https://github.com/3rd-Eden
3rd-Edenhttps://github.com/3rd-Eden
Mar 25, 2015https://github.com/nodejs/node/pull/1202#issuecomment-86210676
@theturtle32https://github.com/theturtle32
Please reload this pagehttps://github.com/nodejs/node/pull/1202
https://github.com/3rd-Eden
3rd-Edenhttps://github.com/3rd-Eden
Mar 25, 2015https://github.com/nodejs/node/pull/1202#issuecomment-86211458
Please reload this pagehttps://github.com/nodejs/node/pull/1202
https://github.com/theturtle32
theturtle32https://github.com/theturtle32
Mar 25, 2015https://github.com/nodejs/node/pull/1202#issuecomment-86215515
@3rd-Edenhttps://github.com/3rd-Eden
Please reload this pagehttps://github.com/nodejs/node/pull/1202
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1202
Please reload this pagehttps://github.com/nodejs/node/pull/1202
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Please reload this pagehttps://github.com/nodejs/node/pull/1202
https://github.com/chrisdickinson
https://github.com/Fishrock123
https://github.com/theturtle32
https://github.com/bnoordhuis
https://github.com/3rd-Eden
https://github.com/piscisaureus
https://github.com/trevnorris
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.