| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:433ab094-3b83-61e0-38f1-295d8ed1f015 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A402:C9E9C:2CF070:3F98DD:696A07E8 |
| html-safe-nonce | f1a6d9292b2153e37de8daf19eec4e2d1869c5d921ad5732217b824e7f62ac66 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDAyOkM5RTlDOjJDRjA3MDozRjk4REQ6Njk2QTA3RTgiLCJ2aXNpdG9yX2lkIjoiNzEwMjg1NDc1Mzg0NTI2ODI0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | bea443af964b2c590faad28677cfb66fe7b0687b9d6082df946b9623c69be46e |
| hovercard-subject-tag | pull_request:112018467 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/11989/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/82f2b9ce6336de40379f44943a13a0b959628207d72c50200fca71663e322788/nodejs/node/pull/11989 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/82f2b9ce6336de40379f44943a13a0b959628207d72c50200fca71663e322788/nodejs/node/pull/11989 |
| og:image:alt | Add tests of internal/socket_list.js and increase its coverage.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows com... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | DavidCai1111 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 671c2f67171dbced24284331f3133a613d08c366 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/11989#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11989 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11989 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/11989 |
| Reload | https://github.com/nodejs/node/pull/11989 |
| Reload | https://github.com/nodejs/node/pull/11989 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/11989 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/11989 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/11989#issue-comment-box |
| DavidCai1111 | https://github.com/DavidCai1111 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| DavidCai1111:test/socket-list | https://github.com/DavidCai1111/node/tree/test/socket-list |
|
test: add internal/socket_list tests
| https://github.com/nodejs/node/pull/11989#top |
| DavidCai1111 | https://github.com/DavidCai1111 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| DavidCai1111:test/socket-list | https://github.com/DavidCai1111/node/tree/test/socket-list |
|
Conversation
5
| https://github.com/nodejs/node/pull/11989 |
|
Commits
1
| https://github.com/nodejs/node/pull/11989/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/11989/checks |
|
Files changed
| https://github.com/nodejs/node/pull/11989/files |
| Please reload this page | https://github.com/nodejs/node/pull/11989 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/DavidCai1111 |
| DavidCai1111 | https://github.com/DavidCai1111 |
| Mar 22, 2017 | https://github.com/nodejs/node/pull/11989#issue-216077139 |
| commit guidelines | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/11989 |
|
| https://github.com/davidtaikocha |
| test: add internal/socket_list tests | https://github.com/nodejs/node/pull/11989/commits/0341c1b2fa48ef81436083f85756da9b89cd2b70 |
| 0341c1b | https://github.com/nodejs/node/pull/11989/commits/0341c1b2fa48ef81436083f85756da9b89cd2b70 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Mar 22, 2017 | https://github.com/nodejs/node/pull/11989#event-1010524860 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
child_process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process |
| Mar 22, 2017 | https://github.com/nodejs/node/pull/11989#event-1010532645 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Mar 22, 2017
| https://github.com/nodejs/node/pull/11989#pullrequestreview-28402982 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11989/files/0341c1b2fa48ef81436083f85756da9b89cd2b70 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 22, 2017 | https://github.com/nodejs/node/pull/11989#issuecomment-288440396 |
| https://ci.nodejs.org/job/node-test-pull-request/6974/ | https://ci.nodejs.org/job/node-test-pull-request/6974/ |
| Please reload this page | https://github.com/nodejs/node/pull/11989 |
| jasnell | https://github.com/jasnell |
|
Mar 24, 2017
| https://github.com/nodejs/node/pull/11989#ref-commit-4929d12 |
|
| https://github.com/davidtaikocha |
|
| https://github.com/jasnell |
| test: add internal/socket_list tests | https://github.com/nodejs/node/commit/4929d12e999aaab08b0ed90e8a6080e139ca62d1 |
| 4929d12 | https://github.com/nodejs/node/commit/4929d12e999aaab08b0ed90e8a6080e139ca62d1 |
| #11989 | https://github.com/nodejs/node/pull/11989 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 24, 2017 | https://github.com/nodejs/node/pull/11989#issuecomment-289061089 |
| 4929d12 | https://github.com/nodejs/node/commit/4929d12e999aaab08b0ed90e8a6080e139ca62d1 |
| Please reload this page | https://github.com/nodejs/node/pull/11989 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 24, 2017 | https://github.com/nodejs/node/pull/11989#event-1014523783 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
backport-to-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-to-v7.x |
| Mar 28, 2017 | https://github.com/nodejs/node/pull/11989#event-1019509031 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Mar 28, 2017 | https://github.com/nodejs/node/pull/11989#issuecomment-289933133 |
| Please reload this page | https://github.com/nodejs/node/pull/11989 |
| https://github.com/DavidCai1111 |
| DavidCai1111 | https://github.com/DavidCai1111 |
| Mar 29, 2017 | https://github.com/nodejs/node/pull/11989#issuecomment-289947063 |
| Please reload this page | https://github.com/nodejs/node/pull/11989 |
| https://github.com/DavidCai1111 |
| DavidCai1111 | https://github.com/DavidCai1111 |
|
Mar 29, 2017
| https://github.com/nodejs/node/pull/11989#ref-pullrequest-217749513 |
|
backport: v7.x - #11989 - test: add internal/socket_list tests
#12109
| https://github.com/nodejs/node/pull/12109 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Apr 4, 2017
| https://github.com/nodejs/node/pull/11989#ref-pullrequest-219383958 |
|
8.0.0 Release Proposal
#12220
| https://github.com/nodejs/node/pull/12220 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
backported-to-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v7.x |
|
backport-requested-v7.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v7.x |
| Jun 14, 2017 | https://github.com/nodejs/node/pull/11989#event-1124176348 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Jun 15, 2017
| https://github.com/nodejs/node/pull/11989#ref-issue-235404028 |
|
Auditing for 6.11.1
nodejs/Release#230
| https://github.com/nodejs/Release/issues/230 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x |
| Jun 17, 2017 | https://github.com/nodejs/node/pull/11989#event-1127983250 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Jun 17, 2017 | https://github.com/nodejs/node/pull/11989#issuecomment-309244659 |
| b997e62 | https://github.com/nodejs/node/commit/b997e6269211067548bef3d964f933c471ada65d |
| Please reload this page | https://github.com/nodejs/node/pull/11989 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
backported-to-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v6.x |
| Jun 22, 2017 | https://github.com/nodejs/node/pull/11989#event-1135219207 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11989 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/11989/files/0341c1b2fa48ef81436083f85756da9b89cd2b70 |
|
child_process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/11989 |
|
| https://github.com/DavidCai1111 |
|
| https://github.com/Fishrock123 |
|
| https://github.com/jasnell |
|
| https://github.com/MylesBorins |
|
| https://github.com/gibfahn |
|
| https://github.com/mscdex |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/davidtaikocha |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |