René's URL Explorer Experiment


Title: v4.x backport - test: convert var->const/let in tests by gibfahn · Pull Request #11773 · nodejs/node · GitHub

Open Graph Title: v4.x backport - test: convert var->const/let in tests by gibfahn · Pull Request #11773 · nodejs/node

X Title: v4.x backport - test: convert var->const/let in tests by gibfahn · Pull Request #11773 · nodejs/node

Description: I'll fix up the commit messages once the tests are passing. Backport of #10685, I couldn't cherry-pick as it brought in hundreds of unrelated changes, so I redid the eslint --fix and manual fixup f...

Open Graph Description: I'll fix up the commit messages once the tests are passing. Backport of #10685, I couldn't cherry-pick as it brought in hundreds of unrelated changes, so I redid the eslint --fix and manual...

X Description: I'll fix up the commit messages once the tests are passing. Backport of #10685, I couldn't cherry-pick as it brought in hundreds of unrelated changes, so I redid the eslint --fix an...

Opengraph URL: https://github.com/nodejs/node/pull/11773

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c6a038cf-a657-0e0b-7912-abfaf05f19d8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD91A:1BF7E1:12D04:1955B:6969F8A4
html-safe-nonce98e316a6819d8fd23873527e53f155b0873a7a3ca0735f07622284c8aeaa2d38
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTFBOjFCRjdFMToxMkQwNDoxOTU1Qjo2OTY5RjhBNCIsInZpc2l0b3JfaWQiOiIyODMxOTA5MTUxMDY1MTEwNjkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9f7f9a5f5e8a3f9f8e06193906733d63ab436d7ba784ca880ed0c8d9bbd431d8
hovercard-subject-tagpull_request:109954490
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/11773/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cddded0f6014407ff8b8d806b1a699a95233363dcdeb196a4e82888fca4f7bff/nodejs/node/pull/11773
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cddded0f6014407ff8b8d806b1a699a95233363dcdeb196a4e82888fca4f7bff/nodejs/node/pull/11773
og:image:altI'll fix up the commit messages once the tests are passing. Backport of #10685, I couldn't cherry-pick as it brought in hundreds of unrelated changes, so I redid the eslint --fix and manual...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegibfahn
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/11773#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11773
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11773
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/11773
Reloadhttps://github.com/nodejs/node/pull/11773
Reloadhttps://github.com/nodejs/node/pull/11773
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/11773
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/11773
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/11773#issue-comment-box
gibfahnhttps://github.com/gibfahn
nodejs:v4.x-staginghttps://github.com/nodejs/node/tree/v4.x-staging
gibfahn:var2const-v4.x-v2https://github.com/gibfahn/node/tree/var2const-v4.x-v2
v4.x backport - test: convert var->const/let in tests https://github.com/nodejs/node/pull/11773#top
gibfahnhttps://github.com/gibfahn
nodejs:v4.x-staginghttps://github.com/nodejs/node/tree/v4.x-staging
gibfahn:var2const-v4.x-v2https://github.com/gibfahn/node/tree/var2const-v4.x-v2
Conversation 6 https://github.com/nodejs/node/pull/11773
Commits 2 https://github.com/nodejs/node/pull/11773/commits
Checks 0 https://github.com/nodejs/node/pull/11773/checks
Files changed https://github.com/nodejs/node/pull/11773/files
Please reload this pagehttps://github.com/nodejs/node/pull/11773
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Mar 9, 2017https://github.com/nodejs/node/pull/11773#issue-213094282
Please reload this pagehttps://github.com/nodejs/node/pull/11773
#10685https://github.com/nodejs/node/pull/10685
Please reload this pagehttps://github.com/nodejs/node/pull/11773
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Mar 9, 2017https://github.com/nodejs/node/pull/11773#event-993457020
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av4.x
Mar 9, 2017https://github.com/nodejs/node/pull/11773#event-993457128
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
force-pushedhttps://github.com/nodejs/node/compare/ddd770cf222bae56312afff8d6f1230bb67165a7..b7e4e345cd5575839ae9600f3c9a39511ecd0387
ddd770chttps://github.com/nodejs/node/commit/ddd770cf222bae56312afff8d6f1230bb67165a7
b7e4e34https://github.com/nodejs/node/commit/b7e4e345cd5575839ae9600f3c9a39511ecd0387
Compare https://github.com/nodejs/node/compare/ddd770cf222bae56312afff8d6f1230bb67165a7..b7e4e345cd5575839ae9600f3c9a39511ecd0387
March 9, 2017 17:56https://github.com/nodejs/node/pull/11773#event-993588911
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Mar 9, 2017https://github.com/nodejs/node/pull/11773#issuecomment-285430000
test-fs-stat#L40https://github.com/nodejs/node/blob/master/test/parallel/test-fs-stat.js#L40
Please reload this pagehttps://github.com/nodejs/node/pull/11773
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Mar 9, 2017https://github.com/nodejs/node/pull/11773#issuecomment-285430747
Please reload this pagehttps://github.com/nodejs/node/pull/11773
https://ci.nodejs.org/job/node-test-commit/8345/https://ci.nodejs.org/job/node-test-commit/8345/
Please reload this pagehttps://github.com/nodejs/node/pull/11773
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
force-pushedhttps://github.com/nodejs/node/compare/803ae4a3f973881432d5eaa8aea9768e734fe976..dc72f29897f7bf3a5764904c5956c88309aaa748
803ae4ahttps://github.com/nodejs/node/commit/803ae4a3f973881432d5eaa8aea9768e734fe976
dc72f29https://github.com/nodejs/node/commit/dc72f29897f7bf3a5764904c5956c88309aaa748
Compare https://github.com/nodejs/node/compare/803ae4a3f973881432d5eaa8aea9768e734fe976..dc72f29897f7bf3a5764904c5956c88309aaa748
March 9, 2017 20:53https://github.com/nodejs/node/pull/11773#event-993869467
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017https://github.com/nodejs/node/pull/11773#issuecomment-285487112
@gibfahnhttps://github.com/gibfahn
Please reload this pagehttps://github.com/nodejs/node/pull/11773
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Mar 10, 2017https://github.com/nodejs/node/pull/11773#issuecomment-285537000
Please reload this pagehttps://github.com/nodejs/node/pull/11773
@MylesBorinshttps://github.com/MylesBorins
#10698https://github.com/nodejs/node/pull/10698
#10698https://github.com/nodejs/node/pull/10698
Please reload this pagehttps://github.com/nodejs/node/pull/11773
gibfahnhttps://github.com/gibfahn
March 10, 2017 00:50https://github.com/nodejs/node/pull/11773#commits-pushed-e25635b
https://github.com/gibfahn
test: use eslint to fix var->const/lethttps://github.com/nodejs/node/pull/11773/commits/e25635bf443e1b5a9a62a881c5bf50a6c63dd59a
e25635bhttps://github.com/nodejs/node/pull/11773/commits/e25635bf443e1b5a9a62a881c5bf50a6c63dd59a
https://github.com/gibfahn
tools, test: require const/let in testhttps://github.com/nodejs/node/pull/11773/commits/3ed44d44e77e7be2e75ed4e5dc953ee82e733280
3ed44d4https://github.com/nodejs/node/pull/11773/commits/3ed44d44e77e7be2e75ed4e5dc953ee82e733280
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
force-pushedhttps://github.com/nodejs/node/compare/dc72f29897f7bf3a5764904c5956c88309aaa748..3ed44d44e77e7be2e75ed4e5dc953ee82e733280
dc72f29https://github.com/nodejs/node/commit/dc72f29897f7bf3a5764904c5956c88309aaa748
3ed44d4https://github.com/nodejs/node/commit/3ed44d44e77e7be2e75ed4e5dc953ee82e733280
Compare https://github.com/nodejs/node/compare/dc72f29897f7bf3a5764904c5956c88309aaa748..3ed44d44e77e7be2e75ed4e5dc953ee82e733280
March 10, 2017 00:51https://github.com/nodejs/node/pull/11773#event-994160590
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Mar 10, 2017https://github.com/nodejs/node/pull/11773#issuecomment-285538999
@MylesBorinshttps://github.com/MylesBorins
https://ci.nodejs.org/job/node-test-commit/8360/https://ci.nodejs.org/job/node-test-commit/8360/
var2const-v4.x-presquashhttps://github.com/gibfahn/node/tree/var2const-v4.x-presquash
Please reload this pagehttps://github.com/nodejs/node/pull/11773
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
wip https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip
Mar 10, 2017https://github.com/nodejs/node/pull/11773#event-994165623
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Mar 10, 2017https://github.com/nodejs/node/pull/11773#event-994165687
https://github.com/jasnell
jasnellhttps://github.com/jasnell
MylesBorinshttps://github.com/MylesBorins
jasnellhttps://github.com/jasnell
Mar 10, 2017https://github.com/nodejs/node/pull/11773#event-994336003
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Mar 11, 2017 https://github.com/nodejs/node/pull/11773#ref-pullrequest-198206332
test: use const for all require() calls #10550 https://github.com/nodejs/node/pull/10550
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 11, 2017https://github.com/nodejs/node/pull/11773#issuecomment-285895179
Please reload this pagehttps://github.com/nodejs/node/pull/11773
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 11, 2017https://github.com/nodejs/node/pull/11773#event-996081568
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
March 11, 2017 21:31https://github.com/nodejs/node/pull/11773#event-996110382
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11773
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/MylesBorins
MylesBorins https://github.com/MylesBorins
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/11773
https://github.com/gibfahn
https://github.com/MylesBorins
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.