René's URL Explorer Experiment


Title: test: fail when child died in fork-net by joyeecheung · Pull Request #11684 · nodejs/node · GitHub

Open Graph Title: test: fail when child died in fork-net by joyeecheung · Pull Request #11684 · nodejs/node

X Title: test: fail when child died in fork-net by joyeecheung · Pull Request #11684 · nodejs/node

Description: Previously when the child dies with errors in this test, the parent will just hang and timeout, the errors in the child would be swallowed. This PR makes it fail so at least there is more informati...

Open Graph Description: Previously when the child dies with errors in this test, the parent will just hang and timeout, the errors in the child would be swallowed. This PR makes it fail so at least there is more informati...

X Description: Previously when the child dies with errors in this test, the parent will just hang and timeout, the errors in the child would be swallowed. This PR makes it fail so at least there is more informati...

Opengraph URL: https://github.com/nodejs/node/pull/11684

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7c0bc14b-5caf-48c3-1ac5-bb8dc00e1403
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCD4:3C782D:69A96:844F1:696B7809
html-safe-noncebfceffca575d1ec183b28f8f5670a9ed3a6538c28e23764318ec381dae18ae02
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0Q0OjNDNzgyRDo2OUE5Njo4NDRGMTo2OTZCNzgwOSIsInZpc2l0b3JfaWQiOiI0NDM4MzYzMjI5MTQ2MjgxOTkzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3c872193c29d9325bd5b96809dd00f7411636d98053859d9b0896aedd60b1dd9
hovercard-subject-tagpull_request:109105736
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/11684/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c57862a5a9aecc400291d9fc283d063c247f138a861143845b02c9bb9b6f0daf/nodejs/node/pull/11684
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c57862a5a9aecc400291d9fc283d063c247f138a861143845b02c9bb9b6f0daf/nodejs/node/pull/11684
og:image:altPreviously when the child dies with errors in this test, the parent will just hang and timeout, the errors in the child would be swallowed. This PR makes it fail so at least there is more informati...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/11684#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11684
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11684
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/11684
Reloadhttps://github.com/nodejs/node/pull/11684
Reloadhttps://github.com/nodejs/node/pull/11684
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/11684
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/11684
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/11684#issue-comment-box
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:assert-in-fork-nethttps://github.com/joyeecheung/node/tree/assert-in-fork-net
test: fail when child died in fork-net https://github.com/nodejs/node/pull/11684#top
joyeecheunghttps://github.com/joyeecheung
nodejs:masterhttps://github.com/nodejs/node/tree/master
joyeecheung:assert-in-fork-nethttps://github.com/joyeecheung/node/tree/assert-in-fork-net
Conversation 8 https://github.com/nodejs/node/pull/11684
Commits 1 https://github.com/nodejs/node/pull/11684/commits
Checks 0 https://github.com/nodejs/node/pull/11684/checks
Files changed https://github.com/nodejs/node/pull/11684/files
Please reload this pagehttps://github.com/nodejs/node/pull/11684
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 4, 2017https://github.com/nodejs/node/pull/11684#issue-211876148
Please reload this pagehttps://github.com/nodejs/node/pull/11684
#11667https://github.com/nodejs/node/pull/11667
Please reload this pagehttps://github.com/nodejs/node/pull/11684
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Mar 4, 2017https://github.com/nodejs/node/pull/11684#event-986444480
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 4, 2017https://github.com/nodejs/node/pull/11684#issuecomment-284148076
https://ci.nodejs.org/job/node-test-pull-request/6701/https://ci.nodejs.org/job/node-test-pull-request/6701/
Please reload this pagehttps://github.com/nodejs/node/pull/11684
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 4, 2017https://github.com/nodejs/node/pull/11684#event-986454109
https://github.com/mscdex
mscdexhttps://github.com/mscdex
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
Mar 4, 2017https://github.com/nodejs/node/pull/11684#event-986455783
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 4, 2017https://github.com/nodejs/node/pull/11684#event-986473412
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 4, 2017https://github.com/nodejs/node/pull/11684#issuecomment-284154863
https://ci.nodejs.org/job/node-test-commit/8265/https://ci.nodejs.org/job/node-test-commit/8265/
@AndreasMadsenhttps://github.com/AndreasMadsen
Please reload this pagehttps://github.com/nodejs/node/pull/11684
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Mar 13, 2017 https://github.com/nodejs/node/pull/11684#pullrequestreview-26579734
View reviewed changes https://github.com/nodejs/node/pull/11684/files
cjihrighttps://github.com/cjihrig
https://github.com/nodejs/node/pull/11684#pullrequestreview-26579734
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/11684
test/parallel/test-child-process-fork-net.jshttps://github.com/nodejs/node/pull/11684/files#diff-3d763c381b574e34bc8f63eea1ef22f761ecffeb9a19bd89d01baa85a26c3d8a
cjihrighttps://github.com/cjihrig
Mar 13, 2017https://github.com/nodejs/node/pull/11684#discussion_r105688679
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/11684
test/parallel/test-child-process-fork-net.jshttps://github.com/nodejs/node/pull/11684/files#diff-3d763c381b574e34bc8f63eea1ef22f761ecffeb9a19bd89d01baa85a26c3d8a
cjihrighttps://github.com/cjihrig
Mar 13, 2017https://github.com/nodejs/node/pull/11684#discussion_r105689005
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/11684
https://github.com/AndreasMadsen
AndreasMadsenhttps://github.com/AndreasMadsen
Mar 13, 2017https://github.com/nodejs/node/pull/11684#issuecomment-286168982
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/11684
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 13, 2017 https://github.com/nodejs/node/pull/11684#pullrequestreview-26640010
View reviewed changes https://github.com/nodejs/node/pull/11684/files
https://github.com/joyeecheung
test: fail when child dies in fork-nethttps://github.com/nodejs/node/pull/11684/commits/8eb9e5177560dc25732e30a4619b75d7246c5332
8eb9e51https://github.com/nodejs/node/pull/11684/commits/8eb9e5177560dc25732e30a4619b75d7246c5332
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
force-pushedhttps://github.com/nodejs/node/compare/caac39416a1c3c09163365f0db75f4f15eac8c30..8eb9e5177560dc25732e30a4619b75d7246c5332
caac394https://github.com/nodejs/node/commit/caac39416a1c3c09163365f0db75f4f15eac8c30
8eb9e51https://github.com/nodejs/node/commit/8eb9e5177560dc25732e30a4619b75d7246c5332
Compare https://github.com/nodejs/node/compare/caac39416a1c3c09163365f0db75f4f15eac8c30..8eb9e5177560dc25732e30a4619b75d7246c5332
March 14, 2017 16:27https://github.com/nodejs/node/pull/11684#event-999372998
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Mar 14, 2017https://github.com/nodejs/node/pull/11684#issuecomment-286482662
@AndreasMadsenhttps://github.com/AndreasMadsen
@cjihrighttps://github.com/cjihrig
https://ci.nodejs.org/job/node-test-pull-request/6838/https://ci.nodejs.org/job/node-test-pull-request/6838/
Please reload this pagehttps://github.com/nodejs/node/pull/11684
jasnellhttps://github.com/jasnell
Mar 14, 2017 https://github.com/nodejs/node/pull/11684#ref-commit-c9bc3e5
https://github.com/joyeecheung
https://github.com/jasnell
test: fail when child dies in fork-nethttps://github.com/nodejs/node/commit/c9bc3e50edf192aac7a051c1dd585d9df5c43c79
c9bc3e5https://github.com/nodejs/node/commit/c9bc3e50edf192aac7a051c1dd585d9df5c43c79
#11684https://github.com/nodejs/node/pull/11684
#11667https://github.com/nodejs/node/pull/11667
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 14, 2017https://github.com/nodejs/node/pull/11684#issuecomment-286578025
c9bc3e5https://github.com/nodejs/node/commit/c9bc3e50edf192aac7a051c1dd585d9df5c43c79
Please reload this pagehttps://github.com/nodejs/node/pull/11684
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 14, 2017https://github.com/nodejs/node/pull/11684#event-999933647
italoacasashttps://github.com/italoacasas
Mar 20, 2017 https://github.com/nodejs/node/pull/11684#ref-commit-5f6025b
https://github.com/joyeecheung
test: fail when child dies in fork-nethttps://github.com/italoacasas/node/commit/5f6025ba68c0bb19366dc874369cc58d872c5cee
5f6025bhttps://github.com/italoacasas/node/commit/5f6025ba68c0bb19366dc874369cc58d872c5cee
nodejs#11684https://github.com/nodejs/node/pull/11684
nodejs#11667https://github.com/nodejs/node/pull/11667
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
Mar 20, 2017 https://github.com/nodejs/node/pull/11684#ref-pullrequest-215512908
v7.7.4 Release Proposal #11941 https://github.com/nodejs/node/pull/11941
jungx098https://github.com/jungx098
Mar 21, 2017 https://github.com/nodejs/node/pull/11684#ref-commit-1ba472d
https://github.com/joyeecheung
https://github.com/jungx098
test: fail when child dies in fork-nethttps://github.com/jungx098/node/commit/1ba472dc290067e4bfbd5230a66b5061bda8cfe7
1ba472dhttps://github.com/jungx098/node/commit/1ba472dc290067e4bfbd5230a66b5061bda8cfe7
nodejs#11684https://github.com/nodejs/node/pull/11684
nodejs#11667https://github.com/nodejs/node/pull/11667
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x
Apr 18, 2017https://github.com/nodejs/node/pull/11684#event-1047042857
MylesBorinshttps://github.com/MylesBorins
Apr 18, 2017 https://github.com/nodejs/node/pull/11684#ref-commit-0d4d67a
https://github.com/joyeecheung
https://github.com/MylesBorins
test: fail when child dies in fork-nethttps://github.com/nodejs/node/commit/0d4d67a10c64429191acb597ace05acc993d5476
0d4d67ahttps://github.com/nodejs/node/commit/0d4d67a10c64429191acb597ace05acc993d5476
#11684https://github.com/nodejs/node/pull/11684
#11667https://github.com/nodejs/node/pull/11667
MylesBorinshttps://github.com/MylesBorins
Apr 19, 2017 https://github.com/nodejs/node/pull/11684#ref-commit-4d916da
https://github.com/joyeecheung
https://github.com/MylesBorins
test: fail when child dies in fork-nethttps://github.com/nodejs/node/commit/4d916da0d7138fa52e0ec6cc5d05899d195bd47a
4d916dahttps://github.com/nodejs/node/commit/4d916da0d7138fa52e0ec6cc5d05899d195bd47a
#11684https://github.com/nodejs/node/pull/11684
#11667https://github.com/nodejs/node/pull/11667
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 19, 2017 https://github.com/nodejs/node/pull/11684#ref-pullrequest-222580733
v6.10.3 proposal #12498 https://github.com/nodejs/node/pull/12498
andrew749https://github.com/andrew749
Jul 19, 2017 https://github.com/nodejs/node/pull/11684#ref-commit-d070f81
https://github.com/joyeecheung
https://github.com/andrew749
test: fail when child dies in fork-nethttps://github.com/michielbaird/node/commit/d070f81432c291baeafc98dc6fe120ab10c9be78
d070f81https://github.com/michielbaird/node/commit/d070f81432c291baeafc98dc6fe120ab10c9be78
nodejs/node#11684https://github.com/nodejs/node/pull/11684
nodejs/node#11667https://github.com/nodejs/node/pull/11667
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11684
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/11684/files/caac39416a1c3c09163365f0db75f4f15eac8c30
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/11684/files/caac39416a1c3c09163365f0db75f4f15eac8c30
child_process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/11684
https://github.com/joyeecheung
https://github.com/AndreasMadsen
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/mscdex
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.