| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:816ca348-e30f-6f01-a25a-c4dad20fb11b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E5A2:1B40D2:ADB9FF:EFF2B4:6969EF9C |
| html-safe-nonce | 7113febbd70ec57692f1d885b1a2d8fc1a43df4294f3ad34462795eef32ef55f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNUEyOjFCNDBEMjpBREI5RkY6RUZGMkI0OjY5NjlFRjlDIiwidmlzaXRvcl9pZCI6Ijg3NDE2OTczNTc2NjE5OTA4MTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a7322764d7af8f170f805cc30481bc82115954357cebae8f115b6df677617454 |
| hovercard-subject-tag | pull_request:108956655 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/11670/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8a7a3d4973865b21a496e370c69b6be0216e0283a12cc13921c8ee8642d9780e/nodejs/node/pull/11670 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8a7a3d4973865b21a496e370c69b6be0216e0283a12cc13921c8ee8642d9780e/nodejs/node/pull/11670 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines
Affected core... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sushi90 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/11670#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11670 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11670 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/11670 |
| Reload | https://github.com/nodejs/node/pull/11670 |
| Reload | https://github.com/nodejs/node/pull/11670 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/11670 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/11670 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/11670#issue-comment-box |
| sushi90 | https://github.com/sushi90 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| sushi90:doc-timer | https://github.com/sushi90/node/tree/doc-timer |
|
doc: the url is not found
| https://github.com/nodejs/node/pull/11670#top |
| sushi90 | https://github.com/sushi90 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| sushi90:doc-timer | https://github.com/sushi90/node/tree/doc-timer |
|
Conversation
5
| https://github.com/nodejs/node/pull/11670 |
|
Commits
2
| https://github.com/nodejs/node/pull/11670/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/11670/checks |
|
Files changed
| https://github.com/nodejs/node/pull/11670/files |
| Please reload this page | https://github.com/nodejs/node/pull/11670 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/sushi90 |
| sushi90 | https://github.com/sushi90 |
| Mar 3, 2017 | https://github.com/nodejs/node/pull/11670#issue-211665684 |
| Please reload this page | https://github.com/nodejs/node/pull/11670 |
|
| https://github.com/sushi90 |
| doc: the url is not found | https://github.com/nodejs/node/pull/11670/commits/94cec74dc400a630450d8959aca32b0710474bf3 |
| 94cec74 | https://github.com/nodejs/node/pull/11670/commits/94cec74dc400a630450d8959aca32b0710474bf3 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
timers
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers |
| Mar 3, 2017 | https://github.com/nodejs/node/pull/11670#event-985249757 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Mar 3, 2017
| https://github.com/nodejs/node/pull/11670#pullrequestreview-24974490 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11670/files/94cec74dc400a630450d8959aca32b0710474bf3 |
| https://github.com/hiroppy |
| hiroppy | https://github.com/hiroppy |
|
Mar 3, 2017
| https://github.com/nodejs/node/pull/11670#pullrequestreview-24983312 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11670/files/94cec74dc400a630450d8959aca32b0710474bf3 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 3, 2017 | https://github.com/nodejs/node/pull/11670#issuecomment-283969997 |
| @cjihrig | https://github.com/cjihrig |
| @abouthiroppy | https://github.com/abouthiroppy |
| Please reload this page | https://github.com/nodejs/node/pull/11670 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Mar 3, 2017 | https://github.com/nodejs/node/pull/11670#issuecomment-283972474 |
| Please reload this page | https://github.com/nodejs/node/pull/11670 |
|
| https://github.com/sushi90 |
| doc: replace better url | https://github.com/nodejs/node/pull/11670/commits/815e19101c494b19895805104064a46498195d61 |
| 815e191 | https://github.com/nodejs/node/pull/11670/commits/815e19101c494b19895805104064a46498195d61 |
| https://github.com/sushi90 |
| sushi90 | https://github.com/sushi90 |
| Mar 4, 2017 | https://github.com/nodejs/node/pull/11670#issuecomment-284154004 |
| Please reload this page | https://github.com/nodejs/node/pull/11670 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Mar 4, 2017
| https://github.com/nodejs/node/pull/11670#pullrequestreview-25129705 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11670/files/815e19101c494b19895805104064a46498195d61 |
| Trott | https://github.com/Trott |
| https://github.com/nodejs/node/pull/11670#pullrequestreview-25129705 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11670 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Mar 4, 2017
| https://github.com/nodejs/node/pull/11670#pullrequestreview-25129758 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11670/files/815e19101c494b19895805104064a46498195d61 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Mar 4, 2017
| https://github.com/nodejs/node/pull/11670#pullrequestreview-25129847 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11670/files/815e19101c494b19895805104064a46498195d61 |
| lpinca | https://github.com/lpinca |
|
Mar 6, 2017
| https://github.com/nodejs/node/pull/11670#ref-commit-0674771 |
|
| https://github.com/sushi90 |
|
| https://github.com/lpinca |
| doc: fix broken URL to event loop guide | https://github.com/lpinca/node/commit/0674771f233bd79ea2d9c61e072a89487321f533 |
| 0674771 | https://github.com/lpinca/node/commit/0674771f233bd79ea2d9c61e072a89487321f533 |
| nodejs#11670 | https://github.com/nodejs/node/pull/11670 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Mar 6, 2017 | https://github.com/nodejs/node/pull/11670#issuecomment-284422667 |
| 0674771 | https://github.com/nodejs/node/commit/0674771f233bd79ea2d9c61e072a89487321f533 |
| Please reload this page | https://github.com/nodejs/node/pull/11670 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Mar 6, 2017 | https://github.com/nodejs/node/pull/11670#event-987871545 |
| evanlucas | https://github.com/evanlucas |
|
Mar 7, 2017
| https://github.com/nodejs/node/pull/11670#ref-commit-8402888 |
|
| https://github.com/sushi90 |
|
| https://github.com/evanlucas |
| doc: fix broken URL to event loop guide | https://github.com/nodejs/node/commit/84028888dbf1be8f09c41e2e686a202527caccf9 |
| 8402888 | https://github.com/nodejs/node/commit/84028888dbf1be8f09c41e2e686a202527caccf9 |
| #11670 | https://github.com/nodejs/node/pull/11670 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
Mar 8, 2017
| https://github.com/nodejs/node/pull/11670#ref-pullrequest-212713511 |
|
v7.7.2 proposal
#11745
| https://github.com/nodejs/node/pull/11745 |
| https://github.com/aqrln |
| aqrln | https://github.com/aqrln |
|
Mar 23, 2017
| https://github.com/nodejs/node/pull/11670#ref-pullrequest-216557946 |
|
doc: fix link in timers api doc.
#12008
| https://github.com/nodejs/node/pull/12008 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Mar 24, 2017 | https://github.com/nodejs/node/pull/11670#event-1013459902 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Mar 24, 2017
| https://github.com/nodejs/node/pull/11670#ref-issue-216536185 |
|
Doc issue
#12007
| https://github.com/nodejs/node/issues/12007 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Mar 28, 2017 | https://github.com/nodejs/node/pull/11670#event-1018160595 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 28, 2017
| https://github.com/nodejs/node/pull/11670#ref-commit-0cc39e0 |
|
| https://github.com/sushi90 |
|
| https://github.com/MylesBorins |
| doc: fix broken URL to event loop guide | https://github.com/nodejs/node/commit/0cc39e028e8fb814e057f884b8dc22ed1cf6e632 |
| 0cc39e0 | https://github.com/nodejs/node/commit/0cc39e028e8fb814e057f884b8dc22ed1cf6e632 |
| #11670 | https://github.com/nodejs/node/pull/11670 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 29, 2017
| https://github.com/nodejs/node/pull/11670#ref-commit-47cdeb9 |
|
| https://github.com/sushi90 |
|
| https://github.com/MylesBorins |
| doc: fix broken URL to event loop guide | https://github.com/nodejs/node/commit/47cdeb9be58b49f31e7ff6ec8301ac972780f86d |
| 47cdeb9 | https://github.com/nodejs/node/commit/47cdeb9be58b49f31e7ff6ec8301ac972780f86d |
| #11670 | https://github.com/nodejs/node/pull/11670 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 4, 2017
| https://github.com/nodejs/node/pull/11670#ref-commit-6486b97 |
|
| https://github.com/sushi90 |
|
| https://github.com/MylesBorins |
| doc: fix broken URL to event loop guide | https://github.com/nodejs/node/commit/6486b97b4e2f2053f199b96764375c6ede86014f |
| 6486b97 | https://github.com/nodejs/node/commit/6486b97b4e2f2053f199b96764375c6ede86014f |
| #11670 | https://github.com/nodejs/node/pull/11670 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 19, 2017
| https://github.com/nodejs/node/pull/11670#ref-commit-de22ff6 |
|
| https://github.com/sushi90 |
|
| https://github.com/MylesBorins |
| doc: fix broken URL to event loop guide | https://github.com/nodejs/node/commit/de22ff642fdde0b30f1ecf0e012bfaad6c3d492c |
| de22ff6 | https://github.com/nodejs/node/commit/de22ff642fdde0b30f1ecf0e012bfaad6c3d492c |
| #11670 | https://github.com/nodejs/node/pull/11670 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 19, 2017
| https://github.com/nodejs/node/pull/11670#ref-pullrequest-222580733 |
|
v6.10.3 proposal
#12498
| https://github.com/nodejs/node/pull/12498 |
| andrew749 | https://github.com/andrew749 |
|
Jul 19, 2017
| https://github.com/nodejs/node/pull/11670#ref-commit-2b8a26c |
|
| https://github.com/sushi90 |
|
| https://github.com/andrew749 |
| doc: fix broken URL to event loop guide | https://github.com/michielbaird/node/commit/2b8a26cea9c97ec0e66da2bf9fbd45b39da060c2 |
| 2b8a26c | https://github.com/michielbaird/node/commit/2b8a26cea9c97ec0e66da2bf9fbd45b39da060c2 |
| nodejs/node#11670 | https://github.com/nodejs/node/pull/11670 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11670 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/11670/files/815e19101c494b19895805104064a46498195d61 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/11670/files/815e19101c494b19895805104064a46498195d61 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/11670/files/815e19101c494b19895805104064a46498195d61 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/11670/files/94cec74dc400a630450d8959aca32b0710474bf3 |
|
| https://github.com/hiroppy |
|
hiroppy
| https://github.com/hiroppy |
|
| https://github.com/nodejs/node/pull/11670/files/94cec74dc400a630450d8959aca32b0710474bf3 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
timers
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers |
| Please reload this page | https://github.com/nodejs/node/pull/11670 |
|
| https://github.com/sushi90 |
|
| https://github.com/Trott |
|
| https://github.com/cjihrig |
|
| https://github.com/lpinca |
|
| https://github.com/jasnell |
|
| https://github.com/hiroppy |
|
| https://github.com/MylesBorins |
|
| https://github.com/gibfahn |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |