| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d1817e0d-6629-5079-98e2-bed5f2242bbf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 87F8:19FB97:1B536BB:26501E4:696A511F |
| html-safe-nonce | 9328d1f22ea984aff70245472b8928c0c9fbae1868a71be41e42448fc15dccf8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4N0Y4OjE5RkI5NzoxQjUzNkJCOjI2NTAxRTQ6Njk2QTUxMUYiLCJ2aXNpdG9yX2lkIjoiNjc0ODYyOTU4MjIyODM3Nzg4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9ff9aed23b667319c1dbc64802b07e1284be85729811633923488eb15be87e6f |
| hovercard-subject-tag | pull_request:108748719 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/11652/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/55102709e6c01bfb2d707355b7265250708f39524a1321509e170afca577aae1/nodejs/node/pull/11652 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/55102709e6c01bfb2d707355b7265250708f39524a1321509e170afca577aae1/nodejs/node/pull/11652 |
| og:image:alt | See the commit log of the reverted commit: it's a semver-minor change
that can land in the next minor release.
This reverts commit 47cbb88.
CI: https://ci.nodejs.org/job/node-test-pull-request/... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bnoordhuis |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 63c426b30d262aba269ef14c40e3c817b384cd61 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/11652#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11652 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11652 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/11652 |
| Reload | https://github.com/nodejs/node/pull/11652 |
| Reload | https://github.com/nodejs/node/pull/11652 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/11652 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/11652 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/11652#issue-comment-box |
| bnoordhuis | https://github.com/bnoordhuis |
| nodejs:v6.x-staging | https://github.com/nodejs/node/tree/v6.x-staging |
| bnoordhuis:revert-47cbb88 | https://github.com/bnoordhuis/io.js/tree/revert-47cbb88 |
|
Revert "v8: drop v8::FunctionCallbackInfo::NewTarget()"
| https://github.com/nodejs/node/pull/11652#top |
| bnoordhuis | https://github.com/bnoordhuis |
| nodejs:v6.x-staging | https://github.com/nodejs/node/tree/v6.x-staging |
| bnoordhuis:revert-47cbb88 | https://github.com/bnoordhuis/io.js/tree/revert-47cbb88 |
|
Conversation
12
| https://github.com/nodejs/node/pull/11652 |
|
Commits
144
| https://github.com/nodejs/node/pull/11652/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/11652/checks |
|
Files changed
| https://github.com/nodejs/node/pull/11652/files |
| Please reload this page | https://github.com/nodejs/node/pull/11652 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Mar 2, 2017 | https://github.com/nodejs/node/pull/11652#issue-211376760 |
| Please reload this page | https://github.com/nodejs/node/pull/11652 |
| 47cbb88 | https://github.com/nodejs/node/commit/47cbb88ac5929ce6ba17f681785034dd019ce063 |
| https://ci.nodejs.org/job/node-test-pull-request/6657/ | https://ci.nodejs.org/job/node-test-pull-request/6657/ |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/591/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/591/ |
| Please reload this page | https://github.com/nodejs/node/pull/11652 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Mar 2, 2017 | https://github.com/nodejs/node/pull/11652#event-983564076 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av6.x |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Mar 2, 2017 | https://github.com/nodejs/node/pull/11652#event-983564171 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Mar 2, 2017
| https://github.com/nodejs/node/pull/11652#pullrequestreview-24717912 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11652/files |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Mar 2, 2017
| https://github.com/nodejs/node/pull/11652#pullrequestreview-24727982 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11652/files |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Mar 2, 2017
| https://github.com/nodejs/node/pull/11652#pullrequestreview-24775563 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11652/files |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/11652#pullrequestreview-24775563 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11652 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Mar 2, 2017
| https://github.com/nodejs/node/pull/11652#pullrequestreview-24793736 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11652/files |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 2, 2017 | https://github.com/nodejs/node/pull/11652#issuecomment-283793200 |
| Please reload this page | https://github.com/nodejs/node/pull/11652 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Mar 2, 2017 | https://github.com/nodejs/node/pull/11652#issuecomment-283815755 |
| @Fishrock123 | https://github.com/Fishrock123 |
| #9293 (comment) | https://github.com/nodejs/node/pull/9293#issuecomment-257833008 |
| Please reload this page | https://github.com/nodejs/node/pull/11652 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Mar 3, 2017
| https://github.com/nodejs/node/pull/11652#ref-pullrequest-185374185 |
|
v8: fix new.target inheritance from c++
#9293
| https://github.com/nodejs/node/pull/9293 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Mar 3, 2017 | https://github.com/nodejs/node/pull/11652#issuecomment-283902728 |
| @ofrobots | https://github.com/ofrobots |
| #9293 (comment) | https://github.com/nodejs/node/pull/9293#discussion_r100127564 |
| Please reload this page | https://github.com/nodejs/node/pull/11652 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/b3f32f9cbe602c339e2053f1ac6285b6b3fc537e..e71fc7082d216860194260b2faaf1cd8a1dc9446 |
| b3f32f9 | https://github.com/nodejs/node/commit/b3f32f9cbe602c339e2053f1ac6285b6b3fc537e |
| e71fc70 | https://github.com/nodejs/node/commit/e71fc7082d216860194260b2faaf1cd8a1dc9446 |
|
Compare
| https://github.com/nodejs/node/compare/b3f32f9cbe602c339e2053f1ac6285b6b3fc537e..e71fc7082d216860194260b2faaf1cd8a1dc9446 |
| March 8, 2017 09:27 | https://github.com/nodejs/node/pull/11652#event-991033440 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/c2e818dce5495bcbdcd984bfde0effe1bd0911ca..426968ddd84d8a11f4a57963545334c2a34920f2 |
| c2e818d | https://github.com/nodejs/node/commit/c2e818dce5495bcbdcd984bfde0effe1bd0911ca |
| 426968d | https://github.com/nodejs/node/commit/426968ddd84d8a11f4a57963545334c2a34920f2 |
|
Compare
| https://github.com/nodejs/node/compare/c2e818dce5495bcbdcd984bfde0effe1bd0911ca..426968ddd84d8a11f4a57963545334c2a34920f2 |
| March 21, 2017 21:27 | https://github.com/nodejs/node/pull/11652#event-1009426285 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 22, 2017 | https://github.com/nodejs/node/pull/11652#issuecomment-288481050 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/11652 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| force-pushed | https://github.com/nodejs/node/compare/6b8f3c7a299a06374caebcd3956013f2117fd0f3..1f0da51aa14acb8ecf782a73d918f84e5ced6d48 |
| 6b8f3c7 | https://github.com/nodejs/node/commit/6b8f3c7a299a06374caebcd3956013f2117fd0f3 |
| 1f0da51 | https://github.com/nodejs/node/commit/1f0da51aa14acb8ecf782a73d918f84e5ced6d48 |
|
Compare
| https://github.com/nodejs/node/compare/6b8f3c7a299a06374caebcd3956013f2117fd0f3..1f0da51aa14acb8ecf782a73d918f84e5ced6d48 |
| March 23, 2017 11:28 | https://github.com/nodejs/node/pull/11652#event-1012224660 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Mar 23, 2017 | https://github.com/nodejs/node/pull/11652#issuecomment-288690645 |
| Please reload this page | https://github.com/nodejs/node/pull/11652 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 23, 2017 | https://github.com/nodejs/node/pull/11652#issuecomment-288763723 |
| https://ci.nodejs.org/job/node-test-pull-request/7002/ | https://ci.nodejs.org/job/node-test-pull-request/7002/ |
| Please reload this page | https://github.com/nodejs/node/pull/11652 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 23, 2017 | https://github.com/nodejs/node/pull/11652#issuecomment-288789606 |
| @bnoordhuis | https://github.com/bnoordhuis |
| https://ci.nodejs.org/job/node-test-commit-linux/8645/nodes=ubuntu1204-clang341-64/console | https://ci.nodejs.org/job/node-test-commit-linux/8645/nodes=ubuntu1204-clang341-64/console |
| Please reload this page | https://github.com/nodejs/node/pull/11652 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Mar 23, 2017 | https://github.com/nodejs/node/pull/11652#issuecomment-288795835 |
| Please reload this page | https://github.com/nodejs/node/pull/11652 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 23, 2017 | https://github.com/nodejs/node/pull/11652#issuecomment-288796323 |
| Please reload this page | https://github.com/nodejs/node/pull/11652 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Mar 23, 2017
| https://github.com/nodejs/node/pull/11652#ref-pullrequest-216404002 |
|
deps: fix async await desugaring in V8
#12004
| https://github.com/nodejs/node/pull/12004 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Mar 25, 2017
| https://github.com/nodejs/node/pull/11652#ref-pullrequest-215851538 |
|
module: add support for abi stable module API
#11975
| https://github.com/nodejs/node/pull/11975 |
| mhdawson | https://github.com/mhdawson |
| April 4, 2017 14:20 | https://github.com/nodejs/node/pull/11652#commits-pushed-f05982b |
|
| https://github.com/mhdawson |
|
| https://github.com/MylesBorins |
| doc: add supported platforms list | https://github.com/nodejs/node/pull/11652/commits/f05982be97a0ca4aacce41acc00707c3f834890e |
| f05982b | https://github.com/nodejs/node/pull/11652/commits/f05982be97a0ca4aacce41acc00707c3f834890e |
| nodejs#11872 | https://github.com/nodejs/node/pull/11872 |
| nodejs#11872 | https://github.com/nodejs/node/pull/11872 |
| nodejs#11943 | https://github.com/nodejs/node/pull/11943 |
|
| https://github.com/mhdawson |
|
| https://github.com/MylesBorins |
| doc: add supported platforms list for v6.x | https://github.com/nodejs/node/pull/11652/commits/76e903e5d6092f5ecb6f46b1bd40c643dc5877a0 |
| 76e903e | https://github.com/nodejs/node/pull/11652/commits/76e903e5d6092f5ecb6f46b1bd40c643dc5877a0 |
| nodejs#11943 | https://github.com/nodejs/node/pull/11943 |
|
| https://github.com/sushi90 |
|
| https://github.com/MylesBorins |
| doc: fix broken URL to event loop guide | https://github.com/nodejs/node/pull/11652/commits/6486b97b4e2f2053f199b96764375c6ede86014f |
| 6486b97 | https://github.com/nodejs/node/pull/11652/commits/6486b97b4e2f2053f199b96764375c6ede86014f |
| nodejs#11670 | https://github.com/nodejs/node/pull/11670 |
|
| https://github.com/mscdex |
|
| https://github.com/MylesBorins |
| stream: avoid additional validation for Buffers | https://github.com/nodejs/node/pull/11652/commits/078188d75e22d73d1114c61480e38c3bb6ce206c |
| 078188d | https://github.com/nodejs/node/pull/11652/commits/078188d75e22d73d1114c61480e38c3bb6ce206c |
| nodejs#10580 | https://github.com/nodejs/node/pull/10580 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/59b869e83123b7ed8dc678bc76dc80e2fbb5256f..078188d75e22d73d1114c61480e38c3bb6ce206c |
| 59b869e | https://github.com/nodejs/node/commit/59b869e83123b7ed8dc678bc76dc80e2fbb5256f |
| 078188d | https://github.com/nodejs/node/commit/078188d75e22d73d1114c61480e38c3bb6ce206c |
|
Compare
| https://github.com/nodejs/node/compare/59b869e83123b7ed8dc678bc76dc80e2fbb5256f..078188d75e22d73d1114c61480e38c3bb6ce206c |
| April 4, 2017 12:20 | https://github.com/nodejs/node/pull/11652#event-1028278894 |
| gibfahn | https://github.com/gibfahn |
| April 13, 2017 15:11 | https://github.com/nodejs/node/pull/11652#commits-pushed-daddf5a |
|
| https://github.com/gibfahn |
|
| https://github.com/MylesBorins |
| tools, test: require const/let in test | https://github.com/nodejs/node/pull/11652/commits/daddf5ae59ad4700058bca21847caed452416057 |
| daddf5a | https://github.com/nodejs/node/pull/11652/commits/daddf5ae59ad4700058bca21847caed452416057 |
| nodejs#11775 | https://github.com/nodejs/node/pull/11775 |
| nodejs#10685 | https://github.com/nodejs/node/pull/10685 |
|
| https://github.com/gibfahn |
|
| https://github.com/MylesBorins |
| test: use eslint to fix var->const/let | https://github.com/nodejs/node/pull/11652/commits/b2fc0f017a832017b0ba27d3c7545e5759669201 |
| b2fc0f0 | https://github.com/nodejs/node/pull/11652/commits/b2fc0f017a832017b0ba27d3c7545e5759669201 |
| nodejs#11775 | https://github.com/nodejs/node/pull/11775 |
| nodejs#10685 | https://github.com/nodejs/node/pull/10685 |
| silverwind | https://github.com/silverwind |
| April 18, 2017 19:25 | https://github.com/nodejs/node/pull/11652#commits-pushed-b5c9c12 |
|
| https://github.com/silverwind |
|
| https://github.com/MylesBorins |
| doc: add logo to README | https://github.com/nodejs/node/pull/11652/commits/b5c9c129c4bdf431d884d102f9447232946d2498 |
| b5c9c12 | https://github.com/nodejs/node/pull/11652/commits/b5c9c129c4bdf431d884d102f9447232946d2498 |
| nodejs#12148 | https://github.com/nodejs/node/pull/12148 |
| nodejs#6920 | https://github.com/nodejs/node/issues/6920 |
|
| https://github.com/santigimeno |
|
| https://github.com/MylesBorins |
| test: fix flaky test-child-process-exec-timeout | https://github.com/nodejs/node/pull/11652/commits/1f732d3dfeb200075a3d4b7523e2aa3d56baa938 |
| 1f732d3 | https://github.com/nodejs/node/pull/11652/commits/1f732d3dfeb200075a3d4b7523e2aa3d56baa938 |
| nodejs#12159 | https://github.com/nodejs/node/pull/12159 |
| libuv/libuv#1226 | https://github.com/libuv/libuv/issues/1226 |
|
| https://github.com/davidtaikocha |
|
| https://github.com/MylesBorins |
| test: increase querystring coverage | https://github.com/nodejs/node/pull/11652/commits/20c38ebc4100ddf917646e5a6ea5905567fdaf81 |
| 20c38eb | https://github.com/nodejs/node/pull/11652/commits/20c38ebc4100ddf917646e5a6ea5905567fdaf81 |
| nodejs#12163 | https://github.com/nodejs/node/pull/12163 |
|
| https://github.com/refack |
|
| https://github.com/MylesBorins |
| test: performance, remove Popen(shell=True) on Win | https://github.com/nodejs/node/pull/11652/commits/9520762d33334c47745619c7b69280c2ff3cc8da |
| 9520762 | https://github.com/nodejs/node/pull/11652/commits/9520762d33334c47745619c7b69280c2ff3cc8da |
| https://docs.python.org/2/library/subprocess.html#index-2 | https://docs.python.org/2/library/subprocess.html#index-2 |
| nodejs#12138 | https://github.com/nodejs/node/pull/12138 |
|
| https://github.com/refack |
|
| https://github.com/MylesBorins |
| test: more robust check for location of node.exe | https://github.com/nodejs/node/pull/11652/commits/eafe88b5962074e87458768906e97fb5c32e084c |
| eafe88b | https://github.com/nodejs/node/pull/11652/commits/eafe88b5962074e87458768906e97fb5c32e084c |
| nodejs#12120 | https://github.com/nodejs/node/pull/12120 |
|
| https://github.com/Minimalistic |
|
| https://github.com/MylesBorins |
| doc: add table of contents to README.md | https://github.com/nodejs/node/pull/11652/commits/90caad478de9b67aef114e2b4487faa40abb976d |
| 90caad4 | https://github.com/nodejs/node/pull/11652/commits/90caad478de9b67aef114e2b4487faa40abb976d |
| nodejs#11635 | https://github.com/nodejs/node/pull/11635 |
|
| https://github.com/vhmth |
|
| https://github.com/MylesBorins |
| doc: fix string interpolation in Stream 'finish' | https://github.com/nodejs/node/pull/11652/commits/e9a6dddd73881af9496cf02cc8ed5e9f6d641737 |
| e9a6ddd | https://github.com/nodejs/node/pull/11652/commits/e9a6dddd73881af9496cf02cc8ed5e9f6d641737 |
| nodejs#12221 | https://github.com/nodejs/node/pull/12221 |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/MylesBorins |
| doc: modernize and fix code examples in https.md | https://github.com/nodejs/node/pull/11652/commits/db282374201ac164d22bc98b95925180252ba385 |
| db28237 | https://github.com/nodejs/node/pull/11652/commits/db282374201ac164d22bc98b95925180252ba385 |
| nodejs#12171 | https://github.com/nodejs/node/pull/12171 |
|
| https://github.com/danbev |
|
| https://github.com/MylesBorins |
| build: make configure print statements consistent | https://github.com/nodejs/node/pull/11652/commits/fce05e3624fd49cdabcdb02e42f3d51f5a69eb58 |
| fce05e3 | https://github.com/nodejs/node/pull/11652/commits/fce05e3624fd49cdabcdb02e42f3d51f5a69eb58 |
| nodejs#12176 | https://github.com/nodejs/node/pull/12176 |
|
| https://github.com/danbev |
|
| https://github.com/MylesBorins |
| build: add checks for openssl configure options | https://github.com/nodejs/node/pull/11652/commits/cf411d3b3d0a9f23d866709baf1fd3fbcb866ca7 |
| cf411d3 | https://github.com/nodejs/node/pull/11652/commits/cf411d3b3d0a9f23d866709baf1fd3fbcb866ca7 |
| nodejs#12175 | https://github.com/nodejs/node/pull/12175 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: skip irrelevant test on Windows | https://github.com/nodejs/node/pull/11652/commits/6c4f7861134e264dcf46f03a4008e5eeb5740430 |
| 6c4f786 | https://github.com/nodejs/node/pull/11652/commits/6c4f7861134e264dcf46f03a4008e5eeb5740430 |
| nodejs#12261 | https://github.com/nodejs/node/pull/12261 |
| nodejs#12197 (comment) | https://github.com/nodejs/node/pull/12197#issuecomment-292228866 |
|
| https://github.com/dave-k |
|
| https://github.com/MylesBorins |
| test: add a second argument to assert.throws() | https://github.com/nodejs/node/pull/11652/commits/81fceb39d5cad27dced8d53eb13d40adf717a53f |
| 81fceb3 | https://github.com/nodejs/node/pull/11652/commits/81fceb39d5cad27dced8d53eb13d40adf717a53f |
| nodejs#12139 | https://github.com/nodejs/node/pull/12139 |
|
| https://github.com/aqrln |
|
| https://github.com/MylesBorins |
| doc: add aqrln to collaborators | https://github.com/nodejs/node/pull/11652/commits/72e011e36ea4d2873e429795db4a24b0a4ee2a3d |
| 72e011e | https://github.com/nodejs/node/pull/11652/commits/72e011e36ea4d2873e429795db4a24b0a4ee2a3d |
| @aqrln | https://github.com/aqrln |
| nodejs#12273 | https://github.com/nodejs/node/pull/12273 |
|
| https://github.com/gibfahn |
|
| https://github.com/MylesBorins |
| doc: document the performance team | https://github.com/nodejs/node/pull/11652/commits/c520aef73f3fc6f5455dd3bdf5807e178a6ff841 |
| c520aef | https://github.com/nodejs/node/pull/11652/commits/c520aef73f3fc6f5455dd3bdf5807e178a6ff841 |
| nodejs#12213 | https://github.com/nodejs/node/pull/12213 |
| nodejs#12194 (comment) | https://github.com/nodejs/node/pull/12194#issuecomment-291477258 |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/MylesBorins |
| doc: fix confusing reference in net.md | https://github.com/nodejs/node/pull/11652/commits/6577f3e2eb6707fc50c90e6dc28d29272ece69c5 |
| 6577f3e | https://github.com/nodejs/node/pull/11652/commits/6577f3e2eb6707fc50c90e6dc28d29272ece69c5 |
| nodejs#12247 | https://github.com/nodejs/node/pull/12247 |
|
| https://github.com/MylesBorins |
| doc: update information on test/known_issues | https://github.com/nodejs/node/pull/11652/commits/663a1ec0beb2cf946d4915cd230ea91f43fc7682 |
| 663a1ec | https://github.com/nodejs/node/pull/11652/commits/663a1ec0beb2cf946d4915cd230ea91f43fc7682 |
| nodejs#6559 | https://github.com/nodejs/node/pull/6559 |
| nodejs#12262 | https://github.com/nodejs/node/pull/12262 |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/MylesBorins |
| doc: fix confusing example in process.md | https://github.com/nodejs/node/pull/11652/commits/4bfa2bbb20daa4c7298450fed5068bcb79f1fcec |
| 4bfa2bb | https://github.com/nodejs/node/pull/11652/commits/4bfa2bbb20daa4c7298450fed5068bcb79f1fcec |
| nodejs#12282 | https://github.com/nodejs/node/pull/12282 |
| nodejs#12280 | https://github.com/nodejs/node/issues/12280 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| tools: ignore URLs in line length linting | https://github.com/nodejs/node/pull/11652/commits/f463c173629e63dbfc2756ef934667c842b055bf |
| f463c17 | https://github.com/nodejs/node/pull/11652/commits/f463c173629e63dbfc2756ef934667c842b055bf |
| nodejs#11890 | https://github.com/nodejs/node/pull/11890 |
|
| https://github.com/richardlau |
|
| https://github.com/MylesBorins |
| doc: add richardlau to collaborators | https://github.com/nodejs/node/pull/11652/commits/52511b651d726c22fdcc92eeba827b5513086403 |
| 52511b6 | https://github.com/nodejs/node/pull/11652/commits/52511b651d726c22fdcc92eeba827b5513086403 |
| nodejs#12020 | https://github.com/nodejs/node/pull/12020 |
|
| https://github.com/refack |
|
| https://github.com/MylesBorins |
| doc: add refack to collaborators | https://github.com/nodejs/node/pull/11652/commits/97097af16dbec31599e46bb8b5019c3698e79d62 |
| 97097af | https://github.com/nodejs/node/pull/11652/commits/97097af16dbec31599e46bb8b5019c3698e79d62 |
| nodejs#12277 | https://github.com/nodejs/node/pull/12277 |
| https://github.com/nodejs/node/blob/master/doc/onboarding.md | https://github.com/nodejs/node/blob/master/doc/onboarding.md |
|
| https://github.com/danbev |
|
| https://github.com/MylesBorins |
| deps: backport ec1ffe3 from upstream V8 | https://github.com/nodejs/node/pull/11652/commits/6e8419ecf222c2995db145dbe3bfec26c01affac |
| 6e8419e | https://github.com/nodejs/node/pull/11652/commits/6e8419ecf222c2995db145dbe3bfec26c01affac |
| https://codereview.chromium.org/2758373002 | https://codereview.chromium.org/2758373002 |
| nodejs#44136 | https://github.com/nodejs/node/pull/44136 |
| nodejs#12061 | https://github.com/nodejs/node/pull/12061 |
|
| https://github.com/bnoordhuis |
| Revert "v8: drop v8::FunctionCallbackInfo::NewTarget()" | https://github.com/nodejs/node/pull/11652/commits/4976e139bb7a21eecd554d56791a40fe38d20ebd |
| 4976e13 | https://github.com/nodejs/node/pull/11652/commits/4976e139bb7a21eecd554d56791a40fe38d20ebd |
| 47cbb88 | https://github.com/bnoordhuis/io.js/commit/47cbb88ac5929ce6ba17f681785034dd019ce063 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| force-pushed | https://github.com/nodejs/node/compare/1f0da51aa14acb8ecf782a73d918f84e5ced6d48..4976e139bb7a21eecd554d56791a40fe38d20ebd |
| 1f0da51 | https://github.com/nodejs/node/commit/1f0da51aa14acb8ecf782a73d918f84e5ced6d48 |
| 4976e13 | https://github.com/nodejs/node/commit/4976e139bb7a21eecd554d56791a40fe38d20ebd |
|
Compare
| https://github.com/nodejs/node/compare/1f0da51aa14acb8ecf782a73d918f84e5ced6d48..4976e139bb7a21eecd554d56791a40fe38d20ebd |
| April 19, 2017 08:44 | https://github.com/nodejs/node/pull/11652#event-1048126171 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Apr 19, 2017 | https://github.com/nodejs/node/pull/11652#issuecomment-295168719 |
| @MylesBorins | https://github.com/MylesBorins |
| https://ci.nodejs.org/job/node-test-pull-request/7509/ | https://ci.nodejs.org/job/node-test-pull-request/7509/ |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/657/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/657/ |
| Please reload this page | https://github.com/nodejs/node/pull/11652 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/404d1bc8af683be8ddf5ae981e83d8e5ff387257..99dab5bc2c10d2ce56b532a54d307b5f5cda1dc0 |
| 404d1bc | https://github.com/nodejs/node/commit/404d1bc8af683be8ddf5ae981e83d8e5ff387257 |
| 99dab5b | https://github.com/nodejs/node/commit/99dab5bc2c10d2ce56b532a54d307b5f5cda1dc0 |
|
Compare
| https://github.com/nodejs/node/compare/404d1bc8af683be8ddf5ae981e83d8e5ff387257..99dab5bc2c10d2ce56b532a54d307b5f5cda1dc0 |
| April 24, 2017 17:50 | https://github.com/nodejs/node/pull/11652#event-1055256464 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
lts-agenda
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-agenda |
| Apr 24, 2017 | https://github.com/nodejs/node/pull/11652#event-1055642910 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| force-pushed | https://github.com/nodejs/node/compare/f9198074128b3dff6760c4616ff1e0321024b26a..87534d6c254f0ecb14ed460e831b7fee8fc30a31 |
| f919807 | https://github.com/nodejs/node/commit/f9198074128b3dff6760c4616ff1e0321024b26a |
| 87534d6 | https://github.com/nodejs/node/commit/87534d6c254f0ecb14ed460e831b7fee8fc30a31 |
|
Compare
| https://github.com/nodejs/node/compare/f9198074128b3dff6760c4616ff1e0321024b26a..87534d6c254f0ecb14ed460e831b7fee8fc30a31 |
| May 2, 2017 18:01 | https://github.com/nodejs/node/pull/11652#event-1066029883 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| May 16, 2017 | https://github.com/nodejs/node/pull/11652#issuecomment-301651126 |
| c6060fa | https://github.com/nodejs/node/commit/c6060fa33219f327ee8a487a1299bd50dddf5bd3 |
| Please reload this page | https://github.com/nodejs/node/pull/11652 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| May 16, 2017 | https://github.com/nodejs/node/pull/11652#event-1083313512 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Sep 29, 2017
| https://github.com/nodejs/node/pull/11652#ref-issue-260208334 |
|
node-addon-api fails to build against node 4.x
nodejs/node-addon-api#142
| https://github.com/nodejs/node-addon-api/issues/142 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11652 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/11652/files/6b8f3c7a299a06374caebcd3956013f2117fd0f3 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/11652/files/6b8f3c7a299a06374caebcd3956013f2117fd0f3 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/11652/files/6b8f3c7a299a06374caebcd3956013f2117fd0f3 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/11652/files/6b8f3c7a299a06374caebcd3956013f2117fd0f3 |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| Please reload this page | https://github.com/nodejs/node/pull/11652 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/Fishrock123 |
|
| https://github.com/addaleax |
|
| https://github.com/jasnell |
|
| https://github.com/MylesBorins |
|
| https://github.com/cjihrig |
|
| https://github.com/mhdawson |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/sushi90 |
|
| https://github.com/mscdex |
|
| https://github.com/gibfahn |
|
| https://github.com/aqrln |
|
| https://github.com/sotayamashita |
|
| https://github.com/sam-github |
|
| https://github.com/zbjornson |
|
| https://github.com/edsadr |
|
| https://github.com/DavidGoussev |
|
| https://github.com/evanlucas |
|
| https://github.com/seishun |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |