René's URL Explorer Experiment


Title: net: remove misleading comment by bnoordhuis · Pull Request #11573 · nodejs/node · GitHub

Open Graph Title: net: remove misleading comment by bnoordhuis · Pull Request #11573 · nodejs/node

X Title: net: remove misleading comment by bnoordhuis · Pull Request #11573 · nodejs/node

Description: The allowHalfOpen comment was added in commit 8a3befa ("net: Refactor to use streams2") from 2012 but it wasn't true even then as far as I can tell: Node.js simply always does a shutdown(2) first. ...

Open Graph Description: The allowHalfOpen comment was added in commit 8a3befa ("net: Refactor to use streams2") from 2012 but it wasn't true even then as far as I can tell: Node.js simply always does a shutd...

X Description: The allowHalfOpen comment was added in commit 8a3befa ("net: Refactor to use streams2") from 2012 but it wasn't true even then as far as I can tell: Node.js simply always ...

Opengraph URL: https://github.com/nodejs/node/pull/11573

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f0b5d7ca-1ea7-a311-f3b9-57313188bd07
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD50:BB9B6:E114B5:13169E4:6969EF3B
html-safe-nonce140da756d9f3620ecfd34df5b30a17369e560f1ea89b57c0393b9909bad0f017
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDUwOkJCOUI2OkUxMTRCNToxMzE2OUU0OjY5NjlFRjNCIiwidmlzaXRvcl9pZCI6IjI4ODQxNzQ4MDEzNjM2NjA2MDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac60322ce675e6d138dc3ead073123e2a3b7cb6dc7c49847b66b924e306903b839
hovercard-subject-tagpull_request:108047286
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/11573/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2aa48c6d42c7afe97628c866d781e2a5aa43ee4a674817ec7309396560883e9c/nodejs/node/pull/11573
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2aa48c6d42c7afe97628c866d781e2a5aa43ee4a674817ec7309396560883e9c/nodejs/node/pull/11573
og:image:altThe allowHalfOpen comment was added in commit 8a3befa ("net: Refactor to use streams2") from 2012 but it wasn't true even then as far as I can tell: Node.js simply always does a shutd...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/11573#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11573
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11573
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/11573
Reloadhttps://github.com/nodejs/node/pull/11573
Reloadhttps://github.com/nodejs/node/pull/11573
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/11573
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/11573
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/11573#issue-comment-box
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:remove-net-commenthttps://github.com/bnoordhuis/io.js/tree/remove-net-comment
net: remove misleading comment https://github.com/nodejs/node/pull/11573#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:remove-net-commenthttps://github.com/bnoordhuis/io.js/tree/remove-net-comment
Conversation 1 https://github.com/nodejs/node/pull/11573
Commits 1 https://github.com/nodejs/node/pull/11573/commits
Checks 0 https://github.com/nodejs/node/pull/11573/checks
Files changed https://github.com/nodejs/node/pull/11573/files
Please reload this pagehttps://github.com/nodejs/node/pull/11573
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Feb 27, 2017https://github.com/nodejs/node/pull/11573#issue-210388370
8a3befahttps://github.com/nodejs/node/commit/8a3befa0c65ba2ee653e3d3b39360e974536f3ef
Please reload this pagehttps://github.com/nodejs/node/pull/11573
https://github.com/bnoordhuis
net: remove misleading commenthttps://github.com/nodejs/node/pull/11573/commits/2cfa4e233ba145fbc7c9b5dd397c76fa8bfc4897
2cfa4e2https://github.com/nodejs/node/pull/11573/commits/2cfa4e233ba145fbc7c9b5dd397c76fa8bfc4897
8a3befahttps://github.com/bnoordhuis/io.js/commit/8a3befa0c65ba2ee653e3d3b39360e974536f3ef
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
Feb 27, 2017https://github.com/nodejs/node/pull/11573#event-977782013
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 27, 2017 https://github.com/nodejs/node/pull/11573#pullrequestreview-24070425
View reviewed changes https://github.com/nodejs/node/pull/11573/files/2cfa4e233ba145fbc7c9b5dd397c76fa8bfc4897
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Feb 27, 2017 https://github.com/nodejs/node/pull/11573#pullrequestreview-24086736
View reviewed changes https://github.com/nodejs/node/pull/11573/files/2cfa4e233ba145fbc7c9b5dd397c76fa8bfc4897
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 1, 2017https://github.com/nodejs/node/pull/11573#issuecomment-283392955
Please reload this pagehttps://github.com/nodejs/node/pull/11573
04c1fbbhttps://github.com/nodejs/node/commit/04c1fbb0fa8cfa18c8b89985b777f37801660811
Please reload this pagehttps://github.com/nodejs/node/pull/11573
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 1, 2017https://github.com/nodejs/node/pull/11573#event-982159021
addaleaxhttps://github.com/addaleax
Mar 1, 2017 https://github.com/nodejs/node/pull/11573#ref-commit-04c1fbb
https://github.com/bnoordhuis
https://github.com/addaleax
net: remove misleading commenthttps://github.com/nodejs/node/commit/04c1fbb0fa8cfa18c8b89985b777f37801660811
04c1fbbhttps://github.com/nodejs/node/commit/04c1fbb0fa8cfa18c8b89985b777f37801660811
8a3befahttps://github.com/nodejs/node/commit/8a3befa0c65ba2ee653e3d3b39360e974536f3ef
#11573https://github.com/nodejs/node/pull/11573
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
March 2, 2017 10:58https://github.com/nodejs/node/pull/11573#event-983452499
addaleaxhttps://github.com/addaleax
Mar 5, 2017 https://github.com/nodejs/node/pull/11573#ref-commit-13cb8a6
https://github.com/bnoordhuis
https://github.com/addaleax
net: remove misleading commenthttps://github.com/nodejs/node/commit/13cb8a69e4704922646720aaa6e8be5acd4e076c
13cb8a6https://github.com/nodejs/node/commit/13cb8a69e4704922646720aaa6e8be5acd4e076c
8a3befahttps://github.com/nodejs/node/commit/8a3befa0c65ba2ee653e3d3b39360e974536f3ef
#11573https://github.com/nodejs/node/pull/11573
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Mar 8, 2017 https://github.com/nodejs/node/pull/11573#ref-pullrequest-212713511
v7.7.2 proposal #11745 https://github.com/nodejs/node/pull/11745
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x
Apr 17, 2017https://github.com/nodejs/node/pull/11573#event-1045222994
MylesBorinshttps://github.com/MylesBorins
Apr 17, 2017 https://github.com/nodejs/node/pull/11573#ref-commit-c60fd7f
https://github.com/bnoordhuis
https://github.com/MylesBorins
net: remove misleading commenthttps://github.com/nodejs/node/commit/c60fd7f640dd5d043a0fb8877192ccc4cf59ef06
c60fd7fhttps://github.com/nodejs/node/commit/c60fd7f640dd5d043a0fb8877192ccc4cf59ef06
8a3befahttps://github.com/nodejs/node/commit/8a3befa0c65ba2ee653e3d3b39360e974536f3ef
#11573https://github.com/nodejs/node/pull/11573
MylesBorinshttps://github.com/MylesBorins
Apr 19, 2017 https://github.com/nodejs/node/pull/11573#ref-commit-06752d1
https://github.com/bnoordhuis
https://github.com/MylesBorins
net: remove misleading commenthttps://github.com/nodejs/node/commit/06752d1fc004adf4e638541099236c31f0fb1400
06752d1https://github.com/nodejs/node/commit/06752d1fc004adf4e638541099236c31f0fb1400
8a3befahttps://github.com/nodejs/node/commit/8a3befa0c65ba2ee653e3d3b39360e974536f3ef
#11573https://github.com/nodejs/node/pull/11573
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 19, 2017 https://github.com/nodejs/node/pull/11573#ref-pullrequest-222580733
v6.10.3 proposal #12498 https://github.com/nodejs/node/pull/12498
andrew749https://github.com/andrew749
Jul 19, 2017 https://github.com/nodejs/node/pull/11573#ref-commit-7b305b1
https://github.com/bnoordhuis
https://github.com/andrew749
net: remove misleading commenthttps://github.com/michielbaird/node/commit/7b305b16195c86c7a174726f8303905c1ba1bead
7b305b1https://github.com/michielbaird/node/commit/7b305b16195c86c7a174726f8303905c1ba1bead
8a3befahttps://github.com/michielbaird/node/commit/8a3befa0c65ba2ee653e3d3b39360e974536f3ef
nodejs/node#11573https://github.com/nodejs/node/pull/11573
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11573
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/11573/files/2cfa4e233ba145fbc7c9b5dd397c76fa8bfc4897
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/11573/files/2cfa4e233ba145fbc7c9b5dd397c76fa8bfc4897
net https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet
Please reload this pagehttps://github.com/nodejs/node/pull/11573
https://github.com/bnoordhuis
https://github.com/addaleax
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.