René's URL Explorer Experiment


Title: url: use `hasIntl` instead of `try-catch` by watilde · Pull Request #11571 · nodejs/node · GitHub

Open Graph Title: url: use `hasIntl` instead of `try-catch` by watilde · Pull Request #11571 · nodejs/node

X Title: url: use `hasIntl` instead of `try-catch` by watilde · Pull Request #11571 · nodejs/node

Description: Like the other lib codes, we should use process.binding('config').hasIntl instead of try-catch to make sure icu is bonded or not. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes...

Open Graph Description: Like the other lib codes, we should use process.binding('config').hasIntl instead of try-catch to make sure icu is bonded or not. Checklist make -j4 test (UNIX), or vcbuild test (Windows...

X Description: Like the other lib codes, we should use process.binding('config').hasIntl instead of try-catch to make sure icu is bonded or not. Checklist make -j4 test (UNIX), or vcbuild test ...

Opengraph URL: https://github.com/nodejs/node/pull/11571

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:652630fe-944c-d22f-0b71-1d9c5b67bfd1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE61C:34359D:105415F:16ED276:696A362F
html-safe-nonceb7bfddea73ed805bb5294c3ab08539d763751d9b796351caea723505d723efb4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjFDOjM0MzU5RDoxMDU0MTVGOjE2RUQyNzY6Njk2QTM2MkYiLCJ2aXNpdG9yX2lkIjoiMjY2MzM2ODc5NzUwOTUzMTE4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac64caa4928165768ce4ed8d5d05cec90d6d918fe5c6a136adcb054f364e30014a
hovercard-subject-tagpull_request:108029226
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/11571/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a8e0841f3f988713725dd029ada88466a3801521e5131d198a45b2170bc3153d/nodejs/node/pull/11571
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a8e0841f3f988713725dd029ada88466a3801521e5131d198a45b2170bc3153d/nodejs/node/pull/11571
og:image:altLike the other lib codes, we should use process.binding('config').hasIntl instead of try-catch to make sure icu is bonded or not. Checklist make -j4 test (UNIX), or vcbuild test (Windows...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewatilde
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7a9163cefd1ea4bd06f8eb7c082f43e4e53f626f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/11571#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11571
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11571
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/11571
Reloadhttps://github.com/nodejs/node/pull/11571
Reloadhttps://github.com/nodejs/node/pull/11571
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/11571
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/11571
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/11571#issue-comment-box
watildehttps://github.com/watilde
nodejs:masterhttps://github.com/nodejs/node/tree/master
watilde:feature/url-hasIntlhttps://github.com/watilde/node/tree/feature/url-hasIntl
url: use hasIntl instead of try-catch https://github.com/nodejs/node/pull/11571#top
watildehttps://github.com/watilde
nodejs:masterhttps://github.com/nodejs/node/tree/master
watilde:feature/url-hasIntlhttps://github.com/watilde/node/tree/feature/url-hasIntl
Conversation 6 https://github.com/nodejs/node/pull/11571
Commits 1 https://github.com/nodejs/node/pull/11571/commits
Checks 0 https://github.com/nodejs/node/pull/11571/checks
Files changed https://github.com/nodejs/node/pull/11571/files
Please reload this pagehttps://github.com/nodejs/node/pull/11571
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/watilde
watildehttps://github.com/watilde
Feb 27, 2017https://github.com/nodejs/node/pull/11571#issue-210360580
Please reload this pagehttps://github.com/nodejs/node/pull/11571
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aurl
Feb 27, 2017https://github.com/nodejs/node/pull/11571#event-977618935
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 27, 2017 https://github.com/nodejs/node/pull/11571#pullrequestreview-23900547
View reviewed changes https://github.com/nodejs/node/pull/11571/files
https://github.com/JacksonTian
JacksonTianhttps://github.com/JacksonTian
Feb 27, 2017https://github.com/nodejs/node/pull/11571#issuecomment-282609647
Please reload this pagehttps://github.com/nodejs/node/pull/11571
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Feb 27, 2017 https://github.com/nodejs/node/pull/11571#pullrequestreview-23903394
View reviewed changes https://github.com/nodejs/node/pull/11571/files
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Feb 27, 2017https://github.com/nodejs/node/pull/11571#issuecomment-282610632
Please reload this pagehttps://github.com/nodejs/node/pull/11571
https://ci.nodejs.org/job/node-test-pull-request/6593/https://ci.nodejs.org/job/node-test-pull-request/6593/
Please reload this pagehttps://github.com/nodejs/node/pull/11571
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Feb 27, 2017 https://github.com/nodejs/node/pull/11571#pullrequestreview-23913369
View reviewed changes https://github.com/nodejs/node/pull/11571/files
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Feb 27, 2017https://github.com/nodejs/node/pull/11571#issuecomment-282671919
https://ci.nodejs.org/job/node-test-commit/8137/https://ci.nodejs.org/job/node-test-commit/8137/
Please reload this pagehttps://github.com/nodejs/node/pull/11571
https://github.com/lpinca
lpincahttps://github.com/lpinca
Feb 27, 2017 https://github.com/nodejs/node/pull/11571#pullrequestreview-24003427
View reviewed changes https://github.com/nodejs/node/pull/11571/files
https://github.com/watilde
watildehttps://github.com/watilde
Feb 28, 2017https://github.com/nodejs/node/pull/11571#issuecomment-282982799
Please reload this pagehttps://github.com/nodejs/node/pull/11571
https://github.com/watilde
url: use hasIntl instead of try-catchhttps://github.com/nodejs/node/pull/11571/commits/50e7e6e2f18fb9336b9bf211f7a9bb1d227fb826
50e7e6ehttps://github.com/nodejs/node/pull/11571/commits/50e7e6e2f18fb9336b9bf211f7a9bb1d227fb826
https://github.com/watilde
watildehttps://github.com/watilde
force-pushedhttps://github.com/nodejs/node/compare/15cf5ba334efc79c11035091dd6a3f87d50b8fec..50e7e6e2f18fb9336b9bf211f7a9bb1d227fb826
15cf5bahttps://github.com/nodejs/node/commit/15cf5ba334efc79c11035091dd6a3f87d50b8fec
50e7e6ehttps://github.com/nodejs/node/commit/50e7e6e2f18fb9336b9bf211f7a9bb1d227fb826
Compare https://github.com/nodejs/node/compare/15cf5ba334efc79c11035091dd6a3f87d50b8fec..50e7e6e2f18fb9336b9bf211f7a9bb1d227fb826
February 28, 2017 09:06https://github.com/nodejs/node/pull/11571#event-979782220
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 1, 2017 https://github.com/nodejs/node/pull/11571#pullrequestreview-24525438
View reviewed changes https://github.com/nodejs/node/pull/11571/files/50e7e6e2f18fb9336b9bf211f7a9bb1d227fb826
https://github.com/watilde
watildehttps://github.com/watilde
Mar 3, 2017https://github.com/nodejs/node/pull/11571#issuecomment-284007311
https://ci.nodejs.org/job/node-test-pull-request/6686/https://ci.nodejs.org/job/node-test-pull-request/6686/
Please reload this pagehttps://github.com/nodejs/node/pull/11571
jasnellhttps://github.com/jasnell
Mar 4, 2017 https://github.com/nodejs/node/pull/11571#ref-commit-cccc6d8
https://github.com/watilde
https://github.com/jasnell
url: use hasIntl instead of try-catchhttps://github.com/nodejs/node/commit/cccc6d8545c0ebd83f934b9734f5605aaeb000f2
cccc6d8https://github.com/nodejs/node/commit/cccc6d8545c0ebd83f934b9734f5605aaeb000f2
#11571https://github.com/nodejs/node/pull/11571
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 4, 2017https://github.com/nodejs/node/pull/11571#issuecomment-284160924
cccc6d8https://github.com/nodejs/node/commit/cccc6d8545c0ebd83f934b9734f5605aaeb000f2
Please reload this pagehttps://github.com/nodejs/node/pull/11571
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 4, 2017https://github.com/nodejs/node/pull/11571#event-986499632
https://github.com/watilde
watildehttps://github.com/watilde
March 4, 2017 16:15https://github.com/nodejs/node/pull/11571#event-986501476
addaleaxhttps://github.com/addaleax
Mar 5, 2017 https://github.com/nodejs/node/pull/11571#ref-commit-24e6fcc
https://github.com/watilde
https://github.com/addaleax
url: use hasIntl instead of try-catchhttps://github.com/nodejs/node/commit/24e6fcce8b61fe3b94dc5d86af0ce15e180a367a
24e6fcchttps://github.com/nodejs/node/commit/24e6fcce8b61fe3b94dc5d86af0ce15e180a367a
#11571https://github.com/nodejs/node/pull/11571
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Mar 8, 2017 https://github.com/nodejs/node/pull/11571#ref-pullrequest-212713511
v7.7.2 proposal #11745 https://github.com/nodejs/node/pull/11745
MylesBorinshttps://github.com/MylesBorins
Apr 17, 2017 https://github.com/nodejs/node/pull/11571#ref-commit-e6c65b2
https://github.com/watilde
https://github.com/MylesBorins
url: use hasIntl instead of try-catchhttps://github.com/nodejs/node/commit/e6c65b22cfcda08a2e055269c506202c0ad49624
e6c65b2https://github.com/nodejs/node/commit/e6c65b22cfcda08a2e055269c506202c0ad49624
#11571https://github.com/nodejs/node/pull/11571
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v6.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x
Apr 17, 2017https://github.com/nodejs/node/pull/11571#event-1045629620
MylesBorinshttps://github.com/MylesBorins
Apr 19, 2017 https://github.com/nodejs/node/pull/11571#ref-commit-6344997
https://github.com/watilde
https://github.com/MylesBorins
url: use hasIntl instead of try-catchhttps://github.com/nodejs/node/commit/63449972d13f8321bd754879660549eda00844de
6344997https://github.com/nodejs/node/commit/63449972d13f8321bd754879660549eda00844de
#11571https://github.com/nodejs/node/pull/11571
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 19, 2017 https://github.com/nodejs/node/pull/11571#ref-pullrequest-222580733
v6.10.3 proposal #12498 https://github.com/nodejs/node/pull/12498
andrew749https://github.com/andrew749
Jul 19, 2017 https://github.com/nodejs/node/pull/11571#ref-commit-ae48e46
https://github.com/watilde
https://github.com/andrew749
url: use hasIntl instead of try-catchhttps://github.com/michielbaird/node/commit/ae48e46bf14f8915f81a057ee595a396ca57c8db
ae48e46https://github.com/michielbaird/node/commit/ae48e46bf14f8915f81a057ee595a396ca57c8db
nodejs/node#11571https://github.com/nodejs/node/pull/11571
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11571
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/11571/files/15cf5ba334efc79c11035091dd6a3f87d50b8fec
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/11571/files/50e7e6e2f18fb9336b9bf211f7a9bb1d227fb826
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/11571/files/15cf5ba334efc79c11035091dd6a3f87d50b8fec
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/11571/files/15cf5ba334efc79c11035091dd6a3f87d50b8fec
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/11571/files/15cf5ba334efc79c11035091dd6a3f87d50b8fec
url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aurl
Please reload this pagehttps://github.com/nodejs/node/pull/11571
https://github.com/watilde
https://github.com/JacksonTian
https://github.com/TimothyGu
https://github.com/gibfahn
https://github.com/jasnell
https://github.com/addaleax
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/MylesBorins
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.