René's URL Explorer Experiment


Title: test: favor assertions over console logging by Trott · Pull Request #11547 · nodejs/node · GitHub

Open Graph Title: test: favor assertions over console logging by Trott · Pull Request #11547 · nodejs/node

X Title: test: favor assertions over console logging by Trott · Pull Request #11547 · nodejs/node

Description: Communicate about leaked globals via AssertionError rather than console.log(). Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines Affect...

Open Graph Description: Communicate about leaked globals via AssertionError rather than console.log(). Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines Affect...

X Description: Communicate about leaked globals via AssertionError rather than console.log(). Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines Affect...

Opengraph URL: https://github.com/nodejs/node/pull/11547

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:452adf4b-b1c7-cd31-422d-63b27dc3cb24
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE8C2:194D77:B4E4DC:FE91C8:696A1D74
html-safe-nonce9a1c53527fd4b380f62f35535f59f82f0fec096966cde68d1a7c987139be6f4b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOEMyOjE5NEQ3NzpCNEU0REM6RkU5MUM4OjY5NkExRDc0IiwidmlzaXRvcl9pZCI6IjM3NzM0MzcyMDg4MjMxNDYxMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9a3f2506999594650f7b862865f6f098afb3a530e4994c48ee38aebb6533238d
hovercard-subject-tagpull_request:107949190
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/11547
twitter:imagehttps://opengraph.githubassets.com/db4d9105e66e88a6bb79229c39f58f340c9b92a5a8cd8d1723e08fc84179ac5a/nodejs/node/pull/11547
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/db4d9105e66e88a6bb79229c39f58f340c9b92a5a8cd8d1723e08fc84179ac5a/nodejs/node/pull/11547
og:image:altCommunicate about leaked globals via AssertionError rather than console.log(). Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines Affect...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released515f6f09fa57a93bf90355cb894eb84ca4f458f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/11547#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11547
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11547
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/11547
Reloadhttps://github.com/nodejs/node/pull/11547
Reloadhttps://github.com/nodejs/node/pull/11547
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/11547
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 698 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/11547
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/11547#issue-comment-box
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:leakhttps://github.com/Trott/io.js/tree/leak
test: favor assertions over console logging https://github.com/nodejs/node/pull/11547#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:leakhttps://github.com/Trott/io.js/tree/leak
Conversation 3 https://github.com/nodejs/node/pull/11547
Commits 1 https://github.com/nodejs/node/pull/11547/commits
Checks 0 https://github.com/nodejs/node/pull/11547/checks
Files changed https://github.com/nodejs/node/pull/11547/files
Please reload this pagehttps://github.com/nodejs/node/pull/11547
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/Trott
Trotthttps://github.com/Trott
Feb 25, 2017https://github.com/nodejs/node/pull/11547#issue-210214713
Please reload this pagehttps://github.com/nodejs/node/pull/11547
https://github.com/Trott
Trotthttps://github.com/Trott
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Feb 25, 2017https://github.com/nodejs/node/pull/11547#event-976999790
https://github.com/lpinca
lpincahttps://github.com/lpinca
Feb 25, 2017 https://github.com/nodejs/node/pull/11547#pullrequestreview-23852497
View reviewed changes https://github.com/nodejs/node/pull/11547/files
https://github.com/gibfahn
gibfahnhttps://github.com/gibfahn
Feb 25, 2017 https://github.com/nodejs/node/pull/11547#pullrequestreview-23853228
View reviewed changes https://github.com/nodejs/node/pull/11547/files
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Feb 25, 2017 https://github.com/nodejs/node/pull/11547#pullrequestreview-23853607
View reviewed changes https://github.com/nodejs/node/pull/11547/files
TimothyGuhttps://github.com/TimothyGu
https://github.com/nodejs/node/pull/11547#pullrequestreview-23853607
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/11547
test/common.jshttps://github.com/nodejs/node/pull/11547/files#diff-5c1ae2b5e56dedb8288bbde987415e6c63f6805f2e1d07e8c04cbf4e1b5fcc4b
TimothyGuhttps://github.com/TimothyGu
Feb 25, 2017https://github.com/nodejs/node/pull/11547#discussion_r103074124
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/11547
https://github.com/hiroppy
hiroppyhttps://github.com/hiroppy
Feb 25, 2017 https://github.com/nodejs/node/pull/11547#pullrequestreview-23859179
View reviewed changes https://github.com/nodejs/node/pull/11547/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 25, 2017 https://github.com/nodejs/node/pull/11547#pullrequestreview-23860957
View reviewed changes https://github.com/nodejs/node/pull/11547/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Feb 25, 2017 https://github.com/nodejs/node/pull/11547#pullrequestreview-23861040
View reviewed changes https://github.com/nodejs/node/pull/11547/files
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 25, 2017 https://github.com/nodejs/node/pull/11547#pullrequestreview-23862478
View reviewed changes https://github.com/nodejs/node/pull/11547/files
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/bce868168d55ff2a3ac37e2275ada276cf5c5252..71dcf11528d21be38c8ab1d04de1d9018995a6b2
bce8681https://github.com/nodejs/node/commit/bce868168d55ff2a3ac37e2275ada276cf5c5252
71dcf11https://github.com/nodejs/node/commit/71dcf11528d21be38c8ab1d04de1d9018995a6b2
Compare https://github.com/nodejs/node/compare/bce868168d55ff2a3ac37e2275ada276cf5c5252..71dcf11528d21be38c8ab1d04de1d9018995a6b2
February 25, 2017 22:43https://github.com/nodejs/node/pull/11547#event-977234756
https://github.com/Trott
test: favor assertions over console logginghttps://github.com/nodejs/node/pull/11547/commits/c9ad5097ea72b9bc48aca2f0eb2931ab8bb719cf
c9ad509https://github.com/nodejs/node/pull/11547/commits/c9ad5097ea72b9bc48aca2f0eb2931ab8bb719cf
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/443ccf8c2078a952276c69e53732d3b2f32cd517..c9ad5097ea72b9bc48aca2f0eb2931ab8bb719cf
443ccf8https://github.com/nodejs/node/commit/443ccf8c2078a952276c69e53732d3b2f32cd517
c9ad509https://github.com/nodejs/node/commit/c9ad5097ea72b9bc48aca2f0eb2931ab8bb719cf
Compare https://github.com/nodejs/node/compare/443ccf8c2078a952276c69e53732d3b2f32cd517..c9ad5097ea72b9bc48aca2f0eb2931ab8bb719cf
February 26, 2017 00:27https://github.com/nodejs/node/pull/11547#event-977256875
jasnellhttps://github.com/jasnell
Feb 27, 2017 https://github.com/nodejs/node/pull/11547#ref-commit-12de99d
https://github.com/Trott
https://github.com/jasnell
test: favor assertions over console logginghttps://github.com/nodejs/node/commit/12de99d982c85f3e0b5076b85d9af58cf46c0097
12de99dhttps://github.com/nodejs/node/commit/12de99d982c85f3e0b5076b85d9af58cf46c0097
#11547https://github.com/nodejs/node/pull/11547
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 27, 2017https://github.com/nodejs/node/pull/11547#issuecomment-282840080
12de99dhttps://github.com/nodejs/node/commit/12de99d982c85f3e0b5076b85d9af58cf46c0097
https://ci.nodejs.org/job/node-test-pull-request/6606/https://ci.nodejs.org/job/node-test-pull-request/6606/
Please reload this pagehttps://github.com/nodejs/node/pull/11547
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 27, 2017https://github.com/nodejs/node/pull/11547#event-979010105
italoacasashttps://github.com/italoacasas
Feb 28, 2017 https://github.com/nodejs/node/pull/11547#ref-commit-f193c6f
https://github.com/Trott
test: favor assertions over console logginghttps://github.com/italoacasas/node/commit/f193c6f996bce6979c017bdb94886dee9f3bc6f4
f193c6fhttps://github.com/italoacasas/node/commit/f193c6f996bce6979c017bdb94886dee9f3bc6f4
nodejs#11547https://github.com/nodejs/node/pull/11547
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
Feb 28, 2017 https://github.com/nodejs/node/pull/11547#ref-pullrequest-210245474
7.7.0 Proposal #11553 https://github.com/nodejs/node/pull/11553
jasnellhttps://github.com/jasnell
Mar 7, 2017 https://github.com/nodejs/node/pull/11547#ref-commit-c976aad
https://github.com/Trott
https://github.com/jasnell
test: favor assertions over console logginghttps://github.com/nodejs/node/commit/c976aade27624e63aecde27d35b6927eac961b27
c976aadhttps://github.com/nodejs/node/commit/c976aade27624e63aecde27d35b6927eac961b27
#11547https://github.com/nodejs/node/pull/11547
jasnellhttps://github.com/jasnell
Mar 7, 2017 https://github.com/nodejs/node/pull/11547#ref-commit-67a6b13
https://github.com/Trott
https://github.com/jasnell
test: favor assertions over console logginghttps://github.com/nodejs/node/commit/67a6b1336c1975fa7eb5e092b8a35d715e1d0cea
67a6b13https://github.com/nodejs/node/commit/67a6b1336c1975fa7eb5e092b8a35d715e1d0cea
#11547https://github.com/nodejs/node/pull/11547
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/11547#ref-commit-6e5f6e3
https://github.com/Trott
https://github.com/MylesBorins
test: favor assertions over console logginghttps://github.com/nodejs/node/commit/6e5f6e3c024ca10dbcd7996bf015c202d125eb64
6e5f6e3https://github.com/nodejs/node/commit/6e5f6e3c024ca10dbcd7996bf015c202d125eb64
#11547https://github.com/nodejs/node/pull/11547
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/11547#ref-pullrequest-212909365
v6.10.1 proposal #11759 https://github.com/nodejs/node/pull/11759
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/11547#ref-commit-53f2848
https://github.com/Trott
https://github.com/MylesBorins
test: favor assertions over console logginghttps://github.com/nodejs/node/commit/53f2848dc8932df61c0ea7a93ebeeaf1f357ff92
53f2848https://github.com/nodejs/node/commit/53f2848dc8932df61c0ea7a93ebeeaf1f357ff92
#11547https://github.com/nodejs/node/pull/11547
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/11547#ref-pullrequest-212910576
v4.8.1 proposal #11760 https://github.com/nodejs/node/pull/11760
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:34https://github.com/nodejs/node/pull/11547#event-5890899815
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11547
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/11547/files/bce868168d55ff2a3ac37e2275ada276cf5c5252
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/11547/files/bce868168d55ff2a3ac37e2275ada276cf5c5252
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/11547/files/bce868168d55ff2a3ac37e2275ada276cf5c5252
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/11547/files/bce868168d55ff2a3ac37e2275ada276cf5c5252
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
https://github.com/nodejs/node/pull/11547/files/bce868168d55ff2a3ac37e2275ada276cf5c5252
https://github.com/hiroppy
hiroppy https://github.com/hiroppy
https://github.com/nodejs/node/pull/11547/files/bce868168d55ff2a3ac37e2275ada276cf5c5252
https://github.com/gibfahn
gibfahn https://github.com/gibfahn
https://github.com/nodejs/node/pull/11547/files/bce868168d55ff2a3ac37e2275ada276cf5c5252
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/11547
https://github.com/Trott
https://github.com/jasnell
https://github.com/addaleax
https://github.com/lpinca
https://github.com/TimothyGu
https://github.com/cjihrig
https://github.com/hiroppy
https://github.com/gibfahn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.