| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:266b5397-1d27-763b-0aa8-676d49d0eb6f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E134:1EEA:319763D:46FEE99:6A4FBD1C |
| html-safe-nonce | b20c0ec9a70fdc2b2572bd80d8579eab4b013eb0d7c5c9a504d9ebfc741050b4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTM0OjFFRUE6MzE5NzYzRDo0NkZFRTk5OjZBNEZCRDFDIiwidmlzaXRvcl9pZCI6Ijc2OTkxODg3ODQ5NjE2NjYzMzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9ba3cabcd4e7447d4ceaa2d7927b06879dde09d39b800f2002bb62aabdd7b237 |
| hovercard-subject-tag | pull_request:31176336 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/1152/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4778608706965a6e3273c7ed87459fe2c991b827c6a399916bfaacd9db1965ff/nodejs/node/pull/1152 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4778608706965a6e3273c7ed87459fe2c991b827c6a399916bfaacd9db1965ff/nodejs/node/pull/1152 |
| og:image:alt | Port of nodejs/node-v0.x-archive@0d05123
Fixes: #1151 (Not really. It's complicated. #1152 (comment))
Not sure what to call the test, or even if this test is particularly good. (or if it even n... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Fishrock123 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d8f8209b188a80e19a6957836ab9229715797be5db1a04163963c674ccc33f6 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ea848e83cf3bf3613dd7b13d52965a684fd23ec5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/1152#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1152 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1152 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/1152 |
| Reload | https://github.com/nodejs/node/pull/1152 |
| Reload | https://github.com/nodejs/node/pull/1152 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
973
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Fishrock123 | https://github.com/Fishrock123 |
| nodejs:v1.x | https://github.com/nodejs/node/tree/v1.x |
| Fishrock123:fix-1151 | https://github.com/Fishrock123/node/tree/fix-1151 |
| Conversation | https://github.com/nodejs/node/pull/1152 |
| Commits2 (2) | https://github.com/nodejs/node/pull/1152/commits |
| Checks | https://github.com/nodejs/node/pull/1152/checks |
| Files changed | https://github.com/nodejs/node/pull/1152/files |
| timers: fix unref() memory leak | https://github.com/nodejs/node/pull/1152#top |
| Fishrock123 | https://github.com/Fishrock123 |
| nodejs:v1.x | https://github.com/nodejs/node/tree/v1.x |
| Fishrock123:fix-1151 | https://github.com/Fishrock123/node/tree/fix-1151 |
|
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 14, 2015 | https://github.com/nodejs/node/pull/1152#issue-61349699 |
| nodejs/node-v0.x-archive@0d05123 | https://github.com/nodejs/node-v0.x-archive/commit/0d051238be2e07e671d7d9f4f444e0cc1efadf1b |
| #1151 | https://github.com/nodejs/node/issues/1151 |
| #1152 (comment) | https://github.com/nodejs/node/pull/1152#issuecomment-86149840 |
| @trevnorris | https://github.com/trevnorris |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
timers
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers |
| Mar 14, 2015 | https://github.com/nodejs/node/pull/1152#event-252940113 |
| brendanashworth | https://github.com/brendanashworth |
|
Mar 14, 2015
| https://github.com/nodejs/node/pull/1152#discussion-diff-26435780 |
| View reviewed changes
| https://github.com/nodejs/node/pull/1152/files#diff-fc5e8023a96ab2fa07abad098140cd7b9cdbd73480183fb6c30031ee357122f9 |
| test/parallel/test-regress-GH-io-1151.js | https://github.com/nodejs/node/pull/1152/files#diff-fc5e8023a96ab2fa07abad098140cd7b9cdbd73480183fb6c30031ee357122f9 |
| brendanashworth | https://github.com/brendanashworth |
| Mar 14, 2015 | https://github.com/nodejs/node/pull/1152#discussion_r26435780 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 14, 2015 | https://github.com/nodejs/node/pull/1152#discussion_r26438169 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| force-pushed | https://github.com/nodejs/node/compare/3c7a81de6e8efd4c4187720b1ac3f4daccacbca3..5d0f2bfc3319612f10d71d060372b4c0c517d9fc |
| 3c7a81d | https://github.com/nodejs/node/commit/3c7a81de6e8efd4c4187720b1ac3f4daccacbca3 |
| 5d0f2bf | https://github.com/nodejs/node/commit/5d0f2bfc3319612f10d71d060372b4c0c517d9fc |
|
Compare
| https://github.com/nodejs/node/compare/3c7a81de6e8efd4c4187720b1ac3f4daccacbca3..5d0f2bfc3319612f10d71d060372b4c0c517d9fc |
| March 14, 2015 14:22 | https://github.com/nodejs/node/pull/1152#event-253722014 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 16, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-81957635 |
| @trevnorris | https://github.com/trevnorris |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Mar 17, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-82543782 |
| @Fishrock123 | https://github.com/Fishrock123 |
| #1151 | https://github.com/nodejs/node/issues/1151 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 17, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-82576260 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Mar 17, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-82576748 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 17, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-82578200 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Mar 17, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-82606396 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| force-pushed | https://github.com/nodejs/node/compare/5d0f2bfc3319612f10d71d060372b4c0c517d9fc..f35f62f534da4d71b2499a0a50639350bc854ae3 |
| 5d0f2bf | https://github.com/nodejs/node/commit/5d0f2bfc3319612f10d71d060372b4c0c517d9fc |
| f35f62f | https://github.com/nodejs/node/commit/f35f62f534da4d71b2499a0a50639350bc854ae3 |
|
Compare
| https://github.com/nodejs/node/compare/5d0f2bfc3319612f10d71d060372b4c0c517d9fc..f35f62f534da4d71b2499a0a50639350bc854ae3 |
| March 17, 2015 21:41 | https://github.com/nodejs/node/pull/1152#event-257444047 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 17, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-82610406 |
| @trevnorris | https://github.com/trevnorris |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Mar 17, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-82612318 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 17, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-82613380 |
| @trevnorris | https://github.com/trevnorris |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Mar 17, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-82617030 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 17, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-82617337 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Mar 18, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-83054684 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Mar 18, 2015
| https://github.com/nodejs/node/pull/1152#ref-issue-62754134 |
|
setTimeout can fire twice
#1191
| https://github.com/nodejs/node/issues/1191 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 18, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-83092726 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Mar 18, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-83110691 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Mar 24, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-85723914 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 25, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-85775688 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
|
Mar 25, 2015
| https://github.com/nodejs/node/pull/1152#ref-issue-64148220 |
|
Release proposal: v1.6.3
#1252
| https://github.com/nodejs/node/issues/1252 |
| https://github.com/thlorenz |
| thlorenz | https://github.com/thlorenz |
|
Mar 25, 2015
| https://github.com/nodejs/node/pull/1152#ref-issue-61288507 |
|
Timer's unref unreliable when http module required after using them
#1151
| https://github.com/nodejs/node/issues/1151 |
| https://github.com/thlorenz |
| thlorenz | https://github.com/thlorenz |
| Mar 25, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-86086878 |
| @brycebaril | https://github.com/brycebaril |
| not fixed either | https://github.com/iojs/io.js/issues/1151#issuecomment-86081832 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/thlorenz |
| thlorenz | https://github.com/thlorenz |
| Mar 25, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-86105885 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 25, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-86107530 |
| @thlorenz | https://github.com/thlorenz |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/thlorenz |
| thlorenz | https://github.com/thlorenz |
| Mar 25, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-86108302 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/thlorenz |
| thlorenz | https://github.com/thlorenz |
| Mar 25, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-86120340 |
| 056ed4b | https://github.com/iojs/io.js/commit/056ed4b0c9753318ce8f5a88659467579acb3faf |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 25, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-86120793 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| force-pushed | https://github.com/nodejs/node/compare/f35f62f534da4d71b2499a0a50639350bc854ae3..8931fd51ae86aef2cb3b680aa4827af26501b098 |
| f35f62f | https://github.com/nodejs/node/commit/f35f62f534da4d71b2499a0a50639350bc854ae3 |
| 8931fd5 | https://github.com/nodejs/node/commit/8931fd51ae86aef2cb3b680aa4827af26501b098 |
|
Compare
| https://github.com/nodejs/node/compare/f35f62f534da4d71b2499a0a50639350bc854ae3..8931fd51ae86aef2cb3b680aa4827af26501b098 |
| March 25, 2015 18:27 | https://github.com/nodejs/node/pull/1152#event-265044109 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Mar 25, 2015
| https://github.com/nodejs/node/pull/1152#ref-commit-33fea6e |
|
| https://github.com/bnoordhuis |
| lib: don't penalize setInterval() common case | https://github.com/nodejs/node/commit/33fea6ed5f506e7748cb9132f63dc03215a9eb39 |
|
| https://github.com/nodejs/node/commit/33fea6ed5f506e7748cb9132f63dc03215a9eb39#comments |
| 33fea6e | https://github.com/nodejs/node/commit/33fea6ed5f506e7748cb9132f63dc03215a9eb39 |
| #1221 | https://github.com/nodejs/node/pull/1221 |
| https://github.com/brycebaril |
| brycebaril | https://github.com/brycebaril |
| Mar 25, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-86222309 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Mar 25, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-86248631 |
| @brycebaril | https://github.com/brycebaril |
| #1231 | https://github.com/nodejs/node/pull/1231 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/brycebaril |
| brycebaril | https://github.com/brycebaril |
| Mar 25, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-86251227 |
| @silverwind | https://github.com/silverwind |
| #1231 | https://github.com/nodejs/node/pull/1231 |
| @trevnorris | https://github.com/trevnorris |
| nodejs/node-v0.x-archive@a2eeb43 | https://github.com/nodejs/node-v0.x-archive/commit/a2eeb43 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/silverwind |
| silverwind | https://github.com/silverwind |
| Mar 25, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-86254455 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/brycebaril |
| brycebaril | https://github.com/brycebaril |
|
Mar 26, 2015
| https://github.com/nodejs/node/pull/1152#ref-issue-64403468 |
|
unref'd timers running in beforeExit time
#1264
| https://github.com/nodejs/node/issues/1264 |
|
Fix timers
#336
| https://github.com/nodejs/node/pull/336 |
|
Unreferenced timers run during beforeExit timeframe
nodejs/node-v0.x-archive#14171
| https://github.com/nodejs/node-v0.x-archive/issues/14171 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 27, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-87075932 |
| 33fea6e#commitcomment-10436644 | https://github.com/nodejs/node/commit/33fea6ed5f506e7748cb9132f63dc03215a9eb39#commitcomment-10436644 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| thlorenz | https://github.com/thlorenz |
|
Mar 30, 2015
| https://github.com/nodejs/node/pull/1152#ref-commit-a2eeb43 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/indutny |
| src: emit 'beforeExit' event on process object | https://github.com/nodejs/node-v0.x-archive/commit/a2eeb43deda58e7bbb8fcf24b934157992b937c0 |
|
| https://github.com/nodejs/node-v0.x-archive/commit/a2eeb43deda58e7bbb8fcf24b934157992b937c0#comments |
| a2eeb43 | https://github.com/nodejs/node-v0.x-archive/commit/a2eeb43deda58e7bbb8fcf24b934157992b937c0 |
| #6305 | https://github.com/nodejs/node-v0.x-archive/issues/6305 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Apr 1, 2015
| https://github.com/nodejs/node/pull/1152#ref-pullrequest-65765504 |
|
WIP src: don't check closing handles on beforeExit
#1317
| https://github.com/nodejs/node/pull/1317 |
| https://github.com/Olegas |
| Olegas | https://github.com/Olegas |
| Apr 2, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-88870832 |
| https://cloud.githubusercontent.com/assets/389390/6963180/a959583c-d944-11e4-8ee9-82f43cb92b19.PNG |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Apr 2, 2015
| https://github.com/nodejs/node/pull/1152#ref-issue-60021669 |
|
Possible memory leak in TLS(Wrap?)
#1075
| https://github.com/nodejs/node/issues/1075 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Apr 2, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-88982556 |
| 33fea6e#commitcomment-10440550 | https://github.com/nodejs/node/commit/33fea6ed5f506e7748cb9132f63dc03215a9eb39#commitcomment-10440550 |
| @trevnorris | https://github.com/trevnorris |
| #1075 | https://github.com/nodejs/node/issues/1075 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| indutny | https://github.com/indutny |
| Apr 2, 2015 | https://github.com/nodejs/node/pull/1152#event-271957320 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
| Apr 2, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-88994169 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
confirmed-bug
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aconfirmed-bug |
| Apr 2, 2015 | https://github.com/nodejs/node/pull/1152#event-271958454 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
| Apr 2, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-89060108 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| trevnorris | https://github.com/trevnorris |
| April 2, 2015 18:20 | https://github.com/nodejs/node/pull/1152#commits-pushed-47335ce |
|
| https://github.com/trevnorris |
|
| https://github.com/Fishrock123 |
| timers: fix unref() memory leak | https://github.com/nodejs/node/pull/1152/commits/47335ce56fdede2219233100039981efe5c8efbe |
| 47335ce | https://github.com/nodejs/node/pull/1152/commits/47335ce56fdede2219233100039981efe5c8efbe |
| nodejs/node-v0.x-archive#8364 | https://github.com/nodejs/node-v0.x-archive/issues/8364 |
|
| https://github.com/Fishrock123 |
| timers: don't close interval timers when unrefd | https://github.com/nodejs/node/pull/1152/commits/ba676bfff598a0731da2c9153a11c81ded0e5d18 |
| ba676bf | https://github.com/nodejs/node/pull/1152/commits/ba676bfff598a0731da2c9153a11c81ded0e5d18 |
| 0d05123 | https://github.com/Fishrock123/node/commit/0d051238be2e07e671d7d9f4f444e0cc1efadf1b |
| nodejs/node-v0.x-archive#8900 | https://github.com/nodejs/node-v0.x-archive/issues/8900 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| force-pushed | https://github.com/nodejs/node/compare/8931fd51ae86aef2cb3b680aa4827af26501b098..ba676bfff598a0731da2c9153a11c81ded0e5d18 |
| 8931fd5 | https://github.com/nodejs/node/commit/8931fd51ae86aef2cb3b680aa4827af26501b098 |
| ba676bf | https://github.com/nodejs/node/commit/ba676bfff598a0731da2c9153a11c81ded0e5d18 |
|
Compare
| https://github.com/nodejs/node/compare/8931fd51ae86aef2cb3b680aa4827af26501b098..ba676bfff598a0731da2c9153a11c81ded0e5d18 |
| April 2, 2015 22:23 | https://github.com/nodejs/node/pull/1152#event-272161601 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Apr 2, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-89064363 |
| @indutny | https://github.com/indutny |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
| Apr 2, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-89065506 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
|
Apr 2, 2015
| https://github.com/nodejs/node/pull/1152#ref-pullrequest-66026500 |
|
Fix timer .unref() handle management once and for all
#1330
| https://github.com/nodejs/node/pull/1330 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Apr 2, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-89071848 |
| @indutny | https://github.com/indutny |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Apr 2, 2015 | https://github.com/nodejs/node/pull/1152#event-272186611 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| April 4, 2015 00:19 | https://github.com/nodejs/node/pull/1152#event-273098881 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Apr 4, 2015 | https://github.com/nodejs/node/pull/1152#issuecomment-89472067 |
| #1330 | https://github.com/nodejs/node/pull/1330 |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
memory
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amemory |
| Aug 17, 2015 | https://github.com/nodejs/node/pull/1152#event-384364909 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F1152 |
|
| https://github.com/indutny |
|
indutny
| https://github.com/indutny |
|
confirmed-bug
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aconfirmed-bug |
|
memory
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amemory |
|
timers
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atimers |
| Please reload this page | https://github.com/nodejs/node/pull/1152 |
|
| https://github.com/Fishrock123 |
|
| https://github.com/trevnorris |
|
| https://github.com/thlorenz |
|
| https://github.com/brycebaril |
|
| https://github.com/silverwind |
|
| https://github.com/Olegas |
|
| https://github.com/indutny |
|
| https://github.com/bnoordhuis |
|
| https://github.com/brendanashworth |
|
| https://github.com/ChALkeR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |