René's URL Explorer Experiment


Title: doc,test: args to `buffer.copy` can be Uint8Arrays by addaleax · Pull Request #11486 · nodejs/node · GitHub

Open Graph Title: doc,test: args to `buffer.copy` can be Uint8Arrays by addaleax · Pull Request #11486 · nodejs/node

X Title: doc,test: args to `buffer.copy` can be Uint8Arrays by addaleax · Pull Request #11486 · nodejs/node

Description: This was semi-overlooked in #10236 because it always worked and didn’t need additional changes. Ref: #10236 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmar...

Open Graph Description: This was semi-overlooked in #10236 because it always worked and didn’t need additional changes. Ref: #10236 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmar...

X Description: This was semi-overlooked in #10236 because it always worked and didn’t need additional changes. Ref: #10236 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmar...

Opengraph URL: https://github.com/nodejs/node/pull/11486

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cbd27c1e-2b92-7e35-d470-badf9c9a0419
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA80E:34E8DF:58DC03:7CCF0C:696A0F89
html-safe-nonce037ef93272852b578753a22c7515392f32f906104e47de839c2dc5c6167d0eb5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODBFOjM0RThERjo1OERDMDM6N0NDRjBDOjY5NkEwRjg5IiwidmlzaXRvcl9pZCI6IjE0MjEyNDQ4NTA4NDQwNzc5NjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac658da80e6e65d59db8bf342863a1703f76e77b642b5337355ac8bc44c36be309
hovercard-subject-tagpull_request:107301224
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/11486/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/38748eb6759fab31a8f2aef6f5a9eec94145c012d55f7ae3f55184380d394b2e/nodejs/node/pull/11486
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/38748eb6759fab31a8f2aef6f5a9eec94145c012d55f7ae3f55184380d394b2e/nodejs/node/pull/11486
og:image:altThis was semi-overlooked in #10236 because it always worked and didn’t need additional changes. Ref: #10236 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmar...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7266b2d935baa1c6474b16dd9feaa5ca30607261
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/11486#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11486
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11486
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/11486
Reloadhttps://github.com/nodejs/node/pull/11486
Reloadhttps://github.com/nodejs/node/pull/11486
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/11486
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 698 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/11486
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/11486#issue-comment-box
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:buf-copy-uint8arrayhttps://github.com/addaleax/node/tree/buf-copy-uint8array
doc,test: args to buffer.copy can be Uint8Arrays https://github.com/nodejs/node/pull/11486#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:buf-copy-uint8arrayhttps://github.com/addaleax/node/tree/buf-copy-uint8array
Conversation 5 https://github.com/nodejs/node/pull/11486
Commits 1 https://github.com/nodejs/node/pull/11486/commits
Checks 0 https://github.com/nodejs/node/pull/11486/checks
Files changed https://github.com/nodejs/node/pull/11486/files
Please reload this pagehttps://github.com/nodejs/node/pull/11486
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 21, 2017https://github.com/nodejs/node/pull/11486#issue-209303599
Please reload this pagehttps://github.com/nodejs/node/pull/11486
#10236https://github.com/nodejs/node/pull/10236
#10236https://github.com/nodejs/node/pull/10236
https://ci.nodejs.org/job/node-test-commit/8059/https://ci.nodejs.org/job/node-test-commit/8059/
Please reload this pagehttps://github.com/nodejs/node/pull/11486
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Feb 21, 2017https://github.com/nodejs/node/pull/11486#event-971665195
https://github.com/Trott
Trotthttps://github.com/Trott
Feb 21, 2017 https://github.com/nodejs/node/pull/11486#pullrequestreview-23100035
View reviewed changes https://github.com/nodejs/node/pull/11486/files
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/11486#pullrequestreview-23100035
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/11486
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 22, 2017 https://github.com/nodejs/node/pull/11486#pullrequestreview-23247627
View reviewed changes https://github.com/nodejs/node/pull/11486/files
https://github.com/lpinca
lpincahttps://github.com/lpinca
Feb 22, 2017 https://github.com/nodejs/node/pull/11486#pullrequestreview-23286356
View reviewed changes https://github.com/nodejs/node/pull/11486/files
test/parallel/test-buffer-copy.jshttps://github.com/nodejs/node/pull/11486/files#diff-cdf22a5c4cbb285725042206ab2beb1fed145a6b3f43066710559a6b625df319
lpincahttps://github.com/lpinca
Feb 22, 2017https://github.com/nodejs/node/pull/11486#discussion_r102527928
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/11486
addaleaxhttps://github.com/addaleax
Feb 22, 2017https://github.com/nodejs/node/pull/11486#discussion_r102528440
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@lpincahttps://github.com/lpinca
Please reload this pagehttps://github.com/nodejs/node/pull/11486
https://github.com/addaleax
doc,test: args to buffer.copy can be Uint8Arrayshttps://github.com/nodejs/node/pull/11486/commits/6e49735639df25148e35d27e06c6191f60ed3a25
6e49735https://github.com/nodejs/node/pull/11486/commits/6e49735639df25148e35d27e06c6191f60ed3a25
nodejs#10236https://github.com/nodejs/node/pull/10236
nodejs#10236https://github.com/nodejs/node/pull/10236
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node/compare/2851c32ffb38f13d3c0846e04b6c617d535cd336..6e49735639df25148e35d27e06c6191f60ed3a25
2851c32https://github.com/nodejs/node/commit/2851c32ffb38f13d3c0846e04b6c617d535cd336
6e49735https://github.com/nodejs/node/commit/6e49735639df25148e35d27e06c6191f60ed3a25
Compare https://github.com/nodejs/node/compare/2851c32ffb38f13d3c0846e04b6c617d535cd336..6e49735639df25148e35d27e06c6191f60ed3a25
February 22, 2017 17:55https://github.com/nodejs/node/pull/11486#event-973000804
https://github.com/lpinca
lpincahttps://github.com/lpinca
Feb 22, 2017 https://github.com/nodejs/node/pull/11486#pullrequestreview-23287836
View reviewed changes https://github.com/nodejs/node/pull/11486/files/6e49735639df25148e35d27e06c6191f60ed3a25
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 24, 2017https://github.com/nodejs/node/pull/11486#issuecomment-282171736
cba1020https://github.com/nodejs/node/commit/cba1020531119bd93cd10fc5ee019a125f068175
Please reload this pagehttps://github.com/nodejs/node/pull/11486
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 24, 2017https://github.com/nodejs/node/pull/11486#event-975365047
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
February 24, 2017 01:00https://github.com/nodejs/node/pull/11486#event-975365153
addaleaxhttps://github.com/addaleax
Feb 24, 2017 https://github.com/nodejs/node/pull/11486#ref-commit-cba1020
https://github.com/addaleax
doc,test: args to buffer.copy can be Uint8Arrayshttps://github.com/nodejs/node/commit/cba1020531119bd93cd10fc5ee019a125f068175
cba1020https://github.com/nodejs/node/commit/cba1020531119bd93cd10fc5ee019a125f068175
#10236https://github.com/nodejs/node/pull/10236
#10236https://github.com/nodejs/node/pull/10236
#11486https://github.com/nodejs/node/pull/11486
addaleaxhttps://github.com/addaleax
Feb 24, 2017 https://github.com/nodejs/node/pull/11486#ref-commit-89b66dc
https://github.com/addaleax
doc,test: args to buffer.copy can be Uint8Arrayshttps://github.com/nodejs/node/commit/89b66dc63615eb031fa2d2c7fb7d5a772fbdef6d
89b66dchttps://github.com/nodejs/node/commit/89b66dc63615eb031fa2d2c7fb7d5a772fbdef6d
#10236https://github.com/nodejs/node/pull/10236
#10236https://github.com/nodejs/node/pull/10236
#11486https://github.com/nodejs/node/pull/11486
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
Feb 25, 2017 https://github.com/nodejs/node/pull/11486#ref-pullrequest-210245474
7.7.0 Proposal #11553 https://github.com/nodejs/node/pull/11553
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 7, 2017https://github.com/nodejs/node/pull/11486#issuecomment-284629582
Please reload this pagehttps://github.com/nodejs/node/pull/11486
https://github.com/jasnell
jasnellhttps://github.com/jasnell
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Mar 7, 2017https://github.com/nodejs/node/pull/11486#event-989008673
jasnellhttps://github.com/jasnell
Mar 7, 2017 https://github.com/nodejs/node/pull/11486#ref-commit-cd1dca6
https://github.com/addaleax
https://github.com/jasnell
doc,test: args to buffer.copy can be Uint8Arrayshttps://github.com/nodejs/node/commit/cd1dca623031c2e8e296ba4336acfa809191ea26
cd1dca6https://github.com/nodejs/node/commit/cd1dca623031c2e8e296ba4336acfa809191ea26
#10236https://github.com/nodejs/node/pull/10236
#10236https://github.com/nodejs/node/pull/10236
#11486https://github.com/nodejs/node/pull/11486
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/11486#ref-commit-b503824
https://github.com/addaleax
https://github.com/MylesBorins
doc,test: args to buffer.copy can be Uint8Arrayshttps://github.com/nodejs/node/commit/b503824b8105939af3a13a25a4261caad3aa4da4
b503824https://github.com/nodejs/node/commit/b503824b8105939af3a13a25a4261caad3aa4da4
#10236https://github.com/nodejs/node/pull/10236
#10236https://github.com/nodejs/node/pull/10236
#11486https://github.com/nodejs/node/pull/11486
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/11486#ref-pullrequest-212909365
v6.10.1 proposal #11759 https://github.com/nodejs/node/pull/11759
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11486
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/11486/files/2851c32ffb38f13d3c0846e04b6c617d535cd336
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/11486/files/2851c32ffb38f13d3c0846e04b6c617d535cd336
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/11486/files/6e49735639df25148e35d27e06c6191f60ed3a25
buffer https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/11486
https://github.com/addaleax
https://github.com/jasnell
https://github.com/Trott
https://github.com/lpinca
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.