| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ab4f067b-6685-9ec9-6f76-e140326f4007 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EBEC:531C6:2BBD3D:3DC3B0:696A077D |
| html-safe-nonce | 73abb1a721b33f8e90b8db57376626c0b12b86d984c0c6e4a07789c71ed084b6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkVDOjUzMUM2OjJCQkQzRDozREMzQjA6Njk2QTA3N0QiLCJ2aXNpdG9yX2lkIjoiODUwMTIzODIwMTkzNjY0Mzk2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e0dbeb4836f4303cf3dd7ee552855da7ff4fa0c4d99c997910d4ff2d621da076 |
| hovercard-subject-tag | pull_request:106401963 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/11404/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/239da11752f2c1e9b885efc11521423fdc729d582bcb97ae8cf2c890816bbb69/nodejs/node/pull/11404 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/239da11752f2c1e9b885efc11521423fdc729d582bcb97ae8cf2c890816bbb69/nodejs/node/pull/11404 |
| og:image:alt | Use the more efficient module.exports = {} approach
Eliminate some uses of arguments
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines
A... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jasnell |
| hostname | github.com |
| expected-hostname | github.com |
| None | 578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 671c2f67171dbced24284331f3133a613d08c366 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/11404#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11404 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11404 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/11404 |
| Reload | https://github.com/nodejs/node/pull/11404 |
| Reload | https://github.com/nodejs/node/pull/11404 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/11404#issue-comment-box |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:internal-util-refactor | https://github.com/jasnell/node/tree/internal-util-refactor |
|
lib: refactor internal/util
| https://github.com/nodejs/node/pull/11404#top |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:internal-util-refactor | https://github.com/jasnell/node/tree/internal-util-refactor |
|
Conversation
29
| https://github.com/nodejs/node/pull/11404 |
|
Commits
3
| https://github.com/nodejs/node/pull/11404/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/11404/checks |
|
Files changed
| https://github.com/nodejs/node/pull/11404/files |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Feb 15, 2017 | https://github.com/nodejs/node/pull/11404#issue-207931669 |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
| Feb 15, 2017 | https://github.com/nodejs/node/pull/11404#event-963848764 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/37282b0ef27df359b64b729ea8da5114cde3934f..ece816179eea3e2f8aafedff08cb150dff2b8b0a |
| 37282b0 | https://github.com/nodejs/node/commit/37282b0ef27df359b64b729ea8da5114cde3934f |
| ece8161 | https://github.com/nodejs/node/commit/ece816179eea3e2f8aafedff08cb150dff2b8b0a |
|
Compare
| https://github.com/nodejs/node/compare/37282b0ef27df359b64b729ea8da5114cde3934f..ece816179eea3e2f8aafedff08cb150dff2b8b0a |
| February 15, 2017 21:23 | https://github.com/nodejs/node/pull/11404#event-963849331 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Feb 15, 2017 | https://github.com/nodejs/node/pull/11404#event-963858605 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Feb 15, 2017
| https://github.com/nodejs/node/pull/11404#ref-issue-203179311 |
|
Another case of possibly deoptimizing use of arguments in libs
#11001
| https://github.com/nodejs/node/issues/11001 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Feb 15, 2017 | https://github.com/nodejs/node/pull/11404#issuecomment-280162796 |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Feb 15, 2017 | https://github.com/nodejs/node/pull/11404#issuecomment-280165281 |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Feb 16, 2017 | https://github.com/nodejs/node/pull/11404#issuecomment-280368860 |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Feb 16, 2017 | https://github.com/nodejs/node/pull/11404#issuecomment-280372185 |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Feb 16, 2017
| https://github.com/nodejs/node/pull/11404#ref-issue-208242029 |
|
module.exports = {} approach and objects with fast / slow properties
#11430
| https://github.com/nodejs/node/issues/11430 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
| Feb 16, 2017 | https://github.com/nodejs/node/pull/11404#issuecomment-280455829 |
| @sam-github | https://github.com/sam-github |
| #11430 | https://github.com/nodejs/node/issues/11430 |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/vsemozhetbyt |
| vsemozhetbyt | https://github.com/vsemozhetbyt |
|
Feb 17, 2017
| https://github.com/nodejs/node/pull/11404#ref-pullrequest-208012984 |
|
net: avoid use of arguments
#11411
| https://github.com/nodejs/node/pull/11411 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Feb 17, 2017 | https://github.com/nodejs/node/pull/11404#event-967588978 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/ece816179eea3e2f8aafedff08cb150dff2b8b0a..7ba5f4cd923a4437764cb94546241fd8bd5d4283 |
| ece8161 | https://github.com/nodejs/node/commit/ece816179eea3e2f8aafedff08cb150dff2b8b0a |
| 7ba5f4c | https://github.com/nodejs/node/commit/7ba5f4cd923a4437764cb94546241fd8bd5d4283 |
|
Compare
| https://github.com/nodejs/node/compare/ece816179eea3e2f8aafedff08cb150dff2b8b0a..7ba5f4cd923a4437764cb94546241fd8bd5d4283 |
| February 17, 2017 21:08 | https://github.com/nodejs/node/pull/11404#event-967590177 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Feb 17, 2017 | https://github.com/nodejs/node/pull/11404#issuecomment-280767502 |
| @mscdex | https://github.com/mscdex |
| @sam-github | https://github.com/sam-github |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Feb 17, 2017 | https://github.com/nodejs/node/pull/11404#issuecomment-280767586 |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/3acfcb3afd746d958802778421a2249d7f0f9c24..1fe0ac8164d52861f192a30595f509bf4be201e5 |
| 3acfcb3 | https://github.com/nodejs/node/commit/3acfcb3afd746d958802778421a2249d7f0f9c24 |
| 1fe0ac8 | https://github.com/nodejs/node/commit/1fe0ac8164d52861f192a30595f509bf4be201e5 |
|
Compare
| https://github.com/nodejs/node/compare/3acfcb3afd746d958802778421a2249d7f0f9c24..1fe0ac8164d52861f192a30595f509bf4be201e5 |
| February 20, 2017 15:43 | https://github.com/nodejs/node/pull/11404#event-969412626 |
| https://github.com/fhalde |
| fhalde | https://github.com/fhalde |
|
Feb 21, 2017
| https://github.com/nodejs/node/pull/11404#pullrequestreview-23005791 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11404/files |
| fhalde | https://github.com/fhalde |
| https://github.com/nodejs/node/pull/11404#pullrequestreview-23005791 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Feb 21, 2017 | https://github.com/nodejs/node/pull/11404#issuecomment-281404450 |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/refack |
| refack | https://github.com/refack |
| force-pushed | https://github.com/nodejs/node/compare/16073c083efdcaf70aef1e490679457dd0f624bd..fbe946bb6316f1e1083ec47baaf812fc98d60f00 |
| 16073c0 | https://github.com/nodejs/node/commit/16073c083efdcaf70aef1e490679457dd0f624bd |
| fbe946b | https://github.com/nodejs/node/commit/fbe946bb6316f1e1083ec47baaf812fc98d60f00 |
|
Compare
| https://github.com/nodejs/node/compare/16073c083efdcaf70aef1e490679457dd0f624bd..fbe946bb6316f1e1083ec47baaf812fc98d60f00 |
| April 14, 2017 04:11 | https://github.com/nodejs/node/pull/11404#event-1042928819 |
|
| https://github.com/jasnell |
| lib: refactor internal/util | https://github.com/nodejs/node/pull/11404/commits/bf29544079be7fa749539ff54ee349c66eda1936 |
| bf29544 | https://github.com/nodejs/node/pull/11404/commits/bf29544079be7fa749539ff54ee349c66eda1936 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/1fe0ac8164d52861f192a30595f509bf4be201e5..bf29544079be7fa749539ff54ee349c66eda1936 |
| 1fe0ac8 | https://github.com/nodejs/node/commit/1fe0ac8164d52861f192a30595f509bf4be201e5 |
| bf29544 | https://github.com/nodejs/node/commit/bf29544079be7fa749539ff54ee349c66eda1936 |
|
Compare
| https://github.com/nodejs/node/compare/1fe0ac8164d52861f192a30595f509bf4be201e5..bf29544079be7fa749539ff54ee349c66eda1936 |
| April 20, 2017 17:58 | https://github.com/nodejs/node/pull/11404#event-1051034668 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 20, 2017 | https://github.com/nodejs/node/pull/11404#issuecomment-295843856 |
| @mscdex | https://github.com/mscdex |
| @sam-github | https://github.com/sam-github |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Apr 20, 2017 | https://github.com/nodejs/node/pull/11404#event-1051073400 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 20, 2017 | https://github.com/nodejs/node/pull/11404#issuecomment-295845863 |
| https://ci.nodejs.org/job/node-test-pull-request/7558/ | https://ci.nodejs.org/job/node-test-pull-request/7558/ |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Apr 20, 2017 | https://github.com/nodejs/node/pull/11404#issuecomment-295845913 |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Apr 20, 2017
| https://github.com/nodejs/node/pull/11404#pullrequestreview-33851838 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11404/files/bf29544079be7fa749539ff54ee349c66eda1936 |
| lib/internal/util.js | https://github.com/nodejs/node/pull/11404/files/bf29544079be7fa749539ff54ee349c66eda1936#diff-f70ef1e11e07dbfe54a7470ee790031f214ed08577129d0a9d3891d7310c0a35 |
| sam-github | https://github.com/sam-github |
| Apr 20, 2017 | https://github.com/nodejs/node/pull/11404#discussion_r112528950 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| jasnell | https://github.com/jasnell |
| Apr 20, 2017 | https://github.com/nodejs/node/pull/11404#discussion_r112529961 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| mscdex | https://github.com/mscdex |
| Apr 20, 2017 | https://github.com/nodejs/node/pull/11404#discussion_r112530360 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Apr 20, 2017
| https://github.com/nodejs/node/pull/11404#pullrequestreview-33852181 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11404/files/bf29544079be7fa749539ff54ee349c66eda1936 |
| lib/internal/util.js | https://github.com/nodejs/node/pull/11404/files/bf29544079be7fa749539ff54ee349c66eda1936#diff-f70ef1e11e07dbfe54a7470ee790031f214ed08577129d0a9d3891d7310c0a35 |
| sam-github | https://github.com/sam-github |
| Apr 20, 2017 | https://github.com/nodejs/node/pull/11404#discussion_r112529262 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Apr 20, 2017
| https://github.com/nodejs/node/pull/11404#pullrequestreview-33852798 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11404/files/bf29544079be7fa749539ff54ee349c66eda1936 |
| sam-github | https://github.com/sam-github |
| https://github.com/nodejs/node/pull/11404#pullrequestreview-33852798 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 20, 2017 | https://github.com/nodejs/node/pull/11404#issuecomment-295851391 |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
|
| https://github.com/jasnell |
| Address nits | https://github.com/nodejs/node/pull/11404/commits/4b013e8d862395e1181788ed5b133ea5ee54b3a8 |
| 4b013e8 | https://github.com/nodejs/node/pull/11404/commits/4b013e8d862395e1181788ed5b133ea5ee54b3a8 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 20, 2017 | https://github.com/nodejs/node/pull/11404#issuecomment-295852313 |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
| Apr 20, 2017 | https://github.com/nodejs/node/pull/11404#issuecomment-295853184 |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Apr 20, 2017
| https://github.com/nodejs/node/pull/11404#pullrequestreview-33854351 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11404/files/4b013e8d862395e1181788ed5b133ea5ee54b3a8 |
| lib/internal/util.js | https://github.com/nodejs/node/pull/11404/files/4b013e8d862395e1181788ed5b133ea5ee54b3a8#diff-f70ef1e11e07dbfe54a7470ee790031f214ed08577129d0a9d3891d7310c0a35 |
| mscdex | https://github.com/mscdex |
| Apr 20, 2017 | https://github.com/nodejs/node/pull/11404#discussion_r112531243 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| jasnell | https://github.com/jasnell |
| Apr 20, 2017 | https://github.com/nodejs/node/pull/11404#discussion_r112531685 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
|
| https://github.com/jasnell |
| Address nits | https://github.com/nodejs/node/pull/11404/commits/3a6954a22f119d9b0e54a4cf88e10a5e3807039d |
| 3a6954a | https://github.com/nodejs/node/pull/11404/commits/3a6954a22f119d9b0e54a4cf88e10a5e3807039d |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 20, 2017 | https://github.com/nodejs/node/pull/11404#issuecomment-295854323 |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Apr 20, 2017 | https://github.com/nodejs/node/pull/11404#issuecomment-295859685 |
| https://ci.nodejs.org/job/node-test-pull-request/7560/ | https://ci.nodejs.org/job/node-test-pull-request/7560/ |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 20, 2017 | https://github.com/nodejs/node/pull/11404#issuecomment-295879698 |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| jasnell | https://github.com/jasnell |
|
Apr 21, 2017
| https://github.com/nodejs/node/pull/11404#ref-commit-9077b48 |
|
| https://github.com/jasnell |
| lib: refactor internal/util | https://github.com/nodejs/node/commit/9077b482718b8bc6cafcabcd6b84e99498918b26 |
| 9077b48 | https://github.com/nodejs/node/commit/9077b482718b8bc6cafcabcd6b84e99498918b26 |
| #11404 | https://github.com/nodejs/node/pull/11404 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 21, 2017 | https://github.com/nodejs/node/pull/11404#issuecomment-296267157 |
| 9077b48 | https://github.com/nodejs/node/commit/9077b482718b8bc6cafcabcd6b84e99498918b26 |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 21, 2017 | https://github.com/nodejs/node/pull/11404#event-1052888723 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
|
Apr 22, 2017
| https://github.com/nodejs/node/pull/11404#ref-pullrequest-222959647 |
|
url: use util's getConstructorOf
#12526
| https://github.com/nodejs/node/pull/12526 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 11, 2017
| https://github.com/nodejs/node/pull/11404#ref-pullrequest-219383958 |
|
8.0.0 Release Proposal
#12220
| https://github.com/nodejs/node/pull/12220 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
Jun 15, 2017
| https://github.com/nodejs/node/pull/11404#ref-issue-235404028 |
|
Auditing for 6.11.1
nodejs/Release#230
| https://github.com/nodejs/Release/issues/230 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Jun 18, 2017 | https://github.com/nodejs/node/pull/11404#event-1128186299 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Jun 18, 2017 | https://github.com/nodejs/node/pull/11404#issuecomment-309289170 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jun 19, 2017 | https://github.com/nodejs/node/pull/11404#issuecomment-309463042 |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
|
land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Jun 19, 2017 | https://github.com/nodejs/node/pull/11404#event-1129285950 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Jun 19, 2017 | https://github.com/nodejs/node/pull/11404#issuecomment-309468629 |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11404 |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/nodejs/node/pull/11404/files/bf29544079be7fa749539ff54ee349c66eda1936 |
|
| https://github.com/mscdex |
|
mscdex
| https://github.com/mscdex |
|
| https://github.com/nodejs/node/pull/11404/files/4b013e8d862395e1181788ed5b133ea5ee54b3a8 |
|
| https://github.com/fhalde |
|
fhalde
| https://github.com/fhalde |
|
| https://github.com/nodejs/node/pull/11404/files/1fe0ac8164d52861f192a30595f509bf4be201e5 |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
| Please reload this page | https://github.com/nodejs/node/pull/11404 |
|
| https://github.com/jasnell |
|
| https://github.com/mscdex |
|
| https://github.com/sam-github |
|
| https://github.com/vsemozhetbyt |
|
| https://github.com/gibfahn |
|
| https://github.com/fhalde |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |