| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b19ada5c-790e-8170-ff8a-7707333d7e6a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CBD4:531C6:47328E:64D742:696A0BF5 |
| html-safe-nonce | 5d07269282f3a5e661ddd528650bb2c5698085342aa5e06ed996bc5f64a9b636 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQkQ0OjUzMUM2OjQ3MzI4RTo2NEQ3NDI6Njk2QTBCRjUiLCJ2aXNpdG9yX2lkIjoiNTQwNjQxNTI4ODIwMDIwMzI1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 84744f5f0a552586e9a21f147798b551e323d7695bdc61c0cc2daef0844dff4d |
| hovercard-subject-tag | pull_request:106030402 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/11366/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a48179b576e93b304634eb3921203d8d7632245e3d4171841f424985a9f891cb/nodejs/node/pull/11366 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a48179b576e93b304634eb3921203d8d7632245e3d4171841f424985a9f891cb/nodejs/node/pull/11366 |
| og:image:alt | Prefer === to == where possible
Remove condition that will always be false
Prefer for-loop statements to forEach where possible for perfomance reasons
Checklist
make -j4 test (UNIX), or vcbuil... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | notarseniy |
| hostname | github.com |
| expected-hostname | github.com |
| None | 699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7266b2d935baa1c6474b16dd9feaa5ca30607261 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/11366#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11366 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11366 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/11366 |
| Reload | https://github.com/nodejs/node/pull/11366 |
| Reload | https://github.com/nodejs/node/pull/11366 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/11366#issue-comment-box |
| notarseniy | https://github.com/notarseniy |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| notarseniy:internal-child-process-fix | https://github.com/notarseniy/node/tree/internal-child-process-fix |
|
child_process: refactor internal/child_process.js
| https://github.com/nodejs/node/pull/11366#top |
| notarseniy | https://github.com/notarseniy |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| notarseniy:internal-child-process-fix | https://github.com/notarseniy/node/tree/internal-child-process-fix |
|
Conversation
24
| https://github.com/nodejs/node/pull/11366 |
|
Commits
1
| https://github.com/nodejs/node/pull/11366/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/11366/checks |
|
Files changed
| https://github.com/nodejs/node/pull/11366/files |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/notarseniy |
| notarseniy | https://github.com/notarseniy |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#issue-207410904 |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
child_process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#event-960753961 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Feb 14, 2017
| https://github.com/nodejs/node/pull/11366#pullrequestreview-21673650 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11366/files |
| lib/internal/child_process.js | https://github.com/nodejs/node/pull/11366/files#diff-cccecc2fcae39b45f34342807c0403825080037e43bbf0bd659e6409645335b1 |
| mscdex | https://github.com/mscdex |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#discussion_r100957107 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| mscdex | https://github.com/mscdex |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#discussion_r100957414 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| notarseniy | https://github.com/notarseniy |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#discussion_r100957963 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| Trott | https://github.com/Trott |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#discussion_r100966404 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @notarseniy | https://github.com/notarseniy |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Feb 14, 2017
| https://github.com/nodejs/node/pull/11366#pullrequestreview-21673694 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11366/files |
| lib/internal/child_process.js | https://github.com/nodejs/node/pull/11366/files#diff-cccecc2fcae39b45f34342807c0403825080037e43bbf0bd659e6409645335b1 |
| mscdex | https://github.com/mscdex |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#discussion_r100957151 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| notarseniy | https://github.com/notarseniy |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#discussion_r100961079 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| this line | https://github.com/notarseniy/node/blob/0b3efdc5de0abd93e02cbbfa092963ee97e492cb/lib/internal/child_process.js#L804 |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| mscdex | https://github.com/mscdex |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#discussion_r100973365 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| notarseniy | https://github.com/notarseniy |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#discussion_r101022594 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Feb 14, 2017
| https://github.com/nodejs/node/pull/11366#pullrequestreview-21673865 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11366/files |
| lib/internal/child_process.js | https://github.com/nodejs/node/pull/11366/files#diff-cccecc2fcae39b45f34342807c0403825080037e43bbf0bd659e6409645335b1 |
| mscdex | https://github.com/mscdex |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#discussion_r100957339 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| mscdex | https://github.com/mscdex |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#discussion_r100957411 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| notarseniy | https://github.com/notarseniy |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#discussion_r100957680 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| notarseniy | https://github.com/notarseniy |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#discussion_r100958201 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Feb 14, 2017
| https://github.com/nodejs/node/pull/11366#pullrequestreview-21673998 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11366/files |
| lib/internal/child_process.js | https://github.com/nodejs/node/pull/11366/files#diff-cccecc2fcae39b45f34342807c0403825080037e43bbf0bd659e6409645335b1 |
| mscdex | https://github.com/mscdex |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#discussion_r100957468 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| notarseniy | https://github.com/notarseniy |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#discussion_r100957601 |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| previous condition | https://github.com/notarseniy/node/blob/0b3efdc5de0abd93e02cbbfa092963ee97e492cb/lib/internal/child_process.js#L804 |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| https://github.com/notarseniy |
| notarseniy | https://github.com/notarseniy |
| force-pushed | https://github.com/nodejs/node/compare/03eba2606666b9a8b57eefd58c2e1094ffe15e32..0b3efdc5de0abd93e02cbbfa092963ee97e492cb |
| 03eba26 | https://github.com/nodejs/node/commit/03eba2606666b9a8b57eefd58c2e1094ffe15e32 |
| 0b3efdc | https://github.com/nodejs/node/commit/0b3efdc5de0abd93e02cbbfa092963ee97e492cb |
|
Compare
| https://github.com/nodejs/node/compare/03eba2606666b9a8b57eefd58c2e1094ffe15e32..0b3efdc5de0abd93e02cbbfa092963ee97e492cb |
| February 14, 2017 05:00 | https://github.com/nodejs/node/pull/11366#event-960796796 |
| https://github.com/notarseniy |
| notarseniy | https://github.com/notarseniy |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#issuecomment-279610189 |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#issuecomment-279618707 |
| https://ci.nodejs.org/job/node-test-pull-request/6398/ | https://ci.nodejs.org/job/node-test-pull-request/6398/ |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#issuecomment-279630140 |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Feb 14, 2017
| https://github.com/nodejs/node/pull/11366#pullrequestreview-21690768 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11366/files |
| lib/internal/child_process.js | https://github.com/nodejs/node/pull/11366/files#diff-cccecc2fcae39b45f34342807c0403825080037e43bbf0bd659e6409645335b1 |
| mscdex | https://github.com/mscdex |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#discussion_r100973936 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| https://github.com/notarseniy |
| notarseniy | https://github.com/notarseniy |
| force-pushed | https://github.com/nodejs/node/compare/0b3efdc5de0abd93e02cbbfa092963ee97e492cb..9bfcaf4463a885ddfac10f13bea0c2dacb85c61e |
| 0b3efdc | https://github.com/nodejs/node/commit/0b3efdc5de0abd93e02cbbfa092963ee97e492cb |
| 9bfcaf4 | https://github.com/nodejs/node/commit/9bfcaf4463a885ddfac10f13bea0c2dacb85c61e |
|
Compare
| https://github.com/nodejs/node/compare/0b3efdc5de0abd93e02cbbfa092963ee97e492cb..9bfcaf4463a885ddfac10f13bea0c2dacb85c61e |
| February 14, 2017 12:34 | https://github.com/nodejs/node/pull/11366#event-961280984 |
|
| https://github.com/notarseniy |
| child_process: refactor internal/child_process.js | https://github.com/nodejs/node/pull/11366/commits/efaa7d70c9b699826fc0558a2027afc163f307e1 |
| efaa7d7 | https://github.com/nodejs/node/pull/11366/commits/efaa7d70c9b699826fc0558a2027afc163f307e1 |
| https://github.com/notarseniy |
| notarseniy | https://github.com/notarseniy |
| force-pushed | https://github.com/nodejs/node/compare/9bfcaf4463a885ddfac10f13bea0c2dacb85c61e..efaa7d70c9b699826fc0558a2027afc163f307e1 |
| 9bfcaf4 | https://github.com/nodejs/node/commit/9bfcaf4463a885ddfac10f13bea0c2dacb85c61e |
| efaa7d7 | https://github.com/nodejs/node/commit/efaa7d70c9b699826fc0558a2027afc163f307e1 |
|
Compare
| https://github.com/nodejs/node/compare/9bfcaf4463a885ddfac10f13bea0c2dacb85c61e..efaa7d70c9b699826fc0558a2027afc163f307e1 |
| February 14, 2017 12:36 | https://github.com/nodejs/node/pull/11366#event-961283586 |
| https://github.com/notarseniy |
| notarseniy | https://github.com/notarseniy |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#issuecomment-279697719 |
| @Trott | https://github.com/Trott |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#issuecomment-279759924 |
| https://ci.nodejs.org/job/node-test-pull-request/6405/ | https://ci.nodejs.org/job/node-test-pull-request/6405/ |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Feb 14, 2017
| https://github.com/nodejs/node/pull/11366#pullrequestreview-21806877 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11366/files/efaa7d70c9b699826fc0558a2027afc163f307e1 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11366#issuecomment-279771351 |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| https://github.com/sam-github |
| sam-github | https://github.com/sam-github |
|
Feb 15, 2017
| https://github.com/nodejs/node/pull/11366#pullrequestreview-22135771 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11366/files/efaa7d70c9b699826fc0558a2027afc163f307e1 |
| https://github.com/notarseniy |
| notarseniy | https://github.com/notarseniy |
| Feb 18, 2017 | https://github.com/nodejs/node/pull/11366#issuecomment-280866662 |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Feb 18, 2017
| https://github.com/nodejs/node/pull/11366#pullrequestreview-22643985 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11366/files/efaa7d70c9b699826fc0558a2027afc163f307e1 |
| targos | https://github.com/targos |
|
Feb 18, 2017
| https://github.com/nodejs/node/pull/11366#ref-commit-8fc362e |
|
| https://github.com/notarseniy |
|
| https://github.com/targos |
| child_process: refactor internal/child_process.js | https://github.com/nodejs/node/commit/8fc362ea980b726f8cfbfd7af0f2575b3db2731e |
| 8fc362e | https://github.com/nodejs/node/commit/8fc362ea980b726f8cfbfd7af0f2575b3db2731e |
| #11366 | https://github.com/nodejs/node/pull/11366 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Feb 18, 2017 | https://github.com/nodejs/node/pull/11366#issuecomment-280867409 |
| @notarseniy | https://github.com/notarseniy |
| 8fc362e | https://github.com/nodejs/node/commit/8fc362ea980b726f8cfbfd7af0f2575b3db2731e |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Feb 18, 2017 | https://github.com/nodejs/node/pull/11366#event-968089229 |
| https://github.com/notarseniy |
| notarseniy | https://github.com/notarseniy |
| Feb 18, 2017 | https://github.com/nodejs/node/pull/11366#issuecomment-280867450 |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
| https://github.com/notarseniy |
| notarseniy | https://github.com/notarseniy |
| February 18, 2017 19:04 | https://github.com/nodejs/node/pull/11366#event-968089465 |
| addaleax | https://github.com/addaleax |
|
Feb 22, 2017
| https://github.com/nodejs/node/pull/11366#ref-commit-c942e20 |
|
| https://github.com/notarseniy |
|
| https://github.com/addaleax |
| child_process: refactor internal/child_process.js | https://github.com/nodejs/node/commit/c942e2037cdfe18b65c334fd278ad6042d1fd7dd |
| c942e20 | https://github.com/nodejs/node/commit/c942e2037cdfe18b65c334fd278ad6042d1fd7dd |
| #11366 | https://github.com/nodejs/node/pull/11366 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Feb 25, 2017
| https://github.com/nodejs/node/pull/11366#ref-pullrequest-210245474 |
|
7.7.0 Proposal
#11553
| https://github.com/nodejs/node/pull/11553 |
| jasnell | https://github.com/jasnell |
|
Mar 7, 2017
| https://github.com/nodejs/node/pull/11366#ref-commit-253f289 |
|
| https://github.com/notarseniy |
|
| https://github.com/jasnell |
| child_process: refactor internal/child_process.js | https://github.com/nodejs/node/commit/253f289972d2237ea08582203ecdb12a3f2de477 |
| 253f289 | https://github.com/nodejs/node/commit/253f289972d2237ea08582203ecdb12a3f2de477 |
| #11366 | https://github.com/nodejs/node/pull/11366 |
| jasnell | https://github.com/jasnell |
|
Mar 7, 2017
| https://github.com/nodejs/node/pull/11366#ref-commit-6316e53 |
|
| https://github.com/notarseniy |
|
| https://github.com/jasnell |
| child_process: refactor internal/child_process.js | https://github.com/nodejs/node/commit/6316e539b1377053a6841605640e06797a44b1fe |
| 6316e53 | https://github.com/nodejs/node/commit/6316e539b1377053a6841605640e06797a44b1fe |
| #11366 | https://github.com/nodejs/node/pull/11366 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/11366#ref-commit-c371fdc |
|
| https://github.com/notarseniy |
|
| https://github.com/MylesBorins |
| child_process: refactor internal/child_process.js | https://github.com/nodejs/node/commit/c371fdcf3479263ddde6ba6fd10d9de345ece618 |
| c371fdc | https://github.com/nodejs/node/commit/c371fdcf3479263ddde6ba6fd10d9de345ece618 |
| #11366 | https://github.com/nodejs/node/pull/11366 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/11366#ref-pullrequest-212909365 |
|
v6.10.1 proposal
#11759
| https://github.com/nodejs/node/pull/11759 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/11366#ref-commit-2b867d2 |
|
| https://github.com/notarseniy |
|
| https://github.com/MylesBorins |
| child_process: refactor internal/child_process.js | https://github.com/nodejs/node/commit/2b867d2ae5f8e32644a6794720183462e25d5cfe |
| 2b867d2 | https://github.com/nodejs/node/commit/2b867d2ae5f8e32644a6794720183462e25d5cfe |
| #11366 | https://github.com/nodejs/node/pull/11366 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/11366#ref-pullrequest-212910576 |
|
v4.8.1 proposal
#11760
| https://github.com/nodejs/node/pull/11760 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11366 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/11366/files/bbbabaf8730bad0e73f196e3d63195f97969a98a |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/11366/files/efaa7d70c9b699826fc0558a2027afc163f307e1 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/11366/files/efaa7d70c9b699826fc0558a2027afc163f307e1 |
|
| https://github.com/mscdex |
|
mscdex
| https://github.com/mscdex |
|
| https://github.com/nodejs/node/pull/11366/files/0b3efdc5de0abd93e02cbbfa092963ee97e492cb |
|
| https://github.com/sam-github |
|
sam-github
| https://github.com/sam-github |
|
| https://github.com/nodejs/node/pull/11366/files/efaa7d70c9b699826fc0558a2027afc163f307e1 |
|
child_process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Achild_process |
| Please reload this page | https://github.com/nodejs/node/pull/11366 |
|
| https://github.com/notarseniy |
|
| https://github.com/Trott |
|
| https://github.com/mscdex |
|
| https://github.com/targos |
|
| https://github.com/sam-github |
|
| https://github.com/cjihrig |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |