| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:770ab728-35e7-2bba-6278-bfeb93adea17 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B68E:5FEAE:49957F:65E6BF:696A0CBE |
| html-safe-nonce | 45f420f3a89ce191968f83cb097118b540aebcf0c9c22eaf9c6a64d617d01a60 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjhFOjVGRUFFOjQ5OTU3Rjo2NUU2QkY6Njk2QTBDQkUiLCJ2aXNpdG9yX2lkIjoiMzUxNjEwOTE1MzY5MzczMjAzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 77b8138d269d7d27d51d56ac4880cf4b250e2a9a1334b2430190d5d66be5e4ed |
| hovercard-subject-tag | pull_request:105672771 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/11297/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/92ab8acffd6a9b0908a24f3e87d7ad50e8ad852780fd4f5beba782d45027c28c/nodejs/node/pull/11297 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/92ab8acffd6a9b0908a24f3e87d7ad50e8ad852780fd4f5beba782d45027c28c/nodejs/node/pull/11297 |
| og:image:alt | Checklist
Affected core subsystem(s)
test
Merging buffer-read test present in test-buffer-alloc.js to test-buffer-read.js file |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | larissayvette |
| hostname | github.com |
| expected-hostname | github.com |
| None | 699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7266b2d935baa1c6474b16dd9feaa5ca30607261 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/11297#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11297 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11297 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/11297 |
| Reload | https://github.com/nodejs/node/pull/11297 |
| Reload | https://github.com/nodejs/node/pull/11297 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/11297 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/11297 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/11297#issue-comment-box |
| larissayvette | https://github.com/larissayvette |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| larissayvette:read-buffer | https://github.com/larissayvette/node/tree/read-buffer |
|
test: consolidating buffer.read()
| https://github.com/nodejs/node/pull/11297#top |
| larissayvette | https://github.com/larissayvette |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| larissayvette:read-buffer | https://github.com/larissayvette/node/tree/read-buffer |
|
Conversation
7
| https://github.com/nodejs/node/pull/11297 |
|
Commits
2
| https://github.com/nodejs/node/pull/11297/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/11297/checks |
|
Files changed
| https://github.com/nodejs/node/pull/11297/files |
| Please reload this page | https://github.com/nodejs/node/pull/11297 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/larissayvette |
| larissayvette | https://github.com/larissayvette |
| Feb 10, 2017 | https://github.com/nodejs/node/pull/11297#issue-206859215 |
| Please reload this page | https://github.com/nodejs/node/pull/11297 |
| larissayvette | https://github.com/larissayvette |
| February 10, 2017 17:18 | https://github.com/nodejs/node/pull/11297#commits-pushed-259ad23 |
|
| https://github.com/larissayvette |
| test: consolidate buffer.read() in a file | https://github.com/nodejs/node/pull/11297/commits/259ad23636db84aabd1cc51ae71278fc6e567f26 |
| 259ad23 | https://github.com/nodejs/node/pull/11297/commits/259ad23636db84aabd1cc51ae71278fc6e567f26 |
|
| https://github.com/larissayvette |
| test: changing test-buffer-write-noassert.js name | https://github.com/nodejs/node/pull/11297/commits/6e0551befcdc7f6c1d303e7e27f185dc5aa05799 |
| 6e0551b | https://github.com/nodejs/node/pull/11297/commits/6e0551befcdc7f6c1d303e7e27f185dc5aa05799 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Feb 10, 2017 | https://github.com/nodejs/node/pull/11297#event-957652524 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 10, 2017
| https://github.com/nodejs/node/pull/11297#pullrequestreview-21302727 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11297/files/6e0551befcdc7f6c1d303e7e27f185dc5aa05799 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Feb 10, 2017
| https://github.com/nodejs/node/pull/11297#pullrequestreview-21308911 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11297/files/6e0551befcdc7f6c1d303e7e27f185dc5aa05799 |
| Trott | https://github.com/Trott |
| https://github.com/nodejs/node/pull/11297#pullrequestreview-21308911 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11297 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
| Feb 10, 2017 | https://github.com/nodejs/node/pull/11297#event-957957807 |
| https://github.com/thefourtheye |
| thefourtheye | https://github.com/thefourtheye |
|
Feb 12, 2017
| https://github.com/nodejs/node/pull/11297#pullrequestreview-21412503 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11297/files/6e0551befcdc7f6c1d303e7e27f185dc5aa05799 |
| test/parallel/test-buffer-read.js | https://github.com/nodejs/node/pull/11297/files/6e0551befcdc7f6c1d303e7e27f185dc5aa05799#diff-17424c40d6fc68cbb782fc1ce64f5de14c08b58ed9f9e9e46a7fef1b67b2aad9 |
| thefourtheye | https://github.com/thefourtheye |
| Feb 12, 2017 | https://github.com/nodejs/node/pull/11297#discussion_r100698423 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #11162 | https://github.com/nodejs/node/pull/11162 |
| Please reload this page | https://github.com/nodejs/node/pull/11297 |
| Trott | https://github.com/Trott |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11297#discussion_r100934122 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/11297 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Feb 14, 2017 | https://github.com/nodejs/node/pull/11297#issuecomment-279782139 |
| https://ci.nodejs.org/job/node-test-pull-request/6408/ | https://ci.nodejs.org/job/node-test-pull-request/6408/ |
| Please reload this page | https://github.com/nodejs/node/pull/11297 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Feb 16, 2017 | https://github.com/nodejs/node/pull/11297#issuecomment-280491279 |
| Please reload this page | https://github.com/nodejs/node/pull/11297 |
| jasnell | https://github.com/jasnell |
|
Feb 17, 2017
| https://github.com/nodejs/node/pull/11297#ref-commit-8a25e31 |
|
| https://github.com/larissayvette |
|
| https://github.com/jasnell |
| test: consolidate buffer.read() in a file | https://github.com/nodejs/node/commit/8a25e31fbe8e18ae66ca919be8e208309552dac9 |
| 8a25e31 | https://github.com/nodejs/node/commit/8a25e31fbe8e18ae66ca919be8e208309552dac9 |
| #11297 | https://github.com/nodejs/node/pull/11297 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Feb 17, 2017 | https://github.com/nodejs/node/pull/11297#issuecomment-280505859 |
| Please reload this page | https://github.com/nodejs/node/pull/11297 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Feb 17, 2017 | https://github.com/nodejs/node/pull/11297#event-965996204 |
| https://github.com/larissayvette |
| larissayvette | https://github.com/larissayvette |
| February 17, 2017 09:27 | https://github.com/nodejs/node/pull/11297#event-966556549 |
| italoacasas | https://github.com/italoacasas |
|
Feb 20, 2017
| https://github.com/nodejs/node/pull/11297#ref-commit-3bd6845 |
|
| https://github.com/larissayvette |
| test: consolidate buffer.read() in a file | https://github.com/italoacasas/node/commit/3bd68455085af255c716e9b6008eddef5c62d6b8 |
| 3bd6845 | https://github.com/italoacasas/node/commit/3bd68455085af255c716e9b6008eddef5c62d6b8 |
| nodejs#11297 | https://github.com/nodejs/node/pull/11297 |
| italoacasas | https://github.com/italoacasas |
|
Feb 22, 2017
| https://github.com/nodejs/node/pull/11297#ref-commit-add7625 |
|
| https://github.com/larissayvette |
| test: consolidate buffer.read() in a file | https://github.com/nodejs/node/commit/add762550c3cd52ec2e010955be31eae43faeefa |
| add7625 | https://github.com/nodejs/node/commit/add762550c3cd52ec2e010955be31eae43faeefa |
| #11297 | https://github.com/nodejs/node/pull/11297 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Feb 25, 2017
| https://github.com/nodejs/node/pull/11297#ref-pullrequest-210245474 |
|
7.7.0 Proposal
#11553
| https://github.com/nodejs/node/pull/11553 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Mar 7, 2017 | https://github.com/nodejs/node/pull/11297#event-989719995 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 7, 2017 | https://github.com/nodejs/node/pull/11297#issuecomment-284748301 |
| Please reload this page | https://github.com/nodejs/node/pull/11297 |
| jasnell | https://github.com/jasnell |
|
Mar 7, 2017
| https://github.com/nodejs/node/pull/11297#ref-commit-fcad958 |
|
| https://github.com/larissayvette |
|
| https://github.com/jasnell |
| test: consolidate buffer.read() in a file | https://github.com/nodejs/node/commit/fcad958726c1fcd34c2702a75fdf3216796c121d |
| fcad958 | https://github.com/nodejs/node/commit/fcad958726c1fcd34c2702a75fdf3216796c121d |
| #11297 | https://github.com/nodejs/node/pull/11297 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/11297#ref-commit-5a92fc2 |
|
| https://github.com/larissayvette |
|
| https://github.com/MylesBorins |
| test: consolidate buffer.read() in a file | https://github.com/nodejs/node/commit/5a92fc25a103389384f50e8624ed004511055e40 |
| 5a92fc2 | https://github.com/nodejs/node/commit/5a92fc25a103389384f50e8624ed004511055e40 |
| #11297 | https://github.com/nodejs/node/pull/11297 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/11297#ref-pullrequest-212909365 |
|
v6.10.1 proposal
#11759
| https://github.com/nodejs/node/pull/11759 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11297 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/11297/files/6e0551befcdc7f6c1d303e7e27f185dc5aa05799 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/11297/files/6e0551befcdc7f6c1d303e7e27f185dc5aa05799 |
|
| https://github.com/thefourtheye |
|
thefourtheye
| https://github.com/thefourtheye |
|
| https://github.com/nodejs/node/pull/11297/files/6e0551befcdc7f6c1d303e7e27f185dc5aa05799 |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/11297 |
|
| https://github.com/larissayvette |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
|
| https://github.com/thefourtheye |
|
| https://github.com/mscdex |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |