René's URL Explorer Experiment


Title: test: improve crypto coverage by toiroakr · Pull Request #11279 · nodejs/node · GitHub

Open Graph Title: test: improve crypto coverage by toiroakr · Pull Request #11279 · nodejs/node

X Title: test: improve crypto coverage by toiroakr · Pull Request #11279 · nodejs/node

Description: This PR improves test coverage on crypto dh functions. Just add 2 exceptions check. Please review. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are ...

Open Graph Description: This PR improves test coverage on crypto dh functions. Just add 2 exceptions check. Please review. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are ...

X Description: This PR improves test coverage on crypto dh functions. Just add 2 exceptions check. Please review. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are ...

Opengraph URL: https://github.com/nodejs/node/pull/11279

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0ef0e978-8548-d1cf-9e49-2513a92336cf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA458:2F5B11:C2A7AE:10CEC6E:6969F3FD
html-safe-nonceefbd28e74e08e49d7741eab3137eaad18ff4315484df0f366271330ba257da71
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDU4OjJGNUIxMTpDMkE3QUU6MTBDRUM2RTo2OTY5RjNGRCIsInZpc2l0b3JfaWQiOiI0NjMyMTQ1MTQ4NDUwMDQyODc3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac10f468bc6a279f7ddf1aaa0895b3cf0407bee55d9560deb630f614addc302884
hovercard-subject-tagpull_request:105563504
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/11279/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0063486324d1622b57f2b105a08f9160e34c32774824b45b01b72a372e00bbec/nodejs/node/pull/11279
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0063486324d1622b57f2b105a08f9160e34c32774824b45b01b72a372e00bbec/nodejs/node/pull/11279
og:image:altThis PR improves test coverage on crypto dh functions. Just add 2 exceptions check. Please review. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametoiroakr
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/11279#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11279
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11279
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/11279
Reloadhttps://github.com/nodejs/node/pull/11279
Reloadhttps://github.com/nodejs/node/pull/11279
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/11279
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/11279
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/11279#issue-comment-box
toiroakrhttps://github.com/toiroakr
nodejs:masterhttps://github.com/nodejs/node/tree/master
toiroakr:test-improve-crypto-coveragehttps://github.com/toiroakr/node/tree/test-improve-crypto-coverage
test: improve crypto coverage https://github.com/nodejs/node/pull/11279#top
toiroakrhttps://github.com/toiroakr
nodejs:masterhttps://github.com/nodejs/node/tree/master
toiroakr:test-improve-crypto-coveragehttps://github.com/toiroakr/node/tree/test-improve-crypto-coverage
Conversation 9 https://github.com/nodejs/node/pull/11279
Commits 1 https://github.com/nodejs/node/pull/11279/commits
Checks 0 https://github.com/nodejs/node/pull/11279/checks
Files changed https://github.com/nodejs/node/pull/11279/files
Please reload this pagehttps://github.com/nodejs/node/pull/11279
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/toiroakr
toiroakrhttps://github.com/toiroakr
Feb 10, 2017https://github.com/nodejs/node/pull/11279#issue-206704522
test coveragehttps://coverage.nodejs.org/coverage-2db3b941a9384a03/root/crypto.js.html
Please reload this pagehttps://github.com/nodejs/node/pull/11279
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Feb 10, 2017https://github.com/nodejs/node/pull/11279#event-956742146
https://github.com/hiroppy
hiroppyhttps://github.com/hiroppy
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Feb 10, 2017https://github.com/nodejs/node/pull/11279#event-956742904
https://github.com/Trott
Trotthttps://github.com/Trott
Feb 10, 2017https://github.com/nodejs/node/pull/11279#issuecomment-278856614
Please reload this pagehttps://github.com/nodejs/node/pull/11279
https://github.com/Trott
Trotthttps://github.com/Trott
Feb 10, 2017https://github.com/nodejs/node/pull/11279#issuecomment-278856626
Please reload this pagehttps://github.com/nodejs/node/pull/11279
https://github.com/toiroakr
toiroakrhttps://github.com/toiroakr
force-pushedhttps://github.com/nodejs/node/compare/c2701df2bf552dd4cb5c0586f2a3cdbe7696d159..ccc74dfd8593a220e5675977145a0dda9ce0af04
c2701dfhttps://github.com/nodejs/node/commit/c2701df2bf552dd4cb5c0586f2a3cdbe7696d159
ccc74dfhttps://github.com/nodejs/node/commit/ccc74dfd8593a220e5675977145a0dda9ce0af04
Compare https://github.com/nodejs/node/compare/c2701df2bf552dd4cb5c0586f2a3cdbe7696d159..ccc74dfd8593a220e5675977145a0dda9ce0af04
February 10, 2017 05:12https://github.com/nodejs/node/pull/11279#event-956774221
https://github.com/toiroakr
toiroakrhttps://github.com/toiroakr
Feb 10, 2017https://github.com/nodejs/node/pull/11279#issuecomment-278860046
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/11279
https://github.com/hiroppy
hiroppyhttps://github.com/hiroppy
Feb 10, 2017 https://github.com/nodejs/node/pull/11279#pullrequestreview-21181046
View reviewed changes https://github.com/nodejs/node/pull/11279/files
test/parallel/test-crypto-dh.jshttps://github.com/nodejs/node/pull/11279/files#diff-07a942232c55ff014a06365cfe047ef10ad02029a98f523ef4c96d5cb860bb25
hiroppyhttps://github.com/hiroppy
Feb 10, 2017https://github.com/nodejs/node/pull/11279#discussion_r100473004
Please reload this pagehttps://github.com/nodejs/node/pull/11279
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/11279
test: improve crypto coveragehttps://github.com/nodejs/node/pull/11279/commits/b95d60686476892b7f6f20909daadf57f9fb4874
b95d606https://github.com/nodejs/node/pull/11279/commits/b95d60686476892b7f6f20909daadf57f9fb4874
https://github.com/toiroakr
toiroakrhttps://github.com/toiroakr
force-pushedhttps://github.com/nodejs/node/compare/ccc74dfd8593a220e5675977145a0dda9ce0af04..b95d60686476892b7f6f20909daadf57f9fb4874
ccc74dfhttps://github.com/nodejs/node/commit/ccc74dfd8593a220e5675977145a0dda9ce0af04
b95d606https://github.com/nodejs/node/commit/b95d60686476892b7f6f20909daadf57f9fb4874
Compare https://github.com/nodejs/node/compare/ccc74dfd8593a220e5675977145a0dda9ce0af04..b95d60686476892b7f6f20909daadf57f9fb4874
February 10, 2017 05:39https://github.com/nodejs/node/pull/11279#event-956788446
https://github.com/toiroakr
toiroakrhttps://github.com/toiroakr
Feb 10, 2017https://github.com/nodejs/node/pull/11279#issuecomment-278862907
Please reload this pagehttps://github.com/nodejs/node/pull/11279
@abouthiroppyhttps://github.com/abouthiroppy
Please reload this pagehttps://github.com/nodejs/node/pull/11279
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Feb 10, 2017 https://github.com/nodejs/node/pull/11279#pullrequestreview-21246193
View reviewed changes https://github.com/nodejs/node/pull/11279/files/b95d60686476892b7f6f20909daadf57f9fb4874
https://github.com/hiroppy
hiroppyhttps://github.com/hiroppy
Feb 10, 2017 https://github.com/nodejs/node/pull/11279#pullrequestreview-21253638
View reviewed changes https://github.com/nodejs/node/pull/11279/files/b95d60686476892b7f6f20909daadf57f9fb4874
hiroppyhttps://github.com/hiroppy
https://github.com/nodejs/node/pull/11279#pullrequestreview-21253638
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/11279
https://github.com/hiroppy
hiroppyhttps://github.com/hiroppy
Feb 10, 2017https://github.com/nodejs/node/pull/11279#issuecomment-278951528
https://ci.nodejs.org/job/node-test-pull-request/6333/https://ci.nodejs.org/job/node-test-pull-request/6333/
Please reload this pagehttps://github.com/nodejs/node/pull/11279
https://github.com/santigimeno
santigimenohttps://github.com/santigimeno
Feb 10, 2017 https://github.com/nodejs/node/pull/11279#pullrequestreview-21261925
View reviewed changes https://github.com/nodejs/node/pull/11279/files/b95d60686476892b7f6f20909daadf57f9fb4874
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 10, 2017 https://github.com/nodejs/node/pull/11279#pullrequestreview-21298517
View reviewed changes https://github.com/nodejs/node/pull/11279/files/b95d60686476892b7f6f20909daadf57f9fb4874
jasnellhttps://github.com/jasnell
Feb 17, 2017 https://github.com/nodejs/node/pull/11279#ref-commit-513d9bb
https://github.com/jasnell
test: improve crypto coveragehttps://github.com/nodejs/node/commit/513d9bb8aa53feb6630ac56fc231e846d928804f
513d9bbhttps://github.com/nodejs/node/commit/513d9bb8aa53feb6630ac56fc231e846d928804f
#11279https://github.com/nodejs/node/pull/11279
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 17, 2017https://github.com/nodejs/node/pull/11279#issuecomment-280508223
513d9bbhttps://github.com/nodejs/node/commit/513d9bb8aa53feb6630ac56fc231e846d928804f
Please reload this pagehttps://github.com/nodejs/node/pull/11279
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 17, 2017https://github.com/nodejs/node/pull/11279#event-966009700
italoacasashttps://github.com/italoacasas
Feb 20, 2017 https://github.com/nodejs/node/pull/11279#ref-commit-36e4596
test: improve crypto coveragehttps://github.com/italoacasas/node/commit/36e45967378381e1607aa03ebdbf5372ede7a8a0
36e4596https://github.com/italoacasas/node/commit/36e45967378381e1607aa03ebdbf5372ede7a8a0
nodejs#11279https://github.com/nodejs/node/pull/11279
italoacasashttps://github.com/italoacasas
Feb 22, 2017 https://github.com/nodejs/node/pull/11279#ref-commit-8ee236f
test: improve crypto coveragehttps://github.com/nodejs/node/commit/8ee236f85a4890e5a2992c0829fc3a2d3a654ea4
8ee236fhttps://github.com/nodejs/node/commit/8ee236f85a4890e5a2992c0829fc3a2d3a654ea4
#11279https://github.com/nodejs/node/pull/11279
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
Feb 25, 2017 https://github.com/nodejs/node/pull/11279#ref-pullrequest-210245474
7.7.0 Proposal #11553 https://github.com/nodejs/node/pull/11553
jasnellhttps://github.com/jasnell
Mar 7, 2017 https://github.com/nodejs/node/pull/11279#ref-commit-444066e
https://github.com/jasnell
test: improve crypto coveragehttps://github.com/nodejs/node/commit/444066e720b33724e90fd22aea1b933d3e38fe08
444066ehttps://github.com/nodejs/node/commit/444066e720b33724e90fd22aea1b933d3e38fe08
#11279https://github.com/nodejs/node/pull/11279
https://github.com/jasnell
jasnellhttps://github.com/jasnell
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Mar 7, 2017https://github.com/nodejs/node/pull/11279#event-989718695
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 7, 2017https://github.com/nodejs/node/pull/11279#issuecomment-284748102
Please reload this pagehttps://github.com/nodejs/node/pull/11279
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/11279#ref-commit-607158a
https://github.com/MylesBorins
test: improve crypto coveragehttps://github.com/nodejs/node/commit/607158ab6ecbfd29046f5bd8123f678be7676fb2
607158ahttps://github.com/nodejs/node/commit/607158ab6ecbfd29046f5bd8123f678be7676fb2
#11279https://github.com/nodejs/node/pull/11279
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 9, 2017 https://github.com/nodejs/node/pull/11279#ref-pullrequest-212909365
v6.10.1 proposal #11759 https://github.com/nodejs/node/pull/11759
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11279
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/11279/files/b95d60686476892b7f6f20909daadf57f9fb4874
https://github.com/santigimeno
santigimeno https://github.com/santigimeno
https://github.com/nodejs/node/pull/11279/files/b95d60686476892b7f6f20909daadf57f9fb4874
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/11279/files/b95d60686476892b7f6f20909daadf57f9fb4874
https://github.com/hiroppy
hiroppy https://github.com/hiroppy
https://github.com/nodejs/node/pull/11279/files/b95d60686476892b7f6f20909daadf57f9fb4874
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/11279
https://github.com/toiroakr
https://github.com/Trott
https://github.com/hiroppy
https://github.com/jasnell
https://github.com/santigimeno
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.