René's URL Explorer Experiment


Title: src: fix recent --icu-data-dir= regression by bnoordhuis · Pull Request #11255 · nodejs/node · GitHub

Open Graph Title: src: fix recent --icu-data-dir= regression by bnoordhuis · Pull Request #11255 · nodejs/node

X Title: src: fix recent --icu-data-dir= regression by bnoordhuis · Pull Request #11255 · nodejs/node

Description: Commit a8734af ("src: make copies of startup environment variables") introduced a regression in the capturing of the --icu-data-dir= switch. This commit fixes that and shuffles code around so it ca...

Open Graph Description: Commit a8734af ("src: make copies of startup environment variables") introduced a regression in the capturing of the --icu-data-dir= switch. This commit fixes that and shuffles code aroun...

X Description: Commit a8734af ("src: make copies of startup environment variables") introduced a regression in the capturing of the --icu-data-dir= switch. This commit fixes that and shuffles co...

Opengraph URL: https://github.com/nodejs/node/pull/11255

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ae5abf36-7092-08b7-cb5e-1cb7387a95ca
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9046:2F843D:CAFD94:118670F:696A8BED
html-safe-nonce992face78f4c8b203b90616fba6bf611f3f3c693eda94fc179440b0f0e747e1f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDQ2OjJGODQzRDpDQUZEOTQ6MTE4NjcwRjo2OTZBOEJFRCIsInZpc2l0b3JfaWQiOiIzMTcxMDM2MzQ4NzAwNzg0NDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac08a2e3b3294181275ebca2eb684767011ba8cd34262b5a45ba3e0bceb72904f6
hovercard-subject-tagpull_request:105372624
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/11255/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/79a3f281c0dc5e7fc4f0a9f2f1489ff7243cbf6bf1a6044bef155578d9f5f244/nodejs/node/pull/11255
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/79a3f281c0dc5e7fc4f0a9f2f1489ff7243cbf6bf1a6044bef155578d9f5f244/nodejs/node/pull/11255
og:image:altCommit a8734af ("src: make copies of startup environment variables") introduced a regression in the capturing of the --icu-data-dir= switch. This commit fixes that and shuffles code aroun...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebnoordhuis
hostnamegithub.com
expected-hostnamegithub.com
Noned2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec1dbca8981c5e3d6a69bce2f1d289e732b86241d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/11255#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11255
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11255
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/11255
Reloadhttps://github.com/nodejs/node/pull/11255
Reloadhttps://github.com/nodejs/node/pull/11255
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/11255
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/11255
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/11255#issue-comment-box
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix-icu-data-dirhttps://github.com/bnoordhuis/io.js/tree/fix-icu-data-dir
src: fix recent --icu-data-dir= regression https://github.com/nodejs/node/pull/11255#top
bnoordhuishttps://github.com/bnoordhuis
nodejs:masterhttps://github.com/nodejs/node/tree/master
bnoordhuis:fix-icu-data-dirhttps://github.com/bnoordhuis/io.js/tree/fix-icu-data-dir
Conversation 9 https://github.com/nodejs/node/pull/11255
Commits 2 https://github.com/nodejs/node/pull/11255/commits
Checks 0 https://github.com/nodejs/node/pull/11255/checks
Files changed https://github.com/nodejs/node/pull/11255/files
Please reload this pagehttps://github.com/nodejs/node/pull/11255
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Feb 9, 2017https://github.com/nodejs/node/pull/11255#issue-206425225
a8734afhttps://github.com/nodejs/node/commit/a8734af4422e6f8a4e3640971883577795796d6e
@sam-githubhttps://github.com/sam-github
@srl295https://github.com/srl295
Please reload this pagehttps://github.com/nodejs/node/pull/11255
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
i18n-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api
process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess
Feb 9, 2017https://github.com/nodejs/node/pull/11255#event-955123780
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Feb 9, 2017 https://github.com/nodejs/node/pull/11255#ref-pullrequest-203805176
src: make copies of startup environment variables #11051 https://github.com/nodejs/node/pull/11051
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Feb 9, 2017 https://github.com/nodejs/node/pull/11255#pullrequestreview-20947938
View reviewed changes https://github.com/nodejs/node/pull/11255/files
test/parallel/test-intl-no-icu-data.jshttps://github.com/nodejs/node/pull/11255/files#diff-013f60fcc63e2ea8a0d7fd529a0089f3a38288da61e53b3fc65ff8b8aa0d8baa
richardlauhttps://github.com/richardlau
Feb 9, 2017https://github.com/nodejs/node/pull/11255#discussion_r100248816
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/11255
bnoordhuishttps://github.com/bnoordhuis
Feb 9, 2017https://github.com/nodejs/node/pull/11255#discussion_r100297812
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
nodejs/build#419https://github.com/nodejs/build/issues/419
Please reload this pagehttps://github.com/nodejs/node/pull/11255
richardlauhttps://github.com/richardlau
Feb 9, 2017https://github.com/nodejs/node/pull/11255#discussion_r100395894
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/11255
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 9, 2017 https://github.com/nodejs/node/pull/11255#pullrequestreview-21043676
View reviewed changes https://github.com/nodejs/node/pull/11255/files
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Feb 9, 2017https://github.com/nodejs/node/pull/11255#issuecomment-278751306
nodejs/build#419https://github.com/nodejs/build/issues/419
Please reload this pagehttps://github.com/nodejs/node/pull/11255
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Feb 9, 2017 https://github.com/nodejs/node/pull/11255#pullrequestreview-21107701
View reviewed changes https://github.com/nodejs/node/pull/11255/files
sam-githubhttps://github.com/sam-github
https://github.com/nodejs/node/pull/11255#pullrequestreview-21107701
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/11255
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Feb 9, 2017https://github.com/nodejs/node/pull/11255#issuecomment-278775410
Please reload this pagehttps://github.com/nodejs/node/pull/11255
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/2d92b8183a426bc4f7cc85c40c90f8b4b16ecf66..ab1143cfd830609db4ef1740a05ff57dc722748e
2d92b81https://github.com/nodejs/node/commit/2d92b8183a426bc4f7cc85c40c90f8b4b16ecf66
ab1143chttps://github.com/nodejs/node/commit/ab1143cfd830609db4ef1740a05ff57dc722748e
Compare https://github.com/nodejs/node/compare/2d92b8183a426bc4f7cc85c40c90f8b4b16ecf66..ab1143cfd830609db4ef1740a05ff57dc722748e
February 11, 2017 13:14https://github.com/nodejs/node/pull/11255#event-958333027
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Feb 11, 2017https://github.com/nodejs/node/pull/11255#issuecomment-279143270
https://ci.nodejs.org/job/node-test-pull-request/6353/https://ci.nodejs.org/job/node-test-pull-request/6353/
Please reload this pagehttps://github.com/nodejs/node/pull/11255
bnoordhuishttps://github.com/bnoordhuis
February 11, 2017 15:23https://github.com/nodejs/node/pull/11255#commits-pushed-46345b9
https://github.com/bnoordhuis
src: make --icu-data-dir= switch testablehttps://github.com/nodejs/node/pull/11255/commits/46345b937448dbeac54f33bd3a8d38be4c1dc1ef
46345b9https://github.com/nodejs/node/pull/11255/commits/46345b937448dbeac54f33bd3a8d38be4c1dc1ef
nodejs#11255https://github.com/nodejs/node/pull/11255
https://github.com/bnoordhuis
src: fix --icu-data-dir= regressionhttps://github.com/nodejs/node/pull/11255/commits/291b599bba0f484f35a2deebb2350b178c1f1758
291b599https://github.com/nodejs/node/pull/11255/commits/291b599bba0f484f35a2deebb2350b178c1f1758
a8734afhttps://github.com/bnoordhuis/io.js/commit/a8734af4422e6f8a4e3640971883577795796d6e
nodejs#11255https://github.com/nodejs/node/pull/11255
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
force-pushedhttps://github.com/nodejs/node/compare/ab1143cfd830609db4ef1740a05ff57dc722748e..291b599bba0f484f35a2deebb2350b178c1f1758
ab1143chttps://github.com/nodejs/node/commit/ab1143cfd830609db4ef1740a05ff57dc722748e
291b599https://github.com/nodejs/node/commit/291b599bba0f484f35a2deebb2350b178c1f1758
Compare https://github.com/nodejs/node/compare/ab1143cfd830609db4ef1740a05ff57dc722748e..291b599bba0f484f35a2deebb2350b178c1f1758
February 11, 2017 14:26https://github.com/nodejs/node/pull/11255#event-958348419
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Feb 11, 2017https://github.com/nodejs/node/pull/11255#event-958348441
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
February 11, 2017 14:26https://github.com/nodejs/node/pull/11255#event-958348442
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
291b599https://github.com/nodejs/node/commit/291b599bba0f484f35a2deebb2350b178c1f1758
Feb 11, 2017https://github.com/nodejs/node/pull/11255#event-958348610
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
Feb 13, 2017https://github.com/nodejs/node/pull/11255#issuecomment-279269027
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/11255
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Feb 13, 2017https://github.com/nodejs/node/pull/11255#issuecomment-279334637
@italoacasashttps://github.com/italoacasas
#11051 (comment)https://github.com/nodejs/node/pull/11051#issuecomment-278763305
@sam-githubhttps://github.com/sam-github
Please reload this pagehttps://github.com/nodejs/node/pull/11255
sam-githubhttps://github.com/sam-github
Feb 13, 2017 https://github.com/nodejs/node/pull/11255#ref-commit-a83aa3f
https://github.com/bnoordhuis
https://github.com/sam-github
src: make --icu-data-dir= switch testablehttps://github.com/sam-github/node/commit/a83aa3f621f2df2dd919340e609ff3af463e240c
a83aa3fhttps://github.com/sam-github/node/commit/a83aa3f621f2df2dd919340e609ff3af463e240c
nodejs#11255https://github.com/nodejs/node/pull/11255
sam-githubhttps://github.com/sam-github
Feb 13, 2017 https://github.com/nodejs/node/pull/11255#ref-commit-9765138
https://github.com/bnoordhuis
https://github.com/sam-github
src: fix --icu-data-dir= regressionhttps://github.com/sam-github/node/commit/97651385266a311eb54c2516edcee3b3b092b707
9765138https://github.com/sam-github/node/commit/97651385266a311eb54c2516edcee3b3b092b707
a8734afhttps://github.com/sam-github/node/commit/a8734af4422e6f8a4e3640971883577795796d6e
nodejs#11255https://github.com/nodejs/node/pull/11255
https://github.com/sam-github
sam-githubhttps://github.com/sam-github
Feb 13, 2017 https://github.com/nodejs/node/pull/11255#ref-pullrequest-207288657
7.x backport: crypto: support OPENSSL_CONF again (and its dependencies) #11345 https://github.com/nodejs/node/pull/11345
https://github.com/targos
targoshttps://github.com/targos
Feb 14, 2017 https://github.com/nodejs/node/pull/11255#ref-pullrequest-203062948
deps: update V8 to 5.6 #10992 https://github.com/nodejs/node/pull/10992
https://github.com/italoacasas
italoacasashttps://github.com/italoacasas
dont-land-on-v7.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v7.x
Feb 14, 2017https://github.com/nodejs/node/pull/11255#event-961707451
sam-githubhttps://github.com/sam-github
Feb 16, 2017 https://github.com/nodejs/node/pull/11255#ref-commit-ce10b06
https://github.com/bnoordhuis
https://github.com/sam-github
src: make --icu-data-dir= switch testablehttps://github.com/sam-github/node/commit/ce10b06f2bb6a4fdf55adba4c69867cc25d2bbcb
ce10b06https://github.com/sam-github/node/commit/ce10b06f2bb6a4fdf55adba4c69867cc25d2bbcb
nodejs#11255https://github.com/nodejs/node/pull/11255
sam-githubhttps://github.com/sam-github
Feb 16, 2017 https://github.com/nodejs/node/pull/11255#ref-commit-d0b9c34
https://github.com/bnoordhuis
https://github.com/sam-github
src: fix --icu-data-dir= regressionhttps://github.com/sam-github/node/commit/d0b9c3407fb3acd333092a7d386ee2985f6107bf
d0b9c34https://github.com/sam-github/node/commit/d0b9c3407fb3acd333092a7d386ee2985f6107bf
a8734afhttps://github.com/sam-github/node/commit/a8734af4422e6f8a4e3640971883577795796d6e
nodejs#11255https://github.com/nodejs/node/pull/11255
italoacasashttps://github.com/italoacasas
Feb 16, 2017 https://github.com/nodejs/node/pull/11255#ref-commit-fde7878
https://github.com/bnoordhuis
src: make --icu-data-dir= switch testablehttps://github.com/nodejs/node/commit/fde7878a9a778af5a65af2a02dc8a362cc515ba1
fde7878https://github.com/nodejs/node/commit/fde7878a9a778af5a65af2a02dc8a362cc515ba1
#11255https://github.com/nodejs/node/pull/11255
italoacasashttps://github.com/italoacasas
Feb 16, 2017 https://github.com/nodejs/node/pull/11255#ref-commit-62e2ea0
https://github.com/bnoordhuis
src: fix --icu-data-dir= regressionhttps://github.com/nodejs/node/commit/62e2ea0cd135eda00a75483bb0a7cfe4f70eb34c
62e2ea0https://github.com/nodejs/node/commit/62e2ea0cd135eda00a75483bb0a7cfe4f70eb34c
a8734afhttps://github.com/nodejs/node/commit/a8734af4422e6f8a4e3640971883577795796d6e
#11255https://github.com/nodejs/node/pull/11255
italoacasashttps://github.com/italoacasas
Feb 22, 2017 https://github.com/nodejs/node/pull/11255#ref-commit-73e316e
https://github.com/bnoordhuis
src: make --icu-data-dir= switch testablehttps://github.com/nodejs/node/commit/73e316e90870574c9958f38abc65c6cc138fc4e8
73e316ehttps://github.com/nodejs/node/commit/73e316e90870574c9958f38abc65c6cc138fc4e8
#11255https://github.com/nodejs/node/pull/11255
italoacasashttps://github.com/italoacasas
Feb 22, 2017 https://github.com/nodejs/node/pull/11255#ref-commit-a8613f8
https://github.com/bnoordhuis
src: fix --icu-data-dir= regressionhttps://github.com/nodejs/node/commit/a8613f8ce4bdbee32ed25819092e9a9c7f137c87
a8613f8https://github.com/nodejs/node/commit/a8613f8ce4bdbee32ed25819092e9a9c7f137c87
a8734afhttps://github.com/nodejs/node/commit/a8734af4422e6f8a4e3640971883577795796d6e
#11255https://github.com/nodejs/node/pull/11255
krydoshttps://github.com/krydos
Feb 25, 2017 https://github.com/nodejs/node/pull/11255#ref-commit-11339cf
https://github.com/bnoordhuis
https://github.com/krydos
src: make --icu-data-dir= switch testablehttps://github.com/krydos/node/commit/11339cfa3d253f049270097fa6f41eab98d3b8d3
11339cfhttps://github.com/krydos/node/commit/11339cfa3d253f049270097fa6f41eab98d3b8d3
nodejs#11255https://github.com/nodejs/node/pull/11255
krydoshttps://github.com/krydos
Feb 25, 2017 https://github.com/nodejs/node/pull/11255#ref-commit-2cba585
https://github.com/bnoordhuis
https://github.com/krydos
src: fix --icu-data-dir= regressionhttps://github.com/krydos/node/commit/2cba585a89a80c7cb07c5b3596459df3dc29ac07
2cba585https://github.com/krydos/node/commit/2cba585a89a80c7cb07c5b3596459df3dc29ac07
a8734afhttps://github.com/krydos/node/commit/a8734af4422e6f8a4e3640971883577795796d6e
nodejs#11255https://github.com/nodejs/node/pull/11255
https://github.com/jasnell
jasnellhttps://github.com/jasnell
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Mar 7, 2017https://github.com/nodejs/node/pull/11255#event-989847447
https://github.com/evantorrie
evantorriehttps://github.com/evantorrie
Apr 4, 2017 https://github.com/nodejs/node/pull/11255#ref-issue-219105625
test-intl-no-icu-data.js fails unless node compiled --with-intl=small-icu #12198 https://github.com/nodejs/node/issues/12198
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Apr 5, 2017 https://github.com/nodejs/node/pull/11255#ref-pullrequest-219453939
test: Skip intl-no-icu-data test when not (Intl and smallICU) #12226 https://github.com/nodejs/node/pull/12226
https://github.com/srl295
srl295https://github.com/srl295
Dec 4, 2018 https://github.com/nodejs/node/pull/11255#ref-pullrequest-386544747
src: remove icuDataDir from node config #24780 https://github.com/nodejs/node/pull/24780
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11255
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/11255/files/2d92b8183a426bc4f7cc85c40c90f8b4b16ecf66
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/11255/files/2d92b8183a426bc4f7cc85c40c90f8b4b16ecf66
https://github.com/sam-github
sam-github https://github.com/sam-github
https://github.com/nodejs/node/pull/11255/files/2d92b8183a426bc4f7cc85c40c90f8b4b16ecf66
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
i18n-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api
process https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess
Please reload this pagehttps://github.com/nodejs/node/pull/11255
https://github.com/bnoordhuis
https://github.com/richardlau
https://github.com/italoacasas
https://github.com/sam-github
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.