| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b45d8345-e06b-5f97-1cd2-2813e471a3db |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A06A:13E08:D27A28:127F660:696A6609 |
| html-safe-nonce | 75b857b1ee8aa1b5e3b4f4eaf6a138db4d7d1e7a0f63c5288283f2f97b6ae6d0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDZBOjEzRTA4OkQyN0EyODoxMjdGNjYwOjY5NkE2NjA5IiwidmlzaXRvcl9pZCI6IjUzNzQwMTUyMzE3NDAyNDE0MTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b903c14def22c20b4d599b95a2957fefff682f5b9595fcad656f725b915d66bb |
| hovercard-subject-tag | pull_request:105065678 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/11223/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4376c5967183ed2908f7507a34b1580a7a36fb2312e754c778d5565d753cdb31/nodejs/node/pull/11223 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4376c5967183ed2908f7507a34b1580a7a36fb2312e754c778d5565d753cdb31/nodejs/node/pull/11223 |
| og:image:alt | validate full error messages
use assert.throws() instead of try...catch
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message fol... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cjihrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9b7735a184970dd9333b2cbe036c8f3c0a9108c64aaa93827c5a64fc70993392 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87cbd411c2982752221b5751d583a515b23bf5fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/11223#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11223 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11223 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/11223 |
| Reload | https://github.com/nodejs/node/pull/11223 |
| Reload | https://github.com/nodejs/node/pull/11223 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/11223 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
694
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/11223 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/11223#issue-comment-box |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:path-test | https://github.com/cjihrig/node/tree/path-test |
|
test: improve checks in test-path-parse-format
| https://github.com/nodejs/node/pull/11223#top |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:path-test | https://github.com/cjihrig/node/tree/path-test |
|
Conversation
2
| https://github.com/nodejs/node/pull/11223 |
|
Commits
1
| https://github.com/nodejs/node/pull/11223/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/11223/checks |
|
Files changed
| https://github.com/nodejs/node/pull/11223/files |
| Please reload this page | https://github.com/nodejs/node/pull/11223 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Feb 7, 2017 | https://github.com/nodejs/node/pull/11223#issue-205975156 |
| Please reload this page | https://github.com/nodejs/node/pull/11223 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Feb 7, 2017 | https://github.com/nodejs/node/pull/11223#event-952572984 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Feb 7, 2017
| https://github.com/nodejs/node/pull/11223#pullrequestreview-20584624 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11223/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 7, 2017
| https://github.com/nodejs/node/pull/11223#pullrequestreview-20586640 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11223/files |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
path
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apath |
| Feb 7, 2017 | https://github.com/nodejs/node/pull/11223#event-952707810 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
Feb 7, 2017
| https://github.com/nodejs/node/pull/11223#pullrequestreview-20645086 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11223/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 7, 2017
| https://github.com/nodejs/node/pull/11223#pullrequestreview-20647061 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/11223/files |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Feb 9, 2017 | https://github.com/nodejs/node/pull/11223#issuecomment-278523818 |
| https://ci.nodejs.org/job/node-test-pull-request/6303/ | https://ci.nodejs.org/job/node-test-pull-request/6303/ |
| Please reload this page | https://github.com/nodejs/node/pull/11223 |
|
| https://github.com/cjihrig |
| test: improve checks in test-path-parse-format | https://github.com/nodejs/node/pull/11223/commits/0700927832e167ac83183aefa0f63af02b6c3a75 |
| 0700927 | https://github.com/nodejs/node/pull/11223/commits/0700927832e167ac83183aefa0f63af02b6c3a75 |
| nodejs#11223 | https://github.com/nodejs/node/pull/11223 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/a5bfb0899bfa8f68c73a7be060bf56307c8acf6d..0700927832e167ac83183aefa0f63af02b6c3a75 |
| a5bfb08 | https://github.com/nodejs/node/commit/a5bfb0899bfa8f68c73a7be060bf56307c8acf6d |
| 0700927 | https://github.com/nodejs/node/commit/0700927832e167ac83183aefa0f63af02b6c3a75 |
|
Compare
| https://github.com/nodejs/node/compare/a5bfb0899bfa8f68c73a7be060bf56307c8acf6d..0700927832e167ac83183aefa0f63af02b6c3a75 |
| February 9, 2017 18:29 | https://github.com/nodejs/node/pull/11223#event-956075418 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| 0700927 | https://github.com/nodejs/node/commit/0700927832e167ac83183aefa0f63af02b6c3a75 |
| Feb 9, 2017 | https://github.com/nodejs/node/pull/11223#event-956077227 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| February 9, 2017 18:30 | https://github.com/nodejs/node/pull/11223#event-956077346 |
| italoacasas | https://github.com/italoacasas |
|
Feb 13, 2017
| https://github.com/nodejs/node/pull/11223#ref-commit-3d190bb |
|
| https://github.com/cjihrig |
| test: improve checks in test-path-parse-format | https://github.com/nodejs/node/commit/3d190bbe16a46219344d1c6b2a928d1c036b55ef |
| 3d190bb | https://github.com/nodejs/node/commit/3d190bbe16a46219344d1c6b2a928d1c036b55ef |
| #11223 | https://github.com/nodejs/node/pull/11223 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Feb 13, 2017
| https://github.com/nodejs/node/pull/11223#ref-pullrequest-205450090 |
|
Proposal - 7.6.0 (Current)
#11185
| https://github.com/nodejs/node/pull/11185 |
| italoacasas | https://github.com/italoacasas |
|
Feb 14, 2017
| https://github.com/nodejs/node/pull/11223#ref-commit-25226ce |
|
| https://github.com/cjihrig |
| test: improve checks in test-path-parse-format | https://github.com/italoacasas/node/commit/25226ced6a75f766ce70b64964412f70900cf6fb |
| 25226ce | https://github.com/italoacasas/node/commit/25226ced6a75f766ce70b64964412f70900cf6fb |
| nodejs#11223 | https://github.com/nodejs/node/pull/11223 |
| krydos | https://github.com/krydos |
|
Feb 25, 2017
| https://github.com/nodejs/node/pull/11223#ref-commit-73adab4 |
|
| https://github.com/cjihrig |
|
| https://github.com/krydos |
| test: improve checks in test-path-parse-format | https://github.com/krydos/node/commit/73adab4e533685a3b8697ac16d0219623f3596d1 |
| 73adab4 | https://github.com/krydos/node/commit/73adab4e533685a3b8697ac16d0219623f3596d1 |
| nodejs#11223 | https://github.com/nodejs/node/pull/11223 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Mar 7, 2017 | https://github.com/nodejs/node/pull/11223#event-990120344 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 7, 2017 | https://github.com/nodejs/node/pull/11223#issuecomment-284820332 |
| Please reload this page | https://github.com/nodejs/node/pull/11223 |
| jasnell | https://github.com/jasnell |
|
Mar 7, 2017
| https://github.com/nodejs/node/pull/11223#ref-commit-1366b64 |
|
| https://github.com/cjihrig |
|
| https://github.com/jasnell |
| test: improve checks in test-path-parse-format | https://github.com/nodejs/node/commit/1366b641f7650b0d9fef7740ebdd0cc4819603cd |
| 1366b64 | https://github.com/nodejs/node/commit/1366b641f7650b0d9fef7740ebdd0cc4819603cd |
| #11223 | https://github.com/nodejs/node/pull/11223 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/11223#ref-commit-7aebc69 |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
| test: improve checks in test-path-parse-format | https://github.com/nodejs/node/commit/7aebc6907c4ebeeac94daff362a483eea84bbf80 |
| 7aebc69 | https://github.com/nodejs/node/commit/7aebc6907c4ebeeac94daff362a483eea84bbf80 |
| #11223 | https://github.com/nodejs/node/pull/11223 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 9, 2017
| https://github.com/nodejs/node/pull/11223#ref-pullrequest-212909365 |
|
v6.10.1 proposal
#11759
| https://github.com/nodejs/node/pull/11759 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F11223 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/11223/files/a5bfb0899bfa8f68c73a7be060bf56307c8acf6d |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/11223/files/a5bfb0899bfa8f68c73a7be060bf56307c8acf6d |
|
| https://github.com/evanlucas |
|
evanlucas
| https://github.com/evanlucas |
|
| https://github.com/nodejs/node/pull/11223/files/a5bfb0899bfa8f68c73a7be060bf56307c8acf6d |
|
path
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apath |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/11223 |
|
| https://github.com/cjihrig |
|
| https://github.com/jasnell |
|
| https://github.com/evanlucas |
|
| https://github.com/joyeecheung |
|
| https://github.com/mscdex |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |